- 01 Apr, 2019 40 commits
-
-
Cathy Li authored
Resolve CL comments from https://chromium-review.googlesource.com/c/chromium/src/+/1535227 Bug: 936050 Change-Id: Ia5a8223577cfa43a5ea38a9a6165f7fd0d266993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545194 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#646435}
-
Andrew Grieve authored
Also fixes our runner scanning the same under-test apk for tests multiple times, and skips scanning of system apks Bug: 917426 Change-Id: I3dc56e87d971cdfb9dca785ad30726afcd1e1372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535353 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#646434}
-
Brandon Wylie authored
Bug: 936052 Change-Id: Ied38dd673b37a296211694a58018aaab9f25a736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546852Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
-
Nicolás Peña Moreno authored
The element ID helps developers and analytics providers determine which element the PerformanceElementTiming entry is referring to. While we have other ways to find out the element for Image Element Timing (for\ example, we can use the image requested URL), for text the available resources will be much limited and thus ID is needed. Bug: 879270, 942033 Change-Id: I0f20609cf4edc7eb6431448c439b9cf911f89fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544948 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#646432}
-
Harley Li authored
It should not just clean the main target's storage. Change-Id: I580a23267e8cd7ca14938debc6f5a8754e59c646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546620 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#646431}
-
rajendrant authored
This reverts commit 452c35d1. Reason for revert: <INSERT REASONING HERE> Original change's description: > Change 502 response with no bypass info to block-once > > CORB failures could block any response headers being sent to the rendere. These > are treated as a random 1-5 minute bypass, since Chrome-Proxy is not in the > response. This CL changes those bypasses to a block-once. > > Bug: 947736 > Change-Id: I83c6a9874ccb26e4f17d8dccf7e9eeac8dd7f535 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546678 > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#646136} TBR=tbansal@chromium.org,rajendrant@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 947736 Change-Id: Ie2fafbf28cb2549d3e4b0d056b420af198dd5cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546886Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#646430}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/320a7de5c9a5..0300a464a4cc git log 320a7de5c9a5..0300a464a4cc --date=short --no-merges --format='%ad %ae %s' 2019-04-01 33432579+alan-baker@users.noreply.github.com Maintain inst to block mapping in merge return (#2469) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@0300a464a4cc The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iffe6d8e6bb5970c69861ad8aff72bcdeb104f597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547303Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646429}
-
Victor Costan authored
This CL removes 0003-fts3-Disasble-fts3_tokenizer-and-fts4.patch. The patch disables the following bits of functionality from SQLite's FTS3 extension: * The fts4 virtual table mode. * The fts3_tokenizer() function. Both bits of functionality were disabled to avoid exposing them to WebSQL. However, the custom authorizer [1] in our WebSQL implementation uses a whitelist that doesn't include fts4 virtual tables or the fts3_tokenizer() functions. So, at this point, the patch only serves to disable the features for use in Chrome features. Blocking Chrome feature code from using FTS features is mildly desirable, as it makes it more likely that we'll be able to disable FTS3 entirely after we stop supporting WebSQL. However, this benefit isn't sufficient to justify carrying a patch on top of SQLite. [1] https://www.sqlite.org/c3ref/set_authorizer.html Bug: 945204 Change-Id: I23fc2a54895dd2063a50d8f9f45636d29dfa19cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545686 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#646428}
-
Emily Hanley authored
Bug: 948142 Change-Id: Ib64633b03bd1d12c5e3d1571ad6d8ba43b1405d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539857 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#646427}
-
Hui(Andy) Wu authored
When script finishes normally, AssistantCoordinator.setVisible(false) is not triggered anywhere, hence the listener to keyboard visibility is not removed. If the previous state is to hide keyboard, it will keep trying to hide keyboard after autobot finishes. Before patch: https://drive.google.com/file/d/13Nw5Tr_PHVeo5qkrBB0VA5RmkGl3ZyKe/view?usp=sharing After patch: https://drive.google.com/file/d/1DXKmblltiz4tEoDqaGHWRgFOiNeJXmIz/view?usp=sharing Change-Id: I1d2efa5739471aaeb7fe0a966e3f11c46a69d092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546235Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Hui Wu <wuandy@chromium.org> Cr-Commit-Position: refs/heads/master@{#646426}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/de206c75c2c8..b6a3a3b245a5 git log de206c75c2c8..b6a3a3b245a5 --date=short --no-merges --format='%ad %ae %s' 2019-04-01 bsalomon@google.com Make lazy proxies have 2 modes for proxy/surface key management. Created with: gclient setdep -r src/third_party/skia@b6a3a3b245a5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@chromium.org Change-Id: I5bb680baf21fd43a5ebc6f2b8e4d1d506180b3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547302Reviewed-by:
-
Sergey Ulanov authored
Previously VulkanImplementation defined functions for semaphore import/export from/to file descriptors. This approach doesn't work on platforms that don't support FDs for semaphores, specifically on Fuchsia and Windows. This CL: 1. Adds cross-platform gpu::SemaphoreHandle that allows to represent semaphore handle on any platforms. 2. Replaces ImportSemaphoreFdKHR() with ImportSemaphoreHandle(). 3. Replaces GetSemaphoreFdKHR() with GetSemaphoreHandle() This allows to remove dependency on ScopedFD in gpu::ExternalVkImageFactory, which will make it easier to reuse that class on Fuchsia and Windows. Bug: 934526 Change-Id: I16b1a9f3a606683b76a73c4e68a33b3294f25a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540724 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#646424}
-
Josh Karlin authored
It's a big method that can easily be broken up into smaller methods. This will make it easier to review downstream changes. Also, rather than create a TextWrapper every time it's needed, I instantiated one for the class. That winds up saving about .3 seconds when running histograms pretty_print.py. Bug: 1538783 Change-Id: I4bb697c74472e8729060828e29a2f67766fa4f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543248 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#646423}
-
Paul Jensen authored
Ignore network interfaces with just link-local addresses when computing a computer's network connection type. Mac assigns link local addresses to several different types of interfaces even when they are not connected. Internal bug b/128444384. Change-Id: Iee6f3143903c5f2f7e4c3b3942221ab4251854d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546877 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#646422}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/21d000094ade..010a4da72d17 git log 21d000094ade..010a4da72d17 --date=short --no-merges --format='%ad %ae %s' 2019-04-01 tsepez@chromium.org Limit input size in pdf_fx_date_helpers_fuzzer. 2019-04-01 thestig@chromium.org Avoid premature decoding completion in CJBig2_ArithDecoder. Created with: gclient setdep -r src/third_party/pdfium@010a4da72d17 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:947780,chromium:947622 TBR=dsinclair@chromium.org Change-Id: I42f2ec103277a13cfb9dbae2cd0cb0a200375a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547300Reviewed-by:
-
Yuke Liao authored
This CL deletes some comments that shouldn't be there. Change-Id: I8cb2bc8838be3b265028dd99e75c88b7dd2c0a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546726Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#646420}
-
Becky Zhou authored
Bug: 899318 Change-Id: Idc40408aa27a8c67f923343d50975f7099567999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548030Reviewed-by:
-
Will Cassella authored
This sort of worked before since the logic to detect if any part of the list was focused was broken, but that didn't work in the VRB so. This CL fixes that logic and makes the menu close in a more direct way. Bug: 865010 Change-Id: Ie6974404947380bb45c48c597b0b4a7830c68228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546725Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#646418}
-
Ian Kilpatrick authored
This patch adds a series of checks to allow us to cache layout results which floats are present within the BFC. We perform these additional checks when: - The BFC offset isn't equal. - The ExclusionSpace isn't equal. The cases when we can't reuse a layout result are: - The layout result was pushed by floats. This is due to complexities with margin collapsing. I believe that if we wanted to cache this case we'd need to either return the BFC-offset if it wasn't affected by clearance, or add a bit telling us if the margin-strut *when the BFC offset was resolved* was empty. This seems too complex to get right at the moment. NOTE: we'll still may cache things with clear:both, etc. (if they weren't pushed by floats. - If we *may* have a descendant above the block-start edge. E.g. an arbitrary descendant may have a negative top margin, and any content within it would be affected by floats. We just add a "May" check for this (child_offset.block_offset < LayoutUnit()) as this should be relatively rare. - If there were overhanging floats initially. - If there may be overhanging floats once moved. This adds a new test file as the ng_block_layout_algorithm_test.cc was getting long. Bug: 635619 Change-Id: Iaac7ec58099e2d4c3359aee61e6454bec84c0888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496955 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#646417}
-
Henrique Nakashima authored
There are already files called download_service_factory.(cc|h) in //src/chrome/browser/download, which use the components files. Therefore, calling the components files download_service_factory_helper.(cc|h) Change-Id: Id34daa36a975321b6b0e1c99e2b7608e7d75b798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546421Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Auto-Submit: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#646416}
-
Ian Kilpatrick authored
If a layout result had exclusions inside it we previously didn't move them relative to the given new bfc offset. This introduces NGExclusionSpace::MergeExclusionSpaces which looks at the: - old input exclusion space - old output exclusion space - new input exclusion space - bfc movement offset and produces a "new output exclusion space". Bug: 635619 Change-Id: I436dd97f88b1a75287703a8f3692d0a56342c7b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546494 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Becca Hughes authored
If we do not have any artwork we should not shift the media notification contents to the right. BUG=897836 Change-Id: Ia1b333e5c80e2065fda9ad2c1eea90dfdd86742d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545728 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#646414}
-
Eugene But authored
Failed when run locally on iOS 12 iPhone. Bug: 947536 Change-Id: Ic4c6cd02afb0289658f7658794df93cc212fffa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545997 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#646413}
-
Ian Kilpatrick authored
Previously if a NGConstraintSpace had a rare-data object, and the comparison NGConstraintSpace did not, we said we couldn't skip layout. However there are cases where we may allocate a rare-data object and still be able to skip layout. I don't believe this case is particularly common, so this is just a cleanup patch. Bug: 635619 Change-Id: Iba91c9028b614fcce0c3bf48b14fe38030709ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546309 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Andres Calderon Jaramillo authored
This CL adds support to detect when the encoded data for an image has been received in its entirety prior to creating the first DecodingImageGenerator for it. This is to support the use case of sending the encoded data to a hardware decoder. The motivation is as follows: hardware decoding requires that all the data has been received. If the image is received incrementally and we software-decode the partial data as it comes, there is no point in sending the complete image to the hardware decoder once it's received because the software decoder has already done a lot of the work, so it's better to finish the decoding in software. A DeferredImageDecoder is shared across the process of incrementally receiving the image. However, at each step, a new DecodingImageGenerator is created (which is what cc uses ultimately to decode the image). Therefore, we keep enough state in DeferredImageDecoder to detect when we create the first DecodingImageGenerator. If at that point, all the encoded data has been received, then it's okay to send the image to hardware decoder. We store this decision in the DecodingImageGenerator. That way a PaintImage can have an IsEligibleForAcceleratedDecoding() method which asks the underlying PaintImageGenerator if it's okay to hardware-decode. Additionally, a small clean-up is done: the DecodingImageGenerator::SetCanYUVDecode() method is removed in favor of passing the YUV decoding decision at construction. Test: unit tests are added for the new behavior. Bug: 868400 Change-Id: I396cf08ab007fd98b6fd65d60704ae8d26673aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546327Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#646411}
-
Ian Kilpatrick authored
Previously to answer questions about clearance offsets, we'd need to potentially build the derived-geometry data-structure. This has a very large overhead for something that looks relatively cheap. This moves those tracking members into NGExclusionSpaceInternal instead. Bug: 635619 Change-Id: I01b57014c479133e9eeaa95e65ecfa05ca954e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544882 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
dpapad authored
Specifically: - directory_model.js - filtered_volume_manager.js Also had to declare more member variables in the constructor of directory_model.js, to address newly discovered compiler erros, as a result of ES6 classes being @struct by default. This is in preparation of removing the custom cr.EventTarget implementation in favor of native EventTarget, which requires all subclasses to be ES6 classes, otherwise a runtime "Illegal invocation" error is thrown. Bug: 854268,778674 Change-Id: I7e2944c0112b8676fd1dbfb5717d722da62e0c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546856Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#646409}
-
Nate Fischer authored
No change to logic, this just renames a test. This renames "redirectFromThirdToFirst" to "redirectFromThirdPartyToFirst," for consistency with the "...FirstPartyToThird" test case. The original name was a typo. R=changwan@chromium.org Bug: 941337 Test: N/A Change-Id: I8c0bc3daa4fa24c854e5cc2dc2c473827037d5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546759 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#646408}
-
David Benjamin authored
SetUpOnMainThread is too late to mutate the command-line. By then, other threads have started and may be reading from it. Instead, use SetUpCommandLine. This should fix the following TSan flake: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8917832371169415328/+/steps/content_browsertests/0/logs/Flaky_failure:_WebRtcInternalsBrowserTest.UpdateAllPeerConnections__status_FAILURE_ON_EXIT_SUCCESS_/0 Change-Id: Ibf819a3247b290b9d583d25dc0111881868c4a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541497 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Alexander Potapenko <glider@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#646407}
-
rajendrant authored
Servicification is enabled by default on tests. For the tests that use request_headers, only main frame request headers will be available. So they are changed accordingly. Bug: 947736 Change-Id: I16e0b915f8667fa2a75bfece58395c4262e02681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546197Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#646406}
-
Mikel Astiz authored
This is a reland of e73ae865 In this version, the issue causing flakiness has been fixed. Namely, FaviconCache powers two sync datatypes so WaitUntilReadyToSync() must support overlapping calls. Original change's description: > Make sure HistoryService is ready before favicon sync > > This is achieved with SyncableService::WaitUntilReadyToSync(), which > holds sync interactions back until the SyncableService is ready to > start. > > This CL was uploaded by git cl split. > > R=treib@chromium.org > > Change-Id: Icdfb17cc36132488cb30600f894e5118e9ac01a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545054 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Auto-Submit: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#645741} Change-Id: Ie2b765479c6a7352ebc10e1f9ecc21f71679c5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545408 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#646405}
-
Livvie Lin authored
Backend still sends this since it's a required field. We cannot yet remove it completely since it's non-optional and sent over public protocol API. Bug: 744601 Change-Id: Iee1ea175ba1fa9cf8ce596e218f98109836e5b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546498Reviewed-by:
-
Raphael Kubo da Costa authored
This fixes a TODO item I added for myself back in commit dd9b04ee ("sensors: Remove bogus DCHECK from SensorReader::Create()"). Commit 9d8348e5 ("sensors: Clean up sequence, task and thread handling in the Linux implementation") got rid of PlatformSensorProviderLinux's polling thread altogether, so we can finally make |disallow_blocking_| a regular member variable that is used for the entirety of PlatformSensorAndProviderLinuxTest's lifetime. Change-Id: Ic78bc2d4d2ad64ea4be7a2e2cf39315a87d96e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546102 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#646403}
-
Michael Ludwig authored
Change-Id: If6e543d8319f2e2160d8c8d8e3b6b42a9b3f5f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530005 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#646402}
-
Raul Tambre authored
Bug: 879657 Change-Id: I753af2ee72b695d8cecc24e15795235823e4306d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1396383 Commit-Queue: Raul Tambre <raul@tambre.ee> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#646401}
-
Avery Musbach authored
BEFORE: https://photos.app.goo.gl/WJgfDni6K83tZ2NA9 AFTER: https://photos.app.goo.gl/mynmp7i3t8F53qJu6 Test: manual Bug: 946601 Change-Id: I9a9f952048f9f819e7751bf726ac19fc9cdf7fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541839 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#646400}
-
Tarun Bansal authored
Setting the flag enables the data saver feature. This is necessary for testing data saver features on CrOS. The flag has been added to bad flags prompt since enabling the flag causes user's traffic to be proxied in unexpected ways. Bug: 940943 Change-Id: I4070055234b02cc9d4be0d3644ffbe0d450273fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546328Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
-
Robert Liao authored
BUG=947314 Change-Id: I671483b4d28934303bb4d55294b25dc0a5851f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546492 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#646398}
-
Mitsuru Oshima authored
This was causing missing debug info on the pillar boxed window. Bug: None Test: manual Change-Id: I1b7d8f2c0f40a9cc72853490de670a22e3f76d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542243Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#646397}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/507bf397d15c..f6cbd3926d95 git log 507bf397d15c..f6cbd3926d95 --date=short --no-merges --format='%ad %ae %s' 2019-04-01 pprabhu@chromium.org config: Migrate {mistral,whirlwind}-paladin to Skylab Created with: gclient setdep -r src/third_party/chromite@f6cbd3926d95 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I75a9e492812e864d5036c34d4332ac4847d00397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547407Reviewed-by:
-
