GitLab

Looks like rebaseline-cl picked up some .txt diffs for a handful of
flaky Android tests.

TBR=liyuqian@google.com,rockot@chromium.org

Review-Url: https://codereview.chromium.org/2547613002
Cr-Commit-Position: refs/heads/master@{#435687}

resource_size_in_pixels was missed in TextureDrawQuad. This was missed
because unit tests used SetNew instead of SetAll and only set all
set the resource_size_in_pixels. This CL adds the missing field
and updates the corresponding test.

BUG=659601
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2541403002
Cr-Commit-Position: refs/heads/master@{#435686}

[e57cdc4...]c:\src\cr\src\third_party\ced\src>git log --oneline 9012c0a..e57cdc4
e57cdc4 Merge pull request #3 from sgraham/master
3882135 Encode compact_enc_det.cc as utf-8

TBR=jinsukkim@chromium.org
BUG=454858,637203

Review-Url: https://codereview.chromium.org/2547623002
Cr-Commit-Position: refs/heads/master@{#435685}

Follow-up to renames performed in http://crrev.com/2536453002

Review-Url: https://codereview.chromium.org/2539713004
Cr-Commit-Position: refs/heads/master@{#435684}

BUG=None

Review-Url: https://codereview.chromium.org/2545743002
Cr-Commit-Position: refs/heads/master@{#435683}

https://pdfium.googlesource.com/pdfium.git/+log/02759102cf99..9be9c3486688

$ git log 02759102c..9be9c3486 --date=short --no-merges --format='%ad %ae %s'
2016-12-01 npm Improve early return in CGifLZWDecoder::Decode

BUG=659417

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2544863002
Cr-Commit-Position: refs/heads/master@{#435682}

This patch stops the prepaint tree walk when no paint invalidation or
paint property updates are needed.

The three major changes are:
1) PaintPropertyTreeBuilder now detects when properties are added or
removed and forces a paint property update for all descendants. This
is needed because tree structure changes can cause descendant objects
to reference new/different ancestors.
2) When stopping the prepaint tree walk due to throttled frames, paint
invalidation and property update flags are no longer cleared. This
allows subsequent prepaint tree walks to correctly invalidate subframes
when they unthrottle.
3) PrePaintTreeWalk::walk(LayoutObject&...) exits early when possible.

Design doc:
https://docs.google.com/document/d/1_GkBfvameyhnLV7ODIRsOoTedQEG5liAcHwAxmwS-Vk/view

Performance results on blink_perf.Paint[1]:
  color-changes.html: -3.4%
  large-table-background-change-with-invisible-collapsed-borders.html: -19.2%
  large-table-background-change-with-visible-collapsed-borders.html: -3.0%
  large-table-collapsed-border-change.html: -0.4%
  large-table-collapsed-border-change-with-backgrounds.html: -6.8%
  large-table-collapsed-border-change-with-text.html: -17.2%
  large-table-repaint.html: -6.0%
  paint-offset-changes.html: -4.7%
  transform-changes.html: -2.7%

[1] tools/perf/run_benchmark blink_perf.paint --browser=content-shell-release --pageset-repeat=5 --extra-browser-args=--enable-slimming-paint-v2

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2539693002
Cr-Commit-Position: refs/heads/master@{#435681}

We want to be able to use --test-launcher-filter-file
AND --gtest_filter.

A test is run if and only if:

A) positive_patterns_from_gtest_filter are empty,
or the test matches at least one pattern from
positive_patterns_from_gtest_filter

AND

B) positive_patterns_from_test_launcher_filter_file are empty,
or the test matches at least one pattern from
positive_patterns_from_test_launcher_filter_file

AND

C) the test doesn't match ANY negative_patterns_from_gtest_filter

AND

D) the test doesn't match ANY
negative_patterns_from_test_launcher_filter_file

R=dpranke@chromium.org
BUG=587527

Review-Url: https://codereview.chromium.org/2515573003
Cr-Commit-Position: refs/heads/master@{#435680}

To be used in Chrome OS when separating functionality based on board.

Fixed the bad usage of GetLsbReleaseBoard().

BUG=653814,663857

Review-Url: https://codereview.chromium.org/2489853002
Cr-Commit-Position: refs/heads/master@{#435679}

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2541113003
Cr-Commit-Position: refs/heads/master@{#435678}

Revert of Don't expand empty rect during rect mapping (patchset #4 id:60001 of https://codereview.chromium.org/2416693002/ )

Reason for revert:
It changed
  transform->mapRect(enclosingIntRect(rect))
to
  transform->mapRect(FloatRect(enclosingIntRect(rect)))
causing missing enclosingIntRect() after the transform.

We may also need enclosingIntRect for empty rects because even empty
object can have visible filter depending on pixel snapping here.

BUG=669774
TEST=paint/invalidation/rotated-subpixel.html

Original issue's description:
> Don't expand empty rect during rect mapping
>
> For example, enclosingIntRect(LayoutRect(0.5, 0.5, 0, 0)) results
> IntRect(0, 0, 1, 1). This causes unnecessary non-empty visual rects
> mapped from empty LayoutRects.
>
> This CL is mainly to reduce the difference between the old path and
> slimmingPaintInvalidation with pixel snapping feature.
>
> Committed: https://crrev.com/67c516aaed2486295a98d7f0ff2235b921cd7933
> Cr-Commit-Position: refs/heads/master@{#424970}

TBR=chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2545573002
Cr-Commit-Position: refs/heads/master@{#435677}

This change adds a new histogram factory method that provides a count histogram but with linearly spaced buckets.

BUG=none

Review-Url: https://codereview.chromium.org/2545703002
Cr-Commit-Position: refs/heads/master@{#435676}

When a new action is added to the incognito toolbar (which can happen with the
Media Router component action), it should become visible regardless of the state
of the non-incognito toolbar. This change ensures that and adds a unit test.

BUG=668039

Review-Url: https://codereview.chromium.org/2539153003
Cr-Commit-Position: refs/heads/master@{#435675}

Just removing the assert.

BUG=670158

Review-Url: https://codereview.chromium.org/2543903002
Cr-Commit-Position: refs/heads/master@{#435674}

Update: The server has started sending updates to Google Chrome builds for all supported lists. See: http://b/33182208

BUG=543161

Review-Url: https://codereview.chromium.org/2536913002
Cr-Commit-Position: refs/heads/master@{#435673}

The map lookup was added by http://crrev.com/434349, but caused a
5-10% regression in CalcDrawPropsTests cc_perftests. This CL sets
the effect tree index on the surface during the surface update step
(when EffectNode::render_surface gets updated).

BUG=670074
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2540333002
Cr-Commit-Position: refs/heads/master@{#435672}

Remove bad Mac10.10 baseline for svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox.svg.

Originally landed in: https://codereview.chromium.org/2538943002

The platform/mac/ baseline is correct (matches the actual result on the bot), so deleting this file should suffice.

TBR=liyuqian@google.com
NOTRY=true

Review-Url: https://codereview.chromium.org/2542843005
Cr-Commit-Position: refs/heads/master@{#435671}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/228237cf..d7fb769f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2540383004
Cr-Commit-Position: refs/heads/master@{#435670}

The setExperimentalOptions() method is considered to be an experimental. Its behavior may change in the future. For that reason, it is moved to ExperimentalCronetEngine.Builder instead of being in CronetEngine.Builder.

BUG=629299
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2541593002
Cr-Commit-Position: refs/heads/master@{#435669}

Mark http/tests/media/video-buffered-range-contains-currentTime.html as [ Failure Timeout ] on Mac10.9.

Sometimes it doesn't time out, and fails like on other platforms.
Expand the expectation to allow either outcome.

BUG=646644
TBR=rockot@chromium.org,liberato@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2549603002
Cr-Commit-Position: refs/heads/master@{#435668}

This is cleaner than using
ChromePermissionMessageRule::PermissionIDSetInitializer (and resolves
TODO associated with said class).

Also, avoids "Single-parameter constructors should be marked explicit."
presubmit warning when changing chrome_permission_message_rules.cc file.

BUG=None

Review-Url: https://codereview.chromium.org/2540613003
Cr-Commit-Position: refs/heads/master@{#435667}

BUG=655247
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2539163003
Cr-Commit-Position: refs/heads/master@{#435666}

Mark virtual/mojo-loading/http/tests/xmlhttprequest/workers/shared-worker-response-type-blob-sync.html as flaky timeout.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fmojo-loading%2Fhttp%2Ftests%2Fxmlhttprequest%2Fworkers%2Fshared-worker-response-type-blob-sync.html&testType=webkit_tests

BUG=659917
TBR=yhirano@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2548563002
Cr-Commit-Position: refs/heads/master@{#435665}

This allows the Browser Task Scheduler to initialize during
CreateThreads since SetupMetrics() ultimately requires use of the
blocking pool. The blocking pool has to be redirected by the Browser
Task Scheduler before this point

BUG=662052

Review-Url: https://codereview.chromium.org/2514373003
Cr-Commit-Position: refs/heads/master@{#435664}

The CL crrev.com/2480353006 introduced a bug by not changing focus on gesture
generated context menus. This CL adds back the logic changing focus logic.

BUG=668034

Review-Url: https://codereview.chromium.org/2544653002
Cr-Commit-Position: refs/heads/master@{#435663}

When Contextual Cards integration is enabled we now check for server
diagnostic data in the response and output it to the log when on a
debug build.

BUG=644934

Review-Url: https://codereview.chromium.org/2542813002
Cr-Commit-Position: refs/heads/master@{#435662}

This CL lands server changes 140349928 by alyssar and 140661724 by bnc.

BUG=624095, 488484

Review-Url: https://codereview.chromium.org/2544813002
Cr-Commit-Position: refs/heads/master@{#435661}

Tab switcher sometimes hides one tab stack incorrectly if sufficient
time has not elapsed between creating a new tab and tapping on tab
switcher. Cancelling the unfinished animation before starting a new
animation fixes this bug.

BUG=571364

Review-Url: https://codereview.chromium.org/2546603002
Cr-Commit-Position: refs/heads/master@{#435660}

- Fixed the animation so that the toolbar animates in when it's locked
by an object

BUG=659752

Review-Url: https://codereview.chromium.org/2542803002
Cr-Commit-Position: refs/heads/master@{#435659}

Ash has not shipped on Windows for years so we're removing support.

BUG=666775
TEST=bots

Review-Url: https://codereview.chromium.org/2546783003
Cr-Commit-Position: refs/heads/master@{#435658}

In preparation of moving Task Scheduler initialization to the content
CreateThreads phase, metrics has to be initialized during
PreMainMessageLoopRun.

The only reference to metrics during PreCreateThreads was in the
IO Thread state initialization to set up a IO thread to UI thread
forwarder that reported network connection state (e.g. cellular or not).

This change moves that initialization to be called on demand as the
callback is not needed until the first network URL request is satisfied.
This happens after CreateThreads and generally after PreMainMessageLoopRun.

BUG=662052

Review-Url: https://codereview.chromium.org/2517363002
Cr-Commit-Position: refs/heads/master@{#435657}

Adds a clone() method to MediaStreamComponent that carries over enabled
and muted state which should carry over when cloning a MediaStreamTrack.

MediaStreamTrack's id intentionally does not carry over and remains
unique.

R=guidou@chromium.org,esprehn@chromium.org
BUG=669212

Review-Url: https://codereview.chromium.org/2540263003
Cr-Commit-Position: refs/heads/master@{#435656}

It's common to add --mash to the /etc/chrome_dev.conf when working on a
Chrome OS device. However, that can lead to two copies of --mash if you run
an autotest on the device that also passes --mash. This makes Chrome crash.

Ignore duplicate --mash flags.

BUG=669705
TEST=Run chrome --mash --mash, doesn't crash.

Review-Url: https://codereview.chromium.org/2545633002
Cr-Commit-Position: refs/heads/master@{#435655}

BUG=582315

Review-Url: https://codereview.chromium.org/2256913002
Cr-Commit-Position: refs/heads/master@{#435654}

Some useful subresources could be fetched by webpages via XMLHttpRequest. This
CL adds support of this type of requests to ResourcePrefetchPredictor.

BUG=631966

Review-Url: https://codereview.chromium.org/2539263004
Cr-Commit-Position: refs/heads/master@{#435653}

Skip DevToolsPixelOutputTests.TestLatencyInfoInstrumentation in site_per_process_browser_tests due to flakiness.

Doesn't seem similarly flaky on browser_tests, but further investigation is needed.

BUG=670362
TBR=lukasza@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2538923004
Cr-Commit-Position: refs/heads/master@{#435652}

Due to third-party modifications, some devices access the disk in
Context#bindService(). This call is supposed to be safe to make from
the UI thread, so suppress the StrictMode violation.

BUG=670195

Review-Url: https://codereview.chromium.org/2549473002
Cr-Commit-Position: refs/heads/master@{#435651}

BUG=angleproject:1442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2542653002
Cr-Commit-Position: refs/heads/master@{#435650}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/852f85163d54..da3aa694af97

$ git log 852f85163..da3aa694a --date=short --no-merges --format='%ad %ae %s'
2016-12-01 simonhatch Dashboard - Also check for "staging_win" when modifying non-telemetry commands.

BUG=668529

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2546653004
Cr-Commit-Position: refs/heads/master@{#435649}

You can now run an alternative window manager from mash_session, mash_init etc by passing --window-manager=<name_of_wm>

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2511233002
Cr-Commit-Position: refs/heads/master@{#435648}