- 07 Dec, 2018 40 commits
-
-
Xianzhu Wang authored
Some tests have already been passing since BlinGenPropertyTrees is promoted to experimental. Change-Id: I3f99c22550461b096199cef9bbda458f5fcac1d8 Reviewed-on: https://chromium-review.googlesource.com/c/1366277 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#614749}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f7ba919cedb..92795e7e949d Created with: gclient setdep -r src-internal@92795e7e949d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7be99a4a0ca55640be8b582e31d5f2d5ee09bcc5 Reviewed-on: https://chromium-review.googlesource.com/c/1367869Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614748}
-
Akihiro Ota authored
This change only reflects updates to Android-specific code. Substituting recently implemented AXNode::GetPosInSet() and AXNode::GetSetSize() functions when posinset and setsize computations are necessary. Change-Id: I6cd876921cd1ab8cc6f47f058dcfc88d7c365897 Reviewed-on: https://chromium-review.googlesource.com/c/1361654 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#614747}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3f10ca8145d9..10b051083c0d git log 3f10ca8145d9..10b051083c0d --date=short --no-merges --format='%ad %ae %s' 2018-12-07 mbonadei@webrtc.org Disable hermetic toolchain when building on macOS 10.14. Created with: gclient setdep -r src/third_party/webrtc@10b051083c0d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I696e0aa56bd9afd0f8548ce08d25bca532a52332 Reviewed-on: https://chromium-review.googlesource.com/c/1367965Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614746}
-
Ben Pastene authored
And add a test notification for a couple builders. R=nodir, tandrii Bug: 903591 Change-Id: Ic034e8729a9dfdea522ea720e26bddc7466fd6cf Reviewed-on: https://chromium-review.googlesource.com/c/1367113 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#614745}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/8e13fe5e8564..e7e4b386a365 git log 8e13fe5e8564..e7e4b386a365 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 jchinlee@chromium.org Move vpython dependency declaration higher. Created with: gclient setdep -r src/native_client@e7e4b386a365 The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:912379 TBR=mseaborn@chromium.org Change-Id: I109f8ccfa8a3b1cbe2e29bbf89950e3a1c92f294 Reviewed-on: https://chromium-review.googlesource.com/c/1367967Reviewed-by:
-
Yuly Novikov authored
conformance/glsl/constructors/glsl-construct-ivec4.html on Android Nvidia conformance/glsl/constructors/glsl-construct-mat2.html on Nexus 5X TBR=kbr@chromium.org Bug: 912161 Change-Id: I9d772e5defe1f76fbb1235a1af924ae2a7a7e059 Reviewed-on: https://chromium-review.googlesource.com/c/1367932Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#614743}
-
bsheedy authored
Makes the environment variable paths set by XR browser tests relative to the test binary's location instead of the current working directory. This makes the tests runnable from any directory instead of only from the output directory. Bug: 912392 Change-Id: I0f6ef8e2019add1457807b3d645d18e6b413b1de Reviewed-on: https://chromium-review.googlesource.com/c/1367101Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#614742}
-
khachatryan authored
Checking if Chrome version is compatible with ChromeDriver version.. Change-Id: Ib7f9be9133e69b2c670b94fc6fec20a9598aed65 bug: chromedriver:2685 Reviewed-on: https://chromium-review.googlesource.com/c/1363687Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#614741}
-
James Cook authored
This eliminates calls to AXAuraObjCache::GetInstance() and is a step towards making the cache not be a singleton. Bug: 888147 Test: views_unittests Change-Id: I94dee9693881ff760be1c32b084072379e5d803b Reviewed-on: https://chromium-review.googlesource.com/c/1359093 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#614740}
-
Stefan Zager authored
This reverts commit 2d343ac8. Reason for revert: Compile failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/5323 Original change's description: > [Feed] Import feed@8f0baf678cd55565412717d583f036a9b529bfdc > > +62,280 bytes main lib size > +479,128 bytes main dex size > +771,550 bytes normalized apk size > +295,224 bytes APK size > +855,804 bytes Estimated installed size (Android Go) > +2,230,901 bytes Estimated installed size > InstallBreakdown (+2,229,176 bytes): > +2,802 bytes unwind_cfi (dev and canary only) size > +2,718 bytes Non-compiled Android resources size > +62,280 bytes Native code size > +551 bytes Package metadata size > +2,145,521 bytes Java code size > +15,304 bytes Compiled Android resources size > +2,448 entries fields > +3,462 entries methods > +789 entries types > +1,727 entries strings > > Specifics: > InstallSize: > Dex: > Change-Id: Iee99df34b6c2fe177619c9d8978b10351b7a6375 > Reviewed-on: https://chromium-review.googlesource.com/c/1367364 > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Commit-Queue: Sky Malice <skym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614728} TBR=fgorski@chromium.org,skym@chromium.org Change-Id: I70d82a859a0dc8ad2cd2547d386874176ff2bd68 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1368047Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#614739}
-
Peng Huang authored
This reverts commit 1808a743. Reason for revert: Null-dereference READ in gpu::gles2::ContextState::api https://crbug.com/912981 Original change's description: > Share one GLContext for all RasterDecoder when virtual context is used. > > With this CL, we will create a GLContextVirtual in RasterDecoderContextState, > and share it with all raster decoders, display compositoer, etc. It is a > temporary solution. In follow up CLs, we will share the one GLContext with > GLES2 as well. In that case, we will use GLContext directly instead of > GLContextVirtual. > > Change-Id: If9b8d1f32e58b32a9d9f8cd07aa10c30432e3183 > Bug: 902904 > Reviewed-on: https://chromium-review.googlesource.com/c/1357463 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614694} TBR=penghuang@chromium.org,piman@chromium.org Change-Id: I2eb66f211d408988f30bfb870425da80e0eb7a4b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902904 Reviewed-on: https://chromium-review.googlesource.com/c/1368284Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#614738}
-
Robert Liao authored
If there is no MessageLoop and SingletonHwnd is receiving messages, this means it is receiving messages via an external message pump such as COM Uninitialization. It is unsafe to forward these messages as observers may depend on the existence of a MessageLoop to proceed. BUG=912626 Change-Id: I9d6e76a03931db59450ac4b3d17c6aeaa365061b Reviewed-on: https://chromium-review.googlesource.com/c/1366278Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#614737}
-
Mason Freed authored
TBR=masonfreed@chromium.org NOTRY=true Bug: 912748 Change-Id: Ifd814b53adc325737cc5f688551e6fe9c64d910f Reviewed-on: https://chromium-review.googlesource.com/c/1368164Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#614736}
-
Vasilii Sukhanov authored
It can contain URL and it's undesired to truncate its end. Bug: 910681 Change-Id: I187831c2295c8b964239880cb27ce1b426322658 Reviewed-on: https://chromium-review.googlesource.com/c/1367673Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#614735}
-
Philip Rogers authored
This patch removes a bad baseline added in https://crrev.com/614470 and marks the test as passing. Bug: 912380 Change-Id: Ia4cab4002371ff23e75c82f717a12689c7dfdf2a Reviewed-on: https://chromium-review.googlesource.com/c/1367931 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#614734}
-
braveyao authored
With a recent change, the webrtc::DesktopFrame is created and initialized with 0. So it's not necessary to call memset() to the frame again any more. Bug: webrtc:9703 Change-Id: Id3b37940ad3a1e989725db578f743670c786e681 Reviewed-on: https://chromium-review.googlesource.com/c/1366785Reviewed-by:
Julien Isorce <julien.isorce@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#614733}
-
Kazuhiro Inaba authored
This reverts commit 1ceb0793. Reason for revert: ARC and Crostini on ARM broken (crbug.com/896945#c17) Original change's description: > Reland "viz: Turn off or crop primary plane when possible" > > This is a reland of I7946d7acab334bffdf2bb49a1d9c424cf46fc610 and > the following bug fixes as follows; > "viz: Fix wrong uv_rect calculation" 4bf9d01d > "viz: add unittests for CL:1291590" f8dfbe74 > > Additional fix: > - Fix the flickering issue because of primary |uv_rect| cropping even though > an overlay attemption fails mainly due to limited pixel rate (e.g. 4k video). > - Fix wrong |uv_rect| calculation which causes atomic page flip failures with > "No space left on device (28)" error. > > Original change's description: > > viz: Turn off or crop primary plane when possible > > > > For many fullscreen cases, the rest of the renderpass quads are solid > > black quads. In that case, we can turn off the primary plane, and not > > having to scan out an full screen of black pixels saves a good deal of > > power. In other cases, we can crop down the primary plane down to the > > content rectangle (youtube channel logo, for example) and save power. > > > > Averaging battery draw measurement over about a minute of play back > > for a fullscreen youtube video, power savings for soraka is around > > 500mW (6.5W to 6.0W) and 300mW for kevin (4.4W to 4.1W), when we > > turn off the primary plane. > > > > Change-Id: I7946d7acab334bffdf2bb49a1d9c424cf46fc610 > > Reviewed-on: https://chromium-review.googlesource.com/c/1045256 > > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > > Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com> > > Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#600415} > > TEST=SingleOverlayOnTopTest.AllowVideoNormalTransformWithOutputSurfaceOverlay > > Bug: 896945, 900373 > Change-Id: I88db118dbc3ca2fed8c8eaf1f9a4337cdae12990 > Reviewed-on: https://chromium-review.googlesource.com/c/1346997 > Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> > Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com> > Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611484} TBR=dongseong.hwang@intel.com,dcastagna@chromium.org,hoegsberg@chromium.org Bug: 896945, 900373 Change-Id: Iec6d2812d94c286c495d90d8952b65ecffa4c010 Reviewed-on: https://chromium-review.googlesource.com/c/1363734Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#614732}
-
James Cook authored
Bug: none Change-Id: Icf58036bec43cd560ca8119428bcf6b5d2e17004 Reviewed-on: https://chromium-review.googlesource.com/c/1367656Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#614731}
-
Sahel Sharify authored
Revert "Register fling scheduler on GSB instead of GFS." and Revert "Fixed fling regression from registering observer on GSB instead of GFS." This reverts the following two commits: 0b48b62c 0e58f2ca The reason for reverting is that registering fling scheduler observer on GSB instead of GFS does not fix the one frame jank at the beginning of the fling. This change also caused some performance regressions and touchpad scrolling regression on eve. Bug: 882907,911975,911334,903161,903156,903155 Change-Id: I6aba2c0314eeab616fcb1c18c448c0b3c075d4e6 Reviewed-on: https://chromium-review.googlesource.com/c/1363893Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#614730}
-
Eric Karl authored
This chnage causes RenderWidget to invalidate its current LocalSurfaceId whenever it sends WidgetHostMsg_TextInputStateChanged, causing a new RenderFrameMetadata to be sent for the given frame. This ensures that CursorAnchorInfoController receives updates on any frame with a text change. Bug: 912309 Change-Id: Ia1b0faa8bbb0208187d31f0024a17ffdd75bda16 Reviewed-on: https://chromium-review.googlesource.com/c/1364164 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#614729}
-
Sky Malice authored
+62,280 bytes main lib size +479,128 bytes main dex size +771,550 bytes normalized apk size +295,224 bytes APK size +855,804 bytes Estimated installed size (Android Go) +2,230,901 bytes Estimated installed size InstallBreakdown (+2,229,176 bytes): +2,802 bytes unwind_cfi (dev and canary only) size +2,718 bytes Non-compiled Android resources size +62,280 bytes Native code size +551 bytes Package metadata size +2,145,521 bytes Java code size +15,304 bytes Compiled Android resources size +2,448 entries fields +3,462 entries methods +789 entries types +1,727 entries strings Specifics: InstallSize: Dex: Change-Id: Iee99df34b6c2fe177619c9d8978b10351b7a6375 Reviewed-on: https://chromium-review.googlesource.com/c/1367364Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#614728}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e14feaf5b9aa..0c2dc8c378bb git log e14feaf5b9aa..0c2dc8c378bb --date=short --no-merges --format='%ad %ae %s' 2018-12-07 syoussefi@chromium.org Vulkan: Fix dirty default attributes handling Created with: gclient setdep -r src/third_party/angle@0c2dc8c378bb The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I1ed90b16d53425d64953254fb485c076b7389fe1 Reviewed-on: https://chromium-review.googlesource.com/c/1367964Reviewed-by:
-
sebsg authored
Bug: 907929 Change-Id: I5327254e20e4e6bbbfd0d8fc35d24e1dd5814917 Reviewed-on: https://chromium-review.googlesource.com/c/1366374Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#614726}
-
Xida Chen authored
This CL adds a AddPaintWorkletImage which is used in the GatherDiscardableImages when we update a display item list after recording. Essentially this makes the recording source aware of a cc::PaintImage that is backed by a PaintWorkeltInput. Two unit test are added to make sure the correctness. Bug: 907897 Change-Id: I2144a5c729e41b15ae4083ae3b8fcaf4a2ea204d Reviewed-on: https://chromium-review.googlesource.com/c/1365878Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#614725}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dddb0585df2c..5f7ba919cedb Created with: gclient setdep -r src-internal@5f7ba919cedb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I234c7aff71cd2dc8f312c1fddbd58ae3d9df8db4 Reviewed-on: https://chromium-review.googlesource.com/c/1367866Reviewed-by:
-
Nico Weber authored
This entry is already present further down for !is_android && !is_mac, so no need to add it in a is_chromeos-specific block. No intended behavior change. Bug: 912946 Change-Id: I232b056a7e72271e6ecb81243dc79193cfbb751d Reviewed-on: https://chromium-review.googlesource.com/c/1368045Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#614723}
-
gogerald authored
Bug: 912701 Change-Id: I57efa7240173559172b7ccb370a8c18a8cfc6eae Reviewed-on: https://chromium-review.googlesource.com/c/1366696Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#614722}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9dff9d14..d888ec76 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic8cc1605416da07af7d4224cdf090a40c00046d9 Reviewed-on: https://chromium-review.googlesource.com/c/1367824Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614721}
-
Anthony Vallee-Dubois authored
This flag was enabled by default and had no Finch config applying Bug: None Change-Id: Icdff821f271fb2c284e423a6395d8550ad720f4a Reviewed-on: https://chromium-review.googlesource.com/c/1358703Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#614720}
-
Sam Maier authored
Bug: 0 Change-Id: I07d2fffa1e19232449cf10cf9980b2cdac5479cc Reviewed-on: https://chromium-review.googlesource.com/c/1367930Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#614719}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/cf37ab7213d2..6df6194db8b5 git log cf37ab7213d2..6df6194db8b5 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 dneto@google.com Validate Uniform decoration (#2181) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@6df6194db8b5 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I05a0dad84d5b026b39d2ebe937069ecf5838b498 Reviewed-on: https://chromium-review.googlesource.com/c/1367591Reviewed-by:
-
Samuel Huang authored
[Sheriff] Disable virtual/threaded/http/tests/devtools/tracing/user-timing.js on Mac due to flakiness. Culprit CL: https://chromium-review.googlesource.com/c/chromium/src/+/1359865 Tbr: pauirish@chromium.org Bug: 912821 Change-Id: If93c89a65a8c60bfed61719c5282156e36024f94 Reviewed-on: https://chromium-review.googlesource.com/c/1367925 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#614717}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=wfh@chromium.org Bug: 903957 Change-Id: I05f97174944bdfa66f032067fd90ac37a7523eaf Reviewed-on: https://chromium-review.googlesource.com/c/1366018Reviewed-by:Will Harris <wfh@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#614716}
-
Vadym Doroshenko authored
This CL implements checking on IsProbablyNotUsername for candidates in username values as it is in the old parser (IsProbablyNotUsername in password_form_manager.cc) Bug: 831123, 912918 Change-Id: I54fe88d5b87b26c5b5829c3db1f7cf5d3513170c Reviewed-on: https://chromium-review.googlesource.com/c/1367726 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#614715}
-
Bence Béky authored
Move creation of WebSocketHandshakeStreamCreateHelper to WebSocketStreamRequestAPI derived class constructor, making it possible to eliminate WebSocketHandshakeStreamCreateHelper::set_stream_request(). This is not directly related to the crasher bug, but while I was digging into the ownership dependencies and lifetime issues I stumbled upon this low-hanging fruit for simplification. Bug: 850183 Change-Id: Iaf73ec9d70fa4bfe7aac08314282b31208b9a207 Reviewed-on: https://chromium-review.googlesource.com/c/1365657 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#614714}
-
Samuel Huang authored
This reverts commit 1ec12653. Reason for revert: Likely to cause consistent failures in single_process_mash_interactive_ui_tests for linux-chromeos-dbg due to assertion failure from missing icon "cr:insert-drive-file". Bug: 912678 Original change's description: > Downloads: detect failed file icons and show default thumbnail > > On the downloads page, we consult the system for a themed image for the > type of file downloads. Ex: zip files -> archive icon. > > When a system doesn't know why type of icon to show for a specific file > type, it can either return a default or nothing. Right now, Linux > returns nothing, so we show nothing. chrome://fileicon tries to warn > us by giving a network error (which has been ignored until now). > > So, when a chrome://fileicon fails to load, show a default filetype > icon in respond. > > Before & after screenshots: https://imgur.com/a/txRbfIG > > R=dpapad@chromium.org > BUG=855259 > > Change-Id: I370fd8ea119b194ad8e1ba7e0dfad32c6cea1bbe > Reviewed-on: https://chromium-review.googlesource.com/c/1132560 > Commit-Queue: Dan Beam <dbeam@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614581} TBR=dbeam@chromium.org,dpapad@chromium.org Change-Id: I4ef27f132954754a80e3b3def4aadf5774b3875d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855259 Reviewed-on: https://chromium-review.googlesource.com/c/1367933Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/158df43c2d19..7a3805c348c3 git log 158df43c2d19..7a3805c348c3 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 scroggo@google.com SkWuffsCodec: Do not swizzle frame of width 0 2018-12-07 brianosman@google.com Half float vertex colors (when necessary) in small path renderer 2018-12-07 reed@google.com remove unused drawText entry-points in LiteDL 2018-12-07 brianosman@google.com Use GrVertexWriter and support half-float colors in rrect ops 2018-12-07 kjlubick@google.com [canvaskit] Add createPattern support to canvasAPI 2018-12-07 reed@google.com guard paint's breaktext -- trying to remove it 2018-12-07 reed@google.com remove dead methods leftover from drawPosText etc. Created with: gclient setdep -r src/third_party/skia@7a3805c348c3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I9152253fd275c8fd61dfdba2ddcc699c3cd7435f Reviewed-on: https://chromium-review.googlesource.com/c/1367865Reviewed-by:
-
Tommy Martino authored
This CL adds a new option to the Autofill dropdown footer. This consists of: * Changes to components/autofill to include the row as a suggestion under the appropriate conditions. * Changes to the native popup views to display properly if only footer rows are present. (This was not possible before the introduction of the new row type.) * Updates to the autofill_popup_layout_model to return a Google "G" logo as one of the possible icons. * Moves a Google "G" logo vector icon to be available on platforms other than Mac. Bug: 912303 Change-Id: Idc03d7eccc1d9ea371ece79475b0b6e738ce0853 Reviewed-on: https://chromium-review.googlesource.com/c/1356199 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#614711}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/18f0c3c038fc..3f10ca8145d9 git log 18f0c3c038fc..3f10ca8145d9 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 benwright@webrtc.org Always record receive timestamps even on when the invalid flag is set. 2018-12-07 sprang@webrtc.org Include protection bitrate in total max allocated bitrate 2018-12-07 jonasolsson@webrtc.org Export the standardized IceConnectionState. 2018-12-07 saza@webrtc.org Fuzz unfuzzed AEC3 killswitch field trials 2018-12-07 nisse@webrtc.org Replace RegisterExternalDecoder in NetEq test VerifyTimestampPropagation. 2018-12-06 sukhanov@webrtc.org Make sure media transport is deleted before ICE. 2018-12-06 emircan@webrtc.org Add visibility for rtc_vp9_profile 2018-12-06 mirtad@webrtc.org Replace VideoEncoderFactory::QueryVideoEncoder with VideoEncoder::GetEncoderInfo 2018-12-06 kwiberg@webrtc.org Introduce some placeholder build targets 2018-12-06 srte@webrtc.org Merges RtpTransportControllerSend with SendSideCongestionController. 2018-12-06 benwright@webrtc.org Adding partial authentication of the Generic RTP Frame Descriptor. 2018-12-06 orphis@webrtc.org Copy VP8EncoderSimulcastProxy to EncoderSimulcastProxy Created with: gclient setdep -r src/third_party/webrtc@3f10ca8145d9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I457ec21aeb581a7da2a38ecbb92f346e9b274b24 Reviewed-on: https://chromium-review.googlesource.com/c/1367588Reviewed-by:
-
