GitLab

Cr-Commit-Position: refs/heads/master@{#294738}

BUG=None

Review URL: https://codereview.chromium.org/506943003

Cr-Commit-Position: refs/heads/master@{#294737}

PrintWebViewHelperTest.PrintWithIframe document.write()s into
a loaded iframe without a document.close(). This blocks the load event in the parent frame and will soon block load completion notifications.

BlockScriptInitiatedPrinting operates on an initial empty document, which can have strange effects. Load one of the html strings provided in that file, just so we have a real document to work with.

BUG=

Review URL: https://codereview.chromium.org/568933002

Cr-Commit-Position: refs/heads/master@{#294736}

The IOHIDManager object manages the IOHIDDevice instances that it
creates. Calling IOHIDDeviceOpen on such an instance is a no-op and
calling IOHIDDeviceClose prevents the IOHIDManager from tracking the
lifetime of the device. The solution is to never open nor close these
devices.

BUG=413976

Review URL: https://codereview.chromium.org/568873003

Cr-Commit-Position: refs/heads/master@{#294735}

These classes do not need to be classes and expecially don't need to be
abstract classes as this leads to a complicated implementation and
complicated tests. All USB devices no matter the platform will have the
same descriptor data.

This change follows the model of device::HidDeviceInfo.

Relanding this patch (reverted in crrev.com/294640) after restoring the
call to libusb_free_config_descriptor that was removed during
refactoring and caused failures in the Linux ASan LSan tests.

BUG=

Review URL: https://codereview.chromium.org/568943002

Cr-Commit-Position: refs/heads/master@{#294734}

https://skia.googlesource.com/skia/+log/c34b0d4e9ad5806c1f882a1f85191f2ea8ddcdba..abaef86f2b37d8a939506a2076da07f6db456951

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/569843003

Cr-Commit-Position: refs/heads/master@{#294733}

This is a cleanup patch.

ServiceWorkerProviderHost owns ServiceWorkerRegistration and the registration
owns ServiceWorkerVersions, so the provider host doesn't need to hold them.

BUG=n/a
TEST=run_webkit_tests.py --debug http/tests/serviceworker/

Review URL: https://codereview.chromium.org/563923005

Cr-Commit-Position: refs/heads/master@{#294732}

- add 'No matches were found.' hint
- adjust search bubble content when text option content changes
- fix extra padding

BUG=413520,413522

Review URL: https://codereview.chromium.org/568973002

Cr-Commit-Position: refs/heads/master@{#294731}

We are still passing it around and scaling a rect by it but it is
always 1 so just make that explicit.

R=vmpstr

Review URL: https://codereview.chromium.org/566023004

Cr-Commit-Position: refs/heads/master@{#294730}

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/568873004

Cr-Commit-Position: refs/heads/master@{#294729}

These traces were really helpful in tracking out why things were getting
prioritized wrong.

BUG=410625

Review URL: https://codereview.chromium.org/568183002

Cr-Commit-Position: refs/heads/master@{#294728}

Currently we always intersect GetViewportForTilePriorityInContentSpace()
with the visible_content_rect(), so instead just intersect before
returning so we can always use that value more simply.

R=boliu

Review URL: https://codereview.chromium.org/571653003

Cr-Commit-Position: refs/heads/master@{#294727}

Since it's added to the NSThemeFrame directly as a subview, it also needs to be
removed/added during the fullscreen transition animation.

BUG=411770

Review URL: https://codereview.chromium.org/566473002

Cr-Commit-Position: refs/heads/master@{#294726}

We shouldn't have dependencies on chromium types and whatnot in
mojo/public/

Review URL: https://codereview.chromium.org/565323002

Cr-Commit-Position: refs/heads/master@{#294725}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/570773002

Cr-Commit-Position: refs/heads/master@{#294724}

This unfortunately means converting what are currently sandbox_bpf unit
tests into effectively integration tests for bpf_dsl, as they now test
both bpf_dsl + sandbox_bpf.  However, this is a necessary step towards
eliminating dependencies on the current sandbox_bpf API so that we can
more freely evolve it to fit bpf_dsl's needs.

For ease of review, this only converts tests that were already using
SandboxBPFPolicy (i.e., BPF_TEST()s are left alone), and some of the
conversions are slightly non-idiomatic in the interest of mimicking the
existing test structure.  Both of these will be addressed further in
followup CLs so that this CL can be reviewed as a mere translation of
policies from the sandbox_bpf API to bpf_dsl.

Review URL: https://codereview.chromium.org/559653004

Cr-Commit-Position: refs/heads/master@{#294723}

As the second of a three-sided set of change:
This change lays the groundwork for Blink to own the app-visible pieces
of the MSE initialization segment received algorithm. It lets
SourceState notify WebSourceBufferImpl upon parsing an initialization
segment. WSBI then notifies its WebSourceBufferClient.
Updated unit tests are included.

R=acolwell@chromium.org
TEST=No media_unittest regression
BUG=249428,397243

Review URL: https://codereview.chromium.org/547223003

Cr-Commit-Position: refs/heads/master@{#294722}

Ensure that on Windows 7, relaunching the browser via chrome://restart or changing about:flags relaunches into Chrome OS mode.

There were two problems here.
1. The viewer process on Windows 7 would not die : Fixed by destroying the window when we get a
   signal from the browser process that the viewer needs to die.

2. Relaunching on Windows 7 would relaunch the existing browser process with the same command line.
   On Windows 8 relaunch launches back into Windows 8 mode as delegate execute has code to launch back
   into the previous mode. On Windows 7 we don't have that luxury. The current approach is to detect
   that we are in Windows 7 in a browser launched to service the viewer process and return that we
   need to launch into Chrome OS mode. Additionally we set the corresponding pref to ensure that
   this is honored.

BUG=413101

Review URL: https://codereview.chromium.org/568623002

Cr-Commit-Position: refs/heads/master@{#294721}

This patch implements the Chromium-side change of
ServiceWorkerContainer#getRegistration().

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#navigator-service-worker-getRegistration

[1/3] https://codereview.chromium.org/553983010/
[3/3] https://codereview.chromium.org/540823003/

BUG=404951
TEST=content_unittests

Review URL: https://codereview.chromium.org/535753002

Cr-Commit-Position: refs/heads/master@{#294720}

BUG=314889

Review URL: https://codereview.chromium.org/560983002

Cr-Commit-Position: refs/heads/master@{#294719}

First, it is a good cleanup to avoid an extra copy of all the variable info.
Second, this cleanup will make switching to ANGLE's new APIs to query variable
info much easier.

BUG=401311
TEST=gpu_unittests, webgl_conformance_tests
R=bajones@chromium.org,kbr@chromium.org,piman@chromium.org

Review URL: https://codereview.chromium.org/566023002

Cr-Commit-Position: refs/heads/master@{#294718}

 Added CHECKs in static methods in ash::Shell/RootWindowController to identify the chrome code accessing ash

BUG=410444
TBR=sky@chromium.org
TEST=tested on Pixel

Review URL: https://codereview.chromium.org/549453005

Cr-Commit-Position: refs/heads/master@{#294717}

https://skia.googlesource.com/skia/+log/83658305a1bda2d862f50145ecf5cb697b575e86..c34b0d4e9ad5806c1f882a1f85191f2ea8ddcdba

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/569803002

Cr-Commit-Position: refs/heads/master@{#294716}

BUG=413513

Review URL: https://codereview.chromium.org/568793002

Cr-Commit-Position: refs/heads/master@{#294715}

There's no functional change in this CL.

I clarified the behavior of resolution changes for video capture devices
by using an enum to describe resolution change policy instead of a
simple boolean.

BUG=388355

Review URL: https://codereview.chromium.org/541163002

Cr-Commit-Position: refs/heads/master@{#294714}

BUG=402728

Review URL: https://codereview.chromium.org/559103003

Cr-Commit-Position: refs/heads/master@{#294713}

TBR=cpu@chromium.org,jochen@chromium.org,piman@chromium.org,rockot@chromium.org,rsleevi@chromium.org,vrk@chromium.org
,zea@chromium.org

Review URL: https://codereview.chromium.org/563173002

Cr-Commit-Position: refs/heads/master@{#294712}

Previously, the TouchEventQueue would flush itself when notified that
all touch handlers have been removed. As that is no longer the case,
remove the assert verifying that the queue is empty when notified that
a touch handler has been added.

BUG=406916

Review URL: https://codereview.chromium.org/569793003

Cr-Commit-Position: refs/heads/master@{#294711}

Remove cc:RasterRequiredForActivation synthetic delays from raster
worker pools and disable pages that use it.

R=reveman@chromium.org, skyostil@chromium.org, brianderson@chromium.org
BUG=

Review URL: https://codereview.chromium.org/569733002

Cr-Commit-Position: refs/heads/master@{#294710}

In general, GN assumes that static libraries are intermediate targets and
will forward their child dependencies up the tree until a "final" target
is reached. Until now, this meant only shared_library and executable targets.
This change introduces the notion of a "complete" static_library target
which is linked and, as such, suitable for distribution.

BUG=413776
TEST=gn_unittests
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/565283002

Cr-Commit-Position: refs/heads/master@{#294709}

An edge case around direction and playback rate is calculating the time
incorrectly. In particular, when the playback rate is negative and the
direction is set to AlternateReverse, the resulting iteration times
calculated are incorrect. This change brings the compositor in line
with the Web Animation Spec to calculate the iteration time.

Reference for calculations:
http://dev.w3.org/fxtf/web-animations/#core-animation-node-calculations

BUG=398330

Review URL: https://codereview.chromium.org/565353003

Cr-Commit-Position: refs/heads/master@{#294708}

Becuase base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/568173004

Cr-Commit-Position: refs/heads/master@{#294707}

Currently each render surface takes as its clip rect for visible content
rects as the clip rect directly clipping its own surface, but drops the
clip for visible content rects from outside the surface.

This means that the viewport does not clip the visible_content_rect of
any layers that aren't in the root surface. Fixed by intersecting this
clip for visible content rects with the one from outside the surface.

BUG=410625

Review URL: https://codereview.chromium.org/565353002

Cr-Commit-Position: refs/heads/master@{#294706}

The memory allocated for an enumeration should be freed when a backend
is deleted.

R=clamy@chromium.org,jkarlin@chromium.org
BUG=410276

Review URL: https://codereview.chromium.org/533293002

Cr-Commit-Position: refs/heads/master@{#294705}

No need to keep useless helper mocks around. This also helps clean up
VideoRendererImpl's unit tests in preparation for switching to the
scheduler.

Review URL: https://codereview.chromium.org/566853006

Cr-Commit-Position: refs/heads/master@{#294704}

Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not have been created at this point.

BUG=413481

Review URL: https://codereview.chromium.org/554583003

Cr-Commit-Position: refs/heads/master@{#294703}

Probably left over from code being moved around.

Review URL: https://codereview.chromium.org/569793002

Cr-Commit-Position: refs/heads/master@{#294702}

BUG=408493, 408534

Review URL: https://codereview.chromium.org/509313002

Cr-Commit-Position: refs/heads/master@{#294701}

 * Fix wrong header guard.
 * Remove or add explicit constructor
 * Remove unwanted semicolon

BUG=None

Review URL: https://codereview.chromium.org/563263002

Cr-Commit-Position: refs/heads/master@{#294700}

When windows are moved the underlying display controller changes. In these cases
we need to hide the cursor before moving and restore it after.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/566953002

Cr-Commit-Position: refs/heads/master@{#294699}