GitLab

Avoid double attribute lookup in HTMLElement::matchesReadWritePseudoClass().
Instead of calling fastHasAttribute() then fastGetAttribute(), call
fastGetAttribute() directly and check if the returned value is nullAtom.

fastHasAttribute() and fastGetAttribute() do exactly the same thing internally
and the only difference is the return type. The attribute lookup is a linear
search and thus it is a good idea to avoid doing it twice.

R=adamk, eseidel

Review URL: https://codereview.chromium.org/184613003

git-svn-id: svn://svn.chromium.org/blink/trunk@168318 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Suspected of causing lots of browser_test failures on Mac:
http://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/23338

> Drop background color optimization for composited layers
> 
> Rationale
> 1. GraphicsLayer deals with background-color layer as a contents layer, so a
> background-color layer is in trouble in terms of the correct order with negative
> z-order children.
> 2. CompositedLayerMapping has the big hack to decide the given layer can be
> background-color layer. Unfortunately, the big hack is incomplete and invasive.
> 3. Hybrid Accelerated Rasterization will cover this optimization in more generic way.
> 4. background-color layer covers very limited cases. A layer-promoted box
> object must not have children, not have decoration, only have a background-color
> property.
> 
> BUG=114658, 340691
> TEST=compositing/background-color/background-color-drawn-over-child.html,
> compositing/*
> 
> Review URL: https://codereview.chromium.org/178013003

TBR=dongseong.hwang@intel.com

Review URL: https://codereview.chromium.org/183763024

git-svn-id: svn://svn.chromium.org/blink/trunk@168317 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This target will replace the current blink_web_test_support target. But
we need to add it first, then change Chromium to use, just after that we
will be able to remove blink_web_test_support from blink.gyp.

In fact webkit_test_support after this three side change lands,
webkit_test_support will actually be renamed to blink_web_test_support.

BUG=None
TEST=content_unittests, blink_tests
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/180743011

git-svn-id: svn://svn.chromium.org/blink/trunk@168315 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=caseq@chromium.org

Review URL: https://codereview.chromium.org/185403008

git-svn-id: svn://svn.chromium.org/blink/trunk@168314 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168303

BUG=114658
TBR=apavlov@chromium.org

Review URL: https://codereview.chromium.org/181063017

git-svn-id: svn://svn.chromium.org/blink/trunk@168312 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman@chromium.org, pfeldman
BUG=347496

Review URL: https://codereview.chromium.org/176843007

git-svn-id: svn://svn.chromium.org/blink/trunk@168311 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/185543006

git-svn-id: svn://svn.chromium.org/blink/trunk@168310 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=erik.corry@gmail.com, eseidel@chromium.org, jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/183833009

git-svn-id: svn://svn.chromium.org/blink/trunk@168309 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Remove Persistent handles from heap allocated CSSRule objects and fix finalization of CSSKeyFramesRule which iterates its children in the destructor. There is no need to do that with oilpan.

R=erik.corry@gmail.com, wibling@chromium.org
BUG=

Review URL: https://codereview.chromium.org/177423010

git-svn-id: svn://svn.chromium.org/blink/trunk@168308 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=346642

Review URL: https://codereview.chromium.org/183923004

git-svn-id: svn://svn.chromium.org/blink/trunk@168307 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some operations such as createClosure and v8::ObjectTemplate::NewInstance
returns an empty handle when the stack is exhausted.
Promise should throw a StackOverFlow exception in such a case.

BUG=345088
R=haraken

Review URL: https://codereview.chromium.org/174073009

git-svn-id: svn://svn.chromium.org/blink/trunk@168306 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL caused a lot of failures in oilpan bots:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan/builds/1657

NOTRY=true

Review URL: https://codereview.chromium.org/185393006

git-svn-id: svn://svn.chromium.org/blink/trunk@168305 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The new implemention logs a different console message for this
case. Updated the expectation accordingly.

This CL requires Chromium CL https://codereview.chromium.org/177403002/ to be landed first.

BUG=346211
TEST=compressed-control-frame.html layout test

Review URL: https://codereview.chromium.org/177433002

git-svn-id: svn://svn.chromium.org/blink/trunk@168304 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
Stale expectations

Original issue's description:
> Auto-rebaseline for r168245
> 
> http://src.chromium.org/viewvc/blink?view=revision&revision=168245
> 
> BUG=114658
> TBR=dongseong.hwang@intel.com
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168273

TBR=dongseong.hwang@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=114658

Review URL: https://codereview.chromium.org/180273011

git-svn-id: svn://svn.chromium.org/blink/trunk@168303 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=apavlov@chromium.org

Review URL: https://codereview.chromium.org/185553006

git-svn-id: svn://svn.chromium.org/blink/trunk@168302 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=331572
TBR=vsevik

Review URL: https://codereview.chromium.org/185383005

git-svn-id: svn://svn.chromium.org/blink/trunk@168301 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r168267 contained obsolete expectations

TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/181493003

git-svn-id: svn://svn.chromium.org/blink/trunk@168300 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168168

BUG=345609
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/183683011

git-svn-id: svn://svn.chromium.org/blink/trunk@168299 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167970

BUG=261177
TBR=fs@opera.com

Review URL: https://codereview.chromium.org/185303009

git-svn-id: svn://svn.chromium.org/blink/trunk@168298 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167954

BUG=342077
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/185533005

git-svn-id: svn://svn.chromium.org/blink/trunk@168297 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167933

BUG=335212
TBR=ziran.sun@samsung.com

Review URL: https://codereview.chromium.org/185783002

git-svn-id: svn://svn.chromium.org/blink/trunk@168296 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167732

BUG=157539
TBR=mario.prada@samsung.com

Review URL: https://codereview.chromium.org/185773002

git-svn-id: svn://svn.chromium.org/blink/trunk@168295 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167929

BUG=346132
TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/185763002

git-svn-id: svn://svn.chromium.org/blink/trunk@168294 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167579

TBR=vollick@chromium.org

Review URL: https://codereview.chromium.org/185753002

git-svn-id: svn://svn.chromium.org/blink/trunk@168293 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167551

BUG=344774
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/184043015

git-svn-id: svn://svn.chromium.org/blink/trunk@168292 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167551

BUG=344774
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/183663013

git-svn-id: svn://svn.chromium.org/blink/trunk@168291 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change splits the model and presentation parts of the timeline recod. Now model + all views operates modal records. TimelineView wraps them in presentation records. Next step is to move filters out of presentation model and make it private to the TimelineView.

R=caseq@chromium.org

Review URL: https://codereview.chromium.org/183893010

git-svn-id: svn://svn.chromium.org/blink/trunk@168290 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The expected output for layout test reserved-bits.html contains warnings
about the deprecation of x-webkit-deflate-frame. Since the new
implementation doens't have that extension or those warnings, remove them.

BUG=346211

Review URL: https://codereview.chromium.org/181303002

git-svn-id: svn://svn.chromium.org/blink/trunk@168289 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=enne,pfeldman

Apparently, it became flaky after r168232.

Review URL: https://codereview.chromium.org/176933003

git-svn-id: svn://svn.chromium.org/blink/trunk@168288 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167551

BUG=344774
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/185723002

git-svn-id: svn://svn.chromium.org/blink/trunk@168287 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This would happen for cases like "BUG=None"

TBR=eseidel

Review URL: https://codereview.chromium.org/185653003

git-svn-id: svn://svn.chromium.org/blink/trunk@168286 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=caseq@chromium.org

Review URL: https://codereview.chromium.org/185333002

git-svn-id: svn://svn.chromium.org/blink/trunk@168285 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=caseq@chromium.org

Review URL: https://codereview.chromium.org/185323002

git-svn-id: svn://svn.chromium.org/blink/trunk@168284 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Don't setStyle the RenderView every style recalc (https://codereview.chromium.org/185263002/)

Reason for revert:
Crash-broke fast/images/link-body-content-imageDimensionChanged-crash.html on "WebKit Android (Nexus 4)"

Original issue's description:
> Don't setStyle the RenderView every style recalc
> 
> Prior to this CL, we were setting the style of the RenderView on every style
> recalc because we were comparing the RenderView's overflow style with the wrong
> value. This CL corrects the bug.
> 
> This CL doesn't have much effect yet, but it will become important in a future
> CL when we use style modification on RenderLayers to scope compositing updates.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168254

TBR=eseidel@chromium.org,esprehn@chromium.org,ojan@chromium.org,abarth@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/183883009

git-svn-id: svn://svn.chromium.org/blink/trunk@168283 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=caseq@chromium.org

Review URL: https://codereview.chromium.org/185233002

git-svn-id: svn://svn.chromium.org/blink/trunk@168282 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=caseq@chromium.org

Review URL: https://codereview.chromium.org/184823002

git-svn-id: svn://svn.chromium.org/blink/trunk@168281 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added null and invalid argument test cases.

Review URL: https://codereview.chromium.org/179493002

git-svn-id: svn://svn.chromium.org/blink/trunk@168280 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167551

BUG=344774
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/185553004

git-svn-id: svn://svn.chromium.org/blink/trunk@168279 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In applyInlineStyleToNodeRange(), a call to removeConflictingInlineStyleFromRun() can modify the start and end Nodes of InlineRunToApplyStyle.

For the crash scenario, the start node being set in removeConflictingInlineStyleFromRun() is invalid and further use of it when calling positionToComputeInlineStyleChange() causes a crash.

Thus adding a check for startAndEndAreStillInDocument() fixes the crash. However, since for the invalid scenario positionForStyleComputation shall not be set, we should check for it's validity before using the same for creating the StyleChange object.

Have added a testcase based on the simplified clusterfuzz testcase added by yoichio in http://crbug.com/343799 which verifies the crash.

BUG=343799

Review URL: https://codereview.chromium.org/181103004

git-svn-id: svn://svn.chromium.org/blink/trunk@168278 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/185673002

git-svn-id: svn://svn.chromium.org/blink/trunk@168277 bbb929c8-8fbe-4397-9dbb-9b2b20218538