GitLab

http://src.chromium.org/viewvc/blink?view=revision&revision=167933

BUG=335212
TBR=ziran.sun@samsung.com

Review URL: https://codereview.chromium.org/185783002

git-svn-id: svn://svn.chromium.org/blink/trunk@168296 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167732

BUG=157539
TBR=mario.prada@samsung.com

Review URL: https://codereview.chromium.org/185773002

git-svn-id: svn://svn.chromium.org/blink/trunk@168295 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167929

BUG=346132
TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/185763002

git-svn-id: svn://svn.chromium.org/blink/trunk@168294 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167579

TBR=vollick@chromium.org

Review URL: https://codereview.chromium.org/185753002

git-svn-id: svn://svn.chromium.org/blink/trunk@168293 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167551

BUG=344774
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/184043015

git-svn-id: svn://svn.chromium.org/blink/trunk@168292 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167551

BUG=344774
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/183663013

git-svn-id: svn://svn.chromium.org/blink/trunk@168291 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change splits the model and presentation parts of the timeline recod. Now model + all views operates modal records. TimelineView wraps them in presentation records. Next step is to move filters out of presentation model and make it private to the TimelineView.

R=caseq@chromium.org

Review URL: https://codereview.chromium.org/183893010

git-svn-id: svn://svn.chromium.org/blink/trunk@168290 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The expected output for layout test reserved-bits.html contains warnings
about the deprecation of x-webkit-deflate-frame. Since the new
implementation doens't have that extension or those warnings, remove them.

BUG=346211

Review URL: https://codereview.chromium.org/181303002

git-svn-id: svn://svn.chromium.org/blink/trunk@168289 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=enne,pfeldman

Apparently, it became flaky after r168232.

Review URL: https://codereview.chromium.org/176933003

git-svn-id: svn://svn.chromium.org/blink/trunk@168288 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167551

BUG=344774
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/185723002

git-svn-id: svn://svn.chromium.org/blink/trunk@168287 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This would happen for cases like "BUG=None"

TBR=eseidel

Review URL: https://codereview.chromium.org/185653003

git-svn-id: svn://svn.chromium.org/blink/trunk@168286 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=caseq@chromium.org

Review URL: https://codereview.chromium.org/185333002

git-svn-id: svn://svn.chromium.org/blink/trunk@168285 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=caseq@chromium.org

Review URL: https://codereview.chromium.org/185323002

git-svn-id: svn://svn.chromium.org/blink/trunk@168284 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Don't setStyle the RenderView every style recalc (https://codereview.chromium.org/185263002/)

Reason for revert:
Crash-broke fast/images/link-body-content-imageDimensionChanged-crash.html on "WebKit Android (Nexus 4)"

Original issue's description:
> Don't setStyle the RenderView every style recalc
> 
> Prior to this CL, we were setting the style of the RenderView on every style
> recalc because we were comparing the RenderView's overflow style with the wrong
> value. This CL corrects the bug.
> 
> This CL doesn't have much effect yet, but it will become important in a future
> CL when we use style modification on RenderLayers to scope compositing updates.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168254

TBR=eseidel@chromium.org,esprehn@chromium.org,ojan@chromium.org,abarth@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/183883009

git-svn-id: svn://svn.chromium.org/blink/trunk@168283 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=caseq@chromium.org

Review URL: https://codereview.chromium.org/185233002

git-svn-id: svn://svn.chromium.org/blink/trunk@168282 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=caseq@chromium.org

Review URL: https://codereview.chromium.org/184823002

git-svn-id: svn://svn.chromium.org/blink/trunk@168281 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added null and invalid argument test cases.

Review URL: https://codereview.chromium.org/179493002

git-svn-id: svn://svn.chromium.org/blink/trunk@168280 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167551

BUG=344774
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/185553004

git-svn-id: svn://svn.chromium.org/blink/trunk@168279 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In applyInlineStyleToNodeRange(), a call to removeConflictingInlineStyleFromRun() can modify the start and end Nodes of InlineRunToApplyStyle.

For the crash scenario, the start node being set in removeConflictingInlineStyleFromRun() is invalid and further use of it when calling positionToComputeInlineStyleChange() causes a crash.

Thus adding a check for startAndEndAreStillInDocument() fixes the crash. However, since for the invalid scenario positionForStyleComputation shall not be set, we should check for it's validity before using the same for creating the StyleChange object.

Have added a testcase based on the simplified clusterfuzz testcase added by yoichio in http://crbug.com/343799 which verifies the crash.

BUG=343799

Review URL: https://codereview.chromium.org/181103004

git-svn-id: svn://svn.chromium.org/blink/trunk@168278 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/185673002

git-svn-id: svn://svn.chromium.org/blink/trunk@168277 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168245

BUG=114658
TBR=dongseong.hwang@intel.com

Review URL: https://codereview.chromium.org/185533003

git-svn-id: svn://svn.chromium.org/blink/trunk@168273 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/184543002

git-svn-id: svn://svn.chromium.org/blink/trunk@168272 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=348401
TEST=fast/css/use-incorrect-svg-crash.html
TBR=morrita@chromium.org, dglazkov@chromium.org

Review URL: https://codereview.chromium.org/183743012

git-svn-id: svn://svn.chromium.org/blink/trunk@168271 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168245

BUG=114658
TBR=dongseong.hwang@intel.com

Review URL: https://codereview.chromium.org/183833008

git-svn-id: svn://svn.chromium.org/blink/trunk@168270 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/176883013

git-svn-id: svn://svn.chromium.org/blink/trunk@168268 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167551

BUG=344774
TBR=jamesr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/183693005

git-svn-id: svn://svn.chromium.org/blink/trunk@168267 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch also allows multiple bugs on the BUG= line, perhaps having some non-digit characters (see r168027 for an example).

It also occurred to me that with this patch committed, we should require that BUG= (and R=) starts at the beginning of line

NOTRY=true

Review URL: https://codereview.chromium.org/177123013

git-svn-id: svn://svn.chromium.org/blink/trunk@168266 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/184043004

git-svn-id: svn://svn.chromium.org/blink/trunk@168265 bbb929c8-8fbe-4397-9dbb-9b2b20218538

InterfaceDependencies.txt was used by Perl.
This is no longer necessary in Python, as we pickle
(which is faster and avoids having ad hoc reading/writing).

R=haraken
BUG=341748

Review URL: https://codereview.chromium.org/180273009

git-svn-id: svn://svn.chromium.org/blink/trunk@168264 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was removed from the spec [1] in favor of endDelay.

[1] https://github.com/web-animations/web-animations-spec/commit/d00254dd8a79ae5f06b3db144f37302bda4f69ce
NOTRY=true
BUG=335350

Review URL: https://codereview.chromium.org/180163003

git-svn-id: svn://svn.chromium.org/blink/trunk@168263 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces the InterpolableValue hierarchy, which stores
the interpolable portion of generic values.

This is part of an effort to refactor the animations pipeline in order
to make it generic on animation value type (see linked master bug).

This header is not yet included anywhere. It will be used in future
patches.

BUG=346495

Review URL: https://codereview.chromium.org/177183007

git-svn-id: svn://svn.chromium.org/blink/trunk@168262 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=335350

Review URL: https://codereview.chromium.org/178663007

git-svn-id: svn://svn.chromium.org/blink/trunk@168261 bbb929c8-8fbe-4397-9dbb-9b2b20218538

(Background: This is a preparation CL for making DOMWrapperWorld::current() callable from anywhere.)

Currently, when we initialize a context, we need to call the following things in a proper order.

- V8PerContextDataHolder::install()
- V8PerContextData::create()
- V8PerContextData::init()
- gin::ContextHolder()
- gin::ContextHolder::SetContext()

However, this is more complicated than necessary. This CL refactors code so that we just need to call V8PerContextData::create() when initializing a context.

Specifically, this CL does the following refactoring:

- Move gin::ContextHolder from V8WindowShell/WorkerScriptController to V8PerContextData.
- Remove V8_STORE_PRIMORDIAL macro.
- Move the contents of V8PerContextData::init() to V8PerContextData's constructor.

BUG=341032

Review URL: https://codereview.chromium.org/180773003

git-svn-id: svn://svn.chromium.org/blink/trunk@168260 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Followup to:
Kill [SetWrapperReferenceFromReference] IDL extended attribute
https://codereview.chromium.org/181513002/

TBR=haraken
BUG=345503

Review URL: https://codereview.chromium.org/176993007

git-svn-id: svn://svn.chromium.org/blink/trunk@168259 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a font resource takes a long time to download, currently Blink
keeps the text invisible until the font is ready. After this patch,
Blink behaves similar to FireFox; keeps the text invisible until 3
seconds, then fallback to the next available font in the fallback
list. When the webfont finally loads, change the text to use it.

- Add a Timer to FontResource that fires after 3 seconds since load start.
- fontLoadWaitLimitExceeded() callback invalidates the fallback font and
  triggers style recalc.
- Fallback fonts have m_skipDrawing boolean in CustomFontData, that is
  false if the font load exceeds the wait limit.
- FontFallbackList::shouldSkipDrawing() returns true if it contains at
  least one FontData with m_skipDrawing == true.

BUG=235303
TEST=http/tests/webfont/slow-loading.html

Review URL: https://codereview.chromium.org/171823002

git-svn-id: svn://svn.chromium.org/blink/trunk@168258 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None

Review URL: https://codereview.chromium.org/171743004

git-svn-id: svn://svn.chromium.org/blink/trunk@168257 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Right now, this can return true even if the frame is detached, since it
doesn't check that the frame has a non-null host.

The remaining changes in DOMWindow are to preserve current web visible
behavior, as well as fixing a null pointer dereferences that this exposes
in Performance and ScreenOrientation.

BUG=347331
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/131113003

git-svn-id: svn://svn.chromium.org/blink/trunk@168256 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These will need baselines too, most likely.

TBR=scottmg@chromium.org
BUG=309197

Review URL: https://codereview.chromium.org/185303004

git-svn-id: svn://svn.chromium.org/blink/trunk@168255 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Prior to this CL, we were setting the style of the RenderView on every style
recalc because we were comparing the RenderView's overflow style with the wrong
value. This CL corrects the bug.

This CL doesn't have much effect yet, but it will become important in a future
CL when we use style modification on RenderLayers to scope compositing updates.

Review URL: https://codereview.chromium.org/185263002

git-svn-id: svn://svn.chromium.org/blink/trunk@168254 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes a crash on xe.com where the text autosizer would call
isEmpty() on a RenderObject and crash. The issue is that RenderSVGShape
overrides RenderObject::isEmpty and implements it differently:
RenderObject::isEmpty() - true if the RenderObject has children
RenderSVGShape::isEmpty() - true if the bounding box is empty

I've refactored RenderSVGShape::isEmpty() as isShapeEmpty() to both
clarify the override and fix a crash.

BUG=302005
NOTRY=true

Review URL: https://codereview.chromium.org/185243002

git-svn-id: svn://svn.chromium.org/blink/trunk@168252 bbb929c8-8fbe-4397-9dbb-9b2b20218538