GitLab

On Windows & Chrome OS, pressing Alt+Shift+A will bring focus to the first
control in the first infobar, if any are shown. No reason for 'A' - 'I' is
already taken on Chrome OS, but all other hotkeys to directly focus a given
pane are Alt+Shift+Letter shortcuts.

BUG=226334

Review URL: https://chromiumcodereview.appspot.com/14225016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195030 0039d316-1c4b-4281-b951-d872f2087c98

DuplicateHandle with DUPLICATE_CLOSE_SOURCE always closes the handle, right now on failure
we close it which means we are closing an invalid handle or closing some other handle in
the small race window.

Reported by Ashutosh Mehra from Adobe.

BUG=233251
TEST=none

Review URL: https://chromiumcodereview.appspot.com/13912024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195029 0039d316-1c4b-4281-b951-d872f2087c98

Make View::RequestFocus non-virtual; replace override.
Also add mouse-press/release inhibiting of select-all.
(this prevents a flash of all text selected on click)

BUG=232290
TEST=No find bar focus-related behavior/appearance regressions; switching back to a tab that had the find bar focused (from a tab that didn't have the find bar focused) restores find bar focus and selects the entire text content; clicking the find bar doesn't flash all the text selected before placing the cursor or starting a drag.
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13852009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195028 0039d316-1c4b-4281-b951-d872f2087c98

Broke mouse dodge on Mac, and perhaps isn't correct for Win Aura anyhow.

BUG=233299

> push MouseMove through WebContents and back to delegate to fix status bubble avoid
> 
> This fixes the status bubble not "dodging" the mouse on Aura.
> 
> On non-Aura, the path to get to StatusBubbleViews::MouseMoved is:
> - RenderWidgetHostViewWin::OnMouseEvent
> - SendMessage to the parent window
> - WebContentsViewWin::OnMouseMove
> - Browser::ContentsMouseEvent
> - StatusBubbleViews::MouseMoved
> 
> On Aura, the path is:
> - HWNDMessageHandler
> - DesktkopRootWindowHostWin::HandleMouseEvent
> - RootWindow::OnHostMoustEvent
> - EventDispatcher, etc.
> - content::RenderWidgetHostViewAura::OnMouseEvent
> - RenderViewHostImpl::ForwardMouseEvent
> - WebContentsImpl::HandleMouseMove  // ***
> - Browser::ContentsMoveEvent
> - StatusBubbleViews::MouseMoved.
> 
> This patch implements HandleMouseMove in WebContentsImpl to delegate back to Browser for Aura at ***.
> 
> R=jam@chromium.org
> 
> Review URL: https://codereview.chromium.org/14234020

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/13893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195027 0039d316-1c4b-4281-b951-d872f2087c98

The (harmless) warning was:

../../webkit/plugins/ppapi/message_channel.cc:286:69: error: comparison of constant 2305843009213693951 with expression of type 'unsigned int' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
      if (std::numeric_limits<size_t>::max() / sizeof(NPIdentifier) <=
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.

It's always false in 64bit mode, but it's arguably useful in 32bit mode.

BUG=233330

Review URL: https://codereview.chromium.org/14246019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195026 0039d316-1c4b-4281-b951-d872f2087c98

TBR=asargent@chromium.org
BUG=233404

Review URL: https://codereview.chromium.org/14192010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195025 0039d316-1c4b-4281-b951-d872f2087c98

With the fix all numbered address lines after line two are ignored (not just the third line); without the fix line four is classified as the start of a billing section and the form is 'split' in two address areas.

The problem can seen on site https://www.southwesttrains.co.uk/register.aspx

BUG=224601
TEST=Manual test; South West Trains site should fully autocomplete (including Post Code field). New unit test FormStructureTest.SurplusAddressLinesIgnored

Review URL: https://chromiumcodereview.appspot.com/13888008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Tests run.

Review URL: https://codereview.chromium.org/14328023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195022 0039d316-1c4b-4281-b951-d872f2087c98

A small number of devices cannot be paired, but can at least be
connected to insecurely. Support these by marking the devices as
Trusted, which causes BlueZ to remember the device and which allows
future incoming connections from them.

Make IsPaired() return true for these devices, there's no reason in
the UI to treat these any differently than paired devices.

TBR=youngki@chromium.org
BUG=232145
TEST=device_unittests

Review URL: https://codereview.chromium.org/14225017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195021 0039d316-1c4b-4281-b951-d872f2087c98

More standards-comformant, also needed for C++11 on Linux.

BUG=233330

Review URL: https://codereview.chromium.org/14188028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195020 0039d316-1c4b-4281-b951-d872f2087c98

It has been timing out on Vista interactive_ui_tests.
BUG=233372

Review URL: https://codereview.chromium.org/14366006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195019 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195018 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=148651%3A148661&mode=html

TBR=caseq@chromium.org

Review URL: https://codereview.chromium.org/13896015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195017 0039d316-1c4b-4281-b951-d872f2087c98

R=jzern
TBR=darin
BUG=none

Review URL: https://codereview.chromium.org/14328020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195016 0039d316-1c4b-4281-b951-d872f2087c98

Missed this during refactoring of:
https://chromiumcodereview.appspot.com/13140006

BUG=179250
NOTRY=true

No try to get this landed ASAP.

Review URL: https://chromiumcodereview.appspot.com/14365005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195015 0039d316-1c4b-4281-b951-d872f2087c98

This was causing renderer crashes when the alternate error page
passed in a NULL WebURLRequest.

> New network error page:  Fix resubmit warning when
> navigating forward / back to a page generated by a
> POST that can not be retrieved from the CACHE.
> 
> This was broken (knowingly) in revision 191712
> (https://codereview.chromium.org/12277011/).
> 
> BUG=174194,226909
> 
> Review URL: https://codereview.chromium.org/13811022

TBR=mmenke@chromium.org

Review URL: https://codereview.chromium.org/14369002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195014 0039d316-1c4b-4281-b951-d872f2087c98

> Remove reference counting from media::VideoDecoder and friends.
> 
> In addition:
>   * VideoRenderer is now passed a list of decoders via constructor instead of Initialize()
>   * WebMediaPlayerImpl's FilterCollection is now built in one shot instead of incrementally
> 
> BUG=173313
> 
> Review URL: https://codereview.chromium.org/12989009

TBR=scherkus@chromium.org

Review URL: https://codereview.chromium.org/14320005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195013 0039d316-1c4b-4281-b951-d872f2087c98

This is an update on a fix that landed in r193296 and fixed the ASAN builder. The target folder name can be different from one builder to the next, so I'm switching to using the GYP variable instead.

BUG=233173

Review URL: https://chromiumcodereview.appspot.com/14084004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195012 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13874012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195011 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cduvall@chromium.org

Review URL: https://codereview.chromium.org/14366003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195008 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 194964 "Added images for disabled print button for PDF pl..."
>
> > Added images for disabled print button for PDF plugin.
> > BUG=224623
> > Review URL: https://codereview.chromium.org/14113021
>
> TBR=vitalybuka@chromium.org
> Review URL: https://codereview.chromium.org/14301013

TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/14040007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195007 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/14330016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195006 0039d316-1c4b-4281-b951-d872f2087c98

This is temporary just to avoid weird link issues in Windows XP.

- Update the gyp file.
- Rename the gyp file from googleurl.gyp to url.gyp, so it matches the directory
name.
- Update the header include paths.
- Update the header include guards.
- Rename the target name from googleurl to url and googleurl_unittests to
url_unittests.
- Remove GURL_API (this will be replaced by URL_EXPORT when we componentize it again).
- Remove url_common.h (will be replaced by url_export.h when we componentize it again).

BUG=229660
TEST=url_unittests
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/13998025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195005 0039d316-1c4b-4281-b951-d872f2087c98

are windows open in the other side.

Chrome AURA and ASH in Windows 8 share the same browser process. If the browser windows
on one side are closed then we should not attempt to shutdown if there are browser windows
open in the other side (desktop/ASH)

BUG=232245
R=cpu

Review URL: https://codereview.chromium.org/13977008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195003 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/14308014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195002 0039d316-1c4b-4281-b951-d872f2087c98

libav's AVFrame doesn't have channels field.

BUG=none

Review URL: https://codereview.chromium.org/13991013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195001 0039d316-1c4b-4281-b951-d872f2087c98

This patch connects MediaStreamCaptureIndicator with status tray on Android so that status icons can be displayed.

BUG=231804

Review URL: https://codereview.chromium.org/14318005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195000 0039d316-1c4b-4281-b951-d872f2087c98

Motivated by issues I had working in BrowserView and BrowserViewLayout:
* Remove unnecessary virtual keyword and protected section, as this class
  has no subclasses.
* Grouped overridden methods together.
* Fixed function order in .cc file.
* Renamed contents_container_ to contents_web_view_, as it is a WebView
* Renamed contents_ to contents_container_, as it is a ContentsContainer

BUG=232971
TEST=compiles, existing browser tests

Review URL: https://codereview.chromium.org/14205026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194999 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/14002006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194998 0039d316-1c4b-4281-b951-d872f2087c98

MSVC extends the lifetime of such objects, but clang does not, and it
errors on this construct.

R=ananta@chromium.org
BUG=82385

Review URL: https://codereview.chromium.org/14141005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194997 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194996 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/14246013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194995 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/14016002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194994 0039d316-1c4b-4281-b951-d872f2087c98

In addition:
  * VideoRenderer is now passed a list of decoders via constructor instead of Initialize()
  * WebMediaPlayerImpl's FilterCollection is now built in one shot instead of incrementally

BUG=173313

Review URL: https://codereview.chromium.org/12989009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194993 0039d316-1c4b-4281-b951-d872f2087c98

* Introduce MiscWebContentsBackend for chrome://oobe/login.
* Fix navigation of chrome://oobe/login by using misc_web_contents_backend instead of tab_list_backend.

BUG=228970
TEST=unit tests.

Review URL: https://codereview.chromium.org/13836002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194992 0039d316-1c4b-4281-b951-d872f2087c98

The change unintentionally made the "always re-run strip" logic apply to
non-component build as well. Restored the original logic.

BUG=158821
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/14057015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194991 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=148644%3A148650&mode=html

TBR=caseq@chromium.org

Review URL: https://codereview.chromium.org/14044013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194989 0039d316-1c4b-4281-b951-d872f2087c98

By not putting opt out users in the "No" group, our dashboard in Finch
was showing only the explicit opt in users. Not ideal for A/B
comparisons!

R=stevet, pasko

Review URL: https://chromiumcodereview.appspot.com/14048014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194987 0039d316-1c4b-4281-b951-d872f2087c98

This is the same as https://chromiumcodereview.appspot.com/13495003
rebased.

Hopefully the unit tests are more robust now and will not be
broken by the added tests changing test order this time.

BUG=226495
TBR=xiyuan@chromium.org,nkostylev@chromium.org,bartfab@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/14269004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194986 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a coding convention violation (since signin_manager_fake.h actually
defined FakeSigninManager) and also matches what the rest of Chrome does (there
is only one other instance of xxxxx_fake.cc, but many instances of fake_xxxxx.cc).

BUG=none
TBR=sky@chromium.org, tim@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13871009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194985 0039d316-1c4b-4281-b951-d872f2087c98