- 09 Oct, 2020 40 commits
-
-
Devlin Cronin authored
For browser actions, certain properties are persisted, while others are not. (By contrast, page actions do not persist any properties). Since we're introducing the generic "action" key, we need to provide defined behavior for persistence. In this case, we default to *not* persisting values. This is consistent across properties (unlike browser action), and it is easier to add in support later if we evaluate that it would be worthwhile. Add a browsertest that covers both browser action values and the new "action" values. Bug: 1110156, 893373 Change-Id: Icc4472599e52e0309cab0b3704ea9394865787de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439975Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815847}
-
Tommy Li authored
This CL just adds the flag for the WebUI Omnibox Popup to about:flags a.k.a. chrome://flags. This also fixes a trivial crash when the flag is on, as we haven't paid much engineering effort to this flag recently. I fixed the crash with this too, as otherwise, users who turn this flag on won't be able to easily access chrome://flags to turn it off! Bug: 1046561 Change-Id: Ie458c14b3e56d647d413d57325a26653a906e858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463747 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#815846}
-
Cattalyya Nuengsigkapian authored
Opens an image editor, an Essential App's Backlight from an edit button in a screenshot notification. Important Note: the edit button is only available for image screen capturing but not video. Testing: - Screen recording showing that edit button open the screenshot image in Backlight https://bugs.chromium.org/p/chromium/issues/attachment?aid=469945&signed_aid=7kntFxv5qL2TWN8JYNxQ4Q==&inline=1 Bug: 1135247 Change-Id: Ia9f48cd82021b96fc3bbda8f140e90477b1a0152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457306 Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#815845}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ff7913204ce2..294729f33cbf 2020-10-09 danilchap@webrtc.org Support layer skipping in full svc structures with 3 temporal layers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd877ef5a7e98f3fd9197ef35eb52df63408a5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464103Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815844}
-
Miriam Zimmerman authored
Also, fix height calculation of the dialog (otherwise, this change would cause the buttons to scroll partially out of the visible area). BUG=chromium:1107910 TEST=deployed to chromebook, verified that label was present and read \ by ChromeVox Change-Id: I1d9d1dd37bc98a684b13ded643970692ed7e2240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461725 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#815843}
-
Xiaohui Chen authored
Bug: b:168817491 Change-Id: I4269b354c686613cc172b2e5ffdac6acd27ab780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464008 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#815842}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ad8eb02a. With Chromium commits locally applied on WPT: 57f68063 "Remove anonymous box from details/summary shadow dom" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure jsbell@chromium.org: external/wpt/resources lanwei@chromium.org: external/wpt/infrastructure/testdriver/actions NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Iebb18b125fc314652ec232fa623f7ceeb425456a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463373Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815841}
-
minch authored
Update on the spec. Bug: 1128755 Change-Id: I62a9cf60f33f3bc9c162cdb1aad68a811a2c4e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464046Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#815840}
-
Reilly Grant authored
This change makes a number of bugs impossible by removing the "closed" state from SerialPortImpl and BluetoothSerialPortImpl. Instead of calling GetPort() to get a mojo::Remote<SerialPort> the OpenPort() message combines the operation of connecting a pipe to the implementation of the SerialPort interface with establishing a connection to the serial port itself. This fixes issue 1121774 by making it an invalid state for the SerialPort implementation to stick around if the connection failed. The USB Mojo interface solves this problem with the more complex UsbDeviceClient interface. I think the solution in this patch is better. Bug: 1121774 Change-Id: Ic33256a3d193f70490e207ba9c97277c74323018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459693 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#815839}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iccb3e247ee296850052bd5c0f3958ed5442ac8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464105Reviewed-by:
-
Travis Skare authored
Functionality will follow in crrev 2380212. For enterprise users: Enterprises may enable the feature, or enable did-you-mean without checks, as they know their machines' path to DNS servers. For non-enterprise users: Adds a feature to roll out a new default-off behavior. A heurisitic-based approach for non-enterprise users will follow, though likely in a future milestone. Bug: 1090985, 1090985 Change-Id: Icc7dff576cc503d6ffab23be38c1faea8cf22993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443689Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#815837}
-
James Vecore authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/fe6fea125882..16aafbd27d09 $ git log fe6fea125..16aafbd27 --date=short --no-merges --format='%ad %ae %s' 2020-09-14 vpalatin shill: cellular: add optional field to mark 'attach APN' in database 2020-10-08 mcchou system_api: bluetooth: Add ScanResponseData property constant Created with: roll-dep src/third_party/cros_system_api Bug: 1135699 Change-Id: I9438567001f56e91430983390b1d015ee8e1223b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464026 Commit-Queue: James Vecore <vecore@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
-
Matthew Mourgos authored
This change adds a nudge view that is triggered to show after copy and pasting twice. The nudge is only shown for 6 seconds before being automatically dismissed. The nudge should only be shown 3 times total. Bug: 1105541 Change-Id: Ic31863e1bab23ca50a298e22848611168bd17dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417978 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#815835}
-
Gavin Williams authored
Hide the labels so the power source is one stop in ChromeVox. Video: http://crbug/1031355#c9 Fixed: 1031355 Change-Id: I4878e916fb44229a9ef195b616a1cd21a4103624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463331Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#815834}
-
Eric Lawrence authored
It is possible to infer the capture mode (which limits how much sensitive information is stored in a NetLog file) by scanning emitted events, but explicitly recording the capture mode in the file enables automated tooling to more easily classify logs. Bug: 1057773 Change-Id: Ia36fb2cbb091cf2b4a940fbe48fce87269438c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087702Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815833}
-
cfredric authored
This reverts commit 5f6a15df. Reason for revert: This API does not appear to have high usage, so is unlikely to give us much data for the Identifiability Study. This instrumentation will, however, make it less likely for us to select other APIs (from which to collect data) on a given client. Bug: 973801 Change-Id: I1879784dfd1bf32c9cbe472f215e6c825fa91b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464002Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#815832}
-
Kevin Marshall authored
Replaces uses of Blink MessagePort/MessageChannel with cast_api_bindings::MessagePort. Updates Fuchsia and Cast tests to use the new cast_api_bindings::MessagePort API. Removes Mojo and Blink deps. Bug: 1131102,1126571 Change-Id: Ib4f2da74d03dcbae9f271f5a2f7c069d8e9f0e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458877 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#815831}
-
Yulun Wu authored
This CL addresses changes in: https://chromium-review.googlesource.com/c/chromium/src/+/2416763 Bug: 1134800 Change-Id: Id31abaf88693fc6bdfd834033800e80eb6fb1f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462622Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
-
Gavin Williams authored
Use the tooltip description in the aria label so it's spoken by ChromeVox. Before video: http://crbug/1111569#c9 After video: http://crbug/1111569#c10 Fixed: 1111569 Change-Id: I637281ce9b0727f05bed0809ece6f29819bb79d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462375Reviewed-by:
-
David Tseng authored
On lower-end devices, given a very long, complex utterance, the first call to GoogleTtsReadBuffered can take time enough to underflow the SyncReader and cause an udnerrun. This manifests itself by the first few chunks of the tts playback being dropped entirely. No stuttering occurs though as playback is smooth the rest of the way. Therefore, a reasonable fix that works on-device is to pre-fetch the first buffer prior to starting audio playback for the utterance. Within the critical path (TtsService::Render), we can simply use the cached buffer and only call into read buffered for subsequent chunks, which is fast. R=dmazzoni@chromium.org Change-Id: I6bb049d3e8b487af11ca7f34d7ef7b7f82627792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464067 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#815828}
-
chinsenj authored
In Capture Mode, when a user makes their own capture region the dimensions label shows always. This CL makes it so the label only shows when the region is non-empty and the user is resizing the region, matching the spec. Test: manual + modified existing test Bug: 1136324 Change-Id: I56578d7f735f0c09ace6298f5b3172cbeedb5f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462177 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#815827}
-
Haiyang Pan authored
This reverts commit 3d00c8a1. Reason for revert: Likely causes webgl2_conformance_gl_passthrough_tests to fail. Example builds are: * https://ci.chromium.org/p/chromium/builders/ci/Linux%20FYI%20Release%20%28NVIDIA%29/19363 * https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20Retina%20Release%20(AMD)/23905 Original change's description: > Update V8 to version 8.8.64. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/07b0b1dc..e4ed803f > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Ifcadac29a122c1a22c5ab749e372d066e09aceee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463662 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#815717} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I15080d2e1e2e1c64ab8e631c4f8998be7fa0f4a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464150Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#815826}
-
Adam Norberg authored
If the service has a matching port with a receive right in userspace, the task with the receive right owns the lock. If the service is not assigned, the lock is free. This implementation polls to attempt to acquire the lock, using a constant service name and constant polling interval. Further development could fetch these values from another source of truth (a file of constants, compiler macros, options loaded at runtime, etc.) or use bootstrap_look_up and mach_port_request_notification to find the owner of the lock and wait for the lock to be released. This change includes two broad changes to preexisting unit tests, due to issues revealed with those tests while developing this CL: * app_server_unittest.cc included tests where the AppServer lived in the same scope as test code that generates a reference to the Global Prefs Object, which requires the prefs lock. This results in deadlock with a non-reentrant implementation of a prefs lock, since the AppServer owns that lock at that time. This CL introduces scopes to deallocate the AppServer instance before the test itself grabs the global prefs lock. * prefs_unittest.cc marked out all the lock tests as Windows-only. Now that there is a Mac lock, this limitation does not need to exist. However, one of its tests explicitly checked that the lock supports reentrancy within a thread (while another verified that it bans reentrancy across threads). This test has been deleted, after discussion with teammates where we decided that a non-reentrant lock is desired. Change-Id: I513cb67d1c3a12b2b0c01b532a9af10ae2233530 Bug: 1135692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453800Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Adam Norberg <norberg@google.com> Cr-Commit-Position: refs/heads/master@{#815825}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I85e324ec83076de031b3aa0fed81aa4b7de6b755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463785Reviewed-by:
-
evliu authored
This CL adds a data dependency on the //third_party/soda directory for the Speech On-Device API (SODA) unit and browser tests as they both require files in the SODA directory. Change-Id: Ifba311f47c8ecdfdf8e44b82bb2d85220bd2e69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462549Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#815823}
-
Antonio Gomes authored
The enum class ash::WindowTypeState is used in the definition of ash::kWindowStateTypeKey window property. This property is needed by code in //ash/public/cpp/caption_buttons/frame_size_button.cc. In order to move the later to //chromeos/ui, the property needs to be moved. In order to move the property, the enum class needs to be moved too. This CL moves window_state_type.cc|h to //chromeos/ui. BUG=1113900 R=jamescook@chromium.org, sky@chromium.org Change-Id: Id7c1e64fafff0182d4843513e5697bc5c463aeee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456289 Commit-Queue: Antonio Gomes (use @igalia instead) <tonikitoo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#815822}
-
Thomas Lukaszewicz authored
This CL updates the tab strip's UpdateNewTabButtonBorder() method to apply the vertical border insets to the tab control buttons rather than the tab controls container. This is necessary as the NewTabButton will extend its targetable area to the top of its bounds when the tab strip is in a condensed state (i.e. the window is maximized). This is done to ensure the tab strip controls comply with Fitt's law expectations. Bug: 1136557 Change-Id: I8b312363bdabbef358ec2689321bb30d7680953b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463994 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
-
Jonah Chin authored
A recent change intentionally stopped caching SkImage readbacks. This benchmark results in a single video frame being requested multiple times, forcing multiple readbacks into CPU memory. This is not representative of a real world regression, as applications are expected to cache any uploaded WebGL textures themselves. See discussion on bug for more details. Bug: 1115128 Change-Id: I4de6fc4bfb82f5c6baf1778342f2c4c9bfc0c3cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437470Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815820}
-
Scott Violet authored
For methods called by native it's easier to declare the function as throwing a RemoteException. BUG=none TEST=none Change-Id: I2a5aa0caa2b683312390ff6d941cfe534a997fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463967Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#815819}
-
Elly Fong-Jones authored
Both of these tests are inherently flaky because they rely on events in the native system that we can neither observe nor wait for completion of. Specifically: * OrderFrontAfterMiniaturize relies on being able to figure out when a miniaturize is complete, which it attempts to do by sleeping for 2 seconds; this obviously causes flakes depending on bot load * VisibleAfterNativeParentShow depends on [NSApp hide:], which has different behavior depending on whether other unit tests are running in parallel; this makes the test inherently flaky The latter *could* be rewritten as an interactive UI tests instead, but I think it does not test anything of value compared to the similar test at the Widget layer. Bug: None Change-Id: Ida502a4ee839fbe764af73eff1df08631e450838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463993 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#815818}
-
Gayane Petrosyan authored
On Android 11, setGravity is deprecated. For text toasts is noop. Therefore, create toast from a custom view, for which setGravity still works. This is a short term solution. Bug: 1135597 Change-Id: I8fc9c85df4b5f749b6e0d0781cee4b8963460c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460971 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#815817}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99db0de96759..6dc612511e7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lukasza@google.com,flackr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1122784,chromium:1136968 Tbr: lukasza@google.com,flackr@google.com Change-Id: Ia0d5adcc90d464420f6498eef7facecf7384faaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463926Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815816}
-
Łukasz Anforowicz authored
This reverts commit 32b6222e. Reason for revert: Seems responsible for test failures/crashes below: ShareServiceUnitTest.FileCount (modified by the reverted CL) crashed on https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/50136 ShareServiceUnitTest.Multimedia (hmm... not modified by the reverted CL) crashed on https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/50135 Original change's description: > WebShare: Share implementation for Windows > > Finishing the implementation for navigator.share() on Windows. > > Updating the existing tests for basic exercising of this functionality > and adding new tests for the Windows-specific functionality checks. > > Bug: 1035527 > Change-Id: Ibc2c50e85109fd1739124c40966b353c5db2c00f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443757 > Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Reviewed-by: Eric Willigers <ericwilligers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815706} TBR=ericwilligers@chromium.org,ajgo@chromium.org,mhochk@microsoft.com Change-Id: I9dd866d3c1cc925d20da94974e5ad8fe7018b99e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1035527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463071Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#815815}
-
Tim Song authored
BUG=1106937,1126208 Change-Id: Ibb9cfbc40f19d45d34082289d1cd999507e36ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461605Reviewed-by:
Andre Le <leandre@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#815814}
-
Saurabh Nijhara authored
We have different cache status when an attempt is made to fetch a force installed extension from it during the downloading process. We want to add download cache status event to the existing events for the event based reporting for force installed extensions. Bug: 1048640 Change-Id: Ib12adfcde9052714a15829e9ef1a0462f24383df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460899 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
-
Dirk Pranke authored
In r778991 (7203e2f8, https://crrev.com/c/2242233), we added a data dependency on args.gn to the blink_web_tests, so that we could detect if the build had dchecks enabled and adjust the test timeout accordingly. Now that the tests are configured and launched by the generated bin/run_* wrappers, we can push that logic into the wrapper script from the build, and not require args.gn to be a data dependency. This allows builds that differ only by things in args.gn that don't affect the build (e.g., comments, or goma/no-goma) to share the same isolate, and helps improve build determinism. The blinkpy code will still optionally look in args.gn if it is present to determine a default value; this allows devs to still get the right value if they invoke run_web_tests.py directly locally, rather than using the bin/run_ wrapper. Bug: 1135151 Change-Id: If11ce12fc6bb47e0673d604e96ce130353e83cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462762 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#815812}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I06fd1b13f42880bdd701b882ad9cbc4cc64bf29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463925 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/71f3a45238af..a3f46f23c526 2020-10-09 jophba@chromium.org Add build flag for self-signed certs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I10cfba299303dc622e78e7c45220fb536f7dd48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463748Reviewed-by:
Jordan Bayles <jophba@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815810}
-
Samuel Huang authored
This reverts commit dda82c9a. Reason for reland: Fixed by adding missing deps to eu-strip. Original change's description: > Revert "[Lacros] Size dashboard: Track stripped size of ELF files." > > This reverts commit a4d34d8a. > > Reason for revert: This causes chromeos-amd64-generic-lacros-builder-perf to fail, likely due to missing eu-strip. > > Original change's description: > > [Lacros] Size dashboard: Track stripped size of ELF files. > > > > This CL modifies lacros_resource_sizes.py to identify ELF files, and > > also track their stripped sizes (using eu-strip) as well as compressed > > stripped sizes. These news info are recorded for chrome and the Total. > > > > If eu-strip fails for a file then we simply ignore its stripping > > results and print warning. Known-bad files include .nexe files and > > libwidevinecdm.so. These are explicitly excluded to denoise the system. > > > > Bug: 1106626 > > Change-Id: I9cb47bb41baa2b73996e6662db2fe4bc537338d7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458869 > > Commit-Queue: Samuel Huang <huangs@chromium.org> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#814972} > > TBR=huangs@chromium.org,erikchen@chromium.org > > Change-Id: I580c4ea4a125fef785cdb0c6de1c31846a7e8180 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1106626 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459794 > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814986} Bug: 1106626 Change-Id: If0967507192c467bb4efbc7c57d7271628c60ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463447 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#815809}
-
Regan Hsu authored
If the Task Continuation multidevice feature is not enabled, clear the mutable phone model's browser tab model. Otherwise, use the cached browser tab model that is updated by the provider. Bug: 1106937 Change-Id: I671542daa97f4ea4893ec8cc80fb2016d632f574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462553 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
