- 30 Jan, 2018 40 commits
-
-
Matt Menke authored
MockURLLoader::RunTest had a case statement that was accidetnally falling through to the next case. Bug: 177475, 746977 Change-Id: Ifce64d1afaaaff6b33ef8057517627e694389641 Reviewed-on: https://chromium-review.googlesource.com/891739Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#532933}
-
Xida Chen authored
It appears that under certain conditions (ASAN), the |script_state_| in the CSSPaintDefinition is nullptr. Notice that the |script_state_| itself is a scroped_refptr, it being null indicates that the CSSPaintDefinition object itself is null. The cluster fuzz seems to be able to repro this with a 29KB minimized test case and I can never repro it locally with the same build args. This CL is a speculate fix, and let's wait for fuzzer to tell us whether the problem is fixed by this or not. Bug: 806082 Change-Id: Iad22be412709d697d42e111cbf74de972b094918 Reviewed-on: https://chromium-review.googlesource.com/891598Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532932}
-
Ella Ge authored
This CL changes mac SetShowingContextMenu to send a MouseMove instead of MouseLeave. And add kRelativeMotionEvent flag in the modifier to avoid sending the event to DOM. Sending MouseLeave will cause hover/active state be cleared when open contextmenu. Bug: 803844 Change-Id: I38f2864b108f95a51c6e93536a1b410333fdf50e Reviewed-on: https://chromium-review.googlesource.com/888092Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#532931}
-
https://chromium.googlesource.com/catapult.git/+log/857b65094956..9ce4426b187b $ git log 857b65094..9ce4426b1 --date=short --no-merges --format='%ad %ae %s' 2018-01-25 perezju [Telemetry] Remove support for old browser creation API Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I0b1acf70de0fecd4b10118e9c4159c698e82503b Reviewed-on: https://chromium-review.googlesource.com/893619Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532930}
-
Nico Weber authored
This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 177475 Change-Id: I8f6b7f32865c6a8c5f4db94bbd5c0a61296f7876 Reviewed-on: https://chromium-review.googlesource.com/889947Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532929}
-
Victor Costan authored
The current schema creates a full index for iOS, and a partial index on all other platforms. This was done because the SQLite versions that shipped in iOS 8.1 and before did not have partial index support. This CL removes the special-casing for iOS. Chrome now requires iOS 10+, which ships with a sufficiently modern of SQLite. The difference should not be visible outside small variations in space usage and query processing times, so it's safe to let the old schema instances die off as the iOS fleet is organically refreshed. Change-Id: Iac461c83cc121fbdc98dd12c91ff5eef57eec4ed Reviewed-on: https://chromium-review.googlesource.com/889921Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
Nico Weber authored
Fixes a bug where TaskManagerTester::GetColumnValue() would return the ColumnSpecifier::TOTAL_NETWORK_USE value for ColumnSpecifier::NETWORK_USE. Change a test that was relying on the broken behavior to query TOTAL_NETWORK_USE instead of NETWORK_USE, which also happens to fix a TODO in that test. This CL was uploaded by git cl split. R=afakhry@chromium.org Bug: 177475 Change-Id: I1c146e4f60c41f024a0f32f0924b4d0811a9a620 Reviewed-on: https://chromium-review.googlesource.com/891885 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#532927}
-
https://skia.googlesource.com/skia.git/+log/6da98f10951f..ab2621d3e2d2 $ git log 6da98f109..ab2621d3e --date=short --no-merges --format='%ad %ae %s' 2018-01-30 caryclark generate tables instead of manual entry 2018-01-30 halcanary SkQP: More logging details. 2018-01-30 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 5dd4ad896..efb5a5c8f (1 commit) 2018-01-29 jvanverth Reduce the amount of padding needed for SDFs. 2018-01-30 egdaniel Add ref counted wrapped around GrTexture ReleaseProc 2018-01-30 fmalita [skottie] Anti-alias masks 2018-01-30 mtklein temporarily disable BadImage test on new ASAN bot Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ie22a8eddb1da29db49bb939ff4d9db930a3ea1f2 Reviewed-on: https://chromium-review.googlesource.com/893210Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532926}
-
https://chromium.googlesource.com/angle/angle.git/+log/5dd4ad896bcb..6969132c134f $ git log 5dd4ad896..6969132c1 --date=short --no-merges --format='%ad %ae %s' 2018-01-30 yunchao.he ES31: update deqp tests for renderbuffer integer formats. 2018-01-29 jmadill Vulkan: Fix swaps done right after a clear. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I8cf7d9b21eeca69753962426b5c83663a090f587 Reviewed-on: https://chromium-review.googlesource.com/893202 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532925}
-
John Chen authored
This is a reland of 9de3051e, with the change to enable the ChromeDriver tests on release bot only. The original commit was reverted due to flakiness of the tests on debug build. The reason for the flakiness is debug build of Chrome takes a long time to start, usually between 20 to 40 seconds. The timeout for the test is 30 seconds, thus it can either succeed or fail depending on whether Chrome started quick enough or not. While it is possible to increase the timeout, spending over 30 seconds per test appears to be too much overhead in the long run. Also, the purpose of running these tests is to catch incompatibilities that can develop between Chrome and ChromeDriver, and running these tests on release builds should suffice for that purpose. Original change's description: > [ChromeDriver] Enable CQ tests on Mac/Windows > > Previously, the commit queue only runs ChromeDriver tests on Linux. > This CL expands the test to other desktop platforms, including Mac > and Windows. > > Bug: 793370 > Change-Id: I2a28d3a5c8371edc28566010739681acfac41c21 > Reviewed-on: https://chromium-review.googlesource.com/881641 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531399} Bug: 793370 Change-Id: I87df556896593ab9497435611a7d78122adbddd8 Reviewed-on: https://chromium-review.googlesource.com/890391Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532924}
-
Eugene But authored
This is the final CL for New Download Manager UI skeleton. This adds coordinator class and creates DownloadManagerTabHelper object in BVC. New Download Manager feature is still not enabled in flags. Design doc: https://goto.google.com/ios-chrome-download Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8fcd0646762ef90465aa722622102a5e2b23c413 Reviewed-on: https://chromium-review.googlesource.com/889399Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#532923}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2181b01c. With Chromium commits locally applied on WPT: 9f32e9c0 "S13nServiceWorker: Add tests for network fallback for navigations with request bodies" b72e8903 "service worker: Deflake fetch-event.https.html." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11319 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=lukebjerring No-Export: true Change-Id: I73d2d96a24804ebab1f029486f50aaf2eb4b2713 Reviewed-on: https://chromium-review.googlesource.com/893279 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532922}
-
Tommy Steimel authored
This CL fixes a few problems with the CSS for the modern media controls audio tag. It hides the controls completely when the controls attribute is not set. It ensures that the controls always have a height of 54px, which fixes a bug where the controls could become shorter down to 0px. It also removes some duplicated properties. Bug: 805897 Change-Id: I224389e17e9bc98bcd6f339aed1f9a44ca3cb8d4 Reviewed-on: https://chromium-review.googlesource.com/886652Reviewed-by:
Mounir Lamouri (slow) <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#532921}
-
Tommi authored
This class links together Chromium's ScopedAllowBaseSyncPrimitives and WebRTCs. Now that WebRTC is starting to use Chromium's sync primitives, this allows us to continue reduce locking inside of WebRTC that can cause slowdown on Chromium threads, while guarding against regressions. Bug: 796889, 795340 Change-Id: Icd71c13e04433aa67e3f22f5d510aa724b413fa9 Reviewed-on: https://chromium-review.googlesource.com/871631Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532920}
-
David Bokan authored
Bug: 801381 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I27e9f0ac5d372400bc2c72e7904a3908fc546454 Reviewed-on: https://chromium-review.googlesource.com/887647Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532919}
-
David Tseng authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I364949b358db73b125d7687b73bf2239648352d1 Reviewed-on: https://chromium-review.googlesource.com/887426Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#532918}
-
Jennifer Apacible authored
Only one interstitial (of media remoting and picture in picture) will be shown at a time. This change renames IDs for elements in the interstitial element with the same styling. This change also pulls out the CSS into a separate file, per TODO. Expected further work here includes some more styling updates with an interstitial icon for picture in picture. BUG: 805516 Change-Id: I6c2151f2166b4dbbf2aaa0be83f8492369008a11 Reviewed-on: https://chromium-review.googlesource.com/890025Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#532917}
-
Vasilii Sukhanov authored
Previously the following happened: - a background tab decided that it should pop up a password bubble. - the bubble was suppressed as the tab is inactive. - another event changed the state of the controller but the flag to open the bubble was still on. - the tab became active and the bubble was popped up despite the state was unexpected. With this CL the bubble is not gonna open automatically when the state has changed in the mean time. Bug: 805556 Change-Id: Ia66054889550b1b26b3abeb5926acbb8d7ceea05 Reviewed-on: https://chromium-review.googlesource.com/893381 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#532916}
-
Mythri Alle authored
Bug: chromium:799080, chromium:804828 Change-Id: Ia53c46840b47086dd55f989d190b063af54eb2a4 Reviewed-on: https://chromium-review.googlesource.com/892442Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#532915}
-
Ramin Halavati authored
'empty_policy_justification' field in traffic_annotation.proto is not used in any annotation and doesn't seem to be needed. It is removed. Bug: 656607 Change-Id: Iddde9ea668690b7a684d6f320b2cf952faa60e0c Reviewed-on: https://chromium-review.googlesource.com/892880 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#532914}
-
Jan Krcal authored
This CL introduces a retry mechanism in RemoteSuggestionsProvider when suggestions are cleared while a request is in flight. This change does not violate the previous contract that all fetches are triggered by the scheduler. From the point of view of the scheduler, the original fetch and the retry seem as one single fetch. Bug: 802179 Change-Id: I6138e16cc68d2a1f4b93576002ce241829255c18 Reviewed-on: https://chromium-review.googlesource.com/873034 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#532913}
-
Andrew Wilson authored
Updated the policy code on Chrome OS to track whether a given user requires policy in the known_users DB and via a SessionManager-provided cmd line flag for ephemeral users. Also added logic in UserCloudPolicyManagerChromeOS to enforce that policy is indeed loaded when known_users says it should be loaded. Bug: 676624 Change-Id: Ib2aaa9fdee8c3cccf84b3ec370618215f78d4fc6 Reviewed-on: https://chromium-review.googlesource.com/719838 Commit-Queue: Drew Wilson <atwilson@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#532912}
-
Douglas Creager authored
There are separate sampling rates for reports about successful and failed requests. Even though we're not currently reporting anything for successful requests, this plumbs through both sampling rates from the NEL header into the OriginPolicy instance. (A future change will add reports for successful requests; doing the patches in this order ensures that we never upload reports for 100% of successful requests unless specifically instructed to do so by the origin.) Bug: 748549 Change-Id: I66d9d0c0544372e642d3a146deb0a06f7973452d Reviewed-on: https://chromium-review.googlesource.com/891741 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#532911}
-
Raymond Toy authored
Remove dezippering from all of the attributes. The value will now change immediately instead of gradually changing from the old value to the new value. Chromium Feature: https://www.chromestatus.com/features/5287995770929152 Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YKYRrh0nWMo/aGzd3049AgAJ Bug: 752986 Test: BiquadFilter/dezipper.html Change-Id: I86840159709158fd52a69a7c3c5f279267277d44 Reviewed-on: https://chromium-review.googlesource.com/612104 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532910}
-
Hannes Payer authored
Bug: chromium:804279, chromium:633030 Change-Id: I47f3b5ae087971105e64262cfe2e65495f99f3ca Reviewed-on: https://chromium-review.googlesource.com/893181Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#532909}
-
https://webrtc.googlesource.com/src.git/+log/49456a5b3327..79d331b09102 $ git log 49456a5b3..79d331b09 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=NONE The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I68ab9f5881ff7000a546339be136b954755c9598 Reviewed-on: https://chromium-review.googlesource.com/893205 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532908}
-
Sylvain Defresne authored
Xcode 8 required that code implements initializer methods marked as NS_UNREACHABLE but this was fixed with Xcode 9. Remove those methods as they just add visual clutter. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic18320e7a8059688413fa09c26feb99d0a3e995c Reviewed-on: https://chromium-review.googlesource.com/891024 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532907}
-
Tommy Steimel authored
This CL changes the scrubbing check in MediaControlsImpl::State to only return the scrubbing state when the video is actually scrubbable. This fixes a bug where the video CSS class would have a ready state when no video source was available. Bug: 802155 Change-Id: Ib7dfd26cb1be98dde2fc53ea6e230103162f64b1 Reviewed-on: https://chromium-review.googlesource.com/884262Reviewed-by:
-
Matt Morehouse authored
Enabling this option prevents fuzzers/sanitizers from setting the -gline-tables-only and -gcolumn-info flags, and instead uses the symbol level defined by symbol_level. This is particularly useful for reducing binary sizes when building with use_clang_coverage=true, where stack traces are unneeded and line numbers for coverage are determined from the coverage mappings. Bug: 759795 Change-Id: Iae3ea9ede10281c9f29c461ed5d6eec503a661cd Reviewed-on: https://chromium-review.googlesource.com/887285Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#532905}
-
Nico Weber authored
This CL was uploaded by git cl split. R=junov@chromium.org Bug: 177475 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I377f439e850f0b26bc1c50f9bbb1f97a7d7dc8e1 Reviewed-on: https://chromium-review.googlesource.com/890003Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532904}
-
Ramin Halavati authored
GetNinjaPath() function in 'tools/clang/pylib/clang/compile_db.py' did not return the path to ninja correctly. This is fixed. Bug: 807146 Change-Id: Ie149b4d5a2684454b6fdbbd59598421e008136fd Reviewed-on: https://chromium-review.googlesource.com/892918Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#532903}
-
https://pdfium.googlesource.com/pdfium.git/+log/95b232f79123..af9f83656f98 $ git log 95b232f79..af9f83656 --date=short --no-merges --format='%ad %ae %s' 2018-01-30 dsinclair Combine more combo and list code Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I84bab8b8a3f045bd1bab3b8f9754eb9684c464c3 Reviewed-on: https://chromium-review.googlesource.com/893201 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532902}
-
Chong Zhang authored
This CL removes unnecessary cross-origin requests from the test. Bug: 780956 Change-Id: I7835d6363d8e1b5862889c5fd9992fdb1e064dac Reviewed-on: https://chromium-review.googlesource.com/891550Reviewed-by:
-
Gauthier Ambard authored
This CL changes the creation of the URL used to get the favicon at the root of the WebSite (www.website.com/favicon.ico), which is used to get a favicon if non is provided in the html of the page. It strips the query part of the URL, to avoid re-downloading a new favicon everytime the query part of the URL changes. Bug: 804077 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1d6224af357065ab749031ca3533d5f5a5d092ff Reviewed-on: https://chromium-review.googlesource.com/889739 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#532900}
-
Lukasz Anforowicz authored
instance. Extensions violate browsing instance boundaries. The UMA metrics added in this CL should help confirm or deny the theory that violating browsing instance boundaries is only needed for looking up background contents / pages (of VIEW_TYPE_BACKGROUND_CONTENTS type). Bug: 718489 Change-Id: I69246c7d38962c85c55b2e4d271b19eaae1dae1e Reviewed-on: https://chromium-review.googlesource.com/766469 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532899}
-
Eric Boren authored
I missed this account on my last CL. Bug: 799919 Change-Id: I8cd866cfed3c0a846cc20e2135a4a92b372bf608 Reviewed-on: https://chromium-review.googlesource.com/893440Reviewed-by:
-
Tommy Steimel authored
This CL makes use of the size_ member of the MediaControlsImpl when updating the overflow menu for modern media controls. This fixes a bug where a video of normal size will have all controls in the overflow menu because it thinks the size is 0x0. Bug: 805690 Change-Id: I11dc8f991696d4771f517d6cca585b3e293bb57a Reviewed-on: https://chromium-review.googlesource.com/886656Reviewed-by:
-
Marton Hunyady authored
Bug: 785275 Change-Id: I30e401025d78ef5e9771c9ee11b3570b8968beb6 Reviewed-on: https://chromium-review.googlesource.com/888624Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Marton Hunyady <hunyadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#532896}
-
Ashley Enstad authored
Turns out pylib is needed to discover all the benchmarks in benchmark_runner Bug: 758632 Change-Id: I1b4d1106c8c32ab87b7431fa9331d67777a925a9 Reviewed-on: https://chromium-review.googlesource.com/893208Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#532895}
-
Jungshik Shin authored
A couple of fuzzers that rely on url/ didn't initialize ICU. Because url/ depends on ICU for IDN handling, this results in an assertion failure when ICU's IDN class is initialized. Initialize ICU in a test enivornment for the following fuzzers: payment_method_manifest_parser_fuzzer csv_reader_fuzzer In addition, print a human readable error message instead of a numeric error code. Bug: 754996 Test: The two fuzzers above do not fail the assertion about UIDNA. Change-Id: I942d339d1ef1d71dd5c9c4e79a774f2c2980555d Reviewed-on: https://chromium-review.googlesource.com/871350Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
