GitLab

Instead of calling CFRunLoopRemoveSource, call CFRunLoopSourceInvalidate. Since
the runloop is bound to the thread and threads are reused between resolutions,
if the internals of the proxy resolver create any deferred tasks on the runloop,
those tasks could refer to the removed-and-destroyed source when the runloop is
next run. Instead, we call Invalidate, which should prevent any deferred tasks
from running.

BUG=166387

Review URL: https://codereview.chromium.org/959803004

Cr-Commit-Position: refs/heads/master@{#318233}

These entries were found using a modified version of Eric's
fix-includes.py script found attached in
https://code.google.com/p/chromium/issues/detail?id=435361#c4.

BUG=435361
TEST=content_unittests
R=avi@chromium.org

Review URL: https://codereview.chromium.org/952323002

Cr-Commit-Position: refs/heads/master@{#318232}

Revert of [Android WebView] Synthesize a fake page loading event on page source modification (patchset #8 id:140001 of https://codereview.chromium.org/924833003/)

Reason for revert:
Reverting to see if this caused AwContentsClientFullScreenTest#testPowerSaveBlockerIsTransferredToFullscreen failure here: http://crbug.com/462213.

Original issue's description:
> [Android WebView] Synthesize a fake page loading event on page source modification
>
> When a script modifies page source of a non-committed page, we need to
> notify clients, so they can update the URL bar to avoid confusion.
>
> BUG=458569
>
> Committed: https://crrev.com/e38bb6cdeb1170cb2cd7faae8507dc6c34c58c7d
> Cr-Commit-Position: refs/heads/master@{#318222}

TBR=torne@chromium.org,tedchoc@chromium.org,davidben@chromium.org,creis@chromium.org,mnaganov@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=458569

Review URL: https://codereview.chromium.org/958933002

Cr-Commit-Position: refs/heads/master@{#318231}

Revert of Retry to add MockPresentationClient to use in layout tests. (patchset #4 id:60001 of https://codereview.chromium.org/907893002/)

Reason for revert:
While the LayoutTests only test the logic in the mocks and the plumbing, maintaining the mocks while working on the platform/public interface is a pain and requires landing patches simultaneously in Blink and Chromium repositories. There's no layout test using this anyway yet.
I'll add layout tests later when the Blink-Chromium interface is stable and maybe Blink is merged into Chromium.

Original issue's description:
> Retry to add MockPresentationClient to use in layout tests.
>
> Now there's a MockPresentationService that's owned by WebTestProxy and
> accepts private method calls from the tests.
>
> MockPresentationClient was moved to WebFrameTestProxy instance since
> we want one per each frame. Reset logic is added too to make tests more
> independent.
>
> BUG=412331
>
> Committed: https://crrev.com/57b3af2412a81a4c0abf54e0146c0f7bf5530249
> Cr-Commit-Position: refs/heads/master@{#316199}

TBR=mkwst@chromium.org,peter@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=412331

Review URL: https://codereview.chromium.org/963493002

Cr-Commit-Position: refs/heads/master@{#318230}

Cr-Commit-Position: refs/heads/master@{#318229}

ChromeOS Gaia: When webview is enabled CrOS get oauth_code from accounts.sandbox.google.com and make all the other auths against the default gaia url.

BUG=461854

Review URL: https://codereview.chromium.org/958843003

Cr-Commit-Position: refs/heads/master@{#318228}

It is not necessary to prefix types with bookmarks:: inside bookmarks
namespace.

BUG=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/955753002

Cr-Commit-Position: refs/heads/master@{#318227}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e52e8b6..dfe404b

TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/956203004

Cr-Commit-Position: refs/heads/master@{#318226}

BUG=461076

Review URL: https://codereview.chromium.org/960133002

Cr-Commit-Position: refs/heads/master@{#318225}

BUG=None
TEST=git cl upload && g cl presubmit -uvf
R=danakj@chromium.org

Review URL: https://codereview.chromium.org/947983003

Cr-Commit-Position: refs/heads/master@{#318224}

Update the descriptions for the equivalent OriginSettings UMA.

TBR=jhawkins
BUG=433774

Review URL: https://codereview.chromium.org/952463002

Cr-Commit-Position: refs/heads/master@{#318223}

When a script modifies page source of a non-committed page, we need to
notify clients, so they can update the URL bar to avoid confusion.

BUG=458569

Review URL: https://codereview.chromium.org/924833003

Cr-Commit-Position: refs/heads/master@{#318222}

Bug 399535 is fixed so we no longer need the additional functions added
to debug it.

This reverts commit 27b2b57c.

BUG=399535

Review URL: https://codereview.chromium.org/954393002

Cr-Commit-Position: refs/heads/master@{#318221}

Starting a Chrome OS session (e.g. on Linux build) using "--login-profile=" and then pressing Ctrl+Shift+L triggers some nasty behavior, as the sign-in profile was not loaded yet (which is not the case during normal boot-up, as this profile is usually the first thing that loads). This patch aims to force its loading for such cases.
This affects not only stub login, but also any session that was restored.
Current patch reiterates CL from https://codereview.chromium.org/240333011/

BUG=346763

Review URL: https://codereview.chromium.org/933503004

Cr-Commit-Position: refs/heads/master@{#318220}

WebRTC 8506:8509
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/7251e22..976aecb

Libjingle 8501:8510
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/87d21d8..e574ba0

BUG=webrtc:4344
R=hlundin@chromium.org

Review URL: https://codereview.chromium.org/962573002

Cr-Commit-Position: refs/heads/master@{#318219}

Merge script tags and also use body {display:none;} then document.body.style.display = 'block'.
Also move the page from the web into the repo.
This should reduce the noisiness of thread_times.key_silk_cases layout_avg somewhat.

BUG=459668

Review URL: https://codereview.chromium.org/952733002

Cr-Commit-Position: refs/heads/master@{#318218}

This crash happens often, but I'm unable to reproduce it, so can't find the
root cause.

The suspects are corruption of memory which are protected with DCHECKs.

TEST=Not related.
BUG=454310

Review URL: https://codereview.chromium.org/957983002

Cr-Commit-Position: refs/heads/master@{#318217}

This patch adds a reload feature, which is that reload the gallery with new entries when a 'onLaunched' event is fired.

BUG=461218
TEST=manually tested

Review URL: https://codereview.chromium.org/959643003

Cr-Commit-Position: refs/heads/master@{#318216}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/37d011b..e52e8b6

TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/961623002

Cr-Commit-Position: refs/heads/master@{#318215}

R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/951353003

Cr-Commit-Position: refs/heads/master@{#318214}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/238ad54d..f1e2aa52

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/955343002

Cr-Commit-Position: refs/heads/master@{#318213}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ef73ddc..37d011b

TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/954423002

Cr-Commit-Position: refs/heads/master@{#318212}

iOS does not use //components/feedback to report feedback so remove
the unused dependencies.

BUG=None

Review URL: https://codereview.chromium.org/954943004

Cr-Commit-Position: refs/heads/master@{#318211}

BUG=None.

Review URL: https://codereview.chromium.org/954143004

Cr-Commit-Position: refs/heads/master@{#318210}

Remove the test as the TODO comment in pacing_sender_test.cc by ianswett.

BUG=
R=asanka@chromium.org

Review URL: https://codereview.chromium.org/928913002

Cr-Commit-Position: refs/heads/master@{#318209}

Function isInitialized, unlike calls ensureinitialized should not block
the thread, but it will if initialization is in progress at this moment.
It is not necessery to synchronize the sInitialized flag in
isInitialized function. It is enough that flag have a primitive type and
has a volatile qualifier.

R=nyquist@chromium.org, rmcilroy@chromium.org
TEST=It is rather hard to test. We've found ~300ms stuck on UI thread,
on calling LibraryLoader.isInitialized from ContentApplication.onCreate
with profiler

Review URL: https://codereview.chromium.org/925513002

Cr-Commit-Position: refs/heads/master@{#318208}

Cr-Commit-Position: refs/heads/master@{#318207}

This dialog does not have a single call-to-action button. Additionally,
the existing highlight implementation is a side-effect of using
DialogClientView, which is not well suited to this container. This CL
changes NativeDialogContainer to use a regular ClientView, removing the
default highlighting from the dialog, and refactors the two containers
to use a common base class.

BUG=445695

Review URL: https://codereview.chromium.org/933163002

Cr-Commit-Position: refs/heads/master@{#318206}

Revert of Telemetry: Refactor inspector_websocket to create cleaner interface. (patchset #2 id:80001 of https://codereview.chromium.org/942113004/)

Reason for revert:
This possibly is causing chrome tracing data leakage: BUG=461874

Original issue's description:
> Telemetry: Refactor inspector_websocket to create cleaner interface.
>
> This CL contains several improvements which are tightly coupled.
>  - The method DispatchNotificationsUntilDone is only used by tracing_backend. I
>  moved all the logic into tracing_backend. This has several side effects:
>    - The exception DispatchNotificationsUntilDone is no longer needed.
>    - The method _Receive no longer handles exceptions. It used to handle some,
>    but not all exceptions. This change is very important for sane exception
>    handling of the Chrome/Telemetry bindings.
>    - The method _HandleNotification never has a return value. It used to
>    sometimes return a boolean, and sometimes return nothing.
>  - I removed the member _error_handler. This member was only used in two
>  places: inspector_backend and tracing_backend. Of these two places,
>  tracing_backend only used it to emit a not-so-useful log statement.
>    - The biggest problem with _error_handler is that it decouples the exception
>    handling from the context of the try/catch loop that triggered the
>    exception.
>    - The _error_handler only was called during _Receive(). This is very
>    confusing, since that is not the only method that raises Exceptions. So some
>    exceptions get handled by _error_handler, and some do not. :(
>  - I removed all exception handling from inspector_page.py and
>  inspector_websocket.py. It used to be that some exceptions would be handled in
>  inspector_websocket, some would trickle up to inspector_page, and some would
>  trickle out past inspector_backend.py. The eventual goal is for
>  inspector_backend to catch all exceptions and translate them into
>  {Recoverable/Unrecoverable}Exceptions.
>
> BUG=460625
>
> Committed: https://crrev.com/64cf2ab4a6a348954d46d9d758c5be53aa1c1220
> Cr-Commit-Position: refs/heads/master@{#317972}

TBR=sullivan@chromium.org,slamm@chromium.org,erikchen@chromium.org
BUG=460625

Review URL: https://codereview.chromium.org/962443002

Cr-Commit-Position: refs/heads/master@{#318205}

BUG=452613

Review URL: https://codereview.chromium.org/944283002

Cr-Commit-Position: refs/heads/master@{#318204}

R=jam@chromium.org
BUG=426897

Review URL: https://codereview.chromium.org/960773002

Cr-Commit-Position: refs/heads/master@{#318203}

This was semantically incorrect; a Point represents a point in 2D space
whereas a Vector2d represents an offset. Therefore, 'offset' should be a
Vector2d.

BUG=None
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/884653003

Cr-Commit-Position: refs/heads/master@{#318202}

This reverts commit 603236c7.
The issue of 2x assets has been solved.

BUG=460430
TEST=checked on link

Review URL: https://codereview.chromium.org/962483002

Cr-Commit-Position: refs/heads/master@{#318201}

This makes more sense when it's an inline element in the page,
accessible by keyboard or mouse focus.

On chrome://apps it's not possible to focus this element
as far as I know; it's only shown while dragging.

R=estade@chromium.org
BUG=456706
TEST=visual, see bug

Review URL: https://codereview.chromium.org/952053003

Cr-Commit-Position: refs/heads/master@{#318200}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ee908a2b..238ad54d

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/959833003

Cr-Commit-Position: refs/heads/master@{#318199}

This CL enables the context menu on the doodle web contents and logs
the received doodle data. This will be reverted in a future patch
once an issue with the doodle not displaying is diagnosed.

BUG=462082

Review URL: https://codereview.chromium.org/961553002

Cr-Commit-Position: refs/heads/master@{#318198}

Eliminates a bug where files will spaces in name were not being marked as synced.

Also:
1) Remove an unused method (with a TODO body) in ImportTask.

BUG=461174
TEST=browser_test: FileManagerJsTest.*

Review URL: https://codereview.chromium.org/954943006

Cr-Commit-Position: refs/heads/master@{#318197}

The public methods no longer take an Account as a parameter.
Instead, when the account changes, updateAccount() is called
by ChromeSigninController. This removes the need for all of
the "didUpdate" logic.

Instead, updateCachedSettings() is called only when the
Android settings are changed or the account is changed.

CachedAccountSettings has been removed entirely. A separate
class is not necessary to cache three boolean values (which
it was already only handling two of!)

Review URL: https://codereview.chromium.org/879533004

Cr-Commit-Position: refs/heads/master@{#318196}

Make animation code conform to the style guide by using auto where
appropriate, renaming functions named incorrectly, etc. Avoid
accessing layer_animation_controller directly where possible.

Review URL: https://codereview.chromium.org/948243003

Cr-Commit-Position: refs/heads/master@{#318195}

Some versions of libtool will complain about having multiple files with
the same name.

BUG=461989

Review URL: https://codereview.chromium.org/955263002

Cr-Commit-Position: refs/heads/master@{#318194}