- 04 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/36c6ca3e8f7f..11701ad0ea8f git log 36c6ca3e8f7f..11701ad0ea8f --date=short --first-parent --format='%ad %ae %s' 2020-02-04 jophba@chromium.org Fix GCC + libsdl/libavcodec build Created with: gclient setdep -r src/third_party/openscreen/src@11701ad0ea8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I93f8026ff5ae9b7e9acf22da13e5c7c3f540778d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037615Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738301}
-
dalyk authored
This param will be applied to any WebContents that are newly created during the navigation so that the WebContents can be properly classified before any DNS requests are made. (For WebContents that are created for captive portal resolution in secure mode, we need to disable secure DNS.) Bug: 10161646 Change-Id: Ia38cd9b0d6013cae7f272cc42302bba875152e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026349 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#738300}
-
Charlie Hu authored
- Use base::make_optional instead of base::Optional constructor. - Add const qualifier on field line_number and column_number. Change-Id: I99145d52b98d609aaa0591722626b43093f00900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037323 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#738299}
-
Emily Stark authored
Previously, with HTTP auth committed interstitials, LoginTabHelper cancels navigations that receive 401 responses and commits a blank page. The auth prompt is shown on top of the blank page normally. However, in the case that the browser supplied credentials and the server still sent a 401 response (i.e., credentials were incorrect), LoginTabHelper would cancel the navigation but not show the auth prompt (due to lack of auth challenge -- the challenge is only populated when credentials aren't supplied in the request). This led to a weird situation where neither the auth prompt nor the 401 response body from the server would be displayed to the user. To rectify this, LoginTabHelper should not cancel a request with a 401 response unless there is an auth challenge present for which to show a prompt. This maintains the same UX as we had before committed interstitials. Bug: 1047742 Change-Id: I83eba22e52676946d7f3a6cffc14f699265f75d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036970Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#738298}
-
Avery Musbach authored
Bug: None Change-Id: Ib901eeae6a357baaa9d25605aed71c58664b8dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033889Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#738297}
-
Connie Wan authored
See bug for details on the issues. Issue #1: When dragging multiple tabs to the left, reverting doesn't return them to the correct position. Was happening even without groups. - Fixed by adjusting the target index of revert to account for unreverted tabs. Issue #2: Intermittent crashes. - Seems to be fixed by crrev.com/c/2020908 Issue #3: Header is not returned to the initial view position. - Fixed by adding a call to MoveTabGroup(), which is only needed when dragging within the same tabstrip (otherwise, a new group is being created and positioned correctly). Issue #4: Selection is not restored correctly. - Fixed by actively setting the index of group headers to kNoTab, so that checks in RestoreInitialSelection() correctly ignore group headers. Note: The change at line 657 is to work with line 1656, which is assuming that source_model_index is explicitly set to kNoTab. Bug: 1047761 Change-Id: I18af6a66d4e7788ed90c9be1f27556fc0018c6c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036362 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738296}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/094c157fc3f0..555a304caa85 git log 094c157fc3f0..555a304caa85 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 lamontjones@chromium.org api: compile protos 2020-02-04 honglinyu@chromium.org Make deployment of "icudtl.dat" optional 2020-02-04 ahassani@chromium.org cros_flash: Execute scripts out of /usr/local/tmp/cros-flash 2020-02-04 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-03 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-03 seanabraham@chromium.org chromeos_config_boards: add eve-lacros 2020-02-03 vapier@chromium.org cros_setup_toolchains: handle duplicate source libs better 2020-02-03 seanabraham@chromium.org chromeos_config: lab board nami, not nami-kvm 2020-02-03 achuith@chromium.org Revert "cros_chrome_sdk: Update SDK_VERSION on fallback." 2020-02-03 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-03 saklein@chromium.org cros deploy: ignore built slot operator. 2020-02-03 vapier@chromium.org stripped-packages.tar: clean up internal paths 2020-02-03 geohsu@google.com Update builders for M81 ChromeOS attempt 2 2020-02-03 lamontjones@chromium.org api: compile protos Created with: gclient setdep -r src/third_party/chromite@555a304caa85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I3699241c13a54eb766a2b41a5ace1a62bf121ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738295}
-
Yann Dago authored
Bug: 958893 Change-Id: I46c74b4732f5a76b10c27f0603fa3aa6c0bbd803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018128 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#738294}
-
Eric Seckler authored
Some of our startup tracing tests timeout flakily, and it seems that the flakiness stems from the file not being written quickly enough on the background task runner. This patch overrides the task priority for the task runner for these tests to USER_BLOCKING, which should make file writing more likely to finish in time. Also reenables one of the tests on windows, where it was previously timing out flakily. Bug: 1046447 Change-Id: Ibbe2ef61f81567a364f4d3396162e72be22b4457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032109Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#738293}
-
Kyle Horimoto authored
appManagement.mojom.PageRemote.onAppChanged() requires a parameter of type "!appManagement.mojom.App", but the existing parameter was annotated as potentially being nullable. This CL fixes the issue. Fixed: 1047810 Change-Id: Ie6ba63f95695c20cadcb3b6879f2d84ce118b0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033974 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#738292}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4546c5cefa0e..d8c4b5fb80d4 git log 4546c5cefa0e..d8c4b5fb80d4 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 lexa.knyazev@gmail.com Expose ASTC 2D on OpenGL 2020-02-04 lexa.knyazev@gmail.com Update S3TC GL extension strings 2020-02-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src fb94ccddb725..807f14657a25 (2 commits) 2020-02-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 5e86b28ffb81..540662253ea3 (1 commits) 2020-02-03 geofflang@chromium.org Share scratch buffers between contexts. Created with: gclient setdep -r src/third_party/angle@d8c4b5fb80d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1030835 Tbr: cnorthrop@google.com Change-Id: I41a3fe1c35e23d5118cbbb6aa866ce519714a127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037426Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738291}
-
Su Hong Koo authored
Primary display swapping using Alt + F4 only recognized two displays. Fixed by returning secondary display that is next to the primary display in active_display_list_. Bug: 867966 Change-Id: Icd395582bf48123c0a463e663b0db62c51e352d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019474Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Su Hong Koo <sukoo@google.com> Cr-Commit-Position: refs/heads/master@{#738290}
-
Jimmy Gong authored
- With the flag enabled, users will be able to add their print servers through the printer settings page. Bug: 1015628 Change-Id: Ibb759460dbdea87a3084ba60d388648b7ccfd1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025640Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#738289}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2fca97168bfe..0f6bcd18b2ef git log 2fca97168bfe..0f6bcd18b2ef --date=short --first-parent --format='%ad %ae %s' 2020-02-04 sakal@webrtc.org Hold a reference to AndroidVideoTrackSource while calling onFrameCaptured. 2020-02-04 kwiberg@webrtc.org Define rtc::BufferT::const_iterator 2020-02-04 eshr@google.com Configure QP scaler in adaptation module 2020-02-04 kron@webrtc.org Fix links Created with: gclient setdep -r src/third_party/webrtc@0f6bcd18b2ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ideb0af8eb9746e726ad569b7836d2815cc6c98ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037611Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738288}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bf3087f65d6a..a2406f9218a3 git log bf3087f65d6a..a2406f9218a3 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 robertphillips@google.com Fix BC1 SW decompression on platforms with RGBA PM color order 2020-02-04 brianosman@google.com Ignore warnings when compiling MSL 2020-02-04 fmalita@chromium.org Potentially-uninitialized Sk3LookAt result 2020-02-04 mtklein@google.com tweak screen math 2020-02-04 robertphillips@google.com Fix SW decompression of BC1 and add a GM to check it (take 2). 2020-02-04 ehmaldonado@google.com Modify PostUploadHooks to remove dependency on cl objects. 2020-02-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 49a53d684aff..aa6dd50de0c5 (5 commits) 2020-02-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-04 mtklein@google.com Reland "unorm/unorm -> to_unorm/from_unorm" 2020-02-03 reed@google.com Reland "add skvm for tablecolorfilter" 2020-02-03 mtklein@google.com gather pointers are not necessarily aligned 2020-02-03 mtklein@google.com Revert "add skvm for tablecolorfilter" 2020-02-03 mtklein@google.com Revert "unorm/unorm -> to_unorm/from_unorm" 2020-02-03 mtklein@google.com Revert "impl gather8/gather16 with gather32" 2020-02-03 herb@google.com Arrange atlas image processing by frequency 2020-02-03 jvanverth@google.com Fix timeout for Metal compiler. 2020-02-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-03 robertphillips@google.com Revert "Fix SW decompression of BC1 and add a GM to check it." 2020-02-03 robertphillips@google.com Fix SW decompression of BC1 and add a GM to check it. 2020-02-03 egdaniel@google.com Have GrTextureProducer return views instead of proxies. 2020-02-03 mtklein@google.com unorm/unorm -> to_unorm/from_unorm 2020-02-03 herb@google.com Move the bulk glyph calls up the stack Created with: gclient setdep -r src/third_party/skia@a2406f9218a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1042324 Tbr: scroggo@google.com Change-Id: I8bd03f4a13c0982d477ff0e06060633c523c6578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037423Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738287}
-
chromium-autoroll authored
Also includes a manual modifications to MojoSharedMemory and ProducerEndpoint subclasses to match upstream interface changes. https://android.googlesource.com/platform/external/perfetto.git/+log/349930ee9cd3..30f6fc14e50c git log 349930ee9cd3..30f6fc14e50c --date=short --first-parent --format='%ad %ae %s' 2020-02-04 treehugger-gerrit@google.com Merge "Forward malloc_iterate to dispatch table." 2020-02-04 taylori@google.com Merge "perfetto-ui: Edit track selection with checkboxes" 2020-02-04 treehugger-gerrit@google.com Merge "service: Support producer-provided SMBs service-side" Created with: gclient setdep -r src/third_party/perfetto@30f6fc14e50c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Change-Id: I9890f226c7a59eb236661729d0a347153c5964bd Tbr: perfetto-bugs@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036008 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#738286}
-
Guillaume Jenkins authored
This is the next step into reworking the life cycle of the WindowsSpellChecker global object. - Moved the WindowsSpellChecker object from a static base::NoDestructor in an anonymous namespace to a member of the SpellcheckService class - It was a bug to have a single global instance of WindowsSpellChecker, since it keeps a state based on the profile's preferences. - By moving the ownership to the SpellcheckService, multi-profile spell checking actually works, since now each profile gets its copy. - Because spell check logic is under components/ and SpellcheckService is under browser/, a pointer to WindowsSpellCheck has to be passed around on the components side - Changed the implementation of the WindowsSpellChecker class to use an inner "background helper" class for all background tasks, to ensure sequencing is consistent and life cycle is tied to a background thread - Also shortened the name of the RetrieveSupportedWindowsPreferredLanguages method to "GetSupportedWindowsPreferredLanguages" Bug: 463364, 1035044 Change-Id: I59ab6743f690d70206b630603fe8ab07637db96f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025949 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738285}
-
wutao authored
This cl fixes two issues: 1. When app_list is not active, we should not request focus to assistant_page_view. Otherwise, the active window info will lose so that we cannot get the assistant structure of the active window. 2. The DCHECK of |assistant_tree_| or |assistant_extra_| is not valid because they could be nullptr if there is not such an active window. Bug: b/139363094 Test: manual Change-Id: I3b78688b15047925dc92f613fe9e46b198d864fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017982 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738284}
-
Mike Wittman authored
Provides a native API to query/request module installation and provide interfaces to the native code provided within the module. This API will be used by native code along the lines described in the design doc at https://docs.google.com/document/d/1QB5IzWuVKfoPdPuiyRok2MUEta1FmRLIQkq1wDATA4k. Bug: 1027654 Change-Id: I52fb0a4cfbec06dd603617ed1949fa20fda6ef03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003299Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#738283}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/41a7302e9c62..ddee0f34e4cb git log 41a7302e9c62..ddee0f34e4cb --date=short --first-parent --format='%ad %ae %s' 2020-02-04 lfy@google.com android: avoid exporting normal Vulkan APIs Created with: gclient setdep -r src/third_party/swiftshader@ddee0f34e4cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I98a49a34e9c15d8310c964d20e0e38d35c5ea6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036827Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738282}
-
ssid authored
On renderer processes the action callback is never set. The tracing service checks if a task runner is set and adds a callback for user actions recording when tracing is enabled. This callbcak will record user actions with timestamps in traces. Change-Id: Ic2c5f78a5e62aaf677b9a98a56f185170c570eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026191Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#738281}
-
Robert Liao authored
BUG=1034666 Change-Id: Ie6628347802d652e02d117a12c65dd9ac0e6e4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036929 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#738280}
-
Brandon Walderman authored
Bug: 1048716 A few ChromeDriver tests use the time.time() function to wait for various conditions. We've observed a flakey test failure downstream due to the current time() value being less than the previous time() value. This can happen because time() relies on the system clock which is not guaranteed to be monotonic. Python 3 offers a time.monotonic() function that would suit our needs, but this is not available in Python 2.7. There is a 'monotonic' Python module that polyfills this functionality for Python 2.7. I've updated run_py_tests.py to use monotonic() everywhere time() was used previously. This should improve reliability. Change-Id: I7237daf1124131f824dd389c33f8c28413730c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037349 Commit-Queue: Brandon Walderman <brwalder@microsoft.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738279}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/43a0a815b814..47b15048a1fa git log 43a0a815b814..47b15048a1fa --date=short --first-parent --format='%ad %ae %s' 2020-02-04 kainino@chromium.org Revert "Use libshaderc_spvc as a source_set, so complete_static_lib applies properly" 2020-02-03 bryan.bernhart@intel.com Vulkan: attempt sub-allocation before direct allocation. 2020-02-03 kainino@chromium.org Use libshaderc_spvc as a source_set, so complete_static_lib applies properly 2020-02-03 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@47b15048a1fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1045811,chromium:1047048,chromium:1047220 Tbr: cwallez@google.com Change-Id: I035c1222c4502693dc2cbdb968ae8d75a5bde261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036288Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738278}
-
Sergey Ulanov authored
Previously FuchsiaDecryptor was destroying FuchsiaClearStreamDecryptor in the destructor which may run on a thread that's different than the thread on which FuchsiaClearStreamDecryptor was created. Updated FuchsiaDecryptor destructor to delete audio_decryptor_ asynchronously on the right thread. Bug: 1047783 Change-Id: I9c4dc5d7a292078eb632c0c44be6a68cc949b7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033813 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738277}
-
Patrick Monette authored
This CL modifies PerProfileWorkerTaskTracker to also observe events from the DedicatedWorkerService and the SharedWorkerService. Bug: 1041093 Change-Id: I2f8c3e7cebe77ac4235fbee4a1cbb899b9b77b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020403 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#738276}
-
David Benjamin authored
0-RTT inherently involves a race condition: if the server responds with the ServerHello before the client sends the HTTP request (the client may be busy verifying a certificate), the client will send data over 1-RTT keys rather than 0-RTT. To avoid this, wait for both the ClientHello and HTTP request to come in before allowing the test server to respond. This extracts ReadBufferingStreamSocket from SSLClientSocket tests and allows EmbeddedTestServerConnectionListener to wrap the socket. Bug: 1021021 Change-Id: I8199a0b117e0a2718986b2af1e333a8b069fd3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029627Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#738275}
-
Charlie Hu authored
Bug: 993790 Change-Id: Ic72e0475d6c9ea35d23fcb612d9452fcba1c8835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032164Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#738274}
-
Michael Thiessen authored
Replaces usages of java.net.URI with GURL. This change is slightly complicated as GURL and URI handle about: URLs differently, in that GURL considers everything after the about: scheme as a path instead of a host/path/etc. This is usually handled in the native code by running FixupUrl on URLs with the about: scheme to convert them into the chrome: scheme (unless they're about:blank or about:srcdoc), and this is how navigation to about:newtab works (by converting it to chrome://newtab). So in order to know if something will resolve to the NTP, we need to first fixup the URL, and then check its host/validity. Bug: 783819 Change-Id: Idf6ad46fa6ef9793a969f3a8ee721c9bb05b97a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031710 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#738273}
-
Francois Doray authored
With this CL, PageNode::IsLoading() transitions to true when data is received for a top-level navigation to a different document. It transitions to false when the page reaches an "almost idle" state, based on CPU and network quiescence, or after an absolute timeout. This definition of "loading" is considered better to drive policies, as it indicates when the page stops doing work after a navigation, rather than when the page is loading resources (it may still have a lot of Javascript to run to present useful content to the user). Change-Id: I4fc5b277933133229fde7585d6710f63e6b8244d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015820 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#738272}
-
Regan Hsu authored
"moveUp" and "moveDown" keys currently have the incorrect values, IDS_SETTINGS_LANGUAGES_LANGUAGES_ADD, and IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_ORDERING_INSTRUCTIONS respectively. This CL corrects those values to IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_MOVE_UP and IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_MOVE_DOWN respectively. Bug: 1048562 Change-Id: I115cffac1828ac068fee0260653d94b5da2a4ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036800Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738271}
-
Austin Eng authored
TBR=kbr@chromium.org Bug: 1026588 Change-Id: I6563d489eaa3ea91879e0810f8373b721e1fa75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036541Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#738270}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 182 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-08-02. Change-Id: I5abbcfcdfe89f4efdd3663b7163084d93a427216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037590 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#738269}
-
Michael Thiessen authored
Also adds unit tests for the UrlFormatter java wrapper which didn't previously exist. Bug: 783819 Change-Id: Ib98bd5daa64a48bb06d6593185f53f49ad22b3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036730 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#738268}
-
Sam Bowen authored
Bug: 1044249 Change-Id: I163919382fd8d40a2355a8da71d72db68018e131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023864Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#738267}
-
Saman Sami authored
Add base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope to all methods in DrmThreadProxy that block. Fixed: 1047827 Change-Id: I0ff3239d85264244dd6f5a0098ee18daa3c4960e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033633 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#738266}
-
Natalie Chouinard authored
An empty public constructor should be kept for all Fragments, not just those in Settings. This change also allows us to move settings code alongside respective feature code (see bug). Bug: 1047357 Change-Id: I9e776766be4a693622150b58db5e057447118fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036872 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#738265}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/1cc95ac07c17d61bea601832bbdc1f8d13d313db..bc7e2cb92d948de5f437e5eef2b1c3ad6281bb35 Bug: none Change-Id: Iedfd6ebcd581f76c1794b3eddad2d46b701681e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028292 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#738264}
-
Lijin Shen authored
The tests are flaky on Android K & L. It shows the ntp is scrolled down on launching the activity, but the reason has not been figured out. Launching activity on blank page can prevent the startpage from being scrolled down. Bug: 1046317, 1046316, 1045729, 1045415 Change-Id: I1d14f15218ad8a1e1ceac9c0a7bbfc1d49008700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028212Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#738263}
-
Sammie Quon authored
Replaces the old three view setup which was used before we could apply rounded corners directly on layers. Tested manually on LTR and RTL on all 4 orientations. Visually no difference. Ran ui.OverviewDragWindowPerf.drag_to_snap. Not noticeable improvements on caroline, but input latency goes from 95ms to 80ms on krane. Test: added tests Bug: 1047778 Change-Id: Idff6345fb5778d2e898bc51cd76bd7eac3c1741d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033564 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#738262}
-