- 09 Apr, 2020 40 commits
-
-
Bartek Nowierski authored
Change-Id: Iff85302bb633d9166139bde65a9b627eec13c4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139951Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#757725}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ac910b82. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 239eeaa8 "[css-filters] Migrate effect-reference-image.html to WPT" 29baa8ce "[css-filters] Migrate effect-reference-image-hw.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I007c5df260af10c9f37fe7b787568ac19e935176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142499Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757724}
-
Yu Han authored
Previous to this CL, during manual slot assignment, if an exception is thrown, the state of the HTMLSlotElement is indeterminate. HTMLSlotElement should be restored to the previous state where previous assigned nodes are preserved. This CL implements this behavior by doing the exception check of assigned nodes before the actual assignment. Thus, if an exception is encountered, the assign() function could just return, preserving the previous state. However, this way of doing slot assignment adds an extra loop for assigned nodes. I had tried to do it in one loop. But that required saving the previous state of the Slot and restoring it if exception is detected. I think the added complexity isn't worth it for the little performance benefit. In addition, I made sure that the state of the candidate_assigned_slot_map_ is accurate after each slot assignment recalc. The previous implementation could leave removed nodes still in the map. Because in SlotAssignment:RecalcAssignment(), the children traversal, NodeTraversal::ChildrenOf(owner_->host(), wouldn't encounter removed nodes. Bug: 869308 Change-Id: I3c8938f1c4360d664497b6d16a7753c545729e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124293 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#757723}
-
Kent Tamura authored
This CL has no user-visible behavior changes Bug: 1067527 Change-Id: Ied6beefbdefb438be69f18132930bafed6b6581a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139178 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#757722}
-
Mei Liang authored
Change-Id: Ic59bacb6dce73f6f0431422833cded8be3fb2987 Bug: 1068820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141451 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757721}
-
Hirokazu Honda authored
RtcVideoEncoder doesn't pass ScalingSettings by webrtc::VideoEncoder::GetEncoderInfo() due to crbug.com/1034686. I misunderstood the qp value of ScalingSettings at that time. This is the first step to fix the issue and pass webrtc media::ScalingSettings given by VEA::GetEncoderInfo(); This makes media::ScalingSettings in media::VideoEncoderInfo be base::Optional so that RtcVideoEncoder can set webrtc::ScalingSettings only if VEA provides non nullopt media::ScalingSettings. Bug: 1067522 Test: webrtc.* on eve Change-Id: I585452bf22216ef8d574864bf25375b3536add6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133995 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#757720}
-
rbpotter authored
The aria-label should be on the <select>, rather than on the <print-preview-settings-select> custom element, for Chrome Vox to verbalize the controls correctly. The same issue occurs with NVDA, but currently cannot verify, so this is a speculative fix for the NVDA issue. Bug: 1035569 Change-Id: I3ceb0c75e64e66637a8a4c4a4600ecdf0eb82f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142761 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#757719}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1cba0a9c3a8a..3cfa8e28be80 git log 1cba0a9c3a8a..3cfa8e28be80 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 sugoi@google.com Remove debug only code limiting the number of primitives Created with: gclient setdep -r src/third_party/swiftshader@3cfa8e28be80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I57535e14a5eb388514359778310680a1f5dfb5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142979Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757718}
-
Keith Lee authored
Change-Id: I69cee3613a253fc0303b11c53f6e04650d1db6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143054Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Auto-Submit: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#757717}
-
Koji Ishii authored
|NGSimplifiedLayoutAlgorithm| was once disabled for FragmentItem to focus on working on the correctness. This patch re-enables it for the performance. Bug: 982194 Change-Id: I1bf2d7dc1734c2163a525732a181aa4bdfbbcd0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134185Reviewed-by:
-
Devlin Cronin authored
Remove ExtensionBrowserTest::InstallBookmarkApp() and browsertest_util::InstallBookmarkApp(). Neither were used. Bug: None Change-Id: Ie6164c30430f4ac8ecef9d4645c01c3c72736e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141626Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757715}
-
Ravi Chandra Sadineni authored
Currently we only have one dropdown that reflects both AC and battery idle delay timeouts and idle action. This is limiting from the user perspective as AC idle option cannot be configured differently from battery idle action. Also when the idle actions are different, the current selection might not reflect the underlying behavior. Thus add an additional drop down (one for AC and other for battery idle behavior) thus addressing the above issues. Screen shot before: https://screenshot.googleplex.com/OaBgcgZLwHW.png Screen shot after: https://screenshot.googleplex.com/7co27K1UR8d.png CQ-DEPEND=CL:2044412 Bug: b:148105990 Test: Run browser_tests and manual tests. Change-Id: I8eac3a5408a5808936277ca623e28b5b2ce9bb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135368Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ravi Chandra Sadineni <ravisadineni@chromium.org> Cr-Commit-Position: refs/heads/master@{#757714}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2f3157ba..5dcf1b66 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I60f0ab88e67d5ba54de0ca56503648859073d217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143211Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757713}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/237b8541c13f..f9f8e4b0d42d git log 237b8541c13f..f9f8e4b0d42d --date=short --first-parent --format='%ad %ae %s' 2020-04-08 jalyn@microsoft.com Register all actions in ActionRegistry 2020-04-08 jalyn@microsoft.com Ready module.jsons for multi-keypress shortcuts Created with: gclient setdep -r src/third_party/devtools-frontend/src@f9f8e4b0d42d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0ce1877d7b180a0d52fd413b7cd1c1ad32154932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142981Reviewed-by:
-
John Z Wu authored
Change-Id: I568b219b5567442e8b173606ff8985212307d839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140922Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#757711}
-
Noel Gordon authored
Add getToolTipButtons() service that returns every breadcrumb <button> that has attribute [has-tooltip]. Bug: 1035691 Change-Id: I719b7ea301f127ba14efc92e5e7a7b34174c04b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141559 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#757710}
-
Victor Fei authored
CL:1803983 Improved UIA ExpandCollapseProvider ::get_ExpandCollapseState behavior on menu buttons (i.e. a button contains aria-haspopup attribute) by limiting menu buttons to only support ExpandCollapseState_Expanded/Collapsed and not support ExpandCollapseState_LeafNode. That change was intended to improve UIA behavior for Views toolbar buttons. However, that change introduced an issue where any element, not just menu buttons, that has aria-haspopup="true/menu" would not support ExpandCollapseState_LeafNode Consider the following example: <div aria-haspopup="true"></div> Current behavior: ExpandCollapseState_Collapsed Expected behavior: ExpandCollapseState_LeafNode This change fixes this by limiting only menu buttons to exclude ExpandCollapseState_LeafNode, while all other elements that support IExpandCollapseProvider would support ExpandCollapseState_LeafNode. New behavior: Menu buttons supported state: Expanded, Collapsed All other elements supported state: Expanded, Collapsed, LeafNode Bug:847971 Change-Id: I9756d1d02d27c1e747f4d77fcecae21468a9022e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112757Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#757709}
-
David Van Cleve authored
This is part of a sequence of CLs implementing data removal logic for Trust Tokens [*], a prototype feature that enables annotating requests with some lightweight cryptographic state. The internal storage stores the results of these cryptographic operations, including some state necessary for maintaining privacy invariants. The CL, the first in the series, expands the Trust Tokens storage system to satisfy deletion requests parameterized by a network::mojom::ClearDataFilter. (This is the same way other non-cookie NetworkContext-scoped data, like reporting and the host cache, is cleared.) A follow-up CL will add the removal interface and call it from NetworkContext. [*] https://docs.google.com/document/u/1/d/1TNnya6B8pyomDK2F1R9CL3dY10OAmqWlnCxsWyOBDVQ/edit R=csharrison Bug: 1064747 Change-Id: Id0172932916580bbfff5b41f616e61e8feb99305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134700 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#757708}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I88b4b7b9431da51025606e15f5804cd2363cb823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143117Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757707}
-
chrome://flagsAdrienne Walker authored
AppCache is deprecated and is being removed in a future version. This is to assist developers testing a future without AppCache. Bug: 1055010 Change-Id: I6770a160ab29e8914bb0e97be8cc9eb5e2912450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139366 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#757706}
-
Daniel Libby authored
This change adds parsing and evaluation support for the `screen-spanning` media feature, which currently accepts three values: none, single-fold-vertical, and single-fold-horizontal. These values will describe the state of a viewport that is split by a fold or segment of the window. Plumbing of the values to MediaFeatures will be added in an upcoming change. Intent-to-prototype: https://groups.google.com/a/chromium.org/d/topic/blink-dev/KsPRO3hkOGw/discussion Bug: 1039051 Change-Id: I4646faa49a139e1a0af55da676bdb460a8a6baf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129994Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I351c8c4a781d52d23c13269689aecf10290e1569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140955 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#757704}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3c1ff62f4cca..e521cd14da4a git log 3c1ff62f4cca..e521cd14da4a --date=short --first-parent --format='%ad %ae %s' 2020-04-09 tandrii@chromium.org Make vadimsh@ an owner of cipd*. Created with: gclient setdep -r src/third_party/depot_tools@e521cd14da4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I97ef5eb601aa0270d974db8545482381750bdf7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142977Reviewed-by:
-
Christian Biesinger authored
Also make sure to include the border and padding in the minimum size of a replaced element. Checking IsReplaced instead of HasAspectRatio is the right thing here because what this code cares about is the presence of an intrinsic size Just changing that check exposed the bug that this branch did not add the border and padding, leading to failed DCHECKs in: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-min-height-auto-002{a,b,c}.html Change-Id: Id6f4bf8e600ee15aed98a3d92098dc0bd0e50fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136704Reviewed-by:David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#757702}
-
Gyuyoung Kim authored
This CL moves percentage-sizes.html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to percentage-size.html to be align with existing test names. Bug: 1063749 Change-Id: I6a5fdb560759ad668977e773d0b528548f371fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141477 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
-
Jon Mann authored
This allows us to know which shared networks are configured by the logged in user. Bug: 966270 Change-Id: Id9c6ee003a3ff7f024ace0e3a30309263cd3b98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142614Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#757700}
-
Tetsui Ohkubo authored
For zcr_ interfaces, protocol definitions are always updated in the same CL of the corresponding exo change, and there's no risk of the implementation being behind the definition xml. In fact, it is error-prone that we always have to update versions in two places, so let's just cosolidate them. TEST=tast run eve-DUT arc.Boot BUG=None Change-Id: I802422292fa860dc7347e440fe9f0db2ecd046f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138851Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#757699}
-
Joel Hockey authored
TBR=lxj@google.com Change-Id: I09ac14a96060276a9aa5c9416510025dd687b657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143051Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#757698}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/185d3d4fa709..68219bfacaa8 git log 185d3d4fa709..68219bfacaa8 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 brianosman@google.com Add Usage::kColor to SkVertices custom attributes 2020-04-08 jvanverth@google.com Fixes for running on the iOS simulator. Created with: gclient setdep -r src/third_party/skia@68219bfacaa8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I8113c7e74ec81c7550f3dd09ee250802b200b311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142975Reviewed-by:
-
Jon Mann authored
Bug: 966270 Change-Id: I3d7f0da512e82df6f90b1af5dbb3d0e0f767d477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142338Reviewed-by:
-
Ahmed Mehfooz authored
The focus issue is caused by incorrect order of visibility changes being propagated down to ArcNotificationContentView. Bug: 1068964 Change-Id: Idbb902c9aa5d14a0c1648f41a25e366fd2f7f91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142755Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#757695}
-
Antonio Gomes authored
BUG=1063749 R=cbiesinger@chromium.org Change-Id: I2de65f7a2f8374235f10b640cc4d549fc5a5bb6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134867 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
-
Joon Ahn authored
Impose 1MiB size limit for user logs and read the logs from back. Bug: chromium:1066205 Change-Id: I4c7a2de6f93d87ee0a5a2295dd25b32ec372ac46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133427Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#757693}
-
Christopher Cameron authored
There exist two paths to reveal recently-created app shims in Finder. The are: - In WebAppShortcutCreator::CreateShortcuts, if the shim creation was requested by the user (via chrome://apps, or by installing an app manually), then the just-created shim is revealed. - In WebAppInstallTask::OnShortcutsCreated, RevealAppShim is called. One deficiency of both of these calls is that they go and look up the app shim to reveal based on its bundle id, when they should know the path of the app shim that was just created. Remove the second path, because it isn't necessary. Change the first path to reveal the path that was actually created. Bug: 1057195 Change-Id: I21fb8f035fcc42a652ff8d040d85eff966c7ee03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139077 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#757692}
-
Yulun Wu authored
Bug: 1067457 Change-Id: I939561cfbb960118537bafb79dc83130a364a321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140711 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#757691}
-
Ravi Chandra Sadineni authored
Support the ability for ChromeOS managed users to choose whether they want their devices to sleep or have the display turn off while also allowing administrators to ensure via managed policy that the device will lock after a set period. This change also provides required c++ support for an additional dropdown to set AC idle option differently from battery idle option. CQ-DEPEND=CL:2135368 Bug:b:148105990 Test: Enforce all possible enterprise policies and verified the result. Change-Id: I6f3e8a8be1869a3185d1704a2394ea27225d3bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044412 Commit-Queue: Ravi Chandra Sadineni <ravisadineni@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#757690}
-
Hirokazu Honda authored
The following chromium-style error is caused in building media_unittests with target_os="chromeos" and use_vaapi=true. """ ../../media/gpu/chromeos/platform_video_frame_utils_unittest.cc:73:33: error: [chromium-style] Overriding method must be marked with 'override' or 'final'. ~FakeGpuMemoryBufferFactory() { ^ override """ Bug: None Test: Build media_unittests Change-Id: Ib01d4aae4bf48629f0cdfd1295a2278ea198275b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141753 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#757689}
-
Mei Liang authored
This CL set up the path to fetch the favicon based on the input list of URLs asynchronously, and then compose the favicons into one with the callback. Note: Composing logic integration will be handled in a separate CL. Change-Id: Ifc0280afaaab9437780e586d4a7ea670cffbbacc Bug: 1064153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123768Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
-
Jimmy Gong authored
- The original cause of the flaky is because the page element was not ready by the time we try to query for elements within it. - The fix is to attach a promise to the instatiation of the page and to only continue with the test once the promise is resolved. This ensures that each step of the test is handled synchronously. Bug: 1068860 Test: browser_tests Change-Id: I0a30e2971107b44354603adbb0396ddfea3c218d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142951Reviewed-by:
-
Hiroki Nakagawa authored
This reverts commit 55fb987f. Reason for revert: Looks like this fails cast_runner_integration_tests for timeouts. https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20x64/52142 Original change's description: > [Fuchsia] Cleanup cast_runner integration tests. > > Removed test-only methods from CastRunner, WebContentRunner and > CastComponent that were previously used in > cast_runner_integration_tests. > > 1. Removed CastRunner and WebContentRunner constructors that take > web.Context. Now context is always created in WebContentRunner. > 2. Removed test-only methods. > 3. Updated TestComponentContext to allow initialization with all > services cloned from /svc. > > The tests now inject a script into the frame in order to test > functionality that was previously tested with the test-only methods. > > Bug: 1062351 > Change-Id: I169651b68e0e9344d3450371db1485d9046c5c16 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135154 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757571} TBR=wez@chromium.org,sergeyu@chromium.org Change-Id: I53fd61d53d7f53025194836ea801aca234b5798e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1062351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143172Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#757686}
-
