- 18 Sep, 2019 40 commits
-
-
Fergus Dall authored
TBR=alexmos@chromium.org Bug: 1005049 Change-Id: If88be75391cc296b8b3f178f74dcb7f5f0c719ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809132Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#697478}
-
Khushal authored
We should clear these maps on every navigation to keep them from growing unbounded, and because its safe to clear this state after a navigation. R=ericrk@chromium.org Bug: 1003886 Change-Id: I68dae1d564039c27795e63ac18144ea955bac8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804515 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#697477}
-
Timothy Loh authored
This CL extracts the engagement metrics logic from ArcMetricsService into a new class GuestOsEngagementMetrics, to allow it to be used for both Crostini and Plugin VM. TEST=Manually verified chrome://histograms had sensible entries over a couple of days. Bug: 990252 Change-Id: I395bca7dd2c3d4688c33683cd163c18c8ecc90f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738447Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Shao-Chuan Lee <shaochuan@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#697476}
-
Gyuyoung Kim authored
This is a reland of be56a0b9 Fix the build break caused by the missing dependency. Original change's description: > Include *.mojom-forward.h instead of .mojom.h from logging_utils.h > > This CL replaces .mojom.h with .mojom-forward.h to reduce pre-processed > size of logging_utils.h > > This CL has no behavior changes. > > Bug: 1001360 > Change-Id: Idd305572c67e46a5f7a01937ec1d2e31fc62d8ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808619 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#697134} Bug: 1001360 Change-Id: I5a8112a21782863c6420eddd2fe717d368419b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808953Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#697475}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/20791fdb3e91..da39c6d82324 git log 20791fdb3e91..da39c6d82324 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 saklein@chromium.org PackagesService: Add HasChromePrebuilt method. Created with: gclient setdep -r src/third_party/chromite@da39c6d82324 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I15bc8370e988d2efacd6fdab79a8d590e2b995f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808435Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697474}
-
Fergus Dall authored
TBR=qinmin@chromium.org Bug: 994789 Change-Id: Id9e87e7f424997b8511dfc2a5d2150b35571c201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810145Reviewed-by:
-
Kent Tamura authored
This CL reduces the estimated pre-processed size of resource.h from 5.01MB to 4.55MB. Bug: 242216 Change-Id: Ica5c80d5c5d645dfe199f5ea4db346324f1439a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809040Reviewed-by:
-
Fergus Dall authored
TBR=malaykeshav@chromium.org Bug: 974349 Change-Id: I7cdc3d945a641ddf8ff42fb10909f99bbd403f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810144Reviewed-by:
-
Miyoung Shin authored
This CL converts SpeechRecognitionSessionClient{Ptr, PtrInfo} in blink and content to the new Mojo type, and uses pending_remote<SpeechRecognitionSessionClient> in speech_recognizer.mojom. Bug: 955171, 978694 Change-Id: Ie6316bc231d269bf95439d30c3952db7cf458e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809042Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#697470}
-
Austin Tankiang authored
With the switch to DriveFS, the legacy drive client is no longer needed, so remove it. Bug: 1003238 Change-Id: I7e2bf4afb1bc518962f5629eebfba929c918792e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803947Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#697469}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c6642beb8c78..9d3a62e82627 git log c6642beb8c78..9d3a62e82627 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 awscreen@chromium.org [FXJS] Use double precision when converting textboxes 2019-09-17 awscreen@chromium.org [FXCRT] Test StringTo{Float,Double} with byte and wide strings 2019-09-17 thestig@chromium.org Roll third_party/freetype/src/ 3de1b8d0b..99f23d6ff (2 commits) 2019-09-17 thestig@chromium.org Add helper methods for getting objects in CPDF_FormField. Created with: gclient setdep -r src/third_party/pdfium@9d3a62e82627 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:611744,chromium:611744 Change-Id: I17d8271682de47d90a9a12cd8ea87f0336ba5c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810008Reviewed-by:
-
Jiacheng Guo authored
This change allows all users in the same group to access external mojo service. Bug: 140592503 Test: Build and verified with external client Change-Id: I1f82378460fd8ae002f02d09103841541b1aa788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808630Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Jiacheng Guo <gjc@google.com> Cr-Commit-Position: refs/heads/master@{#697467}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I984eb1770e7e60fd159ca7d1220489b6d213fd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808356Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697466}
-
Jeevan Shikaram authored
The Play Store ARC app has the storage permission granted by default and the storage permission is hidden from the user in Android Settings. This CL hides the storage permission in App Management for the Play Store to align with this decision. Bug: 1002015, 982576 Change-Id: I3c4e4180882dac89730e4941e5557b3a8a41f29a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807639Reviewed-by:
-
Austin Tankiang authored
With the move to DriveFS, drive paths no longer need to be special cased, and can be treated as local paths. Bug: 1003238 Change-Id: I8c2840e6b7ec318904b290aca9b98ebb5d588adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802899 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#697464}
-
Alex Keng authored
This CL implements the new look of radio (accent color), checkbox (accent color and indeterminate state), range (accent color) and also addresses several underlying issues: 1. The drawing code is not ready for dark theme. This is addressed by introducing a new set of color ids in NativeThemeAura and using GetControlColor instead of color constants to draw controls. This way when the colors for dark theme are designed, we can just add new colors to GetControlColor and the drawing codes in NativeThemeAura can be left untouched. 2. Downstream needs a way to implement bifurcation of styles and limit the merge conflicts. This can also be achieved by redirecting logics in NativeThemeAura ::GetControlColor and define new colors in the new code path. 3. Too many duplicated color constants. This is addressed by consolidating 24 constants into 11 color ids. Ex (kCheckboxAndRadioBorderHoveredColor, kInputBorderHoveredColor, and kButtonBorderHoveredColor are mapped to kHoveredBorder) 4. The expected files for high contrast tests are prone to have conflicts. This is because upstream and downstream use different colors for disabled UI so every time upstream file is updated, downstream would need to re-baseline. This is addressed by providing default HC color for web tests mode, which also make the test results more readable. Bug: 1001546,1001553,1001554,986850 Change-Id: Icd6c4a0b96dd974b6500ba4365d22435d9e30f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792578 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Lily Chen authored
This makes CookieSameSite into two separate enums, CookieSameSite (representing the SameSite attribute value of the parsed cookie), and CookieEffectiveSameSite (representing the SameSite mode to be applied to inclusion/exclusion of that cookie). Previously they were the same enum, which resulted in overlapping sets of enum values that were possibly valid for one but not the other. This change removes the need to check whether a value is valid, because only valid semantically values are now included in the respective enums. Bug: None Change-Id: I467e7ac0551511e1afea74828886f40a57065d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808019 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#697462}
-
Jesse Schettler authored
Now that legacy printing IPC messages are being converted to Mojo, the IPC nesting level needs to be incremented/decremented in each Mojo method. This change moves the incrementing/decrementing of the IPC nesting level to helper methods that are used by the new Mojo methods and OnMessageReceived(). Bug: b:140576300 Test: Print a webpage or PDF Change-Id: Ib71796367cd36eef9293dfad455504b3ee2b57c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809803Reviewed-by:
-
Miyoung Shin authored
This CL converts InputDeviceManagerClient{AssociatedPtr, AssociatedPtrInfo} in services and chrome to the new Mojo type, and uses pending_associated_remote<InputDeviceManagerClient> in input_service.mojom. Bug: 955171 Change-Id: I348e6e41558c9529c4c713f1fd1409f37d95db18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806165 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
-
Rakib M. Hasan authored
Bug: 994943 Change-Id: I1f8f1119eff48292f5c00f7b1e152ebb6f059c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809751Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#697459}
-
Joshua Peraza authored
e97cf7b29c16 update gyp_crashpad_android.py 2bfd3c4edcff [POSIX] stop logging on ENOENT 12bc30cdf58a Check if attachment directories exist before open edbbc4609d2d chromeos: fix typo Change-Id: Icb1d0ca0eaf1aa854ac9fcdd083b75f8ec8ec59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809512Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#697458}
-
Robert Ogden authored
This is a reland of 75273409 TBR=tbansal@chromium.org,dullweber@chromium.org Original change's description: > Remove DRP Pingbacks > > Removes all the pingback code. There's still some stale code left but > that's all related to v1 HTTPS Server Previews which will be removed > soon. > > Bug: 957753 > Change-Id: I4d5cccd5e402a786c49b8ea1c5b1d95a396f8850 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807962 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Robert Ogden <robertogden@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697311} Bug: 957753 Change-Id: I5203db014d4a219a9f3c3b2da1bd69e62b0781c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809606Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#697457}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/384489020136..20791fdb3e91 git log 384489020136..20791fdb3e91 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 lamontjones@chromium.org chromeos_config: re-enable hwtests check. Created with: gclient setdep -r src/third_party/chromite@20791fdb3e91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4526d06887e1ee8a7bf89af086ae5284ca429176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809555Reviewed-by:
-
Fergus Dall authored
TBR=sky@chromium.org Bug: 846623 Change-Id: I2c9f73bc25eb0b9927591c3012351154525d0ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810142Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bbd0b15a0667..8e462ce33b7b Created with: gclient setdep -r src-internal@8e462ce33b7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I13deef9c4e42d4000d155d94da89c1753e8401a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810007Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697454}
-
Gyuyoung Kim authored
This CL converts BindingSet to ReceiverSet in CompositingModeReporterImpl. According to the change, |bindings| is changed to |receivers| and BindingRequest() is changed to BindReceiver() as well. Bug: 955171 Change-Id: I69d2a4f05101ac1c92a844fe5c5946099a4c6205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803939 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#697453}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: Icb6f6c47421173cf943070c45bdbf485bd990c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809965 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#697452}
-
Matt Reynolds authored
Previously, GamepadMonitor would only remove itself as a gamepad consumer if it was active (GamepadStartPolling called with no corresponding GamepadStopPolling), and would leak if it was inactive. This CL ensures GamepadMonitor is always removed if it was ever added as a gamepad consumer. BUG=998128 Change-Id: If4f1ac4d1f3b6889acffeb584c2c6dc04b310e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804836Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#697451}
-
Kelvin Jiang authored
This CL changes DNR actions such that a list of actions is returned when DNR rules are matched, and each action has a unique extension ID. This is necessary for remove header rules and the action feedback API to determine exactly which extensions removed which headers from a request. Bug: 973211, 991420 Change-Id: Ie77a9a51a3c6761da414f8bc3a0f8747068f3717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758806 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
-
Jeevan Shikaram authored
This CL fixes the errors that stopped the main page from being shown when an app was uninstalled. dom-switch now detaches it's child when the app-permission-view is not being displayed. Bug: 1001710 Change-Id: Iefb2e19a3a1aa70d69bbafa9c5b347a030f8fa0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799650 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#697449}
-
Steven Bennetts authored
Shill stores the Ethernet EAP properties in a separate service entry. This separation creates unnecessary and awkward complexity for the UI and serves little purpose at the UI layer. Previously we merged the dictionaries in the JS layer. This change does the merge in the mojo model layer, populating the managed EAP properties for the Ethernet network when they exist. This is done regardless of whether they are actually applied. This CL also adds EthernetEAP properties to chrome://network for debugging purposes. Bug: 853953 For comment only changes to cros_network_config.mojom: TBR=dcheng@chromium.org Change-Id: I7c47c7f33c9df1515b1f8674b4e6178747fcd35f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783880Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#697448}
-
khmel@chromium.org authored
At this moment it is not possible to configure custom set of systrace events to capture and all predefined categories are always used. It's not possible to easily change how much data is being captured. This CL allows to pass customs set of events or categories for systrace. TEST=Unit test, chrome//tracing does not break. systrace could be customized (with other CLs). BUG=b:/140939504 Change-Id: Icd590027f64fda251dc0f3dc7fb9632ebae5248f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801914 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts ExternalService and ExternalConnector to new Mojo types. It also updates RegisterServiceInstance and Clone from connector.mojom and members and methods which implement them. Bug: 955171 Change-Id: I8b9c6ab70a65b8c5661b294ec0ccde742123522a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803940 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
Matt Wolenetz authored
When a decoded audio buffer has an effective front discard that fully discards the decode output for that buffer, and also has an end discard, previously this would fail a DCHECK. Release code would fully discard that buffer, ignore that buffer's end discard, and handle any remaining front discard in future ProcessBuffer calls. Since this scenario can happen when the stream's duration metadata is incorrect relative to the precise decode output (and stream duration metadata sometimes has limited precision, commonly 1ms in webm), this change removes the DCHECK, but adds a comment for clarification. BUG=807515 TEST=associated fuzzer cases no longer fail the DCHECK Change-Id: Ibb0ec6469fbba0111e20758c485d38778983df23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809101 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#697445}
-
Leon Han authored
The spec change: https://github.com/w3c/web-nfc/issues/328 BUG=520391 Change-Id: Ida8e5d87ef25dc5b194d0cb4aa65104cfafc8614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806357Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#697444}
-
Ted Meyer authored
The play / pause events were missing, because they have no key/value pairs Change-Id: I7944aafa504070ef75a99fad0ec7ee299dc6ff73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808314Reviewed-by:
-
Sophie Chang authored
This should fix 7 out of the top 10 flaky tests for Blink>Previews The RunUntilIdle could potentially invoke a use after free if the UI thread shuts down the http server but then this gets invoked since the RunUntilIdle is actually called on the IO thread Bug: 1004245 Change-Id: Ia749c8f0b412bab6fcf8008764f244b030f1f94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809554 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#697442}
-
Lily Chen authored
This adds a histogram to record whether a SameSite=None cookie is also Secure. Bug: 993120 Change-Id: Idd40d395f6ea18bad1ebf2cc951a3f622cb86824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804498 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#697441}
-
Haines Sy authored
Report metrics based off of Built Type instead of channel for Fuchsia metrics Bug: 141130864 Change-Id: I8687514babd14fb5d8cec7289aafa72121bbc0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809674Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Haines Sy <hainesy@google.com> Cr-Commit-Position: refs/heads/master@{#697440}
-
Caroline Rising authored
This animates the new extensions container when extensions are added/removed from the toolbar. There will be a follow up that moved the animating layout to toolbar icon container view so that animating layout will also be used for the avatar button. Bug: 985792 Change-Id: Ia0717e982825ddaa794ad495b20a3ef32bf87060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756983 Commit-Queue: Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#697439}
-
