- 16 Oct, 2020 40 commits
-
-
Gavin Williams authored
This change introduces darker colors to Settings search page to improve the background contrast ratio to reach ARIA standards. Add a variable for prompt color and icon opacity to <cr-toolbar-search-field> so these attributes can maintain different values in non-Settings surfaces (Downloads search, Bookmarks search, etc.). Settings screenshot: http://screen/BohiVQV9iENxyZM Downloads screenshot: http://screen/3QNNWn7ZusdeUSU Bookmarks screenshot: http://screen/4PqfQQKNMDaCMsV Bug: 1040957 Change-Id: Ib6d4371c84b40f8a74ee68bc545b25ce0d0c4b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469663Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#818163}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/68ab63fe46c8..426436686c95 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rbpotter@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1136507,chromium:1138515 Tbr: rbpotter@google.com Change-Id: Ideb7e02f121ecfed2da09e473bfeeb4ecd7159f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481883Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818162}
-
evliu authored
This CL updates the paths for the Speech On-Device API (SODA) tests. Bug: 1128306 Change-Id: Ic5aa1f30114b1f79daa9de594fcde716a1b65177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481747Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#818161}
-
Carlos Knippschild authored
Nothing to be merged though. Change-Id: Iaaa819c8efec686380a275d1369a1befb5bd3902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481827 Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#818160}
-
Joe DeBlasio authored
Change-Id: I8b7d141ed54af0e5ee35a8f4e340deb90297ed01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481904 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#818159}
-
Henrique Nakashima authored
These will be internal classes, but while the implementations that use them are not modularized, they need to be in the public target. Only change is to make them package-private so external dependencies on TabModelOrderController aren't added. Bug: 1138005 Change-Id: Ief09c129337463872bec8400fe169c970ce7b466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469537Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#818158}
-
Aidan Wolter authored
When the GATT connectibility is not changing, then do not bother printing a log. Bug: b/139314817 Test: None Change-Id: If80ce46817126baa2ee953bae7eda0f5e3be8695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472419Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Auto-Submit: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#818157}
-
Jesse Schettler authored
The value of a select element is always a string, so the Polymer properties bound to select element values are also strings. Fix the annotations for these properties to indicate the correct types. Bug: 1059779 Change-Id: I4ee229694f7925ac152d7de838779d36b9e9b56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481051 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#818156}
-
Sky Malice authored
TBR: siashah@google.com Bug: 1139488 Change-Id: I2d149addf553a4c83eabfc45aaba811e79817e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481944 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#818155}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6a9de74d. With Chromium commits locally applied on WPT: 1c2c60bf "Synchronize classList on SVGElement.className.baseVal updates" 2f19541f "Fix AtomicStringTable lowercase translator." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I30da50b9c897450c8afb82f871bc650bd6d4e902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481582Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818154}
-
Carlos IL authored
Bug: 1042877 Change-Id: Ib4ba9d336bde09e82c17594dcd105448b2ff8916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454853 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#818153}
-
Gordon Seto authored
Add a visual outline around the currently focused image. Screenshot: https://screenshot.googleplex.com/9Bwy5ZFcFoVuWX4.png Bug: 702730 Change-Id: I9c091d022ed3f230b99894fc35c1afb3c807c075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476627Reviewed-by:
-
Liquan (Max) Gu authored
Context: PaymentRequestEvent.openWindow() fails with a cross-origin error caused by some unknown factors. Change: * Reverted the reverting CL: crrev.com/c/2220705 Bug: 1075481 Change-Id: I2a3452f58d5686e0dcfcd1ba0e30229e69bfe280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459389Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#818151}
-
Sky Malice authored
TBR: dominickn@chromium.org Bug: 1139496 Change-Id: I65f4c3e974ec832e102803213fcdb4c1c7ff6079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481744Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a23231ea7d91..df17a76102df 2020-10-16 srisser@google.com Make abort on LOG_TRAP opt-in If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If9321751814ca97ce36f29420b8afc7a700ebeda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481057Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818149}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fd0b15801ff8..f9c7b2803461 2020-10-16 bungeman@google.com Add test for old font axis deserialization. 2020-10-16 mtklein@google.com move SkTPin to include/private 2020-10-16 michaelludwig@google.com Factor perspective scale into filter matrix decomposition 2020-10-16 csmartdalton@google.com Slightly improve cubic chop precision in stroke tessellation shaders If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I11f0a1c1c531288b33af83c907794eb1bd54de9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481570Reviewed-by:
-
manukh authored
Currently, the chain of methods invoked in the bookmarks model to find bookmark matches for a given omnibox input use a pointer param to return matches. This CL refactors these to return a vector instead. - TitledUrlIndex::AddMatchToResults - TitledUrlIndex::GetResultsMatching - BookmarkModel::GetBookmarksMatching This is a refactor with no behavior change. This is the 3rd CL implementing bookmark-paths which will allow inputs to match bookmark paths (without contributing to the bookmark suggestion's score). Bug: 1129524 Change-Id: Idfbc13bc9d3d9b6c830c5972e68911aa310e2d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459392Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818147}
-
Pranav Batra authored
This change is necessary for the new pita printer tast tests to work properly. BUG=none TEST=tast run -buildbundle pita <DUT> printer.* Change-Id: Ie7898f067e150336f3706101c3fa3ba6dd2a1b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470118 Commit-Queue: Pranav Batra <batrapranav@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#818146}
-
Anupam Snigdha authored
Added a flag to enable/disable toggle mode when insert key is pressed This is currently disabled by-default. Bug: 1030231 Change-Id: I9c2dd62c0afe24d27848d189bf151d6a87a64068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473771Reviewed-by:
Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Chris Davis (EDGE) authored
With this CL, high-resolution timer is never activated for a delayed task that lives in a task queue with a low priority. Since such a task queue must already support late scheduling, it shouldn't care about precise execution delays. Bug: 967777 Change-Id: I6c8403075dc15368acaee74aef9c39b0b9b7c926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470322 Commit-Queue: Chris Davis <chrdavis@microsoft.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#818144}
-
Becca Hughes authored
Add a UKM to track navigations when a user clicks on something in Kaleidoscope. BUG=1110373 Doc: https://docs.google.com/document/d/1RRF7XpUss7vr-qD4ckmOPyiQrfjQUTLip2YTDkXjchY/edit Change-Id: Ib0afa41e997aec8cee9bcdc010030cc086a6fcff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441289 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#818143}
-
Sky Malice authored
This reverts commit 342a65b7. Reason for revert: Test failure https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2559 Original change's description: > network: de-flake NetworkQualityEstimator throttling test > > This test has is flaky when run on devices that have a real wifi or > cellular connection, because in that situation, the call to > SimulateNetworkChange() can cause an arbitrary number of real calls > to GetCurrentSignalStrengthWithThrottling(). This change de-flakes > the test in that situation by: > > 1) Delaying constructing the HistogramTester, to avoid counting > those calls, and > 2) Advancing the fake time the test uses at the start of the test, > so that the NetworkQualityEstimator under test is never in its > timeout period when the test starts > > This change also re-enables the test on Android, since this should > de-flake the test there too. > > Bug: 1133439,1130720 > Change-Id: I4164ce4bb105082fe58382c3f7c72b5b9462a8ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476812 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817719} TBR=ellyjones@chromium.org,tbansal@chromium.org Change-Id: Id4bd9253500cd585a1ce38fd49b5fcae6db7c555 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133439 Bug: 1130720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482084Reviewed-by:
-
Azeem Arshad authored
This CL fixes tooltip for "Show password" button in the network password input not showing when button is focused. This was fixed by using paper-tooltip that is set as the aria label instead of the title attribute. Screenshot: https://screenshot.googleplex.com/5UwHb4PwBRM9zU3.png Fixed: 873114 Change-Id: I4ea4cc48b1a2bb2db679f566454f945fb6ba88a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477603 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#818141}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I890946616ec7d19b3f7285dbd46a6fb01c4f44c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481414 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Henrique Nakashima authored
UrlConstants in //components/embedder_support already knows what is an NTP URL, so the method to detect it makes sense in UrlUtilities. This breaks dependencies on NewTabPage from a number of classes, allowing them to be modularized/componentized. Bug: 1138561 Change-Id: I8813c6277e13272741ddd98c14a11f2067cb6a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472586 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#818139}
-
Xiyuan Xia authored
MemlogBrowserTest depends on PlatformBrowserTest. However, this is not reflected in its BUILD.gn. As a result, InProcessBrowserTest is complied differently. `views_delegate_` address is used for `sampling_profiler_` in MemlogBrowserTest and causes strange crashes in the try run of https://crrev.com/c/2467940. Bug: 1136145 Change-Id: I713f374354056928bd1d24354edcda99bb193b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480818Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#818138}
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: Ib8c644a11cd7cb98a892f9f84b80d8130195cf28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468792 Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818137}
-
Dominic Farolino authored
It became clear during the auditing of process-global associated interfaces that the SearchBouncer interface was clinging to dead code so this CL removes it entirely. More context: https://docs.google.com/document/d/12jyv-8aBwMlSS_Y5roEl_ykZT0_eQszGiiNs7Hxktmk/edit#heading=h.4zjjh3zdcgd Bug: 1132901 Change-Id: Ib71d962d9d41c44fba52c420850b78b23b38b7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481087 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#818136}
-
Corentin Wallez authored
Bug: chromium:1139232 Change-Id: I5be89203e8797a58234a2bee88f9efafc09a6d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478951Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#818135}
-
Rebekah Potter authored
This reverts commit 320837f5. Reason for revert: The tests added here (WebAppHandlerRegistrationUtilsWinTest.*) are failing on multiple Win 7 bots, see https://bugs.chromium.org/p/chromium/issues/detail?id=1139503 Original change's description: > desktop-pwas: Introduce shared file/protocol handler registration logic > > This CL refactors Windows file handler registration in a way that > exposes shared logic useful for protocol handler registration. Protocol > handler registration that consumes the shared logic will be added in a > subsequent CL. This design is detailed in section 4.4 of [1] with a > summary given below. > > The refactor splits up registration by functional concerns, > with pieces that may be shared with protocol handler registration living > in web_app_handler_registration_utils_win.h/.cc. > web_app_file_handler_registration_win.h/.cc is now significantly smaller > and addresses file-handler-specific concerns in addition to consuming > the utils API. > > File handler registration consists of several pieces: > > 1) Create an app registry entry: HKCU\Software\Classes\<app_progid> > 2) Copy (or hardlink) chrome_pwa_launcher.exe from browser install > directory to <profile_dir>\web_applications\<app_id>\<app_name.exe> > 3) Reregister an app (steps 1 and 2) with a profile-specific name when > the same app is installed to a different profile > (e.g. "App" -> "App (Profile 1)") > 4) Create a file type association registry entry: > HKCU\Software\Classes\.<file_ext> > > In this approach, 1 & 4 are contained in the existing > ShellUtil::AddFileAssociations function. 2 & 3 are moved to utils > (CreateAppLauncherFile and CheckAndUpdateExternalInstallations). > > Important note about this design: > - Reregistration logic (3) is altered in this approach. Currently, > pieces 1, 2, 4 are all executed during reregistration. Because (4) is a > file-handler only concern, it wouldn't make sense to use existing logic > from the protocol registration flow. Reregistering (1) and (2) are > sufficient to rename a duplicate app - this is because file handler > registry entries (4) only reference the progid of an app which doesn't > change if its display name is updated (or if the update fails). > CheckAndUpdateExternalInstallations only updates necessary registration > pieces to reflect an updated name while leaving existing file/protocol > pieces in place. > > Alternative design: > crrev.com/c/2309759 previously attempted this refactor by splitting the > registration process into a shared app-level API instead of a Utils API. > As a result, ShellUtil functions that are currently atomic > (AddFileAssociations) were split into non-atomic app-level and file > handler pieces. The design was abandoned for this reason. > > [1] https://docs.google.com/document/d/1NHlWLjAPZ-dyxcz3AoTWibeerDeHW7Vqrx6FmhB0XmE/edit#heading=h.qsh70q > > Bug: 1019239 > Change-Id: I5f727a5ca1483efd21935c0201ee54474a94e598 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462383 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: David Bienvenu <davidbienvenu@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#818065} TBR=sky@chromium.org,dmurph@chromium.org,grt@chromium.org,davidbienvenu@chromium.org,fabio.rocha@microsoft.com Change-Id: Ic050a0aaf46d1c4d9e4b8a7f2b2798d2a73cb2ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482083Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#818134}
-
Nate Fischer authored
This reverts commit db9be6c9. Reason for revert: Still flaking, see https://crbug.com/1135839 Original change's description: > [AW][Dev-UI] Reland "Add some espresso tests for flag UI" > > This relands https://crbug.com/c/2438534 with a couple small changes: > > - android:windowSoftInputMode="adjustPan" attribute was missing in the > test manifest but is used in prod manifest. Adding it to the tests > manifest fixes the problem of auto-showing the keyboard on M devices > which was causing the test flakiness. When the keyboard shows up it > hides the view causing espresso to fail. > > - Merge the small change from https://crrev.com/c/2455687 to > test whether the overrideFlagsMap has the correct entries. > > Fixed: 1135839, 1130599 > Test: run_webview_instrumentation_test_apk -f "*FlagsFragmentTest*" on android M emulator > Change-Id: I973e8cd2b7a9c12651d7a6e14f11a368f6e06bad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453564 > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Commit-Queue: Hazem Ashmawy <hazems@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817184} TBR=changwan@chromium.org,ntfschr@chromium.org,hazems@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1135839 Change-Id: I17327632b54350c4db8cd182f2a2163cedb2f03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481942 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
-
Gang Wu authored
This CL lets TabAndroid supports base::SupportUserData, then ChromeAutocompleteProviderClient can store stripped urls in TabAndroid to avoid stripping url over and over again. Bug: 1094056 Change-Id: If0448c825965ddc7f43bd2aacc9c1d868e27b09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472461Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818132}
-
Manu Cornet authored
Bug: 1136145, 1056219 Change-Id: Ic57ec33b0ede604127e25817e1c67aa4c04bda42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480024Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#818131}
-
zhiyuancai authored
This CL fixes a presubmit warning in TabGridDialogView by replacing setTextColor with setTextAppearance. Bug: 1135433 Change-Id: I863f09939a78fdef0a81ba99df649a771c4b9339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459066Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Cr-Commit-Position: refs/heads/master@{#818130}
-
Chris Hamilton authored
This is a reland of 85ecd948 Original change's description: > [PM] Implement V8ContextTracker business logic. > > BUG=1080672 > > Change-Id: I10d0f001f00f1f7eb566843b9e9647297569abb2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466152 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817764} TBR=joenotcharles@chromium.org Bug: 1080672 Change-Id: Ib8e3eb1e2d1d0cc91adfe4ee5747d816be7b9a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479566Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#818129}
-
Sky Malice authored
TBR: yuezhanggg@chromium.org Bug: 1139475 Change-Id: I3a904e1e09e2a9330c6b4ed97b32704977f73398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481682Reviewed-by:
-
Liquan (Max) Gu authored
Now that PaymentRequestImpl has been renamed PaymentRequestService after CL[1], the variables, methods, classes names in MojoPaymentRequestGateKeeper should be renamed accordingly. [1] https://crrev.com/c/2467359 Bug: 1137006 Change-Id: I1baa16f4220760cb7434ef9397c4a091b8425a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481249Reviewed-by:
-
Wenyu Fu authored
Clean up expired HomepageLocationPolicy flag, which is 100% enabled. Also remove test cases that has the feature disabled. Bug: 1110647 Change-Id: I69c92305439c631a7f4c61d09cfdf226e5f0e2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472265Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818126}
-
Sky Malice authored
TBR: dullweber@chromium.org Bug: 1139480 Change-Id: I0413c0f7d73fe811c678e8cc290609cffab5eedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481823Reviewed-by:
-
dpapad authored
Bug: 720034 Change-Id: Ibddd393abde847d06e3c82ab3c3d4be1d1d56526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478885 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#818124}
-
