GitLab

- One for AppListControllerDelegate class.
- Other for the AppList - Init/Show functions.

R=xiyuan@chromium.org
TBR=sky@chromium.org # for trivial include updates

Review URL: https://codereview.chromium.org/11834002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175961 0039d316-1c4b-4281-b951-d872f2087c98

It used to be manually listed in the new engineer setup guide. Removing
it from there and adding here.

NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11777031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175960 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11830028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175959 0039d316-1c4b-4281-b951-d872f2087c98

Previously the directory name contained spaces which is problematic
when applying patches on trybots. In the future this directory
will go away with the new native host installation mechanism, so the name
doesn't really matter.

BUG=142915

Review URL: https://codereview.chromium.org/11833021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175958 0039d316-1c4b-4281-b951-d872f2087c98

> Windows: Remove content's dependency on d3dx9_43.dll.
> 
> ANGLE doesn't need this loaded anymore.
> 
> Review URL: https://chromiumcodereview.appspot.com/11737027

See also: https://codereview.chromium.org/11747017/

TBR=apatrick@chromium.org
Review URL: https://codereview.chromium.org/11820033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175957 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175956 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166496
BUG=167187
TBR=rsleevi

Review URL: https://chromiumcodereview.appspot.com/11833014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175954 0039d316-1c4b-4281-b951-d872f2087c98

TBR=noel
TEST=
BUG=


Review URL: https://chromiumcodereview.appspot.com/11833012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175953 0039d316-1c4b-4281-b951-d872f2087c98

Clamps the incoming invalidation regions of PictureLayer to the actual layer bounds to avoid bloating the update region data structure. It also adds an early out when the invalidation rect is empty. 

Review URL: https://chromiumcodereview.appspot.com/11824013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175952 0039d316-1c4b-4281-b951-d872f2087c98

> Solution: the popup keeps mouse capture, so that any mouse click closes it (via WebKit's WebPopupMenuImpl.cpp) not just clicks in it or in its browser window.
> 
> BUG=161129
> TEST=navigate to
> http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_select
> Click on the "car name" to bring up the pop-up.
> Click outside the browser window to see it close (just as for clicking inside the browser window)
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11675002

TBR=sschmitz@chromium.org
BUG=169115, 161129
Review URL: https://codereview.chromium.org/11829044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175951 0039d316-1c4b-4281-b951-d872f2087c98

The IPC proxy is now the default. The SRPC proxy can still be run locally and
in tests with the --enable-nacl-srpc-proxy command line flag.
BUG=154443
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/11801039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175950 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=binji@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/11817037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175949 0039d316-1c4b-4281-b951-d872f2087c98

Doing so prevents the silliness of passing the same pointer into WebMediaPlayerParams twice. Furthermore, the switch-checking logic and render view ID code is better contained as part of RenderViewImpl as opposed to being stuffed inside RenderAudioSourceProvider's constructor.

BUG=136442

Review URL: https://codereview.chromium.org/11830004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175948 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11833008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175946 0039d316-1c4b-4281-b951-d872f2087c98

The SyncManager will stop the scheduler as part of StopSyncingForShutdown, which
happens well before things like the invalidator are torn down / told to stop
interacting with the scheduler.  As such, we can wind up scheduling nudges on a lame
duck scheduler.  Some of the stacks associated with 165561 clearly show browser
shutdown happening on the UI thread and OnIncomingInvalidation happening on the
sync thread, which will crash on a second invocation as pending_nudge will be
set to a job that is dropped by ScheduleSyncSessionJob.

BUG=165561


Review URL: https://chromiumcodereview.appspot.com/11827013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175945 0039d316-1c4b-4281-b951-d872f2087c98

This will save some trouble to those who want to interpret
the field trial results.

BUG=chromium-os:37583
TEST=manually tested


Review URL: https://chromiumcodereview.appspot.com/11823028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175944 0039d316-1c4b-4281-b951-d872f2087c98

> [Media Galleries] Add an ImageCaptureCore listener for Mac. (part 2)
> 
> This listener uses the ImageCapture API to watch for attach and detach
> events of PTP devices and other devices which can be read through the
> library. It forwards such notifications through the SystemMonitor.
> 
> Also provides an API for clients to access such devices directly and
> retrieve the media contents from them.
> 
> R=thestig@chromium.org,sail@chromium.org
> BUG=151681
> 
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175471
> 
> Review URL: https://chromiumcodereview.appspot.com/11442057

TBR=gbillock@chromium.org
Review URL: https://codereview.chromium.org/11817036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175943 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11827034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175942 0039d316-1c4b-4281-b951-d872f2087c98

Implement the following functions:
- GetApplicationInfo
- CopyHostedDocument,
- RenameResource
- AddResourceToDirectory
- RemoveResourceFromDirectory,
- AddNewDirectory

Now FakeDriveService behaves meaningfully and should be ready for use.

BUG=162350
TEST=none; no changes in production code.

Review URL: https://codereview.chromium.org/11825021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175941 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168424
TEST=manual
Review URL: https://codereview.chromium.org/11817009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175940 0039d316-1c4b-4281-b951-d872f2087c98

This listener uses the ImageCapture API to watch for attach and detach
events of PTP devices and other devices which can be read through the
library. It forwards such notifications through the SystemMonitor.

Also provides an API for clients to access such devices directly and
retrieve the media contents from them.

R=thestig@chromium.org,sail@chromium.org
BUG=151681


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175471

Review URL: https://chromiumcodereview.appspot.com/11442057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175938 0039d316-1c4b-4281-b951-d872f2087c98

This change didn't end up being the source of the ChromeOS problems so I'm
reverting my revert.

> Revert 175826
> 
> This change appears to be breaking the ChromeOS(x86) and ChromeOS(amd64) bots.
> http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/11010
> 
> > Clean up: remove unnecessary if-branches on initialization of the a11y prefs.
> > 
> > According to the comment at preferences.cc:96, some accessibility prefs may be already registered in WizardController::RegisterPrefs. But the magnifier prefs are never registered there, hence we can remove if statements.
> > 
> > BUG=none
> > TEST=launch ChromeOS, and login.
> > 
> > Review URL: https://chromiumcodereview.appspot.com/11820018
> 
> TBR=yoshiki@chromium.org
> Review URL: https://codereview.chromium.org/11817029

TBR=acolwell@chromium.org
Review URL: https://codereview.chromium.org/11824051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175937 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11824047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175936 0039d316-1c4b-4281-b951-d872f2087c98

I don't think we need to support such a switch because:
  1. Shortcut creation is already controlled by a checkbox in the UI.
  2. Profile creation should be sufficiently rare that it doesn't make
     sense to have a switch to control this.

BUG=none
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/11817016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175935 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11826033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175934 0039d316-1c4b-4281-b951-d872f2087c98

1) The test class name should begin with "Gpu" to be picked by gpu bot filters.

2) implify gpu crash tests by directly call the SimulateCrash function. Before we open a new tab, go to about:gpucrash.  This is really unnecessary.

3) Disable infobar stuff for Kill - otherwise the GPU process won't launch after crashing.

4) Clean up the webgl.html a little bit.

BUG=111506
TEST=gpu bots
Review URL: https://codereview.chromium.org/11824045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175933 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/ui/views/avatar_menu_bubble_view.cc

This is for Chrome on Windows.

Part of work to use standard font sizes instead of "DeriveFont +/- N Pixels". 
Changed UIs were seen and blessed by sgabriel@ and kuscher@.

The code now uses standard fonts: base and small. Base is used for the names. The resulting change is:
Old: 13 pixels (bold for active, non-bold otherwise)
New: 12 pixels (... same bolding)
For the emails the font size did not change, since the std SmallFont was recently changed from 10 to 11 pixels.

Please see crbug.com/169039 for before and after screenshots

BUG=169039, 137349
TEST=manual
Bring up Chrome on windows; click on avatar in top bar.

Review URL: https://chromiumcodereview.appspot.com/11819035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175932 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175931 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds support for Chrome's identity API, part of the Apps v2 migration effort:
* Add identity.js, wrapping chrome.experimental.identity and handling user consent UI automatically.
* Since the consent UI is now shown on-demand, it's better handled as an explicit overlay rather than as a AppMode, so remove home.auth.
* Move access token and email address functionality out of oauth2.js into identiry.js.
* Add stub code to simplify the transition to using the new code.
* Add patch to enable Apps v2 work-in-progress.

BUG=134213

Review URL: https://codereview.chromium.org/11769002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175930 0039d316-1c4b-4281-b951-d872f2087c98

Instead of "unicode/...", "third_party/icu/public/..." should always be used
in Chromium code. This matches the established style.

BUG=165264

Review URL: https://codereview.chromium.org/11791036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175929 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/11828005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175928 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds infrastructure to make it easy for PictureLayerImpl to
manage its set of tilings via PictureLayerImpl::ManageTiles().

The main functionality change is to additionally generate a low-res set
of tiles (by default 1/8 resolution).  Along with generating tilings at
different scales, tile priorities now have the correct resolution set on
them so that they can be prioritized correctly.

There's a few small bugfixes added here as well for correctness, such as
making sure that tilings are sorted in the PictureLayerTilingSet from
highest to lowest.  (This is the order in which tiles will be used.)  It
also correctly calculates a synthetic contents scale / content bounds for
the PictureLayerImpl to support multiple active contents scales.

R=nduca@chromium.org
BUG=167300


Review URL: https://chromiumcodereview.appspot.com/11704002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175927 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175926 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yangguo@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11830021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175925 0039d316-1c4b-4281-b951-d872f2087c98

Changes in preparation to moving buildbot config to point directly
to this file.

- Improved substring bot-id matching. Because we're using an
  unordered dict, look for all possible bot-id substring matches
  and pick the longest one, instead of picking the first substring
  match.

  Added generic 'builder' bot-id that several bots will use.

- Changed factory_property key to 'android_bot_id' to make it more
  clear where this value is used and easier to search for.

R=cmp
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11823032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175924 0039d316-1c4b-4281-b951-d872f2087c98

R=enne


Review URL: https://chromiumcodereview.appspot.com/11830031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175922 0039d316-1c4b-4281-b951-d872f2087c98

Simplify the makefile for the hello_world_XXX examples.
Update create_nmf to support direct PNaCl NMF files.
Update common.mk to support PNaCl

NOTRY=true
R=binji@chromium.org
BUG=169044

Review URL: https://codereview.chromium.org/11725003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175921 0039d316-1c4b-4281-b951-d872f2087c98

MediaPlayerEventRouter and move to extensions namespace

-Move chrome/browser/chromeos/media/media_player_extension_api
to chrome/browser/chromeos/extensions/media_player_api
and to extension namespace.


Patch from Joe Thomas <mhx348@motorola.com>.

BUG=159265
TBR=ben@chromium.org for gyp

Review URL: https://chromiumcodereview.appspot.com/11638024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175920 0039d316-1c4b-4281-b951-d872f2087c98

This patch prevents the creation of some render targets by informing the logic that determines if a sub-tree needs an intermediate render target about the ability of descendants in its sub-tree ability to clip themselves.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11567034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175919 0039d316-1c4b-4281-b951-d872f2087c98

Verified that crbug.com/169028 is not caused by this change. Reapply it.

This reverts commit 9acaad1441f150c9ef8206c28a3c2bfda13634f5 which reverted 4c3f35e3.

TBR=darin
BUG=165783,169028

Review URL: https://codereview.chromium.org/11818039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175917 0039d316-1c4b-4281-b951-d872f2087c98