GitLab

BUG=712479

Review-Url: https://codereview.chromium.org/2825493005
Cr-Commit-Position: refs/heads/master@{#465712}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/121ef2b4a8c6..6939b1db033b

$ git log 121ef2b4a..6939b1db0 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 simonhatch Dashboard - Filter NaN values in /graph_json and /graph_revisions.
2017-04-19 kainino Mac: download numpy and cv2 from Cloud Storage

Created with:
  roll-dep src/third_party/catapult
BUG=711307


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Id2d7bc9cf780f8e0f6d9a78e5118fd5aff8ea955
Reviewed-on: https://chromium-review.googlesource.com/482179
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#465711}

virtual/sharedarraybuffer/fast/css/fontfaceset-check-platform-fonts.html
is flaky on Windows.

BUG=713094
TBR=ksakamoto

Review-Url: https://codereview.chromium.org/2832593002
Cr-Commit-Position: refs/heads/master@{#465710}

Revert of Disable flaky WebNavigationApiTest.CrossProcessHistory. (patchset #1 id:1 of https://codereview.chromium.org/2790383002/ )

Reason for revert:
What I believe was the underlying issue has been reverted, so it should be safe to reenable this test back.

Original issue's description:
> Disable flaky WebNavigationApiTest.CrossProcessHistory.
>
> TBR=nasko@chromium.org
> BUG=708139
>
> Review-Url: https://codereview.chromium.org/2790383002
> Cr-Commit-Position: refs/heads/master@{#461690}
> Committed: https://chromium.googlesource.com/chromium/src/+/656fccff69eae8da012f0f83bcd3fc89214c5258

TBR=maxmorin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=708139

Review-Url: https://codereview.chromium.org/2830813002
Cr-Commit-Position: refs/heads/master@{#465709}

If item get removed from the content pane, the buttons should always
remain at the bottom.

BUG=712539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2833533002
Cr-Commit-Position: refs/heads/master@{#465708}

This also renames the JS<->C++ API; C++ does not need to know about pin.

BUG=623344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2814863002
Cr-Commit-Position: refs/heads/master@{#465707}

Displays a PaymentMethodItem in the credit card form in order to identify
the server card being edited.

http://imgur.com/a/CM38f

BUG=602666

Review-Url: https://codereview.chromium.org/2826593005
Cr-Commit-Position: refs/heads/master@{#465706}

Revert of [Mac] Support for Touch Bar Customization (patchset #8 id:180001 of https://codereview.chromium.org/2814683005/ )

Reason for revert:
Broke the 10.12 build

Original issue's description:
> [Mac] Support for Touch Bar Customization
>
> Implement customization support for the default touch
> bar. Changed the item identifiers to reverse-DNS style format.
>
> BUG=710100
>
> Review-Url: https://codereview.chromium.org/2814683005
> Cr-Commit-Position: refs/heads/master@{#464967}
> Committed: https://chromium.googlesource.com/chromium/src/+/1ad3c00f56fbf19ecba52bdf0591ca7ad1098d3a

TBR=rsesek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=710100

Review-Url: https://codereview.chromium.org/2831713002
Cr-Commit-Position: refs/heads/master@{#465705}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e6777487..bde4f053

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2830753002
Cr-Commit-Position: refs/heads/master@{#465704}

BUG=

Review-Url: https://codereview.chromium.org/2825333003
Cr-Commit-Position: refs/heads/master@{#465703}

I only saw this crash once, and can't reproduce, but better safe than sorry.

BUG=712823

Review-Url: https://codereview.chromium.org/2830463002
Cr-Commit-Position: refs/heads/master@{#465702}

BUG=657826,657825
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2778223005
Cr-Commit-Position: refs/heads/master@{#465701}

Adding all sources to a "_all" pseudo module fixes Studio's code analysis
functions (imports, refactoring).

In order to have things build properly in gradle, the "_all" module has
all sources excluded (gradle applies the filters, studio does not).

Also fix "--all" targets to include tests. Make it easier to make sweeping
java refactors in Android Studio.

BUG=620034

Review-Url: https://codereview.chromium.org/2812133003
Cr-Commit-Position: refs/heads/master@{#465700}

The spec calls this CanvasPath. Renaming to sync with spec.

BUG=708195

Review-Url: https://codereview.chromium.org/2826773002
Cr-Commit-Position: refs/heads/master@{#465699}

Before this patch, calling e.updateWith(new Promise((resolve) => {}));
would result in 'shippingoptionchange' and 'shippingaddresschange' never
timing out. This is because the timeout timer was being stopped in
updateWith() call.

The fix is to stop the timeout timer when the resolve() callback is
invoked instead of when updateWith() is called.

After this patch, calling e.updateWith(new Promise((resolve) => {}));
will timeout after 60 seconds.

To test manually:
1) Open https://rsolomakhin.github.io/pr/ko/promise/.
2) Click [Buy].
3) Change the shipping address or option.
Observe: The UI closes and the page shows an error message after 60
         seconds.

The error message has been made more verbose as well: "Timed out waiting
for a response to a 'shippingaddresschange' event".

BUG=711691
TEST=PaymentRequestUpdateEventTest

Review-Url: https://codereview.chromium.org/2823393002
Cr-Commit-Position: refs/heads/master@{#465698}

Before this patch, calling PaymentRequest.abort() would reject the
PaymentRequest.show() promise with a message "DOMException: The user
aborted a request." This is misleading, because it is the merchant
that's initiating the abort.

The fix is to change the message to "The website has aborted the
payment."

BUG=713206

Review-Url: https://codereview.chromium.org/2825333004
Cr-Commit-Position: refs/heads/master@{#465697}

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/667321

https://chromium.googlesource.com/chromium/src/+/3596d8b9d1ada

BUG=709846
TBR=chrishtr@chromium.org

Review-Url: https://codereview.chromium.org/2831723002 .
Cr-Commit-Position: refs/heads/master@{#465696}

(1) refactor PaswordProtectionRequest to be RefCountedThreadSafe,
(2) use CancelableTaskTracker in PasswordProtectionRequest to make
    sure tasks posted on IO thread can be canceled correctly upon
    destructing PasswordProtectionService,
(3) Add the skeleton of PasswordProtectionFrame struct, which will be
    used to communicate password form information between
    ChromePasswordManagerClient and PasswordProtectionService

BUG=698899

Review-Url: https://codereview.chromium.org/2817533004
Cr-Commit-Position: refs/heads/master@{#465695}

Before this patch, if the merchant website never calls
PaymentResponse.complete(), then the UI shows a generic error dialog to
the user and aborts payment, but nothing indicates to the web developer
that it was a timeout that causes the closing of the web payment UI.

The fix is to add a console error message "Timed out waiting for a
PaymentResponse.complete() call" when the timer expires.

After this patch, the console error message will indicate to the web
developer that it was a timeout that causes the closing of the web
payment UI.

To test manually:
1) Open https://rsolomakhin.github.io/pr/ko/complete/.
2) Click [Buy] on the page.
3) Click [Pay] in the web payment UI.
Observe: Console prints an error message after 60 seconds.

BUG=711027

Review-Url: https://codereview.chromium.org/2827963002
Cr-Commit-Position: refs/heads/master@{#465694}

I really don't know enough about that code anymore to still be doing
owners reviews.

BUG=None

Review-Url: https://codereview.chromium.org/2829753002
Cr-Commit-Position: refs/heads/master@{#465693}

Reland https://codereview.chromium.org/2796533002 with synchronization with
child frame navigation.

When advancing focus into an iframe, allow the frame to focus itself
after deciding which element will be focused. This prevents sending a
focus event to the previous element in that frame only to blur it
immediately. Non-oopifs simply fire a focus event to the new element,
the previously focused element in that frame received a blur event when
another frame was focused.

The test ensures a consistent state when mixing tab and clicking
navigation. In specific cases, focus would early out when the element to
advance to was previously focused, and never cleared when the mouse is
clicked in another frame.

BUG=702330
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2833503002
Cr-Commit-Position: refs/heads/master@{#465692}

BUG=713138

Review-Url: https://codereview.chromium.org/2824413002
Cr-Commit-Position: refs/heads/master@{#465691}

I noticed that NextToken() had a bunch of code doing:

  if (IsASCIIUpper(c)) {
    doStuff(ToLowerCase(c));
  } else if (IsASCIILower(c)) {
    doStuff(c);
  }

Since lowercasing is done by just setting the 0x20 bit, we can fold it into the
range check and always lowercase:

  if (IsASCIIAlpha(c)) {
    doStuff(ToLowerCase(c));
  }

This actually brings the code closer to the tokenization spec which for these
states does not separate between upper- and lower-case inputs.

I tried to measure the performance of this by modifying
PerformanceTests/resources/runner.js to run 1000 iterations and running the
html-parser.html test:

$ tools/perf/run_benchmark run blink_perf.parser \
  --story-filter=html-parser.html \
  --browser-executable=/work/chromium/src/out/release/content_shell

However I could see no change in performance.

Without my change:

avg 379.1670899999993 ms
median 381.46249999999054 ms
stdev 45.56871307699382 ms
min 253.66499999997905 ms
max 1199.0950000000007 ms

With my change:

avg 376.9821549999998 ms
median 381.8125 ms
stdev 42.23547601324007 ms
min 254.27000000000407 ms
max 1127.37 ms

This does remove ~100 lines of code and shave ~1 KB off the object file size
which is always something. And it should be faster, really.

BUG=none

Review-Url: https://codereview.chromium.org/2827653003
Cr-Commit-Position: refs/heads/master@{#465690}

This CL consists of the following three changes:

1) Move DeleteDirectoryContentAndLogResults() so that it runs only if
   jumplist_updater.BeginUpdate() succeeds, otherwise it's pointless.

2) Return early if any AddShellLink call fails. This is suspected to
   cause long execution time for jumplist_updater.

3) Decrease kFileDeleteLimit from 60 to 30. A user without jumplist
   issues should have at most 10 icon files in JumpListIcons folder as
   in crrev.com/2816113002. So changing kFileDeleteLimit to 30 won't
   affect "healthy" users. It'll give a better experience for users
   who have corrupted jumplist folders as the disk IO per jumplist
   update becomes less.

BUG=40407, 179576

Review-Url: https://codereview.chromium.org/2824103003
Cr-Commit-Position: refs/heads/master@{#465689}

Same for the rest of the call chain.

Review-Url: https://codereview.chromium.org/2824283004
Cr-Commit-Position: refs/heads/master@{#465688}

Revert of Disables RendererDebugURLsDontSwap on Mac in combination with ASAN (part 2) (patchset #1 id:1 of https://codereview.chromium.org/2733963004/ )

Reason for revert:
Looks like the symbolization issue on the Mac is fixed, so reverting this disabling of the test.

Original issue's description:
> Disables RendererDebugURLsDontSwap on Mac in combination with ASAN (part 2)
>
> Now excludes the test in combination with ADDRESS_SANITIZER instead of THREAD_SANITIZER
>
>
> NOTRY=TRUE
> TBR=nasko
> BUG=699062
>
> Review-Url: https://codereview.chromium.org/2733963004
> Cr-Commit-Position: refs/heads/master@{#455058}
> Committed: https://chromium.googlesource.com/chromium/src/+/f455b044581f319a0c039a1ba091a435e3c25a73

TBR=henrika@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=699062

Review-Url: https://codereview.chromium.org/2826193002
Cr-Commit-Position: refs/heads/master@{#465687}

Fixes a mistake in https://codereview.chromium.org/2486423003 - it should have
checked whether the current child has a previous sibling, not the candidate parent.

Also revert to the original version of the two tests - as the new versions never
fail.

BUG=695378

Review-Url: https://codereview.chromium.org/2828553002
Cr-Commit-Position: refs/heads/master@{#465686}

I'm going to need to pass additional parameters to the
constructor. It's getting a bit unwieldy and having two constructors
for two different purposes is error prone. So, I've extracted the
paramters into a structure and created a factory function for the
common case.

BUG=708287
TEST=covered by tests
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2823903005
Cr-Commit-Position: refs/heads/master@{#465685}

BUG=699798

Review-Url: https://codereview.chromium.org/2820203002
Cr-Commit-Position: refs/heads/master@{#465684}

  In order to roll GN 71aff04f..7c9bd5f0 (r464797:r465654) and pick up
  the following changes:

  53ca11c0 Update GN roller for new JSON endpoints.
  a38716a1 gn path: Add missing newline to output summary

TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2828043002
Cr-Commit-Position: refs/heads/master@{#465683}

This benchmark has been failing (timing out) for months now, so removing it won't affect the performance.

The issue seem to be that Speedometer takes a while to tun, and it's much slower in a PGI build, so we timeout after 10 minutes and at this
point the benchmark is still running. We could increase the timeout
but as mentioned above this has been failing for months and we haven't noticed a performance regression.

BUG=650432

Review-Url: https://codereview.chromium.org/2814103003
Cr-Commit-Position: refs/heads/master@{#465682}

The sets and maps are typically small or empty and created once. flat_set and
flat_map will have better performance for these workloads.

See the bug for histograms of sizes.

Reland of https://codereview.chromium.org/2821353002 with fix.
Reland of https://codereview.chromium.org/2823043002 with fix.

BUG=712295
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=jbauman@chromium.org

Review-Url: https://codereview.chromium.org/2831663002
Cr-Commit-Position: refs/heads/master@{#465681}

BUG=546208

Review-Url: https://codereview.chromium.org/2819883002
Cr-Commit-Position: refs/heads/master@{#465680}

Cr-Commit-Position: refs/heads/master@{#465679}

During recent changes, it became possible for the first video buffer
timestamp in a stream to be negative. This change restores the invariant
that video buffer timestampes are non-negative, by emitting a demuxer
error in this case.

BUG=710845

Review-Url: https://codereview.chromium.org/2822063002
Cr-Commit-Position: refs/heads/master@{#465678}

This patch refactors FindScrollLayerForDeviceViewportPoint as
FindScrollNodeForDeviceViewportPoint which both simplifies code and lets
us remove two users of ScrollNode's owning_layer_id.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2824683002
Cr-Commit-Position: refs/heads/master@{#465677}

For b/37234823

BUG=711841

Review-Url: https://codereview.chromium.org/2822843003
Cr-Commit-Position: refs/heads/master@{#465676}

https://codereview.chromium.org/2750503010 introduced a call to
GetFrameHostForNavigation while not meaning to create a
RenderFrameHostForNavigation. This is a wrong usage of this function.
This CL removes it in favor of using navigating_frame_host that was
defined earlier in the function.

BUG=711848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2825373002
Cr-Commit-Position: refs/heads/master@{#465675}

The method is now unused.

R=enne@chromium.org
BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2823253004
Cr-Original-Commit-Position: refs/heads/master@{#465423}
Committed: https://chromium.googlesource.com/chromium/src/+/efa3999f76e822cc9580cace498f3f778206a9dc
Review-Url: https://codereview.chromium.org/2823253004
Cr-Commit-Position: refs/heads/master@{#465674}

BUG=709080
TBR=varkha@chromium.org

Review-Url: https://codereview.chromium.org/2827093002
Cr-Commit-Position: refs/heads/master@{#465673}