GitLab

This adds 2 entrypoints:
- CreateSharedImage, which takes a GpuMemoryBuffer to wrap into a shared
image (equivalent to CreateImageCHROMIUM+BindTexImage2DCHROMIUM)
- UpdateSharedImage, which updates the binding after CPU/external writes
to the GMB (equivalent to ReleaseTexImage2DCHROMIUM+BindTexImage2DCHROMIUM).

This is only plumbed to SharedImageBackingFactoryGLTexture in this CL.

Bug: 870116
Change-Id: Ie7645b65649b0f34d5431fc00f62da9d5661c570
Reviewed-on: https://chromium-review.googlesource.com/c/1316250Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605832}

Also get rid of the SIZE placeholder constant, since it requires
additional case statements in switches. Define kMaxValue instead: clang
enforces the correct definition of this value, and the UMA enumeration
histograms can take advantage of it without any weird casting.

Bug: 742517
Tbr: oshima@chromium.org
Tbr: thestig@chromium.org
Change-Id: I34373733f7be363aa1d70827ae88dc03c6934819
Reviewed-on: https://chromium-review.googlesource.com/c/1312685
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605831}

Bug: 678391
Change-Id: I7751e50a050d32f826315832d6e250137eaba1cf
Reviewed-on: https://chromium-review.googlesource.com/c/1320730Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605830}

This callback may be reached as part of a close document action
after the engine has been destroyed. Further inspection of the code
shows that the same might also happen for Print().

Bug: 901640
Change-Id: I8faaeaf72adb37441f9e9c977093273c9e055e91
Reviewed-on: https://chromium-review.googlesource.com/c/1320810Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605829}

https://android.googlesource.com/platform/external/perfetto.git/+log/cc7964918f7c..02924fce9a91


git log cc7964918f7c..02924fce9a91 --date=short --no-merges --format='%ad %ae %s'
2018-11-06 primiano@google.com Merge "UI: tracks drag & drop + minor fixes"


Created with:
  gclient setdep -r src/third_party/perfetto@02924fce9a91

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I51387a85e5496afa1a2d2959fcd7dae3809c18ed
Reviewed-on: https://chromium-review.googlesource.com/c/1320789Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605828}

As there are no implicit conversions, break the inheritance completely
and clean a few remaining callsites.

R=gab@chromium.org
TBR=gab@chromium.org
BUG=891670

Change-Id: Ib8cd1461c24cecec70248e31597198fc670ec857
Reviewed-on: https://chromium-review.googlesource.com/c/1312481Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605827}

Vectors of primitive types and strings were previously implemented; this
extends support to vectors of unions and structs.

Bug: 883496
Change-Id: Id00174b05d04c3f432fae39112afde658e533806
Reviewed-on: https://chromium-review.googlesource.com/c/1318676
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605826}

We're looking to merge this (ideally temporary) metric into M71.
A problem has been discovered with regards to checkout flows that span
multiple domains, and this will help determine its impact.

Bug: 892299
Change-Id: I79c9acba23eb750aecf0171ee92d0de456c2ce0e
Reviewed-on: https://chromium-review.googlesource.com/c/1315953Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#605825}

This reverts commit 9fb6183a.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 605820 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzlmYjYxODNhZWY2NzhmYjJmMmJhM2I5ZTU0MGQwZDYxNTU1Y2U1ODQM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/linux-rel/9695

Sample Failed Step: compile

Original change's description:
> Move legacy DNS-related net/ mojo interfaces to proxy resolver service.
> 
> Also moves the code that imlepments each side of the interfaces from
> net/ over to the location of the single consumer of each of them, in
> the proxy_resolver and network services.
> 
> This CL is strictly a move, with no code changes. I will do some cleanup
> work in followup CLs.
> 
> Bug: 901419
> Change-Id: I31f6bb91dccc1d250d7c2fd03a07c4173030fc97
> Reviewed-on: https://chromium-review.googlesource.com/c/1320209
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Eric Roman <eroman@chromium.org>
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605820}

Change-Id: Ib6e8a9b7501437d72a0a59df5881cdfc5dd12c0f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 901419
Reviewed-on: https://chromium-review.googlesource.com/c/1320594
Cr-Commit-Position: refs/heads/master@{#605824}

* Remove jialiul@ (has left Chrome)
* Add drubery@ to a few dirs where he's the expert now
* Add COMPONENT info to all of them
* Other misc cleanups

Bug: 894851
Change-Id: I60e6b0f8651486a656363fe2b215b1451ae75615
Reviewed-on: https://chromium-review.googlesource.com/c/1318909
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605823}

Instead open links in app windows. See details
on the bug.

BUG=899092
TEST=Manual; all links open inside app windows rather than tabs.

Change-Id: I2fc0dc02a17fb37daec9c715ba1801d35cc1a629
Reviewed-on: https://chromium-review.googlesource.com/c/1320216Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605822}

No flag flip.

In QUIC, fix a bug where write blocked causes a spurious ack alarm to be set.
Protected by FLAGS_quic_reloadable_flag_quic_fix_spurious_ack _alarm.
Merge internal change: 219926538
https://chromium-review.googlesource.com/c/chromium/src/+/1318583

Remove unused constants from QuicConstants.
n/a (Remove unused constants)
Merge internal change: 219898685
https://chromium-review.googlesource.com/c/chromium/src/+/1318674

Factor out common code for sending control frames.
Code refactoring, no functional changes.
This CL extracts common code out of the several QuicControlFrameManager
methods that WriteOrBufferXxxFrame uses to actually perform the write.
This done in support of work for IETF QUIC STOP_SENDING frame.
Merge internal change: 219844258
https://chromium-review.googlesource.com/c/chromium/src/+/1318672

Create connecting methods in QuicSpdyStream to prevent its own class/subclasses
from calling QuicStream::WritevData() and QuicStream::WriteMemSlices() directly.
This CL prepares for change in IETF HTTP/QUIC mapping.
no behavior change.
Merge internal change: 219826835
https://chromium-review.googlesource.com/c/chromium/src/+/1318581

Replace FLAGS_quic_enable_version_99 with (enabling_blocked_by)
FLAGS_quic_reloadable_flags_quic_enable_version_99.
Merge internal change: 219787903
https://chromium-review.googlesource.com/c/chromium/src/+/1318573

Remove RetransmittableOnWireDelegate and the associated alarm and replace it
with the ping alarm in QuicConnection.
n/a (RetransmittableOnWireAlarm and PingAlarm are client only)
Merge internal change: 219732352
https://chromium-review.googlesource.com/c/chromium/src/+/1318569

Prevent all class/subclasses of QuicSpdyStream from calling
QuicStream::WriteOrBufferData() directly.
Instead, call QuicSpdyStream::WriteOrBufferData().
This CL prepares for change on IETF HTTP/QUIC mapping.
no behavior change.
Merge internal change: 219711495
https://chromium-review.googlesource.com/c/chromium/src/+/1317897

Change method signature of data frame encoder to take a length instead of a
frame struct. The reason is that often times when the encoder is called,
there isn't a well constructed data frame that is ready to use. Computing
the length of data is much easier.
n/a --unused code.
Merge internal change: 219708783
https://chromium-review.googlesource.com/c/chromium/src/+/1317920

Use GetCryptoStreamId() rather than hard-coded 1 for crypto stream ID
Test used a hard-coded 1 for the crypto stream ID. This is not the case when
Version 99 is enabled. This change uses GetCryptoStreamId() to get the
actual crypto stream ID for the current version.
n/a -- tests only
Merge internal change: 219471728
https://chromium-review.googlesource.com/c/chromium/src/+/1318445

Add OnCanCreateNewOutgoingStream to QuicSession,
Also revises the simple server session and grpc client session
so that they will receive the notification that more streams are avialable.
N/A code all in support of and protected by flag for version-99 (IETF QUIC).
Merge internal change: 219177525
https://chromium-review.googlesource.com/c/chromium/src/+/1318440

Change-Id: I5819d9c9a9fc45fc5cbeba2f3ddd8b925ae1c381
Reviewed-on: https://chromium-review.googlesource.com/c/1318678Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605821}

Also moves the code that imlepments each side of the interfaces from
net/ over to the location of the single consumer of each of them, in
the proxy_resolver and network services.

This CL is strictly a move, with no code changes. I will do some cleanup
work in followup CLs.

Bug: 901419
Change-Id: I31f6bb91dccc1d250d7c2fd03a07c4173030fc97
Reviewed-on: https://chromium-review.googlesource.com/c/1320209Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605820}

CanvasImageProvider is an inner class of CanvasResourceProvider,
that only needs to be defined on the header for the base::Optional
use of it. This CL changes that to std::unique_ptr<> like its sister
member |canvas_|, moves its implementation to the .cc file and
inlines the 1-line methods.

Also I replaced a base::Unretained() with a WeakPtr() since
I didn't see why wouldn't it work.

No new code intended beyond that, just cleaning up what there is.

Bug: 839970
Change-Id: I8f3b299c12662a7a83c72ac7bc3eae1b8c1f27ea
Reviewed-on: https://chromium-review.googlesource.com/c/1318816
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605819}

This simplifies "some" of the dependencies from the
AutocompleteCoordinator to the list view itself.  The
key handling is going to get a bit gnarly, but this
is closer to being able to move the bulk of the coordinator
into the existing AutocompleteMediator.

NOPRESUBMIT=true
BUG=898522

Change-Id: I71f6458220d4ba48c80db4aa18a3e78fe910872e
Reviewed-on: https://chromium-review.googlesource.com/c/1316832
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605818}

https://chromium.googlesource.com/catapult.git/+log/7b391c51f694..0273c5e3c23a


git log 7b391c51f694..0273c5e3c23a --date=short --no-merges --format='%ad %ae %s'
2018-11-06 perezju@chromium.org Revert "[Telemetry] Increase timeout on CollectChromeTracingData"


Created with:
  gclient setdep -r src/third_party/catapult@0273c5e3c23a

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:900920
TBR=sullivan@chromium.org

Change-Id: Iae4302cfb076a8bcd26ce8dbdb99be7afa47bcf3
Reviewed-on: https://chromium-review.googlesource.com/c/1320611Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605817}

Now this flag is unnecessary.

Bug: 681136
Change-Id: I76d762a7d2d36b42a0556cfd4667731d79cbc01a
Reviewed-on: https://chromium-review.googlesource.com/c/1316949Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605816}

This is a reland of 5528336d, which
was a reland of dd9df78c, which was
a reland of 7bd91635.

VR tests have been properly deflaked in https://crrev.com/c/1319715, this
is otherwise unchanged.

Original change's description:
> Reland "Reland "[blink] Control ScriptStreamer with ScriptResource""
>
> This reverts commit c564235f.
>
> No changes from the original, VR flakes are caused by issues with
> loadUrl and have been deflaked (see 894796 for details)
>
> Original change's description:
> > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource""
> >
> > This reverts commit dd9df78c.
> >
> > Reason for revert: Makes VR tests flaky (https://crbug.com/894796)
> >
> > Original change's description:
> > > Reland "[blink] Control ScriptStreamer with ScriptResource"
> > >
> > > This is a reland of 7bd91635
> > >
> > > No changes from the original, revert reason is fixed with
> > > https://chromium-review.googlesource.com/c/1283037
> > >
> > > Original change's description:
> > > > [blink] Control ScriptStreamer with ScriptResource
> > > >
> > > > Move the ScriptStreamer control logic from ClassicPendingScript to
> > > > ScriptResource. In the future, this will allow us to start streaming
> > > > a ScriptResource before the ClassicPendingScript is available, e.g on
> > > > preload.
> > > >
> > > > The ClassicPendingScript now only sends one "finished" callback, from
> > > > ScriptResource. This callback is either when the streaming completes,
> > > > or when there is no streaming and the ClassicPendingScript has told
> > > > the ScriptResource that it doesn't intend to start streaming. In the
> > > > long run, we want all scripts to go through the streaming interface,
> > > > and we want ScriptResource to control when streaming starts, so the
> > > > "no more streaming" call will disappear -- however it is necessary to
> > > > maintain the current behaviour, and be able to control it with a
> > > > runtime flag.
> > > >
> > > > Bug: chromium:865098
> > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#599148}
> > >
> > > TBR=kouhei@chromium.org,kinuko@chromium.org
> > >
> > > Bug: chromium:865098
> > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450
> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#601143}
> >
> > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:865098
> > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2
> > Reviewed-on: https://chromium-review.googlesource.com/c/1297138
> > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#602310}
>
> TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: chromium:865098
> Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76
> Reviewed-on: https://chromium-review.googlesource.com/c/1317566
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605295}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org

Bug: chromium:865098
Change-Id: I8d6101f51eb33b19ec332a06a310172b371b7fa4
Reviewed-on: https://chromium-review.googlesource.com/c/1318923
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605815}

The original URL points to an article outside of DevTools's website. This
patch updates to URL to a newly-added article section inside DevTools's
website. That article section was added by:
https://github.com/google/WebFundamentals/pull/6781

Bug: 847462
Change-Id: If93df903011a714c657ff673c01376c2a5ee78ec
Reviewed-on: https://chromium-review.googlesource.com/c/1320709Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Haihong Li (Harley) <hhli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605814}

This will set up the next CL that creates an abstract LargeIconService class and adds the Impl class.

Change-Id: I25c7f1dcc8955d420683e6037c4a9fb653ef9ae9
Reviewed-on: https://chromium-review.googlesource.com/c/1313277Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605813}

This is done as per the interop disucssion in UAv2 intent thread:
we decided to try 1 sec timeout first, and would switch back to a
longer expiry if see any compat problem (specially in a slow network).
https://groups.google.com/a/chromium.org/d/msg/blink-dev/nkTDR8AUlwM/RVHaoPgLCQAJ


Bug: 776404
Change-Id: I228eb9d2426d07c3f796ccdad14e7185fa06f98e
Reviewed-on: https://chromium-review.googlesource.com/c/1320021Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605812}

- Also fixed in FocusPreviousUser
- Add unit test to validate crash does not regress

Bug: 895589
Change-Id: Ibb436d95b558089d36a8b10f33fab2bc88568214
Reviewed-on: https://chromium-review.googlesource.com/c/1320212Reviewed-by: Quan Nguyen <qnnguyen@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605811}

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/b54e73475dd0..ef4d21b915d8

$ git log b54e73475..ef4d21b91 --date=short --no-merges --format='%ad %ae %s'
2018-11-01 qiyuh system_api: Add EIR property in bluetooth_device

Created with:
  roll-dep src/third_party/cros_system_api

Bug: chromium:887029,b:118334521
Test: CQ
Change-Id: I5514a5a44c0855159bbecfff863a5df2890ad3c7
Reviewed-on: https://chromium-review.googlesource.com/c/1316428
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605810}

InProcessGpuThreadHolder is only used with tests so make it test only.
Move the global instance out InProcessCommandBuffer to make this
possible.

Note the global is in a component to ensure that we don't end up with
multiple copies of it in different shared libraries.

Bug: 897456
Change-Id: I5155529c9386b3af53b1e610106d2ceb6adb87f5
Reviewed-on: https://chromium-review.googlesource.com/c/1317707Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605809}

Require that a member of the security team reviews changes
to org.chromium.*.conf files in //ash/dbus and
//chrome/browser/chromeos/dbus that specify permissions for
D-Bus services provided by Chrome.

Also add myself to //chromeos/dbus/OWNERS (since I'm already
in //chromeos/OWNERS and end up reviewing many of these
changes).

Bug: 833855
Change-Id: Ib2de0547a105909a66e56bdd3fb80155e53c3c24
Reviewed-on: https://chromium-review.googlesource.com/c/1316354Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605808}

When the SafeBrowsing service starts, record the user font size
preferences. This is part of preliminary metrics collection for vision-
based phishing protection.

Bug: 900235
Change-Id: Iec928924a049a9a3fd1b1bf0a3320c244c744398
Reviewed-on: https://chromium-review.googlesource.com/c/1307877Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605807}

Added GetRootWindowForNewWindows and implemented in wm_helper_chromeos.
This allows simple retrieval of root window from
window manager, used for setting parent window when creating
widgets (https://chromium-review.googlesource.com/c/chromium/src/+/1298172/20,
fullscreen_shell_surface.cc).

Bug: 896710
Test: Built and ran on ChromeOS
Change-Id: Ie43bea17c31cdf79402fadea441d5bc924e64503
Reviewed-on: https://chromium-review.googlesource.com/c/1302823Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#605806}

The associated-control allows the top-level Settings UI to display an arrow under a control (e.g. a button) whose subpage matches the search text.

R=hansberry@chromium.org

Bug: 901381
Test: none
Change-Id: I0e4f4c3b8939213853273a8b186ae082c5bacbed
Reviewed-on: https://chromium-review.googlesource.com/c/1319336Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605805}

TabContents and AwContentsContainer are long gone.

Change-Id: I3dc5c8c1dbd788ce3028f747e02cbaf7b3208ea0
Reviewed-on: https://chromium-review.googlesource.com/c/1320652Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605804}

https://chromium.googlesource.com/angle/angle.git/+log/77b2436e28f4..1bf18ce9e2ca


git log 77b2436e28f4..1bf18ce9e2ca --date=short --no-merges --format='%ad %ae %s'
2018-11-06 enga@chromium.org Implement GL_ANGLE_multi_draw
2018-11-06 jmadill@chromium.org Vulkan: Use dynamic state for Viewport and Scissor.


Created with:
  gclient setdep -r src/third_party/angle@1bf18ce9e2ca

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:890539
TBR=syoussefi@chromium.org

Change-Id: I77b4b457b5709f4d3e4992ec85f71ab5f108f937
Reviewed-on: https://chromium-review.googlesource.com/c/1320155Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605803}

This reverts commit 8bc49ae6.

Reason for revert: The issue this was working around seems to be fixed 
on the verizon side, so this should not be needed anymore

Original change's description:
> Display interstitials in mobile setup webview
> 
> The mobile setup UI loads carrier activation site in a webview.
> The webview is initially hidden, and then shown when the carrier
> content is loaded. This prevents any interstitial pages from getting
> displayed - in particular, an SSL error page in M71+.
> 
> While the issue should be fixed server-side, by the carrier, not showing
> the interstitial (however scary it is), prevents the user from
> proceeding with mobile activation. To unblock testing the flow, update
> mobile setup UI to display the webview contents sooner - when the
> carrier page load starts (instead of when the navigation to the target
> page is committed, which will not happen if interstitial is shown).
> 
> BUG=894281
> 
> Change-Id: I36de9d00afcf0f058bac95a938381c75d5e9a18e
> Reviewed-on: https://chromium-review.googlesource.com/c/1275138
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Toni Baržić <tbarzic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598869}

TBR=stevenjb@chromium.org,tbarzic@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 894281
Change-Id: I5776f5fe94cc80445ef71e50d7e69f8e014638d1
Reviewed-on: https://chromium-review.googlesource.com/c/1316445Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605802}

https://webrtc.googlesource.com/src.git/+log/277b6ea8508e..34fc346a0c77


git log 277b6ea8508e..34fc346a0c77 --date=short --no-merges --format='%ad %ae %s'
2018-11-06 artit@webrtc.org Add support for computing iOS code coverage


Created with:
  gclient setdep -r src/third_party/webrtc@34fc346a0c77

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:844647
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I398b9a5ae3193c1b8e2ef91eba91e9eb0dd8acf1
Reviewed-on: https://chromium-review.googlesource.com/c/1320409Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605801}

The notification offers to manage site data and to share info about the webpage.

The notification is shown while the activity is started. It is not removed when the user leaves
the origin associated with the app by following links.

Bug: 888953
Change-Id: I297e4090b03c081b901a1339f25485ab63640104
Reviewed-on: https://chromium-review.googlesource.com/c/1307400
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605800}

This is an application of review feedback from
https://chromium-review.googlesource.com/c/chromium/src/+/1310638
... that I somehow managed to forget to upload.

Change-Id: I972d4e5a8722d0f3ef2684587cdb4911636c1575
Reviewed-on: https://chromium-review.googlesource.com/c/1318358Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605799}

Using wpt-import in Chromium 18a9ef45.
With Chromium commits locally applied on WPT:
270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content."
0ef86cd5 "Revert "Make XR FrameData and Environment mojo associated""


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
ericwilligers@chromium.org:
  external/wpt/css/motion
hbos@chromium.org, hta@chromium.org:
  external/wpt/webrtc
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request
smcgruer@chromium.org:
  external/wpt/css/css-position

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: I9468a0c44d7505356e09c9c858e3878624b94546
Reviewed-on: https://chromium-review.googlesource.com/c/1320473Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605798}

In order to do server-side experimentation, we need to send the
experiment id to the server. The best approach for this is in the URL.

See bug for additional context and discussion.

Bug: 901157
Change-Id: I4200cbcf7549dce27cb1a8dbf4ee80d81bae6704
Reviewed-on: https://chromium-review.googlesource.com/c/1313838
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605797}

This patch replaces kNavigationPolicyHandledByClient with
an explicit call CreatePlaceholderDocumentLoader.

This technique removes inversion of control between WebLocalFrame
and it's client, and gives the client all the power for driving
navigations. For example:
- RenderFrameImpl::PendingNavigationInfo is gone, since
  RenderFrameImpl controls the process and doesn't have to store
  information between WebLocalFrameClient callbacks.
- We don't issue DidStartProvisionalLoad for placeholders anymore
  for the similar reason.

A couple of small changes required:
- WebNavigationParams::source_location is now optional.
  This is needed for preserving source location when creating
  a placeholder (and for synchronous commits in the future).
- Plumbed WebFrameLoadType instead of replaces_current_item to
  not lose information.

Next step will do the same for kNavigationPolicyCurrentTab
and let the client drive navigation all the time. After that
we'll get rid of multiple WebLocalFrameClient callbacks.

Bug: 855189
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I5f1d1b5269f99227e3998fba2333c0f3661f7e9e
Reviewed-on: https://chromium-review.googlesource.com/c/1263052
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605796}

This CL is part of a refactoring work to unblock other CLs
that would generate a circular dependency when including
modules/audio_processing in WebRTC. It will also allow to easily move
the APM interface part under //api (in WebRTC).

More in detail, this change adds :api as dependency in chromium
where needed. The target is currently a dummy one
(see https://webrtc-review.googlesource.com/c/src/+/109585), but
once this CL lands, https://webrtc-review.googlesource.com/c/src/+/109501
will make it an actual target.

Bug: webrtc:9535
Change-Id: Iffa36ff948369f172970edb53917fccdcb07e05b
Reviewed-on: https://chromium-review.googlesource.com/c/1319674Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Ale Bzk <alessiob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605795}

Looks like a the crashing we see with the LimitParallellMediaPreloading
experiment is caused by the code trying to start a new load while Document is
getting destroyed. By posting that task, everything should be destroyed neatly
and weak pointers should discard the task.

Change-Id: I0629b11ff13f51d9f24cc64c5fd56419ea82fd5f
Reviewed-on: https://chromium-review.googlesource.com/c/1318538Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605794}

Currently when passing unknown options, we get a traceback:
Traceback (most recent call last):
  File "/usr/lib/python-exec/python2.7/grit", line 15, in <module>
    grit.grit_runner.Main(sys.argv[1:])
  File "/usr/lib64/python2.7/site-packages/grit/grit_runner.py", line 229, in Main
    args = options.ReadOptions(args)  # args may be shorter after this
  File "/usr/lib64/python2.7/site-packages/grit/grit_runner.py", line 167, in ReadOptions
    (opts, args) = getopt.getopt(args, 'g:qdvxc:i:p:h:', ('psyco',))
  File "/usr/lib64/python2.7/getopt.py", line 90, in getopt
    opts, args = do_shorts(opts, args[0][1:], shortopts, args[1:])
  File "/usr/lib64/python2.7/getopt.py", line 190, in do_shorts
    if short_has_arg(opt, shortopts):
  File "/usr/lib64/python2.7/getopt.py", line 206, in short_has_arg
    raise GetoptError('option -%s not recognized' % opt, opt)
getopt.GetoptError: option -a not recognized

This is a lot of noise except for the final line.  This can be even
harder when grit doesn't have standard -h (help) options.  Issue a
normal error message so it's clear to users what's wrong.

Bug: 747171
Change-Id: If3989f54e16e7952d872f5f19a97a0cbd2c1f4c7
Reviewed-on: https://chromium-review.googlesource.com/c/1319171
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605793}