- 12 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/51e1fea7385f..2881d6b22d1e 2021-01-12 fmayer@google.com Fix excessive memory usage in trace processor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Test: Test: profile before and after. Change-Id: Ie70baf4471e49fa15f149a377ef54f90c8acfe4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625687Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842752}
-
Robbie McElrath authored
This CL moves [Fragment]SettingsLauncher to components/browser_ui/settings and updates all references to them. This is part of a chain of CLs to componentize the new Safe Browsing UI. Bug: 1106393 Change-Id: I334651d7755202965b1427d83e219e41a634c1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613518Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#842751}
-
Zach Trudo authored
Bug: chromium:1163560 Change-Id: I87dece32d57228f08bee6d11e66b7909618b0c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611273 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842750}
-
Matthew Denton authored
The comment described too much of what //content would do with the result of ContentBrowserClient::ConfigureNetworkContextParams, whereas the comment should really just describe what is expected of the embedder. Change-Id: Ifdf38c47d2117d87f8de0d5974ee306752b32f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622731Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Auto-Submit: Matthew Denton <mpdenton@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#842749}
-
Ian Kilpatrick authored
Previously we'd just use the intrinsic block-size to resolve gaps, and abs-pos containing rects when we didn't know the block-size upfront. This was slightly incorrect as there might be a min/max size constraint growing or shrinking this final size. This patch moves the call to ComputeBlockSizeForFragment into PlaceItems. As a result of this there are a few small fixes: 1) When we have an indefinite available-size, we resolve the grid-gap against zero. (This was surprising to me grid-gutters-{010,011} was testing this). 2) Abspos "default" size is correctly calculated based on the final block-size (not intrinsic block-size). 3) Resolving gaps against the "resolved" available block-size (not the intrinsic block-size). This correctly respects border/padding as well. Bug: 1045599 Change-Id: I6be819b8eb254fe9e8eaee4d5a9caaa500a75601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624032 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#842748}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I78c14f59c1df348c5a9cf246346122877c7aeb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604976Reviewed-by:
Joon Ahn <joonbug@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#842747}
-
Michael Checo authored
- Cards get their "isTestRunning" value from diagnostics-app which means the property never gets assigned a value when testing these cards in isolation. - False makes sense as a default value since all buttons are enabled initially and it's consistent with the value defined in diagnostics-app. Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ia9bba381691abb5566c01f834c7592d214bc4517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616738 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#842746}
-
Monica Basta authored
This CL moves 'Delete' to the bottom of the three dotted menu as requested by UX. Bug: 1063856 Change-Id: I38dda5d613da483b877c36b8bdb1260f9331a781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624656Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#842745}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7fae6cbf1d37..22eff1eb8c2f 2021-01-12 cwoffenden@gmail.com Fixes to build with MSVC 2019 2021-01-12 cwallez@chromium.org Add the correct rpath to use Swiftshader / Vulkan on macOS 2021-01-12 bryan.bernhart@intel.com D3D12: Add HLSL compiler version to key 2021-01-12 cwallez@chromium.org Rolling 3 dependencies 2021-01-12 cwallez@chromium.org cr-buildbucket.cfg: Use Windows 10 only for CQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ic43b785e3c6207c4c22bf01647b858873479a0d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625556Reviewed-by:
-
Collin Baker authored
Bug: 1090038, 1148631 Change-Id: I33a9cbf31e93e56c6e2a81b7736b016100427fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587648 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#842743}
-
Owen Min authored
Disable CrossSiteSubframe/DragAndDropBrowserTest.DragImageFromDisappearingFrame on Linux due to flaky Bug: 1164442 Change-Id: I10bf4b5cfe77ddba2d363bbe48aa2e0b39e985e5 Tbr: connily@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625308Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842742}
-
Garrett Beaty authored
The channel information is only used for the alt value for links to the milestone main consoles. These are intended to be the information displayed when hovering over the links, but this does not appear to happen and maintaining the channel information complicates the automation of activation and deactivation of milestones. Bug: 1165826 Change-Id: I5524db13125d92f2cd319521f74493cda9671863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625391 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#842741}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c60dda78e4ab..002c03c4b6ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If560f2eba43c1f4d5786b57b2d92b1feb3380e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625647Reviewed-by:
-
Joel Riley authored
Recent JS Modules migration caused <script> imported JS modules to fail. AX-Relnotes: N/A Bug: 1165431 Change-Id: I7ca66807f765daf83ba4105265d73b7d705f1535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622754 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#842739}
-
Aga Wronska authored
There is a crash in ArcPackageNameToAppId. Handle the situation when prefs are invalid and return empty string. Add DCHECK for profile passed by pointer. Bug: 1163362 Change-Id: Icb107de221eaa4e75cc5576eee81dcfd72f47be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625154Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#842738}
-
Aaron Krajeski authored
Blink.OffscreenCanvas.NewOffscreenCanvas and OffscreenCanvas.Transferred are still giving us good data, push back their expiry to next year with other canvas metrics. I did the same for IsComposited last week, but looking into it it looks like we've been getting bad data from it for at least a year. It is redundant with isAccelerated anyway, so change it back to the old date to let it expire. Bug: 1160792, 1160789 Change-Id: I7fcd0f1d9a2c92059c8b2ddeec7280c061e019c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625288Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#842737}
-
dpapad authored
Preparation for bundling the PDF Viewer's resources, step 1/3. Specifically register Print Preview PDF resources as part of c/b/r/print_preview:build_grd to decouple from PDF Viewer's build. In the future, Print Preview's PDF resources can be bundled in print_preview.rollup.js, if deemed beneficial. Bug: 1163956 Change-Id: I8beeaa27f815ac4c1dc481bbd075a4a7e4865b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625274 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#842736}
-
Ayu Ishii authored
This adds an origin check in the browser that matches the check in the renderer. Change-Id: I84b5f3628aecbf20bb44c1af60c69385d2fa0d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616482 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#842735}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f6b414c57847..9ce03f80a4b5 2021-01-12 ehmaldonado@google.com presubmit: Add owners_client to presubmit API. 2021-01-12 ehmaldonado@google.com owners: Move constants inside OwnersClient. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I9a06f314a500e98d060a2438570389c338909345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625562Reviewed-by:
-
Fredrik Söderqvist authored
We know what viewport dimension to use up front, so we can just pass that directly rather than calling DimensionForLengthMode(). Change-Id: I59484a91ae986a5b3b0b47352886c450dcd828d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624667 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#842733}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610452567-971e6bfbeacac133e734933b87972f0e8c85e431.profdata to chrome-win32-master-1610474333-c40f8988181199af819c164a2a0a3aef267d7bde.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1fa9a81764b284f604cf0038c61158cd57732485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625551Reviewed-by:
-
Fredrik Söderqvist authored
Change-Id: I0393aa5c9c25525bfa9da1302dcd5fe6f655b8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624649 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
David Maunder authored
Speedup: -> 7297ms -> 257ms (96% speedup) Bug: 1164597 Change-Id: Ibcf3dacfe49839928be1d54d0980483d7047fc2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618965 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#842730}
-
Yao Xiao authored
We expect doing 3rd-party OT for FLoC, thus setting origin_trial_allows_third_party. Also, gate the OT by a base::Feature, as this allows us to keep the experimentation under the global usage limit. Bug: 1163394 Change-Id: Ibaf9554397f8d46fa68c837fe58acc66676a2401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611953Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#842729}
-
Jeff Cyr authored
Blocklisted extensions may have additional disable reasons added such as when they are added to an additional safe browsing blocklist. Allow extensions that are already in the blocklisted set to have their disable reasons updated. This also allows us to remove a one-off condition in ExtensionPrefs that side-stepped this condition. Bug: 1073570 Change-Id: I300f6b3dde6617c56ee0dd8d92c6cdc0bebe58b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622452 Commit-Queue: Jeff Cyr <jeffcyr@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842728}
-
Jamie Madill authored
This test enforces non-spec behaviour. Temporarily disable while the test is updated upstream. Bug: angleproject:5499 Change-Id: I19b284ea0b27888f22628d5f8290f8605f17e6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625568 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#842727}
-
Becca Hughes authored
This will allow blocking when the media notifications are turned off but the new CrOS media controls are enabled. BUG=1142628 Change-Id: Ic35586c508c7c173c2ed828ff6697c841f9a6c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625690 Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#842726}
-
kylechar authored
Pixel moving backdrop filters (eg. blur) could sample from outside an area that isn't behind the render pass when a render pass is clipped. This resulted in color bleeding from pixels outside the render pass. GLRenderer intersects the backdrop filter bounds with the RenderPass::output_rect. This CL adds similar logic to SkiaRenderer and intersects the backdrop filter bounds with the RenderPassDrawQuad::rect which is generally going to be the size as the RenderPass. Bug: 1162743, 1165868 Change-Id: Ibfcad6f58ada11ace2ce262ce71f3159a4b08f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611452 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#842725}
-
Alex Newcomer authored
Instead of sending a single Ctrl + V event, send a control, then a V. This may be better on other platforms. Bug: 1161254 Change-Id: I8178ab36304c5ef1c675418b1132777bcdb1293e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622007 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842724}
-
Martin Kreichgauer authored
This ships support for the AuthenticatorSelectionCriteria.resident_key (and its enum ResidentKeyRequirement type) and the corresponding credProps extension in the Web Authentication API. Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/_Lu3bV0JX-4/m/nl_EaDsBCQAJ Bug: 1117630 Change-Id: I72f203e38bfbcf289016ec2884f10539eebbc646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618472Reviewed-by:
Alex Russell <slightlyoff@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#842723}
-
Michael Thiessen authored
For CCT launches, we only care about the distinction between TWA and CCT launches. We don't currently (or have plans to) care about exactly how the CCT/TWA were launched, unless they were launched from a foreground Chrome instance, in which casea we don't record launch metrics. Bug: 1163961 Change-Id: I870a82183dc512e67a0c489c91ea26c2e3579e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618399 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#842722}
-
Mihai Sardarescu authored
Method OnUnconsentedPrimaryAccountSet is deprecated, so this CL changes the chromeos/services/device_sync/* to override the method OnPrimaryAccountChanged(). Bug: 1158855 Change-Id: Ie65d5c846c5c035c09a805a87f088a3ade653e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624628Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#842721}
-
Andrew Grieve authored
These histograms are no-longer-recorded. Bug: 1158451 Change-Id: Idd19c30d7afc30432eac9257335d70445a3d5f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622329Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#842720}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c8e16bbe32be..ace3f2939f89 2021-01-12 brianosman@google.com Remove SkEffectBinding feature from particle system 2021-01-12 jvanverth@google.com Reland "Fix issues with MTLPixelFormatBGR10A2Unorm on older OSes." 2021-01-12 johnstiles@google.com Construct IntLiterals with type fIntLiteral. 2021-01-12 brianosman@google.com Add is_apple (= is_mac || is_ios) to our GN files 2021-01-12 brianosman@google.com Remove all particle examples that use SkEffectBinding 2021-01-12 johnstiles@google.com Revert "Scrub memory released from a GrMemoryPool in debug mode." 2021-01-12 fmalita@chromium.org Bump SkXMLParser buffer size 2021-01-12 ethannicholas@google.com Changed signature of IRGenerator::convertIndex 2021-01-12 johnstiles@google.com Improve handling of SkSL literal types. 2021-01-12 jvanverth@google.com Revert "Fix issues with MTLPixelFormatBGR10A2Unorm on older OSes." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: I8405272bdc327f0edc9f6a827b84c59445e534e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625549Reviewed-by:
-
Lily Chen authored
To decrease UKM volume, this maintains a list of the 20 most recently recorded (source, target) UKM source ID pairs, such that duplicates can be skipped. Bug: 1112491 Change-Id: I4b6bfe26f55102078305bc7a5c3bc1a774ca62d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622277Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#842718}
-
Aaron Leventhal authored
During accessibility serialization, document lifecycle transitions are not allowed. Unfortunately, calling Element::innerText() can cause the lifecycle to change, causing a DCHECK() failure. The error occurs while serializing a <body contenteditable> and getting the it's StringValue(), which calls Element::innerText(). That method calls UpdateStyleAndLayoutForNode(), and even though we are in kPaintClean and supposedly are being called when style is also clean, the lifecycle gets reset to an earlier state. Add a special method for getting the inner text of an element, that will not update the style. Bug: 1164747 Change-Id: Ibf2afe17b8dc15525f257416fe8155af00f51b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622272 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#842717}
-
Mihai Sardarescu authored
Methods OnPrimaryAccountSet/Cleared() are deprecated, so this CL changes the components/signin/ios/* to override the method OnPrimaryAccountChanged(). Bug: 1158855 Change-Id: Ie61a2fe12aed8cd863bfcc20064f84903a599ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624607Reviewed-by:
-
shivanigithub authored
This CL fixes the flaky disk cache size test. The particular flakiness resulted from off-by-one errors e.g. Expected: (max_file_size_scaled) <= (2 * max_file_size), actual: 55319511 vs 55319510 which occurred because file size is computed as (total cache size/8). The fix however not just accounts for off-by-one errors but removes the check completely as the total cache size is dependent on the available disk space which cannot be guaranteed to be the same between the 2 invocations of VerifyDiskCacheSize. Bug: 1162434 Change-Id: I510eed9ca0ed90e12e953910f7f699be74e10b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625350Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#842715}
-
Nektarios Paisios authored
When navigating the unignored nodes in the accessibility tree and when retrieving any node information that needs to be computed by traversing the accessibility tree, we want to ensure that a tree update is not in progress. This patch adds such DCHECKs in more methods in AXNode. The only methods that are not guarded are those that get or set data members directly, e.g. IndexInParent() and SetIndexInParent(), and those that are used to traverse the whole tree, such as parent() and NextSibling(), as those may be called from AXTree while an update is in progress, in order to populate the AXNode. R=dmazzoni@chromium.org, aleventhal@chromium.org AX-Relnotes: n/a. Change-Id: I92c34991bf4b0583dd09bb061db9ff35c8014e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623288 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842714}
-
ckitagawa authored
While there was a fix for the scoped blocking issue, it looks like there are still some rare timeouts. I believe that this is caused by the initial capture request not succeeding due to a race between crashing and creating a file (this only applies to the FileSystem variant). I did repro the flake locally, but it only occurred in 1/250 runs so while this CL is a probable fix candidate I'm not 100% confident in it and will continue to monitor for flakes. Bug: 1163655 Change-Id: I05efbf25d8e41cac0c48e0993cd47352d423dcdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625307 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842713}
-
