GitLab

This CL fixes the display when showing the NTP on a cold start.
It prevents the animation by directly adding the BVC to the view
hierarchy when the animations are disabled.
It is also making sure that the location bar isn't shown on the NTP
when doing a cold start.

Fixed: 1082726
Change-Id: I02658837b177bbe07d58b507311657d09107fde0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216250Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772328}

This change replaces the CHECKs added in r770407 with logic to reject
invalid lengths from IOCTL_USB_GET_DESCRIPTOR_FROM_NODE_CONNECTION.

Crash reports from when the original DCHECKs were replaced with CHECKs
indicate that the hub driver will sometimes return a response which is
shorter than the struct originally passed to it. This is invalid and so
is treated as a failure.

Bug: 1084316
Change-Id: I8462a5d535935e139f6cd511c26a0ab79db5950e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216548
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: James Hollyer <jameshollyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772327}

This CL fixes a bug in chrome-untrusted://resources where the
Access-Control-Allow-Origin policy would only allow for chrome://
origins. This changes it so that chrome-untrusted://resources only
allows for chrome-untrusted:// origins and chrome://resources only
allows for chrome:// origins.

Bug: 1086327
Change-Id: Icbf05aa66e587ed3cb5d5f26ef2b46c0628641c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216282
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772326}

This CL breaks down previously reported sync commit failures per data
type into particular syncer errors.

Bug: 1086877
Change-Id: I3ff3290b0857624d9a08f645d10f29e382f992eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218111Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#772325}

Ash(ShelfController) should observe AppRegistryCache to get the app
notification badging information. Ash can't depend on chrome/*, so we
can't use AppServiceProxy to get AppRegistryCache, and we can't use
profile as well, because that is in chrome/browser/chromeos directory.

Create a new AppRegistryCacheWrapper to map account id to
AppRegistryCache, so that Ash or other external browser components can
access AppRegistryCache. This could help offload AppServiceProxy, extend
AppRegistryCache to be used out of chrome/browser, and benefit for the
future if we have an AppRegistryCache out of AppServiceProxy.

BUG=1068884

Change-Id: Ib5caa94d944a0d031df9dbee0e3d2c00587ab402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212285
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772324}

screencast:
https://screencast.googleplex.com/cast/NTE3OTA5NzIxMjc4MDU0NHw3YjdhZDQ1OC05MQ

Bug: 1044038
Change-Id: If729650f517848014cb7bd406af2a77c67edba70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210980
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772323}

Bug: 1086855
Change-Id: I47f4d3891172721c3c12e3985172be9156592f08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218091
Auto-Submit: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772322}

https://webrtc.googlesource.com/src.git/+log/df95f5d43f28..65dd291c8da7

2020-05-27 titovartem@google.com Fix documentation for some public API methods

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I3e1b8d0a1421807ca29b45e01ccacf68691b063b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218435Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772321}

The crash is fixed by null checking the profile, and made further
robust by removing the call to the crashing code and instead
using the AppService's own API for checking whether an app is
a system app, AKA "sticky".

Bug: 1026859
Change-Id: I7da239c74aa18e3bed157a7e0ce3c91cdb1e13bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216601Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: Dan S <danan@chromium.org>
Commit-Queue: Dan S <danan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772320}

Removes the crashpad_database_util dependency from ChromeOS,
as CrOS currently still uses Breakpad and attempting to use
the locally compiled version currently fails due to
missing .so files.

Bug: 1054583, 1084334

Change-Id: Ibdf1ed486507a83635d75ab0ff9ce39f04ee0384
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216592
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#772319}

The bug was as follows:
- mechanism binds to NavigationHandle, storing its NavigationId
- main frame does a subsequent same-document navigation
- PMTabHelper observes this navigation, and updates the internally
  stored NavigationId.
- PM dispatches policy message to mechanism to terminate throttles.
- Policy message looks up WCProxy::LastNavigationId (taken from
  PMTabHelper), and feeds that into the mechanism.
- This doesn't match the original NavId stored in the mechanism, and
  the policy message is dispatched.

Fix:

- Have PMTabHelper/WCProxy independently track same-doc and new-doc
  navigation IDs. Use the last new-doc navigation ID with the policy
  message.

BUG=1084555

Change-Id: I726ace3e06ca83cff99b0dec18372647789910c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218228Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772318}

Currently, for some non-attached Documents, we skip providing CSP.
There doesn't seem to be any specific reason for this, or pattern for
when we do or don't provide it.

This has the added benefit of fixing a corner case where we can end
up inspecting a CSP that was not completely initialized.

Bug: 1067034
Test: http/tests/security/contentSecurityPolicy/csp-violation-in-detached-document.html
Change-Id: Ic8f30cc24469618b967f1c8325f7cf144b8cb876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209621
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772317}

Marking kAcceleratedDirect2DUsage as deprecated.
Refactoring tests to use directly CreateSwapChainProvider or
 CreateSharedImageProvider when needed.
Refactoring CanvaResourceProviderHost to stop using ::Create.

Bug: 1035589
Change-Id: I24ca7823809735654a3f57dc05be60d4b78a2638
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198922Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772316}

Background: The current heuristic (i.e. continuously tracking the
position of each frame) has the issue that it doesn't know whether the
frame has overlays on top. We have seen false positives where there's a
fixed large ad that spans the viewpor, and the main content overlays on
top, such that only a small area of the ad is visible. Another false
positive is the parallax ad, which can be dismissed (i.e. blocked by
the scrollable main content) along with scrolling even though its
position never changes.

To be able to handle the false positives, we deprecate the original
heuristic and switch to a hit-testing based heuristic. See the comment
in sticky_ad_detector.h.

Bug: 1013070
Change-Id: Iceec4e058a14e6b19aa5db1980a9320956739963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160729Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772315}

Introduce a histogram reporting successes and failures at pulling code
residency data from /proc/self/pagemap.

Opening and reading /proc/self/pagemap can fail at fopen(3), fseek(3)
and fread(3). We think that we can potentially mitigate errors at fopen,
see the bug for details.

The current code distinguishes two error kinds:
1. at fopen
2. at fseek or fread

The histogram mirrors this separation. In the future the fopen errors
can also be broken down into several errno values. At this point the
extra detail seems unnecessary.

Bug: 1070618
Change-Id: I2b88c24c0861b46845707dbf88b16b2e4817ae22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215856
Commit-Queue: Egor Pasko <pasko@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772314}

Bug: 998546
Change-Id: I1a356768fad7914992631ce1d740029c8f61d39c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213885Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772313}

This was missed in crrev.com/c/2204224 and it should be no-op.

Bug: None
Change-Id: Iac8597d4693a95eae50c9e62f63fe41c71de598e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204649Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772312}

ScrollableShelfView records the number of corner buttons whose ripple
ring is activated. However, the count does not work as expected in the
following two scenarios:

(1) After transition between clamshell and tablet, the shelf icon's
context menu should be closed. However, when the count of activated
corner buttons updates at the end of ripple ring fadeout animation, due
to change in scrollable shelf's layout, the button whose ripple ring is
deactivated is not at the corner of shelf anymore. As a result, the
count does not decrease as expected.

(2) The count fails to decrease when removing an icon from context menu.
Because the ripple ring animation ends after shelf icon removes itself
from the ink drop listener list.

This CL fixes the issue by creating a scoped count owned by
ShelfAppButton

Bug: 1086484
Change-Id: Ib31f8b52d4da845d4a7dc945d44c7f38f3a4662f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213877
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772311}

The field is flag protected and this is only a UI change, so setting the
nickname won't set the nickname in the database. Will follow up with a CL
that updates it in the database.

Screencast: https://drive.google.com/file/d/1aIMedpnwlWtJ1YKNT0cpRCowuhDOnNRq/view?usp=sharing
(Googlers only)

Bug: 1082013
Change-Id: Ib26a67c858da4388563e4ba241604517a5e7fde8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213341Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Siddharth Shah <siashah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772310}

Previously the test gives 400 ms timeout to wait for |onfocus| event
to happen, while sometimes 400 ms is simply not enough, which result
in flakiness.

The solution is to remove this timeout restriction if we are expecting
an onfocus event to happen.

Note: According to html spec: https://html.spec.whatwg.org/#attr-fe-autofocus,
topDocument's autofocus processed flag initially is false and is set to
true after flushing autofocus candidates, i.e. flush of autofocus
candidates only happens once per page load.
In order to test the behaviour with both focus-without-user-activation
on and off, two test files are necessary:
 - focus-without-user-activation-disabled-tentative.html
 - focus-without-user-activation-enabled-tentative.sub.html

Skipping focus-without-user-activation-enabled-tentative.sub.html
because the desired behaviour is not yet implemented.

Bug: 1067482
Change-Id: I3d1c8f77309054bbad0e666543372e28040ddcd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202677Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#772309}

The previous CL used DISABLE_ instead of DISABLED_ to disable a test.
Since the former does not actually have an effect this change fixes it.

TBR=bokan

Bug: 777258
Change-Id: I4ceb48d241078ad708215b1f13044db237689836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218053Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772308}

https://chromium.googlesource.com/external/github.com/google/re2.git/+log/209319c1bf57..787495f0ba2e

$ git log 209319c1b..787495f0b --date=short --no-merges --format='%ad %ae %s'
2020-05-22 junyer Use CMAKE_CXX_STANDARD now that we can.
2020-05-22 junyer Make "front and back" prefix accel work with MSVC.
2020-05-22 junyer Rename to Regexp::RequiredPrefixForAccel().
2020-05-22 junyer Add a basic test for prefix accel.
2020-05-20 junyer Implement "front and back" prefix accel.
2020-05-19 junyer Generalise from "first byte" to "prefix accel".
2020-05-19 junyer have_first_byte now implies run_forward.
2020-05-19 junyer Tidy up the code around the memchr(3) calls.
2020-05-17 junyer Remove a pointer chase from Regexp::Walker<>.
2020-05-17 junyer Tidy up the code for NFA threads a bit more.
2020-05-17 junyer Argh. I overlooked the constructor and destructor.
2020-05-17 junyer Undo use of PODArray<> for NFA threads.
2020-05-17 junyer Use PODArray<> in a few more places.
2020-05-16 junyer Separate build/install for libre2.a and libre2.so.
2020-05-16 junyer Refine a preprocessor check for MSVC.
2020-05-15 junyer Compute first byte for forward Progs only.
2020-05-11 junyer Don't dereference params->start unconditionally.
2020-05-11 junyer Compute first_byte using the Regexp, not the Prog.
2020-05-11 junyer Implement Regexp::RequiredPrefixUnanchored().
2020-05-11 junyer Refactor Regexp::RequiredPrefix().
2020-05-10 junyer Lower the memory budget in TestCompile.InsufficientMemory.
2020-05-05 junyer Remove first_byte from StartInfo and simplify accordingly.
2020-05-02 junyer `^' is a caret, not a carat.

Created with:
  roll-dep src/third_party/re2/src

R=thakis@chromium.org
CC=mmoroz@chromium.org

Change-Id: I119116e108b7b58a4fd00b766f33483e31b2ae64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218493
Commit-Queue: Paul Wankadia <junyer@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772307}

Profile API is being updated (issue 1033903) and the usage of
GetOffTheRecordProfile and HasOffTheRecordProfile without argument is
getting deprecated. Use cases of this call that ONLY refer to incognito
or guest mode can use [Get/Has]PrimaryOTRProfile() instead.

c/b/media tests are updated to use the new API.

This CL does not change any behavior.

Bug: 1060940
Change-Id: I567319bf00a335c12b3a5c4c3171efe60d1b2577
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210583
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Auto-Submit: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772306}

Change Log:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/768eb2ca28..33caf1097e
Full diff:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/768eb2ca28..33caf1097e

Bug: None
Change-Id: I96ffb18e05362b3d56a7d0e17ae1e98a678cb97a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218307Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Danil Chapovalov <danilchap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772305}

Roll Chrome Win64 PGO profile from chrome-win64-master-1590580498-39ab72543da7a96a4f695b1a54bce8558b65f184.profdata to chrome-win64-master-1590594916-ea624ec669480df16e05aa1202066a2c230a60a5.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: Ib48632b6632d06c4f9c7d4d614db3560bdc60aa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218728Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772304}

Roll Chrome Win32 PGO profile from chrome-win32-master-1590580498-31d289ff4006e295949604b3b99c516a32499368.profdata to chrome-win32-master-1590594916-1a49bd7be838713a54921f61c31eff74f9ded2d9.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: Ied0fd2c45e93e726c6a1ca2a8b1c7e11c61d579f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218730Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772303}

Specifically:
 - cr_drawer_tests.js
 - cr_expand_button_focus_tests.js
 - cr_expand_button_tests.js

Bug: 1000989
Change-Id: I5b7bb247e645d795dd45387d4b9d80a2e02e6c12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215459
Commit-Queue: dpapad <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772302}

Use --project to pass in a generated project.xml file for each lint
target instead of passing each argument through the command line. This
allows the lint checks to function more correctly and thoroughly than
before.

Currently lint does not fully support srcjars (fix is in ToT but not yet
in our lint version), so we extract generated sources and generated
resources in a consistent temporary location under their lint target's
gen dir, removing them if lint succeeds and leaving them in place if
lint fails in order to make it easier to debug lint failures.

Clean up and remove various options that are no longer used or needed.
e.g. display lint errors directly rather than parsing an xml file from
lint's results.

Simplify suppressions file comments and remove unnecessary ones. Ignore
common failures for translations since we have a dedicated translation
team.

Remove an unused dimens and fix a few issues. Suppress additional issues
found by this lint improvement.

Bug: 1082743
Change-Id: I67147e582bd904308fe6a5fc5a11baebd60db41b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212550
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772301}

https://chromium.googlesource.com/chromium/src/third_party/libunwindstack.git/+log/dfd3f3d84cfc..046920fc491a

$ git log dfd3f3d84..046920fc4 --date=short --no-merges --format='%ad %ae %s'
2020-05-26 wittman [Sampling profiler] Fix AsmRegs build logic for cross-compilation
2020-05-19 wittman [Sampling profiler] Include AsmGetRegs asm functions on x86/x64

Created with:
  roll-dep src/third_party/libunwindstack
R=etiennep@chromium.org

Bug: 1004855
Change-Id: I8cae2e24f9a6de1e9d4945c352a01dec8d722874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216327
Auto-Submit: Mike Wittman <wittman@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772300}

https://skia.googlesource.com/skia.git/+log/55822f17bd5c..c95dd320931c

2020-05-27 csmartdalton@google.com vk: Call addResource() on indirect draw buffers
2020-05-27 reed@google.com prealloc space for a simple fRunsInVisualOrder
2020-05-27 kjlubick@google.com [canvaskit] Fix width/height API
2020-05-27 michaelludwig@google.com Reland "Simplify GrRTC::clean APIs"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC westont@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: westont@google.com
Change-Id: I49fe0497b0ebcd389ecf24a16f5582b04c63d5db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218437Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772299}

Using wpt-import in Chromium 7e5ebc13.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=smcgruer

No-Export: true
Change-Id: Ie29a8cca61ceac3f4178279d49cdfb85771539d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218387Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772298}

This reverts commit 100226ae.

Reason for revert: Broke the feature on Android. Also, the feature has been disabled on webview in crrev.com/c/2156991

Bug: 1086686

Original change's description:
> [mojo] Enable default InstalledAppProvider binder for Android
> 
> Since only Chrome binds InstalledAppProvider, but a default no-op
> behaviour is expected for other embedders (tests, WebView, WebLayer),
> this change removed the 'non-Android' condition for the default
> InstalledAppProvider binder to avoid renderer termination for the
> 'no binder found' case.
> 
> Bug: 1064644, 1064827
> Test: No crash when opening reddit.com in webview shell on an emulator
> Change-Id: Ia9e6d98f0abff94929bf10dcd778166c90907f40
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124872
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#755083}

TBR=dcheng@chromium.org,oksamyt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1064644, 1064827
Change-Id: Ie2ccdb3724abe7b28dcc461dedebb286c667f595
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218028Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772297}

The reporting API it calls into will soon take NetworkIsolationKeys, and
we want to be able to DCHECK all requests have non-empty NIKs fairly
soon, so it makes sense to start wiring this up now.

The ExpectCTReporter is not currently passed non-empty
NetworkIsolationKeys by net/. That will be taken care of in followup
CLs.

Bug: 969893
Change-Id: I69c4c1615ac3001ad596fd0c97283a087a90a674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212462
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772296}

The only remaining code there was a call to RunLoop::RunUntilIdle() that had
been present since this file was added to the tree.

Whatever it was waiting for seems to have been fixed since then though, as
removing the call still allows all tests to pass, and we get no subsequent
crashes.

Change-Id: Ie1141f7870d89ed4f1ea89015e4ce2b4b67acc36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216223
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772295}

Since Math.random() in python generates a random number in range [0,1),
we need to use rand(256) to generate number [0, 255]. Update all calls
in canvas perftest to call rand(256).

Bug:1087019

Change-Id: I75ded3269cf652d7d352e32eefbfeddb999583b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216736
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772294}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8ae7f6e09a0b..0b9eddaa2663

2020-05-27 saklein@chromium.org Build API: execute with --debug by default
2020-05-27 dianders@chromium.org remote_access: Fix crash with 'cros flash' if port not specified
2020-05-27 mmortensen@google.com GetBuildMetadata: Port get_models & run_cros_config_host from cbuildbot.
2020-05-26 dhanyaganesh@chromium.org config: Refactor some configs
2020-05-26 saklein@chromium.org cros flash-ap: Fix ssh flash with non-22 port.
2020-05-26 mikenichols@chromium.org chromeos-config: Remove eve-lacros custom configuration
2020-05-26 bpastene@chromium.org cros_chrome_sdk: Create build dirs when using --no-shell.
2020-05-26 chrome-bot@chromium.org Update config settings by config-updater.
2020-05-26 navil@google.com chromeos_config: Disable release-basic builder.
2020-05-26 navil@google.com chromeos_config: fix fail fast builder gs_path
2020-05-26 morg@google.com Remove (atlas|kukui) boards from vmpi PFQ
2020-05-26 judyhsiao@google.com usergroup_baseline: Add sound_card_init to audio and cras group
2020-05-26 niwa@google.com Remove unused targets (x86 and arm) from ANDROID_VMRVC_BUILD_TARGETS
2020-05-26 chrome-bot@chromium.org Update config settings by config-updater.
2020-05-26 stimim@google.com workspace_stages: remove duplicated android packages
2020-05-25 chrome-bot@chromium.org Update config settings by config-updater.
2020-05-23 vapier@chromium.org cros lint: allow "#!/usr/bin/env python" shebangs
2020-05-23 kerker@google.com image_test: add /usr/lib/node_modules/ to the whitelist
2020-05-22 levinale@chromium.org Add zwisler to the OWNERS.kernel file
2020-05-22 achuith@chromium.org vm: Increase connect timeout for non-KVM.
2020-05-22 manojgupta@google.com chromeos_config: asan: Disable rootfs verification
2020-05-22 bpastene@chromium.org auto_updater: Fix args to RemoteDevice.run() when cmd is a string.
2020-05-22 dianders@chromium.org remote_access: Don't force the port to 22 if unspecified
2020-05-22 malaykeshav@chromium.org Revert "deploy_chrome: Warn before deploying to device with mismatched board"
2020-05-22 levinale@chromium.org Add a per-file permission for kernel Owners file
2020-05-22 vapier@chromium.org OWNERS.chrome: set COMPONENT
2020-05-22 chrome-bot@chromium.org Update config settings by config-updater.
2020-05-22 navil@google.com chromeos_config: Add child builds for fail fast builder.
2020-05-22 navil@google.com chromeos_config: Create template for the fail fast release builder.
2020-05-22 richardfung@google.com Remove android-container-qt targets
2020-05-21 vapier@chromium.org OWNERS: update build settings
2020-05-21 dhaddock@chromium.org paygen_build_lib_unittest: Fix au_e2e control file.
2020-05-21 levinale@chromium.org Chromite: add owners file for the kernel

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: 1086560
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: I14a8966aac606a9bb5098c16d350fc8ad36ecf7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218431Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772293}

For data gathering re SxS, apparently it's possible for Spotlight to
return a search query result for which there is no path. Defend
against this.

Bug: 1086555, 1061486
Change-Id: I972c6cda16d5c0801673addefd064cdfbc810904
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218549
Auto-Submit: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772292}

Bug: None
Change-Id: Ifcca583ad1f475d78e600584904efdcd4bdac739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218449
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772291}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d81fad6de554..212c527f90e9

2020-05-27 jacktfranklin@chromium.org Upgrade to TypeScript 3.9.3
2020-05-27 tvanderlippe@chromium.org Typecheck browser_sdk/LogManager.js with TypeScript
2020-05-27 jacktfranklin@chromium.org Sort expected files in search results e2e test

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Iacf63754c8a96505e71c76ae2638396693c562b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218433Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772290}

Bug: chromium:1011811, chromium:1079233
Change-Id: I9abc4d504fb61809b9dc93d0370c613da3a20fa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218051
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772289}