- 30 Jun, 2020 40 commits
-
-
Stephanie Kim authored
Bug: 1072012 Change-Id: I2c53e77aafb75007b6ccb99793e0ae30fecc2295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274585Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#784074}
-
Aya ElAttar authored
Changed PolicyMap::Set to accept value parameter as base::Value instead of unique_ptr. Bug: 2270317 Change-Id: I2f195c2ac53d61c94655e93001e2c234594fbf4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274388 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#784073}
-
Henrique Nakashima authored
Reland note: Fixed version without NPE. WebContentsStateBridge#createHistoricalTab() can be accomplished by calling other methods: - WebContentsStateBridge#restoreContentsFromByteBuffer() - WebContentsStateBridge#createHistoricalTabFromContents() - WebContents#destroy() Replace it with these calls. Bug: 1090048 Original change's description: > Revert "Break down WebContentsStateBridge#createHistoricalTab()" > > This reverts commit 864ff6e1. > > Reason for revert: crbug.com/1100325 > TBR=dtrainor@chromium.org,jinsukkim@chromium.org,hnakashima@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1090048 > Change-Id: I73d490b12526ab8f26171f8c4fbf42fcbe284c17 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273682 > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783626} TBR=dtrainor@chromium.org,jinsukkim@chromium.org,hnakashima@chromium.org Bug: 1090048 Change-Id: Ie818a2ab7a9958d60cddac542151d7b0bc487b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274200Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#784072}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9e96ce180331..35c950b7e18e 2020-06-30 bsheedy@chromium.org Revert "[Telemetry] Fix CrOS remote screenshots" 2020-06-30 ahaas@chromium.org [v8] Add first wasm metric for instantiation 2020-06-30 bsheedy@chromium.org [Telemetry] Fix CrOS remote screenshots If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1084929,chromium:1098450,chromium:1098485 Tbr: wenbinzhang@google.com Change-Id: I50c4bba45250d80d6653e626a36d499fce2e2030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276344Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784071}
-
David Bienvenu authored
This reverts commit 9d1db5b8. Reason for revert: <breaks chromium waterfall> Original change's description: > Safety check: add tests for the Chrome cleaner child backend > > * Test that each possible CCT status results in the corresponding > safety check child status and display string. > * Test that CCT being enterprise managed is handled correctly. > > Bug: 1087263 > Change-Id: I84d93408800cb4fbe8d138578c586a0ae89dbfc9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249980 > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Commit-Queue: Rainhard Findling <rainhard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783942} TBR=joenotcharles@chromium.org,aee@chromium.org,rainhard@chromium.org Change-Id: I581fbbf2447c64613bb08861c160b8ce2f781f3e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1087263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276532Reviewed-by:
David Bienvenu <davidbienvenu@google.com> Commit-Queue: David Bienvenu <davidbienvenu@google.com> Cr-Commit-Position: refs/heads/master@{#784070}
-
Rakib M. Hasan authored
Make some changes to build_weblayer_instrumentation_test_cipd_pkg.py so that it can be run from anywhere in chromium/src. TEST: Ran build_weblayer_instrumentation_test_cipd_pkg.py in its parent directory. TBR=jam@chromium.org Bug: 1058968 Change-Id: I92b50418580398826e5af04512fe18463164c083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271101 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#784069}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8f3a83671a13..1c62a7b034c0 2020-06-30 csmartdalton@google.com Implement stroking with GPU tessellation 2020-06-30 brianosman@google.com SkSL: Rename isConstant to isCompileTimeConstant 2020-06-30 brianosman@google.com SkSL: Variable references are never "isConstant" 2020-06-30 westont@google.com [infra] Add xcode-11.4.1 asset 2020-06-30 michaelludwig@google.com Support sample coords in .fp main() 2020-06-30 robertphillips@google.com Make the GrDirectContext a thing and move it to include/private 2020-06-30 bungeman@google.com Remove SkWhitelistTypefaces. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: Idf6efddfd3b2f4d843cf89746a38f56853e6a686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274111Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I841ca618ac1d58e6112ab79b3a9c45ec26e95966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276342Reviewed-by:
-
Jihwan Marc Kim authored
In chrome_pdf::OutOfProcessInstance, we should stop sending metrics through PPAPI, which is being deprecated. Bug: 1098489 Change-Id: I5ad6601233561e28b07e52019a097fff99888b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267597Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#784066}
-
Kevin Schoedel authored
RenderFrameHost::GetView() is documented as being able to return nullptr, and evidently sometimes does. Check it. Bug: b/159923724 Test: manual on device Change-Id: I752365e2f5dba156dbfc690fb3f1243c76ec5f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276216 Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#784065}
-
Charlie Hu authored
This CL does the necessary plumbing so that permissions policy header can be properly parsed and merged with existing init procedure of feature policy. A few wpt tests are added to verify that the plumbing is working as expected. Change-Id: I64b956f55fc36e372c23d6f1df92af54e268d92c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246981Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#784064}
-
Shakti Sahu authored
Bug: 1097102 Change-Id: I8929f8da8ffbfd8fed3fd2b2e7f8d25f2c1a7b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264202 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Mike Wittman authored
This reverts commit b95277ba. Reason for revert: suspected of causing test failures on Marshmallow Tablet Tester and android-asan Original change's description: > [Sampling profiler] Fix and test NativeUnwinderAndroid module extents > > Reuses the ModuleCache POSIX module implementation for Android ELF > modules, which fixes the incorrect start and end addresses previously > generated by AndroidModule. Renames AndroidModule to NonElfModule. > Removes tests specific to the previous implementation. > > Also includes a latent 64-bit bug fix where the register copy would > only copy half the registers. > > Bug: 1004855 > Change-Id: I3b26fac427043b2022b1d35b5c985e468ce35692 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253221 > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783689} TBR=wittman@chromium.org,etiennep@chromium.org Change-Id: I48aca7285e572eab5147ef584dda01eeabfb2008 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1004855, 1101023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274327Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#784062}
-
Mike Wittman authored
The annotation is required to load modules via JNI calls in the renderer process, as done for the sampling profiler. Bug: 1004855 Change-Id: I729edef2cbcb434177ec0d91e827f8839b6516c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274577 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#784061}
-
Pranav Batra authored
Bug: chromium:832266 Change-Id: Icc7eef9b97c54e5777493bdf43db0996e9bc03c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274140Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#784060}
-
OlivierLi authored
[blink scheduler] Add integration tests for inhibiting intensive throttling on title/favicon update. TBR=altimin@chromium.org Bug: 1075553 Change-Id: I7c72213c17342498d6f43f909cb3676d18111dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276232Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#784059}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 20 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-12-27. TBR=chromium-metrics-reviews@google.com Change-Id: Ia920ad26dcf1f307e1b6c77f2e4d101d48c4637d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276073Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#784058}
-
Dale Curtis authored
Allows ImageDecoder API users to select between the still or animation and know that such an animation even exists in formats like AVIF. The JavaScript API now exposes a tracks listing and each track has (for now) just a track id and a boolean animated flag. Clients can use the track listing with a selectTrack() method to change tracks. Under the hood we currently just translate all multi-image files with an animation track to have 2 tracks: still and animated. Long term we will need a precise track list, but this concept allows us to defer that for now while not hamstringing ourselves via the exposed API. It's unclear at this point how a normal <img> tag will access this information or control which type is selected. So long as authors have access to this API, it's not necessary to have <img> do anything. Tested manually with a private asset from libavif folks. Bug: 960620, 1073995 Change-Id: I070bbe11a84d7d03749f3092c20bb5ea785e2c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250937Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#784057}
-
Stephen McGruer authored
Bug: 1095643 Change-Id: I7665d6439733773fe655a3241479f7015f43509c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261164 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#784056}
-
Tao Bai authored
This is 2nd try, wait for all children's width available. Bug: 1098986 Change-Id: I6861b69cfd984f1d362edf5a48fb72de6134f2b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274199Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#784055}
-
Rakib M. Hasan authored
Disable the following for M83 client skew tests org.chromium.weblayer.test.ExternalNavigationTest#testExternalIntentWithNoRedirectBlocked Disable the following for M83 implementtion skew tests org.chromium.weblayer.test.ExternalNavigationTest#testExternalIntentWithNoRedirectLaunched TBR=jam@chromium.org Bug: 1096570 Change-Id: I23fa50f5ac46da88315468e904893ad3fc99329f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274465 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b3240d0c355a..14453b7a67ac 2020-06-30 srisser@google.com Fix debug assert from happening in release build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ia4ecd68c371dce4375a73efbbe97a5a1e8518a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276168Reviewed-by:
-
Nate Chapin authored
It's mostly reading state off of DocumentLoader, and it allows us to make StartLoadingResponse() a private member of DocumentLoader Change-Id: I6cf9b0b6b21c0102b7e1fa1f2b59f7cf54a350c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273624 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#784052}
-
Nico Weber authored
Doesn't actually work, but it's a commonly included header, so this cuts down on build noise quite a bit. Bug: 1098899 Change-Id: Ib1836cc02a072519978a14b66d2bc21338d957d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274176Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a52834d8184b..34eb401ba547 2020-06-30 cclao@google.com Vulkan: Skip repeated VkCmdClear call with the same value If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: If2d7fd529ddeff3c97b22e9a04d81e64ab5ead5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276332Reviewed-by:
-
Lindsay Pasricha authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/af46d99e3add..f971ef807cdc $ git log af46d99e3..f971ef807 --date=short --no-merges --format='%ad %ae %s' 2020-06-30 tirodkar Add iOS 14 support for XCTestCase::recordIssue: 2020-06-26 tirodkar Add support for failed assertions to the error formatter. 2020-06-25 tirodkar Add action failed error code to the new error formatter. 2020-06-25 mobile-devx-github-bot Internal change. 2020-06-25 chanheepark Add timeout error code for the new error formatter. 2020-06-24 tirodkar rm redundant error:nil in FailureFormattingTest and fix failures. 2020-06-24 tirodkar Add the FailureFormattingTest for testing the new formatting. Created with: roll-dep src/ios/third_party/earl_grey2/src Bug: 1100871 Change-Id: I9c98fe8ecf1ad05f565d567c4de16d4f92f7c5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275746Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#784049}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ia0f9df87cd90363c91157e27921c586d207427cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276212Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784048}
-
Dominique Fauteux-Chapleau authored
Race conditions between token unregistration and registration are handled by queueing registrations when unregistrations are pending. Bug: 1092404 Change-Id: Ib19a577e6588f6a80ce013f70d2c59110d739b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276211Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#784047}
-
Filip Gorski authored
Failures happen mostly: * network_service_out_of_process_chrome_public_test_apk, however * chrome_public_test_apk also occasionally fails TBR=gangwu@chromium.org, tedchoc@chromium.org Bug: 1100967 Change-Id: I09180f254ce4566dae3b680b7a5091f474d3528b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274319Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#784046}
-
Robert Phillips authored
With the Skia-side CL: https://skia-review.googlesource.com/c/skia/+/298751 (Be more consistent about calling release procs in SkImage factories) the following SkImage factories guarantee they will call a provided releaseProc on a null return: MakeFromCompressedTexture MakeFromTexture MakeFromYUVATexturesCopyWithExternalBackend MakeFromYUVTexturesCopyWithExternalBackend MakeFromNV12TexturesCopyWithExternalBackend This CL cleans up the relevant call site. Bug: 1097484 Change-Id: I5471fad8df981c7976bdf702575e7cdc91bf9177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264598 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#784045}
-
Steven Bennetts authored
Bug: 1099902 Change-Id: Ibd638587346ccf7060914297f7c4f1f98fcc4dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271081 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#784044}
-
Abigail Klein authored
The UI spec (go/chrome-live-caption-ux) was approved by the Chrome UI reviewers. This CL updates the caption bubble to the spec in the following ways: 1. Change the title text to "Detecting speech..." 2. Left-align the title text and error text 3. Make the error text on one line and update the error icon size when the caption font size changes 4. Add a tooltip to the close button 5. Change the size and color of the close button hover 6. Match all of the sizing specs, such as padding and margin Screenshot of the changes: https://screenshot.googleplex.com/wTduQB95d59 The one remaining spec change needed is to update the focus state, which will be done in a follow-up as it requires more investigation. Bug: 1055150 Change-Id: I9f0b79ecc7f875e4f04f92bf8eea7c2b598f2169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275369Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#784043}
-
behdad authored
The platform specific tags are updated with: - Correct OS names for mac bots - Appropriate master tag were added to the platform specific tags Adjust_upper_limits script is updated to support master tag provided. Bug: chromium:1094379 Change-Id: Icccaf162a42def7ca1413ecf673c00841e9b4056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250349 Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#784042}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bc4525604b66..5f4e87cd92c2 2020-06-29 navil@google.com cbuildbot: Skip Update ChromeOSLKGM stage for basic-builder. 2020-06-29 quasisec@google.com config: add puff back to hw testing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I3aa39adb03df4722cccb884bb3eba645a5dd72c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276164Reviewed-by:
-
Chris Harrelson authored
direct compositing reason. Previously we omitted one for squashed layers, but we should also do so for layers which hit a squashing-disabled reason. There are three reasons to make this change: * The only reason to allocate a paint offset translation is in order to reduce invalidations when the layer moves, but these layers are not intended to be composited by the developer. * This makes pre-CAP behave more like CAP. * It removes a dependency of property trees on the result of the overlap test. Bug: 1100711 Change-Id: If5b32d49521189fe62ecad32a1baf4e142fcc262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274253Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784040}
-
Rakib M. Hasan authored
This reverts commit 4500c34d. crrev.com/c/2273620 was missing several variable declarations. This CL adds those declarations. Bug: chromium:960606, chromium:952105 Change-Id: Id3b7d830b39409675ae6ed7f01da8bbaa74d6507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274366Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#784039}
-
John Delaney authored
If initialization fails to initialize, we reset the |storage_| pointer. This allows possible null pointer exceptions if there are later calls into manager. This change simply removes this pointer reset, as the storage layer itself is robust to initialization failures. Bug: 1088072 Change-Id: Ieda3b4043f55b94add921217abd58ec7971c138e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270703 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#784038}
-
Ghazale Hosseinabadi authored
This CL enables ExtensionService::ReloadExtension() to handle reload failures, where subsequent calls can retry the reload, rather than immediately giving up. Bug: 792277 Change-Id: I482da093133a1baee7f2f5cad8abbc9c85e9e074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242642 Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784037}
-
Nate Chapin authored
* Remove the Document and DocumentLoader variants of CountDeprecation, so only the ExecutionContext variant remains. * Move the special-cases in Document::CountDeprecation to Deprecation::CountDeprecation * Add a Deprecation object to WorkerOrWorkletGlobalScope to track deprecation de-duplication, instead of having its own custom tracking * Deprecation::CountDeprecation can inspect the appropriate Deprecation object to determine whether the deprecation has already been reported, and it can then do the requisite use counting, console messages and deprecation reports based on the ExecutionContext it was provided. * UseCounter::CountDeprecation is now no longer necessary, its subclasses don't do anything. Bug: 1029822 Change-Id: I07f42a49d6371321b4fedde208a586ecda90ea23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261444 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#784036}
-
Nazerke authored
This CL removes a|SyncedWindowDelegateBrowserAgent| from TabModel as a part of a tabmodel deprecation. Bug: 1045575 Change-Id: I9e5b6868348f9ec6039746eec0082787bd17868a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232944Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#784035}
-
