GitLab

Bug: 766653
Change-Id: Iff945c3b637fc566380b6ab8e2ab8e1c409088ba
Reviewed-on: https://chromium-review.googlesource.com/756196Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520966}

Do this to reduce the likelihood of running out of time before
finishing with the corpus on ClusterFuzz.

TBR=mmoroz@chromium.org

Bug: 791052
Change-Id: I8c91dc0ff3e64dbde9bc6e5b17ef85e456c64911
Reviewed-on: https://chromium-review.googlesource.com/803894Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520965}

Change-Id: I295442cc7b3f5168fc69d26bdba17450ff0cc105
Reviewed-on: https://chromium-review.googlesource.com/801987Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520964}

Data bound fields need to have the backend value updated before sending
the input event.
Example website:
- nordstrom.com
- walgreens.com

Bug: 788099
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5b8467a76d15b6ad83061730b3a627f274342c27
Reviewed-on: https://chromium-review.googlesource.com/787433
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520963}

Changing names of variables from subclass
to make them different from variables in superclass
(which will remove Prone warnings)

Bug: 
Change-Id: I3591cb6b64062c94e9f84f30dd505d0c31fbf3d2
Reviewed-on: https://chromium-review.googlesource.com/802435Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#520962}

This reverts commit 52affce6.

Reason for reland: Fixes bug that causes webview to fail

Original change's description:
> Revert "Merges process and package resources script"
>
> This reverts commit ea0f96c8.
>
> Reason for revert:
> Causing resource errors in the real webview (not on cq)
> https://build.chromium.org/p/chromium.android/builders/Android%20WebView%20L%20%28dbg%29/builds/10729
>
> Original change's description:
> > Merges process and package resources script
> >
> > process_resources.py and package_resources.py are currently both required to
> > create the final apk. They currently communicate using zipfiles. This ends up
> > having 3-4 zips/unzips during the final build of the same apk in order to
> > perform modifications. This merger allows all the required processing to be
> > done before apk creation with no need for zipping. It also simplifies the
> > process_resources.py script to separate the code that runs during library
> > builds vs apk builds.
> >
> > Bug: 782316
> > Change-Id: I958c1d107d593b0932275d3c4452c2c51c499b55
> > Reviewed-on: https://chromium-review.googlesource.com/791152
> > Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#519850}
>
> TBR=agrieve@chromium.org,mheikal@chromium.org
>
> Change-Id: If0d30f7e57b18ff56bd17c2c918398158fb3dffa
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 782316
> Reviewed-on: https://chromium-review.googlesource.com/796717
> Reviewed-by: Bo <boliu@chromium.org>
> Commit-Queue: Bo <boliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520149}

Bug: 782316
Change-Id: I4b6d7650c84706b55bfab7ae6943251342f2e0b3
Reviewed-on: https://chromium-review.googlesource.com/801595
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520961}

The http://crrev.com/449177 removed the last file guarded by these
OWNERS rules a while ago. These seem unlikely to be re-introduced.

Bug: None
Change-Id: I3da1654092f5cfdc705f03e9f8f70b6cc0360e7e
Reviewed-on: https://chromium-review.googlesource.com/803574Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520960}

The cc/scheduler/scheduler_state_machine uses a lot of enums.
enums are not real types and hence have subtle problems.
C++ introduced the concept of "enum class" types which would
be better replacements.

BUG=440759

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I12ce9ee05b668bee5c2f84bbe522edd741d2bd56
Reviewed-on: https://chromium-review.googlesource.com/709094
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520959}

* Add AecDumpMessageFilter::GetOverrideAec3().
* Don't set aec3 in AecDumpMessageFilter::AddDelegate().
* Instead, get the override value before init in MSAP.
* In init, the override value is already honored, although that was always not set before this fix.

Bug: 791016
Change-Id: I0d58ab3dac13321b4a686b6f726c449930b185d5
Reviewed-on: https://chromium-review.googlesource.com/803486Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520958}

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I557e788d4cb5fe68c7eb5d61c32dbc6d1b017b46
Reviewed-on: https://chromium-review.googlesource.com/777712Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520957}

R=aleventhal@chromium.org, dmazzoni@chromium.org
Tested; manually

Bug: 730965
Change-Id: I0819a7e053f665ae5150147fd90b5dcab6ca0994
Reviewed-on: https://chromium-review.googlesource.com/786544Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520956}

When the BottomSheet is open, clear the URL. Reset the URL when the
sheet is closed.

Also moves security icon logic from LocationBarLayout to
ToolbarDataProvider and updates tests.

BUG=789775

Change-Id: Iceb934eefa32a71cbb1c3c4ec2b372eded72a237
Reviewed-on: https://chromium-review.googlesource.com/798059
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520955}

This single function will make it easier to support more scenario
(events, frameworks...).

Bug: 788099
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib76aadebbb3c6999b20b5261a8b0045689bd2785
Reviewed-on: https://chromium-review.googlesource.com/786239
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520954}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/009150b7afe1..f6b946d71d43

$ git log 009150b7a..f6b946d71 --date=short --no-merges --format='%ad %ae %s'
2017-11-29 achuith Also print key in commit message.

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: I06bee3c72b420aa6925c67f1d7a18417d2657d30
Reviewed-on: https://chromium-review.googlesource.com/803594Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520953}

virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline.html

is very broken with SPv2.

TBR=majidvp@chromium.org

Bug: 778875
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic94109ad74c09dfcbc48f4bf44a3ba134fda0918
Reviewed-on: https://chromium-review.googlesource.com/802637Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520952}

The way the current code is set up, selecting a shipping address
will kick off a view update under the spinner screen while waiting
for the merchant to call update with. Not only is this wasteful
(the view will update again on updateWith, as the spinner is hidden)
but it's also a source of use-after-free crashes when updateWith
is called in the middle of the view update because the two updates
race to updating and deleting some view objects.

BUG=788514

Change-Id: I86f48907632d679e7702b3bbf9e09d893b1b8c7a
Reviewed-on: https://chromium-review.googlesource.com/801835Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520951}

Bug: 789532
Change-Id: Iad9ed5998dd245df7c8def83cc3123f960a8fdc7
Reviewed-on: https://chromium-review.googlesource.com/802734Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520950}

Import wpt@691ab2189860490becdf2c4813ad62cad62c44ba

Using wpt-import in Chromium a5f4b6fa.

(Backed out WPT_BASE_MANIFEST.json changes.)

No-Export: true
Change-Id: I8db6cc540c633cd3252765c92586af5da328496b
Reviewed-on: https://chromium-review.googlesource.com/793152Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520949}

This reverts commit 1db67406.

Reason for revert: 

NEVER, EVER, EVER!!!! revert one of these chrome-release-bot commits without consulting with TPMs or release team. This can cause major havoc with Chrome releases.

Change-Id: Ib5f4bf96c81e2fe0fac017efa7ee9fa7245a039a
Reviewed-on: https://chromium-review.googlesource.com/803734Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520948}

Bug: 784442
Change-Id: I00bab82f67d2b47f02394831e9ef5126e3fd7a38
Reviewed-on: https://chromium-review.googlesource.com/794133
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520947}

Some javascript frameworks (e.g. React) or pages have a cache version of input fields in
pages.
This cache will override the autofill value of the fields.
When value is changed, events must be sent to update these cache.
When a user type in a field, the following events are usually sent:
- keydown
- input
- change
- keyup
By testing, most framework use use one of these events, and some framework use
the data field of the event as new value.

Send these events when updating fields.

Bug: 783025, 728631, 732360
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I147a4471ecd2e389cfca57d2aa9d78f61360aa61
Reviewed-on: https://chromium-review.googlesource.com/771674
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520946}

NetworkContexts can now be created with an optional
initial proxy configuration and/or a pipe to pass
updated proxy configurations over.

Will make chrome/ use this in a followup CL.

Bug: 754007
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Idc92e3cb6e52716d50e1780dd296bef694411c43
Reviewed-on: https://chromium-review.googlesource.com/755797
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520945}

I expected this to be a no-op, but broke Docs. C'est la vie.
Manually verified that Docs isn't broken after this patch.

Bug: 790955
Change-Id: Id8290a5c1f826d1f374e6531de8e8433a814b21c
Reviewed-on: https://chromium-review.googlesource.com/803478
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520944}

- Replace the old BeginNavigation IPC by the equivalent mojo call in
the FrameHost interface. Removed all reference to the old IPC and the
render_frame_host callback.

- Convert BeginNavigationParams to a mojo structure. Most of this patch
is simply modifying function prototypes to match the new mojo syntax.

Bug: 784904
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I6f288c1d44c6dd7ab34726689ebf241ae45f73de
Reviewed-on: https://chromium-review.googlesource.com/763529Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520943}

virtual/rootlayerscrolls/scrollbars/custom-scrollbar-inactive-pseudo.html
virtual/prefer_compositing_to_lcd_text/scrollbars/custom-scrollbar-inactive-pseudo.html
virtual/prefer_compositing_to_lcd_text/scrollbars/custom-scrollbar-adjust-on-inactive-pseudo.html
are flaky on Linux as well

virtual/gpu-rasterization/images/image-hover-display-alt.html is flaky

TBR=avi@chromium.org
NOTRY=true

Bug: 789567, 789478, 790025
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I6f52e55a3a3a4573750d971f1ce7247448579061
Reviewed-on: https://chromium-review.googlesource.com/801256
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520942}

This reverts commit 67dc496d.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Introduce RtcEventLogManager"
> 
> This reverts commit 437fa566.
> 
> Reason for revert:
> 
> WebRtcEventLogManagerTest.LocalLogMayNotBeStartedTwice fails across multiple bots (https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65151) (https://ci.chromium.org/buildbot/chromium.memory/Linux%20TSan%20Tests/14934) with this change.
> 
> Original change's description:
> > Introduce RtcEventLogManager
> > 
> > RtcEventLogManager will manage both:
> > 1. Writing RTC event logs to local files, based on user input via
> > WebRTCInternals. (Current CL.)
> > 2. Uploading RTC event logs to remote servers, based on JS-triggered
> > configuration. (Upcoming CLs.)
> > 
> > The latter of the two is the use case which motivated the creation of
> > RtcEventLogManager, since we need this manager to outlive the call. We
> > also want RtcEventLogManager to run in new Chrome instances, even if
> > now WebRTC session exists, so that it may upload still-pending logs
> > from previous sessions. (This functionality will be added in upcoming
> > CLs.)
> > 
> > Bug: 775415, 780863
> > Change-Id: I7504857ebf662fd914f5988ecbc1fae051f12275
> > Reviewed-on: https://chromium-review.googlesource.com/760816
> > Commit-Queue: Elad Alon <eladalon@chromium.org>
> > Reviewed-by: Chris Palmer <palmer@chromium.org>
> > Reviewed-by: Tommi <tommi@chromium.org>
> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> > Reviewed-by: Camille Lamy <clamy@chromium.org>
> > Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> > Reviewed-by: Henrik Boström <hbos@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#520926}
> 
> TBR=palmer@chromium.org,tommi@chromium.org,grunell@chromium.org,rdevlin.cronin@chromium.org,clamy@chromium.org,msramek@chromium.org,hbos@chromium.org,guidou@chromium.org,terelius@chromium.org,eladalon@chromium.org
> 
> Change-Id: I97ff60cccac1be13dc250f6a3bb129c09265e212
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 775415, 780863
> Reviewed-on: https://chromium-review.googlesource.com/803614
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520938}

TBR=avi@chromium.org,palmer@chromium.org,tommi@chromium.org,grunell@chromium.org,rdevlin.cronin@chromium.org,clamy@chromium.org,msramek@chromium.org,hbos@chromium.org,guidou@chromium.org,terelius@chromium.org,eladalon@chromium.org

Change-Id: Id36daaafaba9e9582f9fe1edd1c3e96493272f3c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775415, 780863
Reviewed-on: https://chromium-review.googlesource.com/803220Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520941}

Bug: 791021
Change-Id: Ibd01847b97922ea1527de149be7086c86db1b641
TBR: jinsukkim@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/803439Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520940}

This CL does a couple things:
- make the outlink button stay on the bottom of the page
- change the buttons to <a>s for a11y improvement (tabbing, href)

Bug: 787221, 788720
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I326b75113a5cbced9ac9ebf5ae58650db63caca0
Reviewed-on: https://chromium-review.googlesource.com/790515
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520939}

This reverts commit 437fa566.

Reason for revert:

WebRtcEventLogManagerTest.LocalLogMayNotBeStartedTwice fails across multiple bots (https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65151) (https://ci.chromium.org/buildbot/chromium.memory/Linux%20TSan%20Tests/14934) with this change.

Original change's description:
> Introduce RtcEventLogManager
> 
> RtcEventLogManager will manage both:
> 1. Writing RTC event logs to local files, based on user input via
> WebRTCInternals. (Current CL.)
> 2. Uploading RTC event logs to remote servers, based on JS-triggered
> configuration. (Upcoming CLs.)
> 
> The latter of the two is the use case which motivated the creation of
> RtcEventLogManager, since we need this manager to outlive the call. We
> also want RtcEventLogManager to run in new Chrome instances, even if
> now WebRTC session exists, so that it may upload still-pending logs
> from previous sessions. (This functionality will be added in upcoming
> CLs.)
> 
> Bug: 775415, 780863
> Change-Id: I7504857ebf662fd914f5988ecbc1fae051f12275
> Reviewed-on: https://chromium-review.googlesource.com/760816
> Commit-Queue: Elad Alon <eladalon@chromium.org>
> Reviewed-by: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Tommi <tommi@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520926}

TBR=palmer@chromium.org,tommi@chromium.org,grunell@chromium.org,rdevlin.cronin@chromium.org,clamy@chromium.org,msramek@chromium.org,hbos@chromium.org,guidou@chromium.org,terelius@chromium.org,eladalon@chromium.org

Change-Id: I97ff60cccac1be13dc250f6a3bb129c09265e212
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775415, 780863
Reviewed-on: https://chromium-review.googlesource.com/803614Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520938}

Bug: 
Change-Id: I8b3227131de4b5b070fc8a9896b87d9191e1ee5d
Reviewed-on: https://chromium-review.googlesource.com/796852
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520937}

It was invalid. Not quite sure what it assumed, but probably that
column-span:all was allowed to overlap with the column content that came
after.

Bug: 788337
Change-Id: I63d5279da9939a0e027bb1ed9084b03b3a32bacb
Reviewed-on: https://chromium-review.googlesource.com/803277
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520936}

BUG=chromium:788000

Change-Id: I57f930ac095949b2cc8656ac169fc6e192d2fabd
Reviewed-on: https://chromium-review.googlesource.com/802625
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#520935}

The net effect of this CL is to allow scrollable iframes/divs within
an OOPIF subframe, and which do not have their own composited layer for
scrolling, to be able to scroll.

This CL converts ScrollingCoordinator::UpdateAfterCompositingChangeIfNeeded
to take a LocalFrameView* instead of just defaulting to the main frame's
view, so that changes for OOPIF subframes can also be accomodated. All
relevant call sites are updated, and a no-longer-needed hack regarding
NonFastScrollableRegions is removed from RenderWidgetCompositor as a result.

Bug: 787498
Change-Id: I608cfcdc7f7a4edd6469f9c8fed41d9ac0cf9706
Reviewed-on: https://chromium-review.googlesource.com/786307
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520934}

Currently, the share menu controller's |menuNeedsUpdate:| is called
every time a hotkey is pressed.

Implementing |menuHasKeyEquivalent:forEvent:target:action:| disables
that path in the menu code, so this change implements that. Similarly
to the bookmark menu, we return NO unconditionally and let the hotkey
be handled by the menu item. To ensure the menu item exists to handle
it, we populate the menu on the first call to |menuHasKeyEquivalent:|
unless it's already been populated.

Bug: 787049
Change-Id: I321ed87dfc64f89f31c5738712472d33a923a55a
Reviewed-on: https://chromium-review.googlesource.com/801854Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520933}

Bug: 772483
Change-Id: I7a655761660e3d10f25fb0d39f51b13a48c97662
Reviewed-on: https://chromium-review.googlesource.com/802818Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520932}

Bug: 
Change-Id: I934882dd18faee1d999565e5a6661148d52fe20c
Reviewed-on: https://chromium-review.googlesource.com/801291Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520931}

Log failures in Open() and Start().

Previous (reverted) CL: https://chromium-review.googlesource.com/c/chromium/src/+/795727

Bug: 757737, 790557
Change-Id: Idecad5ba1a692da1386823d30ce65462c9a05ff3
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/795727
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#520562}
Reviewed-on: https://chromium-review.googlesource.com/803219
Cr-Commit-Position: refs/heads/master@{#520930}

This will avoid significantly reducing MEI score for users that tend to
open multiple tabs. This will only apply to new tabs loading a given
origin and originating from the same origin, not multiple tabs that have
been manually typed.

It also helps reduce the complexity of MediaEngagementContentsObserver
by delegating some of the work to a different class.

Bug: 776397
Change-Id: Icfc7b810f3ad26f655e2c262de25ac3392de2dfc
Reviewed-on: https://chromium-review.googlesource.com/796861
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520929}

This reverts commit cb41d372.

Reason for revert:

https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64934

Original change's description:
> Local NTP tests: Rewrite LocalNTPUITest to use the real local NTP
> 
> Before, it used local_ntp_browsertest.html instead, for no very good
> reason. While we're here, also get rid of InstantUITestBase as a base
> class, plus a few other small cleanups.
> 
> Bug: none
> Change-Id: I19e038e5c89415b4d1156785f1a68a5d682eba09
> Reviewed-on: https://chromium-review.googlesource.com/789884
> Reviewed-by: Chris Pickel <sfiera@chromium.org>
> Commit-Queue: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520901}

TBR=treib@chromium.org,sfiera@chromium.org

Change-Id: I841aaa9ab526dbe0d8d8512bfe6f85438be1cd92
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/803554Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Commit-Queue: Henrik Andreasson <henrika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520928}

Until now we only disabled all otehr policies if the switch was present and
set to disabled. Not having the switch at all there is just as bad or even worse.

BUG=789584
TEST=components_unittests

Change-Id: Id28384f446b0a8a0976e2a073e2c6a51b176c6ba
Reviewed-on: https://chromium-review.googlesource.com/799699
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520927}