GitLab

This can be modified from both the FILE and IO threads.

BUG=559865

Review URL: https://codereview.chromium.org/1464383004

Cr-Commit-Position: refs/heads/master@{#361272}

For menus in chrome-in-mus, we attempt to create a Widget hosted in a native
window. For desktop builds, this means we attempt to host in a HWND or an
X11 window created by DesktopNativeWidgetAura. But for mus, we want to use
NativeWidgetMus. To do this, use the native-widget factory first if it's
available.

BUG=none

Committed: https://crrev.com/2914df72a605451828a05e108c35fe9a1d72c971
Cr-Commit-Position: refs/heads/master@{#361151}

R=jam@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/1460003004 .

Cr-Commit-Position: refs/heads/master@{#361271}

This patch makes editing/selection/vertical-*.html to use w3c test harness
rather than pixel match for ease of maintain.

This is the first patch of three patches of rewriting vertical-*.html.
Due by Windows command prompt limitation, we can't upload once.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1466543003

Cr-Commit-Position: refs/heads/master@{#361270}

TBR=bruening@chromium.org

BUG=442969

Review URL: https://codereview.chromium.org/1472033002

Cr-Commit-Position: refs/heads/master@{#361269}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/437819f9..6ed50d99

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1464423004

Cr-Commit-Position: refs/heads/master@{#361268}

These tests fail flakily on linux_chromium_chromeos_rel_ng and prevents
patches landing in Chromium CQ.
Disable these tests on CrOS to allow CQ to continue.

Flakiness dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=DownloadNotificationTest

TBR=yoshiki@chromium.org
BUG=560329

Review URL: https://codereview.chromium.org/1467183004

Cr-Commit-Position: refs/heads/master@{#361267}

Specifying fragment input values with locations bound with
CHROMIUM_path_rendering should work, regardless whether the underlying
driver optimized the variable away or not.

Fixes the case where updating an inactive fragment input would cause
INVALID_OPERATION, because the location was empty.

Fixes the case where updating an fragment input would cause wrong
fragment input to be updated, if the fragment input was inactive and
bound to a location that would be assigned to an unbound fragment input.

Makes the Program::fragment_input_infos_ array linear (non-sparse).  The
location bindings are now handled with
Program::fragment_input_locations_ sparse array.

BUG=542355

Review URL: https://codereview.chromium.org/1415763009

Cr-Commit-Position: refs/heads/master@{#361266}

Create a broker interface for the new Mojo EDK so that the browser can create and duplicate message pipes.

This is needed on Windows because sandboxed processes can't create named pipes or duplicate their handles to other processes. Since the new EDK uses one OS pipe per Mojo pipe, child processes need the parent process' help. When a message pipe is created in a child process, it will ask the browser process to do it. When a child process wants to send a mojo pipe to another process, it exchanges the pipe handle with an integer token that it sends instead. The receiving process can exchange that token with a pipe handle.

With this patch, --use-new-edk works with chrome's sandbox.

BUG=478251
R=rickyz@chromium.org, tsepez@chromium.org, yzshen@chromium.org

Review URL: https://codereview.chromium.org/1387963004 .

Cr-Commit-Position: refs/heads/master@{#361265}

Leaking it triggered some canary/dev build checks on Windows that ensure we don't leak handles. In this case, the leak is ok, but the simplest thing for now is to stop leaking it. A side-benefit is we ensure that Mojo message loops shut down correctly at process shutdown.

BUG=559238
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1471123002 .

Cr-Commit-Position: refs/heads/master@{#361264}

Reports indicate that this card is affected as well.

TBR=zmo
BUG=543324

Review URL: https://codereview.chromium.org/1469933004

Cr-Commit-Position: refs/heads/master@{#361263}

R=michaelpg@chromium.org
BUG=none
TEST=new Polymer, same great downloads taste!
NOPRESUBMIT=true  # for long lines in crisper.js

Review URL: https://codereview.chromium.org/1462153007

Cr-Commit-Position: refs/heads/master@{#361262}

BUG=529938

Review URL: https://codereview.chromium.org/1473453002

Cr-Commit-Position: refs/heads/master@{#361261}

Review URL: https://codereview.chromium.org/1471653002

Cr-Commit-Position: refs/heads/master@{#361260}

in SDK, it is AppKit.framework/Versions/C/Headers/AppKit.h.
Use the same case, so it would work on case sensitive filesystem.

BUG=

Review URL: https://codereview.chromium.org/1454113004

Cr-Commit-Position: refs/heads/master@{#361259}

This patch is a port of http://wkb.ug/149153, which is a port of a fix
for crbug.com/520282.

The WebKit patch has additional changes to carry more information of
isolated runs along with BidiRun. As we find we need to carry more
context with isolated runs in crbug.com/391260, this change is useful.

BUG=520282

Review URL: https://codereview.chromium.org/1468103002

Cr-Commit-Position: refs/heads/master@{#361258}

R=amineer@chromium.org, wez@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1475483002

Cr-Commit-Position: refs/heads/master@{#361257}

Now that tools/perf/find_dependencies is the only find_dependencies, this CL
moves all the related under-the-hood code to tools/perf/core. It also moves the
davclient dependency out of tools/telemetry, since find_dependencies is the
only user of it.

BUG=528331
TEST=tools/perf/find_dependencies

Review URL: https://codereview.chromium.org/1467143006

Cr-Commit-Position: refs/heads/master@{#361256}

http://crbug.com/555392

Review URL: https://codereview.chromium.org/1465793005

Cr-Commit-Position: refs/heads/master@{#361255}

Request.context is already removed in M46 and thus the deprecation message
string is no longer needed.

BUG=515786

Review URL: https://codereview.chromium.org/1373713004

Cr-Commit-Position: refs/heads/master@{#361254}

This patch makes editing/selection/vertical-*.html to use w3c test harness
rather than pixel match for ease of maintain.

This is the first patch of three patches of rewriting vertical-*.html.
Due by Windows command prompt limitation, we can't upload once.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1463713002

Cr-Commit-Position: refs/heads/master@{#361253}

This patch makes editing/selection/vertical-*.html to use w3c test harness
rather than pixel match for ease of maintain.

This is the first patch of three patches of rewriting vertical-*.html.
Due by Windows command prompt limitation, we can't upload once.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1463673003

Cr-Commit-Position: refs/heads/master@{#361252}

BUG=528489

Review URL: https://codereview.chromium.org/1474593002

Cr-Commit-Position: refs/heads/master@{#361251}

Cr-Commit-Position: refs/heads/master@{#361250}

The type of shared memory used is controlled by an A/B experiment. If the
experiment isn't present, use Mach primitives.

BUG=466437

Review URL: https://codereview.chromium.org/1453383002

Cr-Commit-Position: refs/heads/master@{#361249}

Revert of Disable kEnableGpuMemoryBufferCompositorResources on Mac (patchset #1 id:1 of https://codereview.chromium.org/1435133003/ )

Reason for revert:
This is no longer needed now that 48 has branched and https://codereview.chromium.org/1463853002/ is landed.

Original issue's description:
> Disable kEnableGpuMemoryBufferCompositorResources on Mac
>
> This caused an uptick in crashes due to GpuMemoryBuffers failing to
> allocate.
>
> BUG=554541
> TBR=reveman
>
> Committed: https://crrev.com/c5b6a85810bd669a3916587ac4d70ac566351258
> Cr-Commit-Position: refs/heads/master@{#359396}

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=554541

Review URL: https://codereview.chromium.org/1470213002

Cr-Commit-Position: refs/heads/master@{#361248}

Mus+ash changes to GpuProcessTransportFactory for Chrome rendering under a
mojo shell checked the command line directly to enable mojo shell mode
because IsRunningInMojoShell wasn't available. Since it is now, use it.

Review URL: https://codereview.chromium.org/1464663003

Cr-Commit-Position: refs/heads/master@{#361247}

Revert of Enable compositor-thread property trees (patchset #1 id:1 of https://codereview.chromium.org/1449143004/ )

Reason for revert:
This is causing overscroll on Mac to fail. Just using the flag --disable-compositor-property-trees fails to make this go away -- I had to do a manual revert
BUG=559550

Original issue's description:
> Enable compositor-thread property trees
>
> This enables compositor-thread property trees for all clients of cc.
> It also replaces the existing --enable-compositor-property-trees flag
> with a --disable-compositor-property-trees flag.
>
> BUG=481585
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/f626d0b9d0fb2bfde430cf63c5111df7da1fba6f
> Cr-Commit-Position: refs/heads/master@{#360635}

TBR=enne@chromium.org,jaydasika@chromium.org,piman@chromium.org,ajuma@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=481585
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1469733006

Cr-Commit-Position: refs/heads/master@{#361246}

security_interstitials::ControllerClient needs to be subclassed by a
standalone class, instead of being part of the SecurityInterstitialPage.

Eventually, future classes like security_interstitials::ClockError will
take ControllerClients as inputs. Until all of the blocking pages have
been updated to take ControllerClients, the functionality needs to
remain available from within the SecurityInterstitialPage, so I've put
in some temporary wrapper methods.

BUG=488673
TBR=cschuet@chromium.org

Review URL: https://codereview.chromium.org/1467063002

Cr-Commit-Position: refs/heads/master@{#361245}

Mark this test failing on Linux/NVIDIA because it's too flaky to retry.

BUG=544989
TBR=zmo@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1471963003

Cr-Commit-Position: refs/heads/master@{#361244}

Replacement for https://codereview.chromium.org/1416793005/

BUG=484261

Review URL: https://codereview.chromium.org/1456943003

Cr-Commit-Position: refs/heads/master@{#361243}

This way the WM can correctly see the set of properties during creation and we don't need a bunch of round trips for setting individual properties.

BUG=548424
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1474543002

Cr-Commit-Position: refs/heads/master@{#361242}

This will hopefully illuminate some of the problems inherent with the low resolution clock on windows.

If filtering by high resolution proves to be an effective way to de-noise UMA, we can come up with next steps and potentially migrate more histograms to use this model (or allow post-processing filtering).

For now, we will only bucket FirstContentfulPaint, as we think it's our best metric to date.

BUG=394757

Review URL: https://codereview.chromium.org/1473443002

Cr-Commit-Position: refs/heads/master@{#361241}

This is a little complex, for reasons that are explained in the code
comments. Also, this refactors ChromotingUtil to make it easier to tint
arbitrary Drawables.

Review URL: https://codereview.chromium.org/1461893002

Cr-Commit-Position: refs/heads/master@{#361240}

BUG=560603
TBR=sbc@chromium.org

Review URL: https://codereview.chromium.org/1473533003

Cr-Commit-Position: refs/heads/master@{#361239}

Continuing https://codereview.chromium.org/1412083002 but:
Removed emojis from generated_resources.grd and update the code.
Now we are keeping Emojis in the code rather than resource files.

BUG=498288
TEST=Follow these steps (taken from bug report):
1. Open multiple Chrome windows (optionally with multiple tabs)
2. Play sound clip (e.g via youtube) on a given tab
3. Drop down the Window menu
4. It is also possible to mute the tab and see what will happen but
chrome://flags/#enable-tab-audio-muting should be enable.

Review URL: https://codereview.chromium.org/1432803002

Cr-Commit-Position: refs/heads/master@{#361238}

Check active tree state separately, on each PrepareToDrawOnThread.

The source of the flakiness that the
test previously made assumptions about the timing of draws (when the active
tree's draw properties get updated) vs commits.

BUG=546867
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1472723002

Cr-Commit-Position: refs/heads/master@{#361237}

Also tweak the newline at the end of the stamp file to be
compatible with update.sh. This way, if either downloads
clang the other will consider it up-to-date.

BUG=494442
NOTRY=true

Review URL: https://codereview.chromium.org/1468243002

Cr-Commit-Position: refs/heads/master@{#361236}

Missing braces when adding code inside an "if" block,
resulting in lots of attributes being marked as editable
when they shouldn't be, breaking VoiceOver.

Regression happened in:
https://crrev.com/6185ca046850b24b92a5dffd9ab7d1ecc3048001
https://codereview.chromium.org/1435113003/

BUG=559210,473220

Review URL: https://codereview.chromium.org/1473483002

Cr-Commit-Position: refs/heads/master@{#361235}

They are not used yet, but will be soon.

BUG=548424
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1471693004

Cr-Commit-Position: refs/heads/master@{#361234}

BUG=560550

Review URL: https://codereview.chromium.org/1471153002

Cr-Commit-Position: refs/heads/master@{#361233}