GitLab

host_main.cc include base headers and thus should depend on //base.

Tbr: garykac@chromium.org,jamiewalch@chromium.org
Bug: 760393
Change-Id: I8a13683201795c3e878ec2d74a0dd72c423ed046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598834Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657315}

If the webauthn dialog is destroyed by the user pressing the ESC key,
the flow should be cancelled. This change removes an assumption that
steps when the request has been "completed" always call
AuthenticatorRequestDialogView::Cancel() at some point.

This fixes a bug where the webauthn js callback would never be called if
the user pressed ESC after tapping a key that was not registered or that
did not support the requested assertion.

Bug: 959341
Change-Id: I8d12fa7393638d97ff2d27a2172cf01d47536ce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597092
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657314}

This patch fixes DCHECK failure for `<wbr>` followed by
collapsible spaces in `white-space: nowrap`.

`<wbr>` in `nowrap` creates a break opportunity in Blink.
When line wraps there, spaces after that should be collapsed.

Whether `<wbr>` in `nowrap` creates a break opportunity or
not is not defined, and that the test only checks if it does
not cause a crash.

Bug: 950209
Change-Id: Ice657287d1ca074b7703adb9025edba633c68c8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598952Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657313}

test_fonts_fuchsia.cc requires the fuchsia.sys.Launcher service, so
must depend-on the SDK-provided GN target for that.

TBR=sergeyu

Change-Id: Ie6484e03917703515ebf148954acc59406871832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598198Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657312}

Avoids measuring assets/unwind_cfi

Bug: 960197
Change-Id: I6e326b4bf6b22f48d6edd5225a18273afc675847
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598234
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657311}

We won't be needing these again.

Bug: 959983
Change-Id: I1f3f159a6c5a5dad28fa72dcf4590328440aa030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599409
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Auto-Submit: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657310}

This causes the offline pref value to be fully reset every session, some
time after startup. When the pref is actually updated depends on when
the offline page model schedules the task, which happens on a task
thread.

Bug: 914577
Change-Id: I6d4d4140f042908394bca8150481a78cd7bbb832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597118Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657309}

It was calling UnescapeAndDecodeUTF8URLComponent(), which uses
UnescapeURLComponent, which leaves UTF-8 strings that are unsafe to
display in some contexts escaped, as well as control characters. In
most contexts, it makes no sense to partially unescape a string, and
the unsafe-to-display logic particularly makes no sense here.

Instead, switch it over to using UnescapeBinaryURLComponent(), which
unconditionally unescapes everything, and have it fall back to not
unescaping in the case of control characters.

Bug: 959213
Change-Id: Ie29e8b166f1ca51ab8dd7b51b29378c34ce40c50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596841
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657308}

With crrev.com/1560152, "Initial sync setup" error is now shown even
when Unity is not on. This patch only changed the UI. When the settings
are closed, the sync with started (like it used to be before the patch).
To keep the same behaviour before the patch, kSyncSettingsNotConfirmed
needs to be ignored in SyncSettingsTableViewController.

Bug: 956506
Change-Id: I9f17778273c62a2dc7dff816abee827d6d3b8333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599169
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657307}

This CL is part of a project to clean up uses of
UnescapeURLComponent(), as it's been used for wildly disparate
purposes, and much of its logic is only suitable for cases where
we want to format a URL for safe display to the user. We want
to make it leave more weird characters escaped, but need to
eliminate usage of it in other contexts before we can do that.

UnescapeBinaryURLComponent() should be used instead in most cases,
particularly where URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS is in use,
as all consumers of that option seem to either be slightly buggy, or
don't actually need to leave any characters unescaped. The primary
cases where switching to UnescapeBinaryURLComponent() may cause
problems (without additional checks), are cases where unescaping
path separators or funky characters (like %01) is a problem. In those
places, we should generally fail instead of partially unescaping a URL.

Bug: 849998
Change-Id: Ic3bfa87b2c893954a49b4ad95a26ee44a37ec764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593980
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657306}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3a702546..94a9e615

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ic7b258d5752f953483c765466d8149b3e85c45b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598421Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657305}

The browser only needed to know if the request is for a main frame navigation or not. It can already
deduce this by looking at the requesting factory and request's IDs.

This is a step towards the TODO to remove this from network::ResourceRequest, since network service
shouldn't know about this enum.

Bug: 960143

Change-Id: Id01b2f654b9af8d2b42c2e861eead1675c6fe7ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597198
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657304}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f51af41d20f0..55b9f5ddd2f6


git log f51af41d20f0..55b9f5ddd2f6 --date=short --no-merges --format='%ad %ae %s'
2019-05-07 dneto@google.com 1.4: GOOGLE suffix drops from certain instructions


Created with:
  gclient setdep -r src/third_party/shaderc/src@55b9f5ddd2f6

The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ibd3db5033e5208e07de133ea9caedd0070d27230
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598782Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657303}

Right now in the CSSPaintValue::GetImage, we are using empty native and
custom properties to build the PaintWorkletStylePropertyMap, and this is
because the DocumentPaintDefinitionMap was not ready yet for the
off-thread paint worklet.

Now that the DocumentPaintDefinition has been implemented, we can pass
the actual properties to build the style map. This CL does that.

Bug: 946519
Change-Id: If8fb1da383f2590ceffa0f3dcda66e380e937051
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584559
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657302}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/396ab3c6c165..bdce6c8361a0


git log 396ab3c6c165..bdce6c8361a0 --date=short --no-merges --format='%ad %ae %s'
2019-05-07 maruel@chromium.org Fix auto_stub.py for skipped tests.


Created with:
  gclient setdep -r src/third_party/depot_tools@bdce6c8361a0

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I61999f78664f23df94d1f09bd54b76a0743ddfc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598781Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657301}

Since the other similar condition to this in LayerTreeHost is a DCHECK,
and since this one only seems to be hit on shutdown, let's make this a
DCHECK.

TBR=bokan@chromium.org

Bug: 845097, 845097
Change-Id: If4fd880076f9ddd0c16a8bf5e63a76bd2b2a69fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598424Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657300}

TemplateURLService::GetDefaultSearchProvider() can return nullptr when
a default search provider is forbidden by policy, but SearchProvider
does not seem to account for this during the loading stage.

This might be the cause of the crashes described in the bug.

Bug: 899309
Change-Id: Ibfb965999eb863114c5fec24a95c482f87cb6981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597651Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657299}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80dc010a4be6..bcb4fd9c4614


Created with:
  gclient setdep -r src-internal@bcb4fd9c4614

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=nhiroki@chromium.org,iclelland@chromium.org,dullweber@chromium.org,dalecurtis@chromium.org,jrummell@chromium.org

Change-Id: Ifc11774af4f6b20783533ec85e52de89cd2de4ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599349Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657298}

This makes large data buffers, which occur for some users, more efficient
and avoids the Mojo message size limit.

This CL also plumbs through base::span to avoid introducing extra
copies in a few places and eliminate copies in others.

Bug: 867848
Change-Id: I1259c5e6846fbbbbb84262c774a711246c7dd7ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588725Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657297}

After https://chromium-review.googlesource.com/c/chromium/src/+/1343054,
HttpStreamFactory::Job::DoInitConnectionComplete will never proceed
on a certificate error, so there is no need to extract ALPN bits.

Inline HandleCertificateError to make this more obvious (otherwise it
looks like HandleCertificateError may sometimes return OK).

Bug: none
Change-Id: I57e9554bd4062a467e4f65306f41f8bbe13c8457
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595979
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657296}

Simplify the code with new sync logic from multizone code. Also updated
to make sync work with playback rates other than 1.0.

Bug: internal b/130321383
Change-Id: I51ee07b17166195fcc3fd0f09c5bd20da4b443d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588745
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657295}

This change prepares //base for the upcoming switch of base::string16 to
std::u16string.

TBR=waffles@chromium.org

Bug: 911896
Change-Id: I6efa8d0d3a2fc76cf88c0399e134cf42ad947bfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591931
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657294}

To better conform to the style guide.

Bug: None
Change-Id: Ic750ade43296b0b7810f0f08adea926411e5f700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589290
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657293}

Bug: 699790
Change-Id: I2d7f6d4cbe86a6ddc09b4669e6e1d59da30b2c08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585768Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Donna Wu <donna.wu@intel.com>
Cr-Commit-Position: refs/heads/master@{#657292}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/150add368038..b5ac6664419e


git log 150add368038..b5ac6664419e --date=short --no-merges --format='%ad %ae %s'
2019-05-07 dhanyaganesh@chromium.org buildbucket_v2: Add a retry on socket timeouts
2019-05-07 saklein@chromium.org Build API: Add ArtifactsService/BundleSimpleChromeArtifacts.


Created with:
  gclient setdep -r src/third_party/chromite@b5ac6664419e

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib08a2340816f2d885d4a2709a3db30ec620fbd49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598778Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657291}

This patch converts the web test with selection_test() so that the test
cases are more explicit and the expectations are easier to maintain.

This is a preparation for switching to logical left/right caret movement:
crrev.com/c/1593632

Bug: 958831
Change-Id: If8c232749b7b1445ad082f02b144c6f79057ad7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594627
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657290}

This patch converts the web test with selection_test() so that the test
cases are more explicit and the expectations are easier to maintain.

This is a preparation for switching to logical left/right caret movement:
crrev.com/c/1593632

Bug: 958831
Change-Id: I329193dc554fcba5472c93321845f40a1e67a2be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594202
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657289}

Bug: 956673
Change-Id: I2479baccec62c1c0683cb85bf4cae36569f3812d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591490
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657288}

Convert editing/selection/modify_move/move-by-word-visually-single-space-one-element.html with selection_test

This patch converts the web test with selection_test() so that the test
cases are more explicit and the expectations are easier to maintain.

This is a preparation for switching to logical left/right caret movement:
crrev.com/c/1593632

Bug: 958831
Change-Id: I1a48469f71c269c0b752e2540a79d3eeb87f1dda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594619
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657287}

https://skia.googlesource.com/skia.git/+log/0362dc268a6f..9f0eeac8204f


git log 0362dc268a6f..9f0eeac8204f --date=short --no-merges --format='%ad %ae %s'
2019-05-07 borenet@google.com [infra] Remove remaining references to go_deps
2019-05-07 brianosman@google.com Viewer: Fixes for shader editing in ANGLE
2019-05-07 bungeman@google.com IWYU for tests A-D.


Created with:
  gclient setdep -r src/third_party/skia@9f0eeac8204f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=robertphillips@chromium.org

Change-Id: Ie97eb81a4886a7379ec11ce20cf07f27dff6d1d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598779Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657286}

This cl moves setting EVENT_SELECTED_... bits from PaymentRequest::Pay
to PaymentRequest::OnPaymentResponseAvailable. This is because on Desktop
the payment_method name is not available before the payment response.
EVENT_SELECTED_GOOGLE bit is set when the method_name indicates that user
has chosen a Google related payment method.

Bug: 959801
Change-Id: I7c277b62925551c01929ebed4b44495a77fffb05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596829Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657285}

Bug: 956673
Change-Id: I8ec2ddfbc5ee09a09a8737fafb5a8fd3ded02e1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592801
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657284}

If we clone the web contents we do not set the audio
focus id map and therefore we hit a DCHECK.

BUG=959308

Change-Id: Ib2395c56af4b51b6e9b6fbe5fb0e64a51f0ff296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594256Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657283}

A few unit tests were failing when UnfiedConsent feature is enabled by
default. This CL updates them to pass when the UnifiedConsent feature
is enabled or disabled by default.

Bug: 960260
Change-Id: I47c08697d595378edc129352579dc8b858e6558a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598792Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657282}

This reverts commit c8e149a5 with more
deps fix.

Note that any target that includes base/logging.h but misses the
dependency to //base could cause a compile error.

Original CL description:

Currently NOTREACHED() uses LogErrorNotReached() on ChromeOS for release
builds, and DCHECK(false) otherwise. However, there are other projects
depending on Chromium that would prefer using DCHECK(false) in all
cases, and currently there's no easy way to do so.

This CL adds an |enable_log_error_not_reached| gn arg to control whether
to use LogErrorNotReached() for NOTREACHED() to solve this problem. It
is enabled by default only for ChromeOS release builds to keep the
current behavior.

Tbr: thakis@chromium.org
Bug: 760393
Change-Id: Ied42ceb2193f2946568051397597dd68809c4c61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595298
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657281}

https://android.googlesource.com/platform/external/perfetto.git/+log/b0119a63642e..808c6984e664


git log b0119a63642e..808c6984e664 --date=short --no-merges --format='%ad %ae %s'
2019-05-07 lalitm@google.com Merge "trace_processor: bump min chunk size in trace processor"
2019-05-07 lalitm@google.com Merge "trace_processor: add heap profiling tables"
2019-05-07 ilkos@google.com Merge "Correct ion values"


Created with:
  gclient setdep -r src/third_party/perfetto@808c6984e664

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I01a4072560186d8f7c32723d263d45a3376a7c28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598283Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657280}

* Use GetPagesTask and DeletePageTask routines to remove duplicate queries.
* Using PageCriteria replaces multiple queries (one for each namespace) with a
  single one, so this should be more efficient.

Change-Id: I7057d35e6e5296fddf6ad3e6b2ef63c1179044c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592038
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657279}

Fixes bug where badge was being displayed defocusing the omnibox regardless if
there was an infobar. Sets the leadingButton to be hidden before focus animation.
Then restores the displayed state of the leadingButton after the defocus animation.
Adds a property in LocationBarViewController to keep track of that displayed state.

Video: https://drive.google.com/open?id=1OrzvgnQez4d54EWVDf9RkBvLtwtkX7sC

Bug: 954624
Change-Id: I0aaa24437fefaf572285a7470c975fa720d04c52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590605Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657278}

TBR=rdevlin.cronin@chromium.org

Bug: 960363
Change-Id: Id9f274bc7c6ece5dd8d5af8f89d851f1b77dc7a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598418Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657277}

After https://chromium-review.googlesource.com/c/chromium/src/+/1594083
which caches cc node ids in blink property tree nodes,
PropertyTreeManager no longer needs to be long lived.

Change-Id: I489cb1b0cf67503b87d6498dbe95614286be3059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597752Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657276}