GitLab

Using wpt-import in Chromium 84b396de.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
hbos@chromium.org, hta@chromium.org:
  external/wpt/webrtc
mstensho@chromium.org:
  external/wpt/css/css-multicol

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I77e41607d705d65e52171fb4581611fdfe361aea
Reviewed-on: https://chromium-review.googlesource.com/c/1340510
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609283}

TBR=avi@chromium.org

Bug: 906602
Change-Id: Ifb1da0eb3b5ce013a3e64f8ab53e91c0708da6ea
Reviewed-on: https://chromium-review.googlesource.com/c/1341969Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609282}

This reverts commit 01a53aa6.

Reason for revert: the test still fails https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36437

Original change's description:
> [LayoutTest] Rebaseline live-edit-no-reveal.js after V8 roll
> 
> Bug: V8:8405
> Change-Id: Ia53c8d5d8842143f4e41b6b82149e58c70664062
> Reviewed-on: https://chromium-review.googlesource.com/c/1341512
> Reviewed-by: Dan Elphick <delphick@chromium.org>
> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609237}

TBR=rmcilroy@chromium.org,delphick@chromium.org

Change-Id: I525c9fe9c6041658b1c4aa67350bbf1f10c024c0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: V8:8405
Reviewed-on: https://chromium-review.googlesource.com/c/1341840Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609281}

It's a common and difficult to debug pitfall when you derive a GC mixin
but fail to use this macro. It leads to confusing crashes during tracing.

With this CL, the compiler will emit a warning like this:

  In file included from ../../third_party/blink/renderer/core/html/portal/document_portals.cc:5:
  ../../third_party/blink/renderer/core/html/portal/document_portals.h:17:25: error: [blink-gc] Garbage-collected class 'DocumentPortals' derives mixin class 'Supplement<blink::Document>'. You must add USING_GARBAGE_COLLECTED_MIXIN(DocumentPortals).
                          public Supplement<Document> {
                          ~~~~~~~^~~~~~~~~~~~~~~~~~~~
  ../../third_party/blink/renderer/platform/supplementable.h:119:27: note: [blink-gc] Mixin base class derived here:
  class Supplement : public GarbageCollectedMixin {
                     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~
  1 error generated.

Bug: 869498
Change-Id: I93454c418d53ebe0fcd411e0a829597dd9aaf925
Reviewed-on: https://chromium-review.googlesource.com/c/1340784
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609280}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7aa42b4c..558ce607

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I5acf9ecc5b1f604fd6507af189d629ff99c6b7e0
Reviewed-on: https://chromium-review.googlesource.com/c/1340511Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609279}

Makes the shortcuts cell shorter for better presentation on iPads.

Bug: none
Change-Id: Ia126279d680760cbb79b6fb07bf51aa6aeac67c6
Reviewed-on: https://chromium-review.googlesource.com/c/1337335
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609278}

These tests are based on SharedPreferences, which previously weren't
reset between tests, causing the tests to start with incorrect
assumptions. This CL adds a setUp() that clears the preferences, and
removes the FlakyTest annotations.

Bug: 905233
Change-Id: Ib66b506811ae38335605498d9eeef9be89d9ef08
Reviewed-on: https://chromium-review.googlesource.com/c/1340817Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609277}

Tests involving TaskScheduler accessed the members of
SameThreadTaskSource from different threads without synchronization.
This CL fixes the issue by making sure that the initial invocation of
TestTask() happens on the same thread as other invocations.

TSAN report before this CL:

WARNING: ThreadSanitizer: data race (pid=126426)
  Write of size 4 at 0x7b1400001c0c by thread T4:
    #0 base::sequence_manager::SameThreadTaskSource::TestTask() base/task/sequence_manager/sequence_manager_perftest.cc:311:25
    #1 Invoke<void (base::sequence_manager::SameThreadTaskSource::*)(), base::sequence_manager::SameThreadTaskSource *> base/bind_internal.h:516:12
    #2 MakeItSo<void (base::sequence_manager::SameThreadTaskSource::*const &)(), base::sequence_manager::SameThreadTaskSource *> base/bind_internal.h:616
    #3 RunImpl<void (base::sequence_manager::SameThreadTaskSource::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<base::sequence_manager::SameThreadTaskSource> > &, 0> base/bind_internal.h:689
    #4 base::internal::Invoker<base::internal::BindState<void (base::sequence_manager::SameThreadTaskSource::*)(), base::internal::UnretainedWrapper<base::sequence_manager::SameThreadTaskSource> >, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:671
    #5 Run base/callback.h:99:12
    #6 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:99
    #7 base::internal::TaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) base/task/task_scheduler/task_tracker.cc:641:23
    #8 base::internal::TaskTrackerPosix::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) base/task/task_scheduler/task_tracker_posix.cc:23:16
    #9 base::internal::TaskTracker::RunAndPopNextTask(scoped_refptr<base::internal::Sequence>, base::internal::CanScheduleSequenceObserver*) base/task/task_scheduler/task_tracker.cc:496:3
    #10 base::internal::SchedulerWorker::RunWorker() base/task/task_scheduler/scheduler_worker.cc:333:24
    #11 base::internal::SchedulerWorker::RunSharedWorker() base/task/task_scheduler/scheduler_worker.cc:237:3
    #12 base::internal::SchedulerWorker::ThreadMain() base/task/task_scheduler/scheduler_worker.cc:207:7
    #13 base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:81:13

  Previous write of size 4 at 0x7b1400001c0c by main thread:
    #0 TestTask base/task/sequence_manager/sequence_manager_perftest.cc:330:27
    #1 base::sequence_manager::SameThreadTaskSource::Start() base/task/sequence_manager/sequence_manager_perftest.cc:297
    #2 base::sequence_manager::SingleThreadImmediateTestCase::Start() base/task/sequence_manager/sequence_manager_perftest.cc:408:41
    #3 base::sequence_manager::SequenceManagerPerfTest::Benchmark(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, base::sequence_manager::TestCase*) base/task/sequence_manager/sequence_manager_perftest.cc:636:15
    #4 base::sequence_manager::SequenceManagerPerfTest_PostImmediateTasks_OneQueue_Test::TestBody() base/task/sequence_manager/sequence_manager_perftest.cc:714:3
    #5 HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc
    #6 testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2522
    #7 testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2703:11
    #8 testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2825:28
    #9 testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5227:43
    #10 HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc
    #11 testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4835
    #12 RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2369:46
    #13 base::TestSuite::Run() base/test/test_suite.cc:294
    #14 main base/test/run_all_perftests.cc:8:42

TSAN report after this CL:
  No races found.

Change-Id: I03b816a01fe33eed86966f89cb1ad1b9ab34c2e3
Reviewed-on: https://chromium-review.googlesource.com/c/1340534Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609276}

Adds descriptions to the new actions opening settings in Manual
Fallback.

Bug: 845472
Change-Id: If6ff348f3e8277ada4756001cfa4b98d3cc520e5
Reviewed-on: https://chromium-review.googlesource.com/c/1341535Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609275}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0c1a474a0142..fe04679d4048


Created with:
  gclient setdep -r src-internal@fe04679d4048

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I8882ace693db99257f920ef80e5e8f2d00f09e58
Reviewed-on: https://chromium-review.googlesource.com/c/1341854Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609274}

The parameter |opt_split| in __gCrWeb.findInPage.highlightWord is always
false. Since we don't support AND search in FindInPage, this parameter
should be removed. This is a preparation work for fixing the bug.

Bug: 228585
Change-Id: I4c0bd3381c7dc0f5012fa4c161814e52a5a1ec97
Reviewed-on: https://chromium-review.googlesource.com/c/1341834Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609273}

Clean up the find_in_page.js by removing unused function. This is a
preparation work for bug fixing.

Bug: 228585
Change-Id: Id20053f8623b8a25dba69c2779623854c2b4d666
Reviewed-on: https://chromium-review.googlesource.com/c/1341536Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609272}

https://webrtc.googlesource.com/src.git/+log/179a3923b9e4..95adedb9c23f


git log 179a3923b9e4..95adedb9c23f --date=short --no-merges --format='%ad %ae %s'
2018-11-19 mbonadei@webrtc.org Always compile VP9 source files.
2018-11-19 nisse@webrtc.org Delete class ChannelSendProxy
2018-11-19 danilchap@webrtc.org in RtcpTransceiver remove workaround for old bug in RtcpReceiver
2018-11-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 92e84c81..3efc758c (608282:609210)
2018-11-19 srte@webrtc.org Adds clamping to TimeDelta.
2018-11-19 srte@webrtc.org Adds scalar division to DataRate.
2018-11-19 mbonadei@webrtc.org Switch from RTC_DISABLE_VP9 to RTC_ENABLE_VP9.
2018-11-19 phoglund@webrtc.org Fix small issues that stops the Chromium DEPS roll.


Created with:
  gclient setdep -r src/third_party/webrtc@95adedb9c23f

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I770253a65f1315505eec116172139566298f2c45
Reviewed-on: https://chromium-review.googlesource.com/c/1341853Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609271}

There is no circumstance in which in an infinite loop actually ever
happens - especially not in production which doesn't use
StubCrosSettingsProvider - but in tests there is a bigger risk,
and it is currently only narrowly avoided.

This CL no longer notifies listeners when the value does not
actually change, which should prevent infinite loops of the form
where a listener tries to immediately write the same value
after it is notified of a change to that value.

See go/onsystemprefchanged for a longer explanation.

(In a different CL I want to make a change that exposes this
infinite loop problem, so I am fixing it first in this CL.)

Change-Id: Ie47ac2db905a54c4d6244e06b54471c36454583d
Reviewed-on: https://chromium-review.googlesource.com/c/1340305
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609270}

The sync data type USER_EVENTS is tied back to TYPED_URLS
when UnifiedConsent is enabled.

Code related to USER_EVENTS in the UnifiedConsentService is
removed. This is includes migration, rollback and metrics.

Bug: 905342
Change-Id: I0361d79c0df269410955ba46a13aaf62affac275
Reviewed-on: https://chromium-review.googlesource.com/c/1339867
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609269}

This function is not needed with a new UI where the user can manually
change username/password in a prompt. So it's not used on Desktop anymore.
But it's still used on Android and iOS. This CL implements the same logic
as in PasswordFormManager::Update.

Bug: 831123
Change-Id: I19edc5a6eddb9afb1d34d9d48bd0935fb551c184
Reviewed-on: https://chromium-review.googlesource.com/c/1340266Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609268}

If decrypting an update fails despite CanDecrypt() returning true, it's
safe to assume the data is corrupted. Hence, let's drop such update and
prevent the worker's update queue from being blocked indefinitely.

Bug: 873902
Change-Id: I01bc8271d2e1daa961f3136d8b5a21d4ecde1ced
Reviewed-on: https://chromium-review.googlesource.com/c/1341531Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609267}

This reverts commit 05672d8d.

Reason for revert: Test failures https://bugs.chromium.org/p/chromium/issues/detail?id=906587

Original change's description:
> Normalize Katakana to Hiragana in ScriptRunIterator
> 
> This patch normalizes Katakana to Hiragana in ScriptData, and
> thus in ScriptRunIterator.
> 
> There are 3 ICU script code for kana; USCRIPT_HIRAGANA,
> USCRIPT_KATAKANA, and USCRIPT_KATAKANA_OR_HIRAGANA. However,
> OpenType has only one 'kana' for all these 3 script codes.
> 
> When shaping, HarfBuzz handles the normalization. However,
> Blink splits the incoming string by the ICU scripts.
> Splitting these 3 scripts is not useful but consumes CPU
> and memory.
> 
> By normalizing in ScriptRunIterator, all types of Kana are
> in single run.
> 
> timeToFirstContentfulPaint:layout shows ~3% improvements
> https://pinpoint-dot-chromeperf.appspot.com/job/10d9760fe40000
> 
> though bink_perf.layout does not show much differences
> https://pinpoint-dot-chromeperf.appspot.com/job/14f19c00140000
> 
> This is probably because Katakana characters are not used
> much in `japanese-kokoro-insert` (written in ~100 years ago,)
> while they are more used in modern pages.
> 
> Bug: 636993
> Change-Id: If692bb575f2232b8fca10cd2ea87e3022debdf05
> Reviewed-on: https://chromium-review.googlesource.com/c/1337650
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609119}

TBR=eae@chromium.org,kojii@chromium.org,drott@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 636993
Change-Id: Icb14d6ad2a3453c9bfab9287e5c0a4995ac1c97f
Reviewed-on: https://chromium-review.googlesource.com/c/1341519Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609266}

A follow-up CL of https://crrev.com/c/1325271.

BUG=902661,903666

Change-Id: I877f4239ffb8ab92225086968dca5dbb729678cf
Reviewed-on: https://chromium-review.googlesource.com/c/1328541Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#609265}

Bug: 905971
Change-Id: I305358199844ecb0858bbd74e6fd4b888bf63966
Reviewed-on: https://chromium-review.googlesource.com/c/1341782Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609264}

This function makes |NGInlineNode::GetOffsetMapping()| to work with legacy
layout tree by changing |CollectInlinesInnternal()| not to call |LayoutInline::
UpdateShouldCreateBoxFragment()| when it is called for offset mapping since
we don't need to call |UpdateShouldCreateBoxFragment()| for offset mapping and
it set |IsInInlineFormattingContext()| bit flag in |LayoutObject| then causing
DCHECK().

This patch is a preparation of the patch[1].

[1] http://crrev.com/c/1337224 Utilize NGInlineNode::GetOffsetMapping() in Element#innerText

Change-Id: I0d7d844faa2581c24cd786f15ec066141c445e1b
Reviewed-on: https://chromium-review.googlesource.com/c/1341780Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609263}

https://drafts.csswg.org/css-values/#math-function-serialize-a-summation
Percentage should be serialized before dimensions with units

Also fix typo in WPTs svg/geometry/parsing/*-computed.svg
calc(50% + 60x) becomes calc(50% + 60px)

BUG=904805

Change-Id: I2ecb732564c405f9315a1ef06e5bd0777c407f19
Reviewed-on: https://chromium-review.googlesource.com/c/1341289Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609262}

This patch introduces const version of |NGPaintFragment::
LastForSameLayoutObject()| to avoid callers to use |const_cast| for improving
code health.

This patch is a preparation of the patch[1].

[1] http://crrev.com/c/1341776 [LayoutNG] Implement LayoutNG version of
{First,Last}CharacterAfterWhitespaceCollapsing()

Change-Id: I2dfad3861db1e93b89f5ca2441c2e222bee0181d
Reviewed-on: https://chromium-review.googlesource.com/c/1341775
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609261}

Bug: none
Change-Id: Ic8355b94db77c728535a68fd00947d44422b4604
Reviewed-on: https://chromium-review.googlesource.com/c/1341908Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609260}

Bug: 878949
Change-Id: Ic6197ff02354d53da9fec1193cd67e073b663d61
Reviewed-on: https://chromium-review.googlesource.com/c/1341436Reviewed-by: Leo Zhang <googleo@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609259}

https://android.googlesource.com/platform/external/perfetto.git/+log/acedb7bc166f..abd53ec26b11


git log acedb7bc166f..abd53ec26b11 --date=short --no-merges --format='%ad %ae %s'
2018-11-19 fmayer@google.com Merge "profiling: Use less strict memory order for sequence_number."


Created with:
  gclient setdep -r src/third_party/perfetto@abd53ec26b11

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I4cf5460f1b3301e017fa4691441e9daf030f53e8
Reviewed-on: https://chromium-review.googlesource.com/c/1341852Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609258}

This patch removes MessageLoop usage from base unittests *except* for the
following ones:

 - MessageLoop's own unit and perf tests
 - SequenceManager unit and perf tests (need to keep MessageLoop interop
   working for now)
 - FileWatcher (needs a controlled threading environment)
 - ObserverListThreadSafe (ditto)
 - TaskObserverPerfTest (measures MessageLoop overhead)
 - ThreadTest (Thread API needs updating)

These tests will eventually be migrated to the MessageLoop's
replacement or removed.

Bug: 891670
Change-Id: Ic32495a77819b9644cca823d64dea77754cf5c84
Reviewed-on: https://chromium-review.googlesource.com/c/1336147Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609257}

Large headers should not be counted, only large response bodies.

Bug: 906042
Change-Id: I941376f671ad63500e3676811ab74c80e659c0fa
Reviewed-on: https://chromium-review.googlesource.com/c/1340310Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609256}

It's always true in practice.
Unfortunately, the pre-GCM code is still not quite dead: The
ChromeOS-only TiclDeviceSettingsProvider still says to *not* use the
GCM channel by default.

Bug: 904782
Change-Id: I904db5088bd0e869343b8acf5bbb62cc7047c300
Reviewed-on: https://chromium-review.googlesource.com/c/1341831Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609255}

Service worker deletion and cache storage deletion have been
implemented years ago but these methods are not mentioned in the json.

Bug: 899216
Change-Id: I625748f6cbf4608c8b9430e84133d65ea1cd2530
Reviewed-on: https://chromium-review.googlesource.com/c/1301596Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609254}

Tests fail.

TBR=yosin@chromium.org

Bug: 906591
Change-Id: Idf84e8776005d0d00409f06816e930f6903f52a4
Reviewed-on: https://chromium-review.googlesource.com/c/1341521
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609253}

This rolls both projects at the same time because the GLFW build files
are in the Dawn repository and they had to be changed to account for
renames of GLFW source files.

Roll src/third_party/dawn/ 69b44ee6a..391c8a922 (4 commits)

https://dawn.googlesource.com/dawn.git/+log/69b44ee6a126..391c8a9224e5

$ git log 69b44ee6a..391c8a922 --date=short --no-merges --format='%ad %ae %s'
2018-11-19 cwallez Roll GLFW to pick up macOS Mojave fixes
2018-11-19 cwallez Roll Chromium's build system to fix Windows builds
2018-11-16 cwallez Run win-dawn-rel on the CQ
2018-11-16 jiawei.shao Support cube map and cube map array

Created with:
  roll-dep src/third_party/dawn

TBR=kainino@chromium.org
BUG=dawn:35

Change-Id: Ied363fe9a74d655c690cefcecdc897c5abcf28ff
Reviewed-on: https://chromium-review.googlesource.com/c/1341830Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609252}

Bug: 845472
Change-Id: Ia214b22388823eee5baa82ffaeb0224981b63a12
Reviewed-on: https://chromium-review.googlesource.com/c/1337610Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609251}

PasswordsSettingsTestCase.testManyPasswords is failing on
(ipad 5th gen ios 11.4.1).
It failed on this assertion every time:
https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm?rcl=e1d1f67d8f56f9f45b01db4d4f523dda21b05366&l=293

Not sure about the reason, cannot reproduce the failure locally.

Has filed a bug(crbug.com/906551) to track this.

TBR=noyau@chromium.org

Change-Id: I1a4d0bc62e5b16c7c3bad69b7587166ccd509bd8
Reviewed-on: https://chromium-review.googlesource.com/c/1341828
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609250}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3d3b79ec881f..0c1a474a0142


Created with:
  gclient setdep -r src-internal@0c1a474a0142

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ice4ef1ab2e518e8a96f6cd816a5b29b4b233b07f
Reviewed-on: https://chromium-review.googlesource.com/c/1341851Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609249}

This reverts commit ebf3a528.

Reason for revert: This change caused a regression in how caret is positioned in contenteditable areas with floats or multicolumns. 

Original change's description:
> Consider floats as HitTest candidate for selection
> 
> Selection with floats has a weird and unpredictable behavior. The root
> cause is that floats are not considered valid HitTest candidates.
> 
> There are many other cases where float elements are ignored when
> traversing the tree looking for the closes element to a specific
> LayoutPoint.
> 
> This patch address just one of this cases, where floats are children
> of a in-flow block-level box.
> 
> Bug: 758526
> Change-Id: I918af3ee21aa1070fa03a9fe1073205cc0a57300
> Reviewed-on: https://chromium-review.googlesource.com/643106
> Reviewed-by: Philip Rogers (OOO) <pdr@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#523410}

TBR=yosin@chromium.org,pdr@chromium.org,jfernandez@igalia.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 758526, 888424
Change-Id: Iba0f1641eeae63a52ef914b334cb302e69b7e7d9
Reviewed-on: https://chromium-review.googlesource.com/c/1271102Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#609248}

Bug: 895897, 801985
Change-Id: I3820e991ae28cefed045e143e2b199633d5d6514
Reviewed-on: https://chromium-review.googlesource.com/c/1328881Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609247}

This patch adds a title to the terms checkbox using the same style as
the payment request section titles.

R=arbesser@google.com, twellington@chromium.org

Bug: 806868
Change-Id: Ia13f80491ad062dcdc1e84d4dcd0cd7fb504cf63
Reviewed-on: https://chromium-review.googlesource.com/c/1340314
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609246}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/55d0017c..7aa42b4c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I34a68c28a15da444d26bead022f05a27dd1f5c09
Reviewed-on: https://chromium-review.googlesource.com/c/1340509Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609245}

[Autofill Assistant] Backend changes to the autofill assistant payment request in order to support collapsing PR sections.

This fixes a bug that prevented using expand(null) to collapse all PR sections.

Bug: 806868
Change-Id: Ia67b2c7fb778d05356927524ddbcd5c93a5ffa22
Reviewed-on: https://chromium-review.googlesource.com/c/1337330Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#609244}