GitLab

See https://docs.google.com/document/d/1DFKZsXCU4GySB9Ry8Bhd8k8sB7pO5wOz0GBcFmAq5B4/edit?pli=1#heading=h.9enkedn5nlfe
for details.

Bug: 982950
Change-Id: Ie1a83a9adff24b2fd56416bf5a11c153b3d21bc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772307
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692876}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/543a3b939df5..3fa35aa420ee

git log 543a3b939df5..3fa35aa420ee --date=short --no-merges --format='%ad %ae %s'
2019-09-03 wl@gnu.org * src/sfnt/sfwoff2.c (compute_ULong_sum): Fix undefined shift.

Created with:
  gclient setdep -r src/third_party/freetype/src@3fa35aa420ee

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
TBR=bungeman@google.com,drott@google.com,thestig@google.com

Bug: None
Change-Id: I983c3eb8fddf19c801b7fb9947e4760e211058f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783246Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692875}

Actually being able to add/edit the list of blocked sites (other than removing
existing blocks) from chrome://settings/content/filesystem behaves weirdly
and doesn't actually match what other settings are doing. So instead use
a read-only list.

Bug: 999753, 999754
Change-Id: Ic06129dcaeda380cc734154dbf6926fb19618968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779577Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692874}

Regardless of with or without subtest names

TBR=lpz

Bug: 1000441
Change-Id: I9aa9c773e796b07e4447c6b107f38bea692048a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783109Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692873}

Bug: 986808
No-Try: True
Change-Id: Ic6460697f1f64f822c550ad21ae04700446116d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783107
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692872}

TBR=carlosil@chromium.org

Bug: 1000446
Change-Id: Ie1b37cecf27ea6b4e6ea8e77ba8b057e036b6b6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783404Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692871}

When ScopedImageDecodeTasks complete, metrics will be uploaded for WebP,
JPEG and "Other" images types. The additional UMAs were added in a
previous commit.

Renderer4.ImageDecodeTaskDuration.Jpeg.{Software, Gpu}
Renderer4.ImageDecodeTaskDuration.Other.{Software, Gpu}

Bug: 995934
Change-Id: Ica1ce76ef96e6a490fb10022c6c4ffa5f3d51abc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769182
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692870}

Bug: 997835, 881099
Change-Id: I1fca272f48d11dce7897229f1c2259998d1f6d85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780337Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692869}

Fixes browertest failures that relied on the default mock network state to
be online by explicitedly setting it to online.

Bug: 999319
Change-Id: Iaff1cb156f9c913a6d09da3ca8c552a2adde46e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783141Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692868}

This change prepares for relaxing MSE addSourceBuffer and changeType
codec specificity per the non-normative guidance in the MSE
codec-switching incubation spec at [1], especially sections 3.5.7 and
10, whose text change for codec-switching is best viewed via the W3C
diff of the MSE REC spec vs the codec-switching incubation spec [2].

This preparation will allow later CLs to also enable implicit codec
switching (e.g., without explicitly calling changeType) in Chrome MSE.
Such implicit codec switching would still require the bytestream
format to remain the same (explicit changeType can be used to switch
bytestream formats).

It updates StreamParserFactory to understand and report one of
media::SupportsType values instead of boolean for support, and updates
usage of the updated implementation such that no behavioral change
should yet be observed with just this change. Forthcoming change(s) will
allow addSourceBuffer and changeType to succeed for incompletely
specified parameters (e.g. kMayBeSupported SupportsType value), while
retaining strictness throughout of MediaSource.isTypeSupported's
requirement for codec specificity.

This change also fixes a previous code style issue where
MIMETypeRegistry::IsSupportedMediaSourceMIMEType cast a boolean to an
enum and then implicitly converted that result back to a boolean.

BUG=535738

[1] https://github.com/WICG/media-source/tree/codec-switching
[2] https://services.w3.org/htmldiff?doc1=https%3A%2F%2Fwww.w3.org%2FTR%2Fmedia-source%2F&doc2=https%3A%2F%2Frawgit.com%2FWICG%2Fmedia-source%2Fcodec-switching%2Findex.html

Change-Id: I444e0f60c04e15df7299af0df932f4fa20b2e747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776902Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692867}

This reverts commit 22c7b0a0.

Reason for revert: Causing b/140266795.

Original change's description:
> Synchronize NavigableContentsView's LocalHostView focus w/ window focus.
>
> Previously, if the user clicked into the WebContents of an
> AssistantCardElementView, the corresponding RenderWidgetHostViewAura
> would become focused. However, the focused view in the Assistant view
> hierarchy (usually the Textfield in the Assistant Dialog Plate) wouldn't
> receive a blur event. As such, the user would think they could keep
> typing because of the blinking caret in the Textfield. When typing,
> they would find nothing entered and think keyboard was broken.
>
> Now, we synchronize the focus state of NavigableContentsView's
> LocalHostView with the associated native window so that as the native
> window subtree takes focus, so does the LocalHostView.
>
> This fixes AssistantCardElementView further upstream.
>
> Bug: b:134170714
> Change-Id: I03d67a3d9fbc779a87449065c97d7e4a877fe10a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649084
> Commit-Queue: David Black <dmblack@google.com>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#668077}

TBR=xiyuan@chromium.org,rockot@google.com,xiaohuic@chromium.org,dmblack@google.com,wutao@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:134170714, b:140266795
Change-Id: I4de99b2ef2c18bb503277fc4a528866b2c832764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778989Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#692866}

Years ago code was added to remove WS_MAXIMIZE property on dpi changes
as part of changes to workaround some fullscreen issues. That was done
in https://codereview.chromium.org/1707233002. Unfortunately, this one
piece of that change has some negative side effects in which the
browser window is incorrectly removed from maximize state and the
restore size is lost. Removing this property breaks the OS' knowledge
of the maximize state and prevents the OS from doing the right thing.

Bug: 951119
Change-Id: I9d594461b9b429b45ed219c28a3156009910ad45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778708Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#692865}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbaff379d261..bb6fc83a0777


Created with:
  gclient setdep -r src-internal@bb6fc83a0777

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: I5e81b80cccecf74916c023520976d5822776aaa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783337Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692864}

Claims that histogram as well as the sync-related histograms.

Claiming means becoming co-owner, adding warning about being
a co-owner, and setting expiration date to never.

Explicitly does not claim WithAccount and WithoutAccount, as
we don't need those.

Bug: 961157
Change-Id: I4f571c4efce4dc8d7031548ebfbd73cf977983b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754497
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Auto-Submit: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692863}

The implementation was assuming that |local_frame_| was a local frame root.

Bug: 1000035
Change-Id: I6e42c49c740ac4dce62775dd5af8c14b7dc59cc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782512
Commit-Queue: Erik Chen <erikchen@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692862}

This is a reland of f8ab5df9

The original (reverted CL) https://crrev.com/c/1778671 had one mistake:
it missed to remove the includes of the autogenerated file

  <out>/gen/content/public/common/buildflags.h in chrome/.

... that is now gone. Given that the bots do not do a full rebuild
(remove <out>/), CQ did not catch it.
This reland CL should fix it.

Original change's description:
> Move definition of kWebRtcH264WithOpenH264FFmpeg to Blink
>
> This is a precursor CL to Onion soup'ing
> content::RtcVideoEncoderFactory (phase 2.3 in the design document [1]).
>
> [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/
>
> Basically, it merged the definition and declaration of
> content/public/common/feature_h264_with_openh264_ffmpeg.cc|h
> into Blink's features.h. More specifically, to
> third_party/blink/public/common/features.h (declaration) and
> third_party/blink/common/features.cc (definition).
>
> This allows rtc_video_encoder_factory.cc|h to move to Blink in a
> follow up step.
>
> BUG=787254
> R=guidou@chromium.org, haraken@chromium.org, jam@chromium.org
>
> Change-Id: I4ba7c59da0f799e1d30053923fb1e692202223b6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778671
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#692757}

TBR=guidou@chromium.org

Bug: 787254
Change-Id: I479b07d13802e3cad25b57e8c7dbeee048db0fd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782514
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692861}

Bug: 977713, 987301
Change-Id: I7e0be3b3f8367be2f5f1e3d42f7b46a7f6b79b66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775188
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692860}

This CL drops the "Safety tip: " prefix from the safety tip bubble to
get us closer to our new mocks.

Bug: 996731
Change-Id: I1dfb629378e0becdeaf7222d78fb2e9616b42a5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782128Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692859}

TBR=rsleevi@chromium.org

Change-Id: I417640eee3feba3ca2205b20376a6d8b808d6f48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781534
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692858}

Mirror highlight path if a view has canvas flip for RTL enabled.
Remove unneeded inkdrop highlight code in system tray.

Bug: 997843
Change-Id: I4df02654d1fc25f5c8a93c59f36abe092fdf4f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771041
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692857}

These actions are no longer recorded.

Bug: None
Change-Id: I163d0ec558f57efd753cdd2d0f2cc3ff7906f14a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775361
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692856}

Avoid letting the focus jump from the password/PIN input field to the
"1" PIN keypad button when both fields are about to be hidden.

This case occurs when entering a security token PIN at the login/lock
screen into the user pod that uses challenge-response (a.k.a. smart
card) authentication. Without this CL, this quick focus jump led to
unexpected effect that the accessibility screen reader was saying
"ONE".

Fix this by swapping the visibility manipulation of the textfield and
the keypad, so that the keypad is hidden before the textfield and
therefore doesn't receive the focus during this UI update.

Bug: 990391
Test: enable ChromeVox, click on the smart card user's pod on the login screen, enter valid PIN, check that ChromeVox didn't say "one"
Change-Id: I2c3fa26580cb94f97b6f98290b2003b226929552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783138Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692855}

Bug: 1000409
Change-Id: I2917f7d8a63b14fc8f13e692ed12551f437e9c9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783245Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Connor Clark <cjamcl@google.com>
Cr-Commit-Position: refs/heads/master@{#692854}

It turns out the process used to load about:srcdoc was not always
correct. For instance, when starting from A(B), if B navigates to
about:srcdoc, it was sometimes loading in B's process instead of
A's process. This is now fixed and enforced.
This is not a regression. The previous code about srcdoc in
RenderFrameHostManager::CanSubframeSwapProcess() isn't really effective
when the about:srcdoc navigation happens AFTER a cross-process one.

Bug: 996044, 996725
Change-Id: I670ee6dc917cfe4cb02721a58a79a1a415b45e61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773264Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692853}

Always set the override size instead of checking whether
we need to, no downside to doing that and code is a bit simpler, and
move this setting to *before* calling CanAvoidLayoutForNGChild, so
that it actually does the right thing.

Also make the code in the condition not overwrite whether we need
layout, just add to it. This may have been a bug but I don't have
a broken testcase.

R=dgrogan@chromium.org, eae@chromium.org

Change-Id: If5b1d69a4307720c40f620d7a76b2e5222f1719c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779129
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692852}

Adding accessibility identifier in the link in the user consent view.
Updating ChromeSigninViewControllerTest to use this identifier.

Bug: 1000357
Change-Id: I327a93f2da0e79ed7bd300bb943b323bf3ae21e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782804
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692851}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/23c7a63c..e576e759

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I062ac15730aa5537291e1a25439f8c465fe05d1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782723Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692850}

The margin for small config is different than other (2 instead of 4), so
it cannot be just hardcoded in folder_image.

Updates how item image offset from the center of the folder icon is
calculated to 1/2 (item icon size + item margin), which matches the new
spec.

It's little different from the existing logic, where the item icon is
inset by 2 dip from the folder icon edge, but the numbers match for the
current (kShared) config.

BUG=996808

Change-Id: I4b5ffab257055d89ec612e60076af6cf6e24f841
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779668Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692849}

Bug: 999391
Change-Id: If2c808eaff4df58729f5fdb11d0a33b4aec25419
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782675Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692848}

Record a pref when the user closes the banner so we don't show it every
time.

Screenshot: http://screen/McRQaMqm23c
With secondary user banner: http://screen/tFGqMWtwCbm
Secondary user banner only: http://screen/eARAncc5nHS

Bug: 1000307
Change-Id: I1134301e1b8a84b71fa83a5994b6fa1aafbdd5ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783060Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692847}

Currently the notification entry is inserted into stl container after
loading the icon, which causes the background task coordinator failed
to find the notification and won't trigger any background task.

This CL inserts the entry when all asynchronous opeartions are done,
and reply the result in a callback.

This behavior should be covered with end to end test.

Bug: 998998
Change-Id: I00d9f3b8c3f6b93c37fa8d93dc319e0c1aa91f11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779567Reviewed-by: Hesen Zhang <hesen@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692846}

Similar to the work done for WebP YUV decoding, we would like to
implement direct decoding of JPEG 4:2:0 images to YUV rather than RGB
for non progressive JPEGs.

BUG: 919627
Change-Id: Ie6522e51204a0013b1db7b0635bed5cdb847baa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768817
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692845}

Failure is expected when the GL context is lost and so we should not
assert as Skia's default handler does.

Bug: 999327
Bug: 1000384
Change-Id: Iab2bd55a674e5143ec006959889a462511cdeabf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783297Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#692844}

After updating aria-hidden to false on ancestor, the table row and cell
roles need to be updated.

Bug: 928384
Change-Id: I57cbda12b3f7de9170fc007eb1561f5ccf2eb93c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776400
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692843}

This is never true, as LocalFrameView is no longer a ScrollableArea.

Change-Id: Ic190ce31bf4f13baa6a0f6a7a439511551011a80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783220
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692842}

This is essentially a hack to fix crbug.com/995806. The HTML spec says that
the clock for animations is only updated once per rendering lifecycle, at the
start. However the spec also assumes that the user agent runs rendering
lifecycles constantly, back-to-back. In Blink we attempt to *not* run rendering
as much as possible, to avoid unnecessary CPU usage. Unfortunately that then
means that when we are outside of the lifecycle, e.g. in a setInterval, the
AnimationClock time no longer updated after https://crrev.com/629180f !

This is a short-term fix for that problem, by re-introducing the old dynamic
self-update behavior - but only when outside of rendering lifecycles. Note
that it may still have an effect on the overall time, as the logic sometimes
guesses too far and the next real frame may have an older time than we updated
the clock to. In that case there would be a discrepancy between the animation
clock time and things like the rAF timestamp, but it isn't the worst bug in
the world.


Bug: 995806
Change-Id: I66642c28026c9370c73b5ce4d7db2fa2981ec7e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778598Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692841}

https://android.googlesource.com/platform/external/perfetto.git/+log/2bacc9ef457f..042f99bcb1d4

git log 2bacc9ef457f..042f99bcb1d4 --date=short --no-merges --format='%ad %ae %s'
2019-09-03 treehugger-gerrit@google.com Merge "Send proto instead of text when tracing an Android device with webUSB"

Created with:
  gclient setdep -r src/third_party/perfetto@042f99bcb1d4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Ie2d4c4469020297cdcdce6aa1f74a6bdad621a75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783248Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692840}

This CL modifies SkiaOutputDevice to support more than one swap
operation in flight. It also enables triple buffering for
SkiaOutputDeviceBufferQueue.

Bug: none
Change-Id: I25bd07caa4ae28fcfbb5b1502682763b5ee76bec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779001
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692839}

This patch moves SVGLengthInterpolableType from the deprecated
list-of-numbers model to the newly introduced InterpolableLength, to
avoid handling details of length values directly.

It also paves the way to supporting SVG length interpolation on
values involving comparison functions min/max.

Note: this patch has no behavior change in MaybeConvertSVGLength. The
old code relies on AccumulateLengthArray(), which doesn't support
unitless lengths in math expressions (e.g., calc(1px + 1)). This patch
doesn't change it, but simply rewrites it and tracks it with a TODO.

Bug: 991672
Change-Id: I50c0a6f2609daf477b5f7970c6c898e5531668bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775736Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692838}

chrome://flags http://screen/Lo55W5zX19F
chrome://flags/enterprise http://screen/93FCOP69fGG

Bug: 999089
Change-Id: Id6018d21283ef40b7e94e1e79eb74b9c104583f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779189
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692837}