GitLab

BUG=249976

Review-Url: https://codereview.chromium.org/1920433003
Cr-Commit-Position: refs/heads/master@{#412563}

Currencies such as JPY do not have fractions by default. If the
website is using web payments with an amount like "500", then
UI should show only "500", without any decimals.

BUG=638480

Review-Url: https://codereview.chromium.org/2246923006
Cr-Commit-Position: refs/heads/master@{#412562}

Remove expectations for compositing/overflow/reflected-overlay-scrollbars-should-appear-without-compositing.html

The test seems to be passing consistently.

TBR=vollick@chromium.org
BUG=396775,636475

Review-Url: https://codereview.chromium.org/2253893002
Cr-Commit-Position: refs/heads/master@{#412561}

This reverts commit 7ce3db95 and relands
22f8a43c without changes. I believe the
failure would be fixed after the bots are clobbered.

Original Description:

This class handles output protection query and request in the browser
process on all platforms. On ChromeOS, it delegates the operations on
the hardware displays to OutputProtectionDelegate. On other platforms,
it does not check hardware displays. On all platforms, it checks
whether there is any network link and adds it to the existing link mask.

This class will also be used to implement mojo OutputProtection service
on all platforms.

This CL also updated PPAPI cdm adapter and PPAPI code to enable output
protection calls on all platforms. A unit test is added via external
clear key tests.

TBR=ddorwin@chromium.org, jrummell@chromium.org, oshima@chromium.org, bbudge@chromium.org
BUG=592122, 589618, 623214
TEST=Added new tests.

Review-Url: https://codereview.chromium.org/2094903005
Cr-Commit-Position: refs/heads/master@{#412560}

Add policy declaration for using of Location Service

BUG= b/30469058
TEST=policy and browser tests extended.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

patch from issue 2225933002 at patchset 20001 (http://crrev.com/2225933002#ps20001)

Review-Url: https://codereview.chromium.org/2243513002
Cr-Commit-Position: refs/heads/master@{#412559}

https://chromium.googlesource.com/skia.git/+log/ff863bc550a8..d24ee1419f17

$ git log ff863bc55..d24ee1419 --date=short --no-merges --format='%ad %ae %s'
2016-08-17 fmalita [SVGDom] Add <line> support
2016-08-17 robertphillips Cast for fuzzer complaint
2016-08-17 jvanverth Add alternative ambient shadow method to Android shadow sample
2016-08-17 halcanary SkPDF: pull out SkPDFMakeCIDGlyphWidthsArray.cpp
2016-08-17 rmistry Add gerrit config lines to cq.cfg

BUG=637187

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2253933002
Cr-Commit-Position: refs/heads/master@{#412558}

Revert of Implement BluetoothGattNotifySession::Stop on Android (patchset #33 id:640001 of https://codereview.chromium.org/2051333004/ )

Reason for revert:
Suspect of breaking https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/2450

[345/345] BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged (TIMED OUT)
6 tests timed out:
    BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1931)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1026)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_Multiple (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1067)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_OnIndicate (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1039)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_OnNotifyAndIndicate (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1054)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_Reentrant_Success_Success (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1217)

Original issue's description:
> Implement BluetoothGattNotifySession::Stop on Android
>
> This change enables the stopNotifications function for remote GATT
> characteristics on Android. In order to do so, two distinct refactorings have been done;
>
> 1) The session classes have been simplified so that platform specific versions are no longer required. All code that previously used BluetoothGattNotifySession[Mac|Win|BlueZ] now simply use the base BluetoothGattNotifySession class.
>
> 2) BluetoothRemoteGattCharacteristic::StartNotifySession and StopNotifySession have been rewritten so that all the code for keeping track of the different session objects and the notification state sits in the base class. Inheriting classes should no longer override these two functions, but instead override the much simpler SubscribeToNotifications and UnsubscribeFromNotifications.
>
> BUG=584370
>
> Committed: https://crrev.com/d41af3adfd8500c81c827ab03ed2736909cf1ee8
> Cr-Commit-Position: refs/heads/master@{#412498}

TBR=ortuno@chromium.org,rkc@chromium.org,msarda@chromium.org,sacomoto@chromium.org,tommyt@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584370

Review-Url: https://codereview.chromium.org/2241263005
Cr-Commit-Position: refs/heads/master@{#412557}

Changes match the logic in SourceHighlighter in the same file and will
result in UI showing message akin to 'No source file available'. This is fine
as already the same happens for other source files in bundled extensions.

BUG=627896

Review-Url: https://codereview.chromium.org/2245143004
Cr-Commit-Position: refs/heads/master@{#412556}

As a safety mechanism, this CL introduces throttling mechanism for
thumbnail fetching for articles for you on mobile NTP. Per default, the
quota is unlimited but can be easily decreased by finch.

Since all thumbnail requests are user initiated (by scrolling below
the fold), the CL also extends the throttler to support separate quota
for interactive requests (previously called "forced").

Lastly, it fixes a bug that the callback passed in in FetchSuggestionImage() got called with a wrong id (with the ID of the snippet "[url]" and not with the ID of the suggestion "[category_id]|[url]").

BUG=627073

Review-Url: https://codereview.chromium.org/2227973002
Cr-Commit-Position: refs/heads/master@{#412555}

BUG=636523

Review-Url: https://codereview.chromium.org/2230183005
Cr-Commit-Position: refs/heads/master@{#412554}

Apply the same resizing method to the reference result as is used on the test.

R=ajuma@chromium.org
BUG=245556,636475

Review-Url: https://codereview.chromium.org/2232373003
Cr-Commit-Position: refs/heads/master@{#412553}

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related target for all pointerevents (similar to mouseevent) should be null except for boundary events. So relatedTarget can be removed from some of the functions as they don't send boundary events.

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2227563003
Cr-Commit-Position: refs/heads/master@{#412552}

Clang warns about this.

BUG=82385
R=rnk@chromium.org
TBR=primiano

Review URL: https://codereview.chromium.org/2258503002 .

Cr-Commit-Position: refs/heads/master@{#412551}

WKWebView returns NSError if script evaluation result type is not
supported. Since all scripts are wrapped into anonymous function,
autofill should be wrapped too.

BUG=None

Review-Url: https://codereview.chromium.org/2242353002
Cr-Commit-Position: refs/heads/master@{#412550}

Move some files and unit tests from chrome/browser/spellchecker/ and
android-specific java code to the spellcheck component. This move
generally includes the android slice of spellchecker.

In particular in this patch:
 - move the relevant chrome/browser/spellchecker files and unit tests
 - move the android java files and create proper jni registrar
 - isolate spellcheck preference constants into separate files
 - properly initialize "java_object_initialization_failed_" in
   spellchecker_session_bridge_android.cc
 - update references in the code base
 - update and create build files

The main motivation behind the componentization of the spellcheck
feature is that we want to make it available in Android WebView.

Preceding spellcheck componentization patches:
[1] https://codereview.chromium.org/2166683003/
[2] https://codereview.chromium.org/2177343002/
[3] https://codereview.chromium.org/2198143002/

BUG=583616, 629609
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2244083002
Cr-Commit-Position: refs/heads/master@{#412549}

Use methods which returns id instead of deprecated methods which return
NSString. JS execution API returned NSString because that was the only
supported option from UIWebView. Now WKWebView returns id which should
be used everywhere.

BUG=595761

Review-Url: https://codereview.chromium.org/2247973002
Cr-Commit-Position: refs/heads/master@{#412548}

Cleaning fast/events media tests to use
testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2246223004
Cr-Commit-Position: refs/heads/master@{#412547}

An out-of-flow positioned object that "belongs" to a line may need to adjust
its block position after the line has been laid out, since the line may have
been pushed to the next fragmentainer by a pagination strut.

BUG=291616

Review-Url: https://codereview.chromium.org/2249853007
Cr-Commit-Position: refs/heads/master@{#412546}

This tool is meant for testing of NetworkChangeNotifier and ProxyConfigService.

R=mmenke

Review-Url: https://codereview.chromium.org/2253023002
Cr-Commit-Position: refs/heads/master@{#412545}

These were using an incorrect path to the shadow tests.

BUG=638323
TBR=kbr@chromium.org,zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2252083002
Cr-Commit-Position: refs/heads/master@{#412544}

As of crrev.com/2238693002 we need to set cc::Display as visible
explicitly otherwise nothing gets drawn. Currently nothing gets drawn to
screen in mash, this is a quick fix.

BUG=none

Review-Url: https://codereview.chromium.org/2253083002
Cr-Commit-Position: refs/heads/master@{#412543}

1, launches the Generic First Run Experience when the Lightweight First Run Experience is active.
2, launches the Generic First Run Experience when the Generic First Run Experience is active.
3, lets ChromeTabbedActivity checks and launches the Generic First Run activity for tabbed mode.
4, launches the Generic First Run Experience for View Intents from GSA.
5, launches the Lightweight First Run Experience for View Intents with URLs from other Apps.
6, skip the Generic First Run Experience in ChromeTabbedActivity if ChromeLauncherActivity has launched the Lightweight First Run Experience.
7, force trigger the Generic First Run Experience when Chrome is started via Chrome icon or intent from GSA if things went wrong.

BUG=631453,627065,626998,627003,628096

Review-Url: https://codereview.chromium.org/2237293003
Cr-Commit-Position: refs/heads/master@{#412542}

When the user movers the cursor over the minimize/maximize/close
buttons, DWM paints them in a hover state. If the user subsequently
moves the cursor out of the window, DWM was not repainting the icons
with the unhovered state because Chrome ate the WM_NCMOUSELEAVE
message.This change notifies DWM of the exit.

BUG=637114
TEST=Unmaximize Chrome. Hover Red-X at top right. Fling mouse upward.

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2244263002
Cr-Commit-Position: refs/heads/master@{#412541}

Currently the option "gnome" is ambiguous between Keyring and Libsecret.
The two new options, "gnome-keyring" and "gnome-libsecret" allow
targeting those implementations individually.

Since password manager and OSCrypt both use this switch to select their
backends, the selection logic has been turned into a common util, to
avoid code duplication.

BUG=602624

Review-Url: https://codereview.chromium.org/2256633002
Cr-Commit-Position: refs/heads/master@{#412540}

This CL splits HTMLFormElement::m_isSubmittingOrInUserJSSubmitEvent into
m_isSubmitting and m_inUserJSSubmitEvent.

- This is a preparation to fix crbug.com/196640.
- Use WTF::AutoReset, which can't apply to bitfields.
- This has no behavior changes.

BUG=196640

Review-Url: https://codereview.chromium.org/2245263005
Cr-Commit-Position: refs/heads/master@{#412539}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/efd25f3722eb..56e262f146e4

$ git log efd25f372..56e262f14 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2252073002
Cr-Commit-Position: refs/heads/master@{#412538}

https://chromium.googlesource.com/skia.git/+log/bf63e616a67e..ff863bc550a8

$ git log bf63e616a..ff863bc55 --date=short --no-merges --format='%ad %ae %s'
2016-08-17 reed move private test for sect_with_horizontal into unittests

BUG=638575

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2251693004
Cr-Commit-Position: refs/heads/master@{#412537}

RenderViewHost is deprecated. Most ExtensionFunctions were updated
awhile back, but there were still some lingering ones. It looks like
one more (zooming in the file manager) can be safely removed.

BUG=498017

Review-Url: https://codereview.chromium.org/2204393002
Cr-Commit-Position: refs/heads/master@{#412536}

If |inner_html| is nil then comparing location with NSNotFound will
return YES. In Objective-C rangeOfString: must always compare length
with 0 instead because calling methods on nil return 0.

This bug was not exposed before because JS execution API could never
return nil and rangeOfString: worked correctly on empty strings.

BUG=637819

Review-Url: https://codereview.chromium.org/2254553003
Cr-Commit-Position: refs/heads/master@{#412535}

BUG=638238

Review-Url: https://codereview.chromium.org/2248083002
Cr-Commit-Position: refs/heads/master@{#412534}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e5e6dcc8..6c31b348

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2250333003
Cr-Commit-Position: refs/heads/master@{#412533}

This test used testharness.js instead of js-test.js
in server-side-imagemap and webgl-teximage2d.

BUG=637859

Review-Url: https://codereview.chromium.org/2253513005
Cr-Commit-Position: refs/heads/master@{#412532}

The last usage was removed in crrev.com/398655 when mojom events stopped
being used.

BUG=none

Review-Url: https://codereview.chromium.org/2250273002
Cr-Commit-Position: refs/heads/master@{#412531}

Its arguments list does not depend on the order and
the index of '--'.
This change enables us to update the .py file step by step.

BUG=634231

Review-Url: https://codereview.chromium.org/2248363002
Cr-Commit-Position: refs/heads/master@{#412530}

TBR=mattm@chromium.org
BUG=638557

Review-Url: https://codereview.chromium.org/2258453002
Cr-Commit-Position: refs/heads/master@{#412529}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ca7ccf52377f..efd25f3722eb

$ git log ca7ccf523..efd25f372 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2247773006
Cr-Commit-Position: refs/heads/master@{#412528}

Final cleanup and tests for supporting [OriginTrialEnabled] applied
directly to a partial interface.

BUG=585656

Review-Url: https://codereview.chromium.org/2252763002
Cr-Commit-Position: refs/heads/master@{#412527}

https://chromium.googlesource.com/skia.git/+log/422310ddbe4d..bf63e616a67e

$ git log 422310ddb..bf63e616a --date=short --no-merges --format='%ad %ae %s'
2016-08-17 egdaniel Add mssa configs for vulkan, and simple bug fix
2016-08-17 caryclark fix fuzz

BUG=638496

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2256673002
Cr-Commit-Position: refs/heads/master@{#412526}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/3cf1448..933964d

$ git log 3cf1448..933964d --date=short --no-merges --format=%ad %ae %s
2016-08-17 danilchap@webrtc.org StartTimestamp generated randomly in RtpSender constructor instead of not-randomly at SetSendingState(true) Renamed to timestamp_offset_ to better match meaning of the variable.
2016-08-17 ehmaldonado@webrtc.org Fix get_landmines.py script.

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2254703004
Cr-Commit-Position: refs/heads/master@{#412525}

This is an interim step to handle FeaturePolicy-enabled features, before the
three conditional feature flags (RuntimeEnabled, OriginTrialEnabled and
FeaturePolicy) are eventually combined into a common 'Feature' attribute.

BUG=638240

Review-Url: https://codereview.chromium.org/2247923004
Cr-Commit-Position: refs/heads/master@{#412524}