GitLab

BUG=672263

Review-Url: https://codereview.chromium.org/2949343002
Cr-Commit-Position: refs/heads/master@{#486209}

Ref: https://codereview.chromium.org/2450963002/

The reason for this CL is that when I tried to turn PVer4 as default
on bots, the bots started failing. The reason for those failures is
that the tests in SafeBrowsingServiceTest instantiate PVer3-like
DB manager explicitly, but the base::feature list says that PVer4
is enabled.

The fix is to check the method on the DB manager, instead of the
feature list, inside chrome_subresource_filter_client.cc


Bug: 543161
Change-Id: I4c7772248c36f78fcac530ea15cd90b9e24ea382
Reviewed-on: https://chromium-review.googlesource.com/567394Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486208}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6c40c273a7fe..1286055c7baf

$ git log 6c40c273a..1286055c7 --date=short --no-merges --format='%ad %ae %s'
2017-07-12 adithyas Add table for Blink RuntimeCallStats
2017-07-12 bpastene devil: Add a device_utils method to mv-then-rm a device file.
2017-07-12 nednguyen Rename webpagereplay_go.py to webpagereplay_go_server.py
2017-07-12 nednguyen Add WPR go binary for Mac platform
2017-07-12 bpastene devil: When pushing data deps to device, don't mkdir redundantly.
2017-07-12 simonhatch Dashboard - Fix test-picker add button never un-greying
2017-07-12 simonhatch Dashboard - Add api_request_handler
2017-07-12 etienneb Fix symbolisation for address out-of-range

Created with:
  roll-dep src/third_party/catapult
BUG=724543,739899,739899,739783


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I114d56bf15f445060eb48951a120fd99819e0024
Reviewed-on: https://chromium-review.googlesource.com/569138
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486207}

This makes UKM able to be enabled on Android when no Incognito windows
are open.

BUG=739971

Change-Id: I310d540d59594bc3377adf9eedb8c05502c5f5bb
Reviewed-on: https://chromium-review.googlesource.com/566241
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486206}

Previously, almost all usages of OffsetAdjuster applied a post-processing
step to clamp the resulting offsets to a "sane" range.

This refactor moves the clamping into the base function, but as an
optional parameter.

This also reduces the API surface by removing the LimitOffset class.

BUG=732582

Review-Url: https://codereview.chromium.org/2953943003
Cr-Commit-Position: refs/heads/master@{#486205}

WallpaperController in ash needs access to local state for color caching.
Whether or not we combine WallpaperManager and WallpaperController, we'll
need local state to be accessible to ash just as user pref is.

Bug: NONE
Change-Id: I8360402864d0cdb173f3a84731d6abdeaf12a4ce
Reviewed-on: https://chromium-review.googlesource.com/566026
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486204}

Currently, MediaPlayerRender has no way of knowing whether or not the
RenderFrameHost that created it has been destroyed. MediaPlayerRender
only gets notified when the RenderFrame gets destroyed, and
MojoRendererService detects that the other end of the connection has
been closed. It is possible for MediaPlayerRenderer to still be
initializing when the RenderFrameHost has been destroyed. This leads to
crashes when trying to access RenderProcessHost resources when trying to
create a MediaResourceGetter.

This CL removes the unsafe passing of a RenderFrameHost*, adds a check
to see whether the creating RFH is still alive, and gets the
RenderProcessHost directly from its ID.

Bug: 675584
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ie8c9936dc0f3e132cc63cadf3bb3ebcf464621c1
Reviewed-on: https://chromium-review.googlesource.com/525133Reviewed-by: Chris Watkins <watk@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486203}

This is ongoing refactoring of offline pages, in order to remove/isolate
Android-specific dependdencies. In this case, it's just a result
of:
tools/git/move_source_file.py chrome/browser/android/offline_pages/offline_page_bookmark_observer.* chrome/browser/offline_pages/

Bug: 722467
Change-Id: I35ecde79bee6b6fba7d7c27d75c5fb7be1799c00
Reviewed-on: https://chromium-review.googlesource.com/568565Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486202}

This fixes a test failure caused by https://chromium-review.googlesource.com/c/567235.

Bug: 672263
Change-Id: I861f8170827f60e3aab7abdf56c1da35d8b6bb92
Reviewed-on: https://chromium-review.googlesource.com/569068Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486201}

Bug: 740871
Change-Id: Ica5bcd76a3f2995a8f414c80698e468f8780734c
Reviewed-on: https://chromium-review.googlesource.com/568595Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486200}

https://skia.googlesource.com/skia.git/+log/1c8bb8a4c63c..d425a1d013b6

$ git log 1c8bb8a4c..d425a1d01 --date=short --no-merges --format='%ad %ae %s'
2017-07-12 halcanary SkPDF:  start to support AlphaOnly Images as masks.
2017-07-12 egdaniel Add arc support to gpu Obj c++ code
2017-07-12 halcanary SkPDF: simplify drawImage/Bitmap/Sprite code.
2017-07-12 fmalita Add some raster pipeline perspective asserts
2017-07-12 herb Experimental blur code with 32 bit fix.
2017-07-12 brianosman On Windows, always re-create window for GL or Vulkan
2017-07-12 brianosman Move expensive initialization to onOnceBeforeDraw
2017-07-12 bsalomon Revert "Revert "Make DashOp a non-legacy GrMeshDrawOp.""
2017-07-12 reed remove references to kIndex_8_SkColorType from our tools/tests
2017-07-12 liyuqian Implement Sk4i's abs, min, max
2017-07-12 brianosman Extend final point in closed degenerate hairline segments
2017-07-12 bsalomon Fix assert in lattice op triggered by GLProgramsTest
2017-07-12 fmalita Clarify adjustMatrixAndAppendStages semantics
2017-07-12 bsalomon Revert "Make DashOp a non-legacy GrMeshDrawOp."

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=ethannicholas@chromium.org

Change-Id: I832b49480e40cf659d748c618f7d2ee687a4bc0c
Reviewed-on: https://chromium-review.googlesource.com/569010Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486199}

Change-Id: I73a4bca08180684a447a1e41c4e268e322a8492d
Reviewed-on: https://chromium-review.googlesource.com/568714Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486198}

ImageQualityController used heuristics to draw resizing images at a lower
quality during resizes, then snap them to high quality once resizing stops.
This was needed for performance of high-quality image scales in the past, but
is less useful today because images are never scaled with a high quality filter.

This patch completely removes the ImageQualityController which has the
following benefits:
1) One less virtual on ImageResourceObserver.
2) No more visual snap as image quality changes (https://crbug.com/503040).
3) A call removed from LayoutBoxModelObject::WillBeDestroyed.
4) Much complexity removed.

[1] https://chromium-review.googlesource.com/c/541609/

Bug: 503040, 734215
Change-Id: I6552767925887b3154a99339976a4b624e64bac5
Reviewed-on: https://chromium-review.googlesource.com/567564Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486197}

Bug: 740993
Change-Id: I742b2aa94048e55204d204e0ce6fcaee7b0af6d8
Reviewed-on: https://chromium-review.googlesource.com/567776
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486196}

After some offline discussion, we felt that we shouldn't have files
directly in the common directory so that we can better control DEPS.

This CL moves SurfaceId, FrameSinkId, LocalSurfaceId, FrameSinkIdAllocator,
and LocalSurfaceIdAllocator to the components/viz/common/surfaces directory
and updates includes.

TBR=tsepez@chromium.org

Bug: 722935
Change-Id: I7d301b277dbf07ead10ec96771ee64469d2bcbac
Reviewed-on: https://chromium-review.googlesource.com/568372Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486195}

Bug: 689520
Change-Id: I65b372857d44c52f97986d02598c74db8d423312
Reviewed-on: https://chromium-review.googlesource.com/567783Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486194}

Change-Id: I84cc5a2fb6b09daa12fe4560664773cfaf635d54
Reviewed-on: https://chromium-review.googlesource.com/569078Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Scott Nichols <nicholss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486193}

to avoid file io.

Bug: 740801
Change-Id: I64c21aabb75bdc8cd2926a665fad9ab2bccfe1d9
Reviewed-on: https://chromium-review.googlesource.com/567396Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Michael Nordman <michaeln@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486192}

This verifies the potential for use-after-free that can occur if the
WaitableEventWatcher is deleted after the event is signaled but before the
callback is run.

Bug: 681167
Bug: 741256
Change-Id: Ic5ca2bc48cb51d5f50be7e67773f8213fbbc80d3
Reviewed-on: https://chromium-review.googlesource.com/568371
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486191}

Bug: none
Change-Id: I1121e7b64cceb1c70e9a8115d9f9cc9d63716133
Reviewed-on: https://chromium-review.googlesource.com/568903Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486190}

1. Added a dummy FontMgr for Fuchsia
2. Fixed libjpeg_turbo linking issues (ELF wasn't defined)

Bug: 737802
Change-Id: I3a48e448fd03a350130680ced5fafc309fc00ae9
Reviewed-on: https://chromium-review.googlesource.com/567032
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486189}

BUG=740750

Change-Id: I7bdc4934dd8ace5c4ce317b6f7f48fe8c73ec5dc
Reviewed-on: https://chromium-review.googlesource.com/565964
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486188}

WebUSB should be using this method to detect whether Feature Policy is
enabled for consistency with other features.

Change-Id: Iea40bcf45f37c0cd432c75ecff5400f4928c7088
Reviewed-on: https://chromium-review.googlesource.com/568850Reviewed-by: Luna Lu <loonybear@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486187}

changes:
(1) refactor AppsGridView's ctor to accept ContentsView*.
(2) move all apps indicator from AppsContainerView to AppsGridView.
(3) host suggested_apps_indicator_, all_apps_indicator_, and
suggestions container view in AppsGridView.
(4) for all apps layout, the first page is 4*5 and all others are 5*5.
(5) update keyboard arrow moving focus for new launcher. See focus
rules in inline comments.
(6) refactor AppsGridViewTest by creating app_list_view_ to test
AppsGridView, also make it parameterized tests to test
EnableFullscreenAppList. Most of the tests are opened for both old
and new launcher.
(7) add tests: CreatePage, HandleSuggestionsMove, 
MoveSelectedOnAllAppsTiles.

UI specification: https://screenshot.googleplex.com/ebJ2ug1xS9Z.

flag, screenshot: https://screenshot.googleplex.com/AbpxexGtKNj
keyboard moving focus works as expected.
also added test coverage.

Bug: 735702
TEST: tested with and without --enable-features=EnableFullscreenAppList
Change-Id: I7fe602c84bdeb8f659013de76285fb2dca9f6ec3
Reviewed-on: https://chromium-review.googlesource.com/564485Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486186}

QuicCryptoClientStream and QuicCryptoServerStream are refactored to delegate
their implementations to a CryptoClientStreamDelegate or
CryptoServerStreamDelegate, and the existing implementations are moved to new
subclasses of the new delegates.

The major work left to do in this refactor is for QuicCryptoStream to no longer
implement CryptoFramerVisitorInterface and to remove the OnHandshakeMessage
method from CryptoClientStreamDelegate and CryptoServerStreamDelegate
interfaces.

Merge internal change: 161549072

Change-Id: I3919d067028cdacd939c64be4362d4645d7e7e65
Reviewed-on: https://chromium-review.googlesource.com/565978
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486185}

- Changed user gesture check from SecurityError to NotAllowedError.
- Throw a TypeError if no recognised fields in the ShareData dictionary.
- IDL: Made ShareData parameter optional (no behavioural effect, other
  than changing Navigator.share.length from 1 to 0).

Removed 3 tests that now fail. These have been converted into automated
tests in WPT so we are still running them, but they are upstream.

Fixed failing WPTs and removed expectations of failure.

Bug: 738956, 738957
Change-Id: I2146a3dc98dd30dc591ea9ccaedf436ca1111531
Reviewed-on: https://chromium-review.googlesource.com/558595Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486184}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8b00387a..a51d9227

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I69b85f67e71401ff957b447854a25f62af77507a
Reviewed-on: https://chromium-review.googlesource.com/568804Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486183}

Certain errors can put leveldb in a mode where all future writes will
automatically fail. If we detect such a situation (because too many consecutive
commits failed) clear out the entire database and start fresh.

Existing renderers that were connected to a LevelDBWrapper already will be
disconnected, resulting in localstorage in those renderers (for origins that
were opened) to now be disconnected from eachother and from potential future
renderers/origins. Connections to localstorage from new renderers or for
new origins in existing renderers will end up going through the database,
and should work normally.

Bug: 712399
Change-Id: Ie38020a33ce383fd43513d1cca22afbe7180fecf
Reviewed-on: https://chromium-review.googlesource.com/533720
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486182}

Using wpt-import in Chromium 383b95ed.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/306

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
chcunningham@chromium.org, wolenetz@chromium.org:
  external/wpt/media-source
dom-dev@chromium.org:
  external/wpt/html
hta@chromium.org:
  external/wpt/webrtc

TBR: qyearsley@chromium.org
No-Export: true
Change-Id: I36f7fa640ecf332e2595472d1715f0da4432212c
Reviewed-on: https://chromium-review.googlesource.com/568373Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486181}

These will be implemented in WebRTC soon (https://codereview.webrtc.org/2964593002/).

Change-Id: Ic1fd11f3463d8fe29b157cdf3095386b33489940
Reviewed-on: https://chromium-review.googlesource.com/563833Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Zach Stein <zstein@google.com>
Cr-Commit-Position: refs/heads/master@{#486180}

Add the capability for clients to be notified when the service fails
initialization.

Bug: 735347
Change-Id: Id274a68c76893ae2286f1f9945a1255d8b592aaa
Reviewed-on: https://chromium-review.googlesource.com/542476Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486179}

This flag was removed long ago in https://crrev.com/35503005 but remains
as a flag in the Android virtual test suite. This patch removes it, it
should be a no-op.

Bug: 285397
Change-Id: I5e99d279e96baea3b495150f19b4e52a193a92d1
Reviewed-on: https://chromium-review.googlesource.com/562926Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486178}

Introduces a Channel::Error enum so reported errors can have a little
more context (was the channel just disconnected, or did it read bad
data?)

Uses the existing optional ProcessErrorCallback on a NodeChannel to
notify embedders when bad data is received, either in BrokerHost,
specific NodeChannel messages, or Channel in general.

This means that any such failures will now get proper crash reports when
happening on renderer-to-browser connections.

BUG=741712
R=jcivelli@chromium.org

Change-Id: Ia9152207f32c4adff669fded68ca66f9240ffc1c
Reviewed-on: https://chromium-review.googlesource.com/568621
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486177}

Add a method that resets FileMonitor in a hard recovery attempt.  This
CL will, with subsequent CLs that add similar recovery methods to other
components, allow recovering (or at least cleaning up) a failed
DownloadService Controller.

The cleanup steps are:
1. Try to erase all files in the directory.
2. Attempt to re-initialize the component (make sure the directory is
created and accessed).
3. Return the result of the re-initialization to the caller.

BUG=736222

Change-Id: Ic5a8ad63c836eedd37aebaa817fb201a9a36663f
Reviewed-on: https://chromium-review.googlesource.com/567865
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486176}

Enable more layout tests with network service after certificate errors were also ignored in r485664.

BUG=713857
TBR=yzshen@chromium.org

Change-Id: I3bbc5454090eb5a6ade2343518072187c8ce17e6
Reviewed-on: https://chromium-review.googlesource.com/568691Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486175}

Currently, DialogOverlays can be created in frames that are pending
or in hidden WebContents. These DOs would count towards the maximal
overlay count, and not actually be visible.

This CL prevent DOs from being created in frames that would not be
immediately visible, and cleans up DOs as soon as their containing
frames are no longer visible.

Bug: 710186
Change-Id: I8f9d870e5d7c0995b00464c72cad87d9c57f9a68
Reviewed-on: https://chromium-review.googlesource.com/565757
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486174}

Console used to format holes in an Array very similarly to Array entries that
contained the value 'undefined'. The former showed up as 'undefined x n',
(e.g. `new Array(2)` or `[,,1]`) while the latter showed up as multiple
'undefined's (e.g. `[undefined, undefined]`). The two cases are functionally
different, since `0 in Array(1)` !== `0 in [undefined]`.

This CL reduces confusion by using 'empty x n' instead of 'undefined x n'
for holes in an Array.

BUG=732021

Review-Url: https://codereview.chromium.org/2977463002
Cr-Commit-Position: refs/heads/master@{#486173}

This allows 2 things:
1- it makes the validation logic a lot simpler: we can just test the shared
   memory id/size/offset in BeginQuery and QueryCounter commands, and if it
   validates we can ensure it stays valid throughout the query lifetime, so
   it removes a lot of failure paths
2- it ensures we don't need to wait for the query to be completed before freeing
   its memory on the client side, giving us the potential to reduce round trips

Bug: 741215
Change-Id: I63a76594c2d8299c4dead5b297d304a9aa204948
Reviewed-on: https://chromium-review.googlesource.com/567721
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486172}

BUG=740769
TBR=zmo@chromium.org

Change-Id: I73c1a95ad06c6f5e0eecd32c6be691840f26afce
Reviewed-on: https://chromium-review.googlesource.com/568909
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486171}

In PaymentDetailsUpdate which is used to update the payment request using
updateWith(), total is an optional field. On the other hand, in
PaymentDetailsInit which is used in the construction of the payment request,
total is a required field. This CL allows for that distinction.

Bug: 602666
Change-Id: I2109a1b5af1bad881d6e3bb63590448ac16aabd0
Reviewed-on: https://chromium-review.googlesource.com/568286
Commit-Queue: mahmadi <mahmadi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486170}