- 02 Oct, 2019 40 commits
-
-
Peter Boström authored
This replaces SetToolbarButtonHighlightPath and removes the OnBoundsChanged calls required to keep it up to date. Bug: chromium:1007546 Change-Id: I942ed7f0e8b9d748ad617af87d3241c1500d35b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836147 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#702224}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0a784e03b0f0..73fb657586a5 git log 0a784e03b0f0..73fb657586a5 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 saklein@chromium.org PackagesService: Add BuildsChrome endpoint. Created with: gclient setdep -r src/third_party/chromite@73fb657586a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1924dc7752bc6bfe08c63c49040660f126379ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835261Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702223}
-
Wez authored
TBR=alexmos Bug: 1010256, fuchsia:36774, b/140763277 Change-Id: I9fd94a2435a35c22945100e054caae6ab0e5052b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836434Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#702222}
-
Miyoung Shin authored
This CL converts XRSessionClient{Ptr, Request} in chrome and blink to the new Mojo type, and uses pending_receiver<XRSessionClient> in vr_service.mojom. Bug: 955171, 978694 Change-Id: Ia226a135173cd3e38c3b52a60beaae562ac63d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828760Reviewed-by:Kent Tamura <tkent@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#702221}
-
Trevor Perrier authored
This CL hides the Lite mode summary text on the settings menu when the data used history chart is not shown in the Lite mode settings. Currently both show when 100KB has been received regardless of how much data has been saved. Bug: 944977 Change-Id: Ic2f70deb770f120adf12070ae2c00d69e6822d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835176Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#702220}
-
Tommy Li authored
No one is looking at these anymore. They expired once already in June, but got extended. Bug: 969931 Change-Id: I345ad00364f5cd39b8b228e6a43419a880d7ab5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829491 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#702219}
-
Sanket Joshi authored
The up-down arrow is currently slight off vertical center. This CL fixes that and updates all affected test baselines. Bug: 1010330 Change-Id: Id1965a6243046816207bf521e25bb06413e6c77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832720Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Patrick Noland authored
In the linked bug, retaining the site instance causes he whole entry to be discarded and replaced when returning. This prevents the stored scroll state from being restored properly. Resetting the SiteInstance means the existing entry can be reused for future visits, preserving the state. Bug: 992198 Change-Id: Ib0f3e2b4f259846f02ee3e5e78c7341d2b98e148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825791 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I6c43f42ce94be9551b741855cfe8ef3bad6bd5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835220Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#702216}
-
Michael Thiessen authored
No functional changes intended, please revert if things break. This function is a large, and hard to follow. I'm hoping to break out a bunch of functions that are clearer about what they're doing and make ordering clearer. Bug: 1006927 Change-Id: I488fc6578141f596979a4729afe02e9cdbe97786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833904Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#702215}
-
John Chen authored
Enable ChromeDriver tests on Win10 bot, as win7-rel bot is no longer included by default in Chromium CQ. Change-Id: Ie8d42abe069ccbcd4313d5067a2c474913c36204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835068Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702214}
-
Travis Skare authored
QR Code generation itself is being added as a mojo service in a follow-on change. Launch with a feature flag: chrome --enable-features=SharingQRCodeGenerator Bug: 993908 Change-Id: Iba2772227ec2d494524e90e45bd0e4726047f66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769685 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#702213}
-
Brian Norris authored
They should also use the cros-network-metrics group. Bug: chromium:975070, chromium:975825 Test: validate_format.py, pretty_print.py, presubmits Change-Id: Id2afb8fed98206268d93a7f2d1f10a379badcf21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834654Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Brian Norris <briannorris@chromium.org> Cr-Commit-Position: refs/heads/master@{#702212}
-
Chris Lu authored
Made a mistake in the final patchset of crrev.com/c/1832157. Modified a unittest to cover this mistake. Bug: 976901 Change-Id: I21b06444ca31ba174d217051266c8edaba97aca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835097 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#702211}
-
Alison Maher authored
Forced colors is currently being sent to the render process over two pipelines. This change cleans up the repeated code to use the new pipeline introduced in the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1728056 Similar to how system colors are accessed in https://chromium-review.googlesource.com/c/chromium/src/+/1793742, ForcedColors have been removed from WebPreferences/WebSettings and can now accessed through WebThemeEngine. A similar change for PreferredColorScheme will follow. Bug: 970285 Change-Id: Id552d8f77c1fe01027b76f0bae5adeae972aaf5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802392 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#702210}
-
chrome://sandboxAlex Gough authored
This collects all chrome://sandbox webui plumbing files into a single subdirectory. No functional changes. Bug: 997273 Change-Id: Idf78f2423d96986e487fa2a383e5af3dce7b74c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835679 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#702209}
-
Matt Mueller authored
Bug: 1008994 Change-Id: I10a52af910605852786ffcf888276764d6660c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835158Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#702208}
-
John Lee authored
When the webview for the tab strip first loads, it thinks it's visible even when the container View for it is hidden. Forcing its WebContents to be hidden allows `document.hidden`, `document.visibilityState` and `visibilitychange` events on the document to all be correct even at load. Bug: 1005554 Change-Id: I5926b03bf86218574b6e644e2710efe8f475efbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834425 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#702207}
-
Sergey Ulanov authored
This will make it easier to test CDM support as it'll be possible to play protected video in Shaka player in WebRunner. Change-Id: Ib1ef1b41b21cfbb837e0babdefaa0281458abcf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836379 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Arthur Hemery authored
Mistake about junit tests. Since we do not work with any native code and do pure java, we do not need to run these. Bug: 976218 Change-Id: I7bc24b2ddadf8ff3ffc9d740d556e9725054c5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835620Reviewed-by:
-
Eric Karl authored
PooledSharedImageVideoProvider::GpuHelperImpl currently registers a stub destruction observer in its constructor. It does not remove this observer in its destructor, which can lead to a crash when CommandBufferStub attempts to notify it of destruction. I was going to unregister in destruction, but then noticed that this observer isn't needed: - CommandBufferHelper already registers its own observer internally - GpuHelperImpl just used this notification to clear |command_buffer_helper_|, which is already taken care of internally in that class. So instead this CL just removes the observer from GpuHelperImpl. Bug: 1010612 Change-Id: I47d1982d6ccaf8624650a4274e8cb1500aba4f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835168Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#702204}
-
Ahmed Mehfooz authored
With this change each notification that is in the message center but not visible will have an icon representing it in the stacking bar. The icons are removed as we scroll up through the message center. If there is not enough space to show all icons there will be a "+ x" appended after the icons to signify remaining notifications. Bug: 1002714 Change-Id: I2e7737a4cf0dd145e0868e7fbf11a15be897d51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803731 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702203}
-
Tommy Li authored
We're proceeding with a button-based remove interface instead of the context menu. We may add this back later for some other reason, but we don't need it currently, so this CL rips it out. Bug: 1205, 929477 Change-Id: I87a6b9b283e6d16656fe263c5271f51192d74adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834895Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#702202}
-
Xianzhu Wang authored
- Remove unused cc/layers/scrollbar_theme_painter.h - Add comments in cc::Scrollbar - Remove rect parameter from cc::Scrollbar::PaintPart() because the rect can be easily calculated by blink, given that the coordinate space of the canvas is clearly defined - Improve performance of blink::ScrollbarLayerDelegate::HasTickMarks (implementation of cc::Scrollbar::HasTickMarks()). The old implementation queried all tick marks and see if it was empty, which may be slow when there are a lot of tick marks (e.g. when searching in a huge document). - Add blink::ScrollbarTheme::PaintTrackAndButtonsForCompositor() to avoid exposing too much details of ScrollbarTheme to outside. This is a preparation for CompositeAfterPaint composited scrollbar implementation. Change-Id: Ibf8c7a90d80ddf972f215495d0fd89470fa2deb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834286Reviewed-by:
-
Jamie Madill authored
This will unblock supporting a build variant in ANGLE where we don't have Chromium supporting folders. This will enable us to port to the Skia standalone build. Bug: angleproject:3943 Change-Id: Ieb88f18b34d330458071c047f03a1c1d420b3d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834909Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#702200}
-
Toby Huang authored
For supervised users, if an extension is disabled due to requiring additional permissions, remove the code that sends a remote approval request to the custodian. The supervised user should be able to re-enable the extension themselves once local as opposed to remote parental approval is enabled. Bug: 1004851 Change-Id: I4fbb463332c50a354afde6d801f8e8f6a4445817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825173Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702199}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6b4c2a88f36e..6154fb127e5c git log 6b4c2a88f36e..6154fb127e5c --date=short --no-merges --format='%ad %ae %s' 2019-10-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@6154fb127e5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Id6e6eb6c352f2b6f9eedfe569fc05d6eda7897c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836352Reviewed-by:
-
Theresa Wellington authored
- ClipDrawableProgressBar - ContextMenuDialog - MaterialProgressBar - PaddedFrameLayout - PromoDialog - PromoDialogLayout - PromoDialogTest - RadioButtonLayout - RadioButtonLayoutTest - RadioButtonWithDescription - DragReorderableListAdapter - DragStateDelegate - ViewResourceFrameLayout BUG=951455 Change-Id: Ic5232c262edae50150ff0f3160a65ed8bd00e1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829676Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#702197}
-
liberato@chromium.org authored
Previously, VideoFrameFactoryImpl might be given a nullopt YCbCrInfo in response to a request for it. It would then clear the callback and crash the next time it tried to return a frame; it didn't check that the callback wasn't clear. Now, it only clears the callback when it actually gets YCbCrInfo, which is also when it quits asking for info on subsequent frames. Also adds a test for it. Bug: 1007196 Change-Id: Idfffe95b319e09285fdd4b6c8855d3e781fc606d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829771Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#702196}
-
Sophie Chang authored
Bug: 988670,988700,988694,988666,988661 Change-Id: Ib4947ced022fbdafdf280314e5e0d8d1a53128d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836145Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702195}
-
Tommy Li authored
No one is monitoring these metrics. Bug: 974982 Change-Id: I81676fd22bd354391f2acd38385152d90b4e8669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830362 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
-
Daniele Castagna authored
Originally this was reverted since crrev.com/c/1685909 needed to be reverted. crrev.com/c/1685909 now relanded. After crrev.com/c/1685909 we won't be reading from a buffer while scanning it out. We can re-enable partial swap on Mali. Bug: 457511 Change-Id: I6b41161925d0d4bb65eb19250ad5747af5493184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830084Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#702193}
-
Jeffrey Yasskin authored
This reverts commit 16cbcb68. Reason for revert: Broke https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/3254; see bug for details. Original change's description: > Add content_nocompile_tests to be run by some builders. > > Bug: 878706 > Change-Id: I5c3bd7d4393fe6c002171ff9937ad70d2b1ba191 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833297 > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702132} TBR=martiniss@chromium.org,gbeaty@chromium.org Change-Id: Iacc49c8ad3330977d0779baa7815ebae7e807753 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835262Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702192}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2fc703395a92ebcc813ac8f3c6cb6a6d681e52cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836351Reviewed-by:
-
K Moon authored
crrev.com/700518 incorrectly assumed PreviewModeClient::ProposeDocumentLayout() could not be reached. In fact, the PreviewModeClient is used only when previewing non-PDF documents with more than 1 page. This change also adds a browser test to check the behavior of the print preview dialog when printing multiple pages: Current print preview tests only generate a single page, which fails to exercise this issue. The crash occurs after the print preview is "ready" (all pages have been rendered), but before the print preview dialog has "loaded" completely. Current tests only wait for the "ready" condition, but the new test must wait for the "loaded" condition. Since fully loading is slow, most tests continue waiting only for the "ready" condition. Bug: 885110 Change-Id: I20316fd658d5a125a13f08d07ced4dd79884fac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835211 Auto-Submit: K Moon <kmoon@chromium.org> Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
-
Sky Malice authored
Bug: 1009831 Change-Id: I9afd34546b9520f34a206a4d026761ab130162bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835705Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#702189}
-
Matthew Jones authored
Similar to https://chromium-review.googlesource.com/c/chromium/src/+/1836031 this patch disables another very flaky test causing failures on the bots. Example bot: https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-arm64-rel/17969 Flakes: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=PasswordGenerationIntegrationTest TBR: vasilii@chromium.org, fhorschig@chromium.org Bug: 1010540 Change-Id: I684f794a971dc1b44a98e54184c8b0b475578d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835167Reviewed-by:
-
Robert Ogden authored
Adds a new PLMObserver, SubresourceLoading, to track these metrics. Bug: 995437 Change-Id: I049d96eafd93b089b06131fb8ad35eb30d0c3a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829881 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Lily Chen authored
Bug: 978172 Change-Id: I5ef4a0d189fc1e17bfa235f2aecef2853d89c006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834888Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#702186}
-
Oystein Eftevaag authored
Cleaned up the TraceController public API a little bit by removing the metadata DictionaryValue which is now inlined in the JSON rather than treated as separate data, and hold the tracing data in a std::unique_ptr<std::string> rather than a RefCountedString as the data only has one owner at any time. Split out from and already LGTM'd (the tracing bits) in https://chromium-review.googlesource.com/c/chromium/src/+/1817207/28 TBR=ssid@chromium.org,zork@chromium.org,erikchen@chromium.org,boliu@chromium.org Bug: 839086 Change-Id: I84a717e7c6915a81348d7e91fbd6fe2ba00a4d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834576 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
-
