- 20 Feb, 2020 40 commits
-
-
Jose Lopes authored
This callback is meant to be called every time a new key is registered, thus it must be a repeating callback, as documented in: https://cs.chromium.org/chromium/src/media/base/decryptor.h?rcl=502d7a8bc634c4248b7cc2f43e2305eee7213d94&l=51 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Ib852f03ab2f862d02d0e09be95626090cee60d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035960 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#743063}
-
Kai Ninomiya authored
This reverts commit 51f4efc9. Reason for revert: rmtree fix was reverted Original change's description: > Roll CTS and fix extract_expectation_names.py > > https://chromium.googlesource.com/external/github.com/gpuweb/cts/+log/ec18cc3262922e7dcdbe70243c6f40606f979144..02b62c256590b040d514ec15c0f12041be8d1575 > > Change-Id: I6db0043cf844a81d1ccdecb4e7c0a51de5430fb4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050036 > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Rakib Hasan <rmhasan@google.com> > Reviewed-by: Austin Eng <enga@chromium.org> > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743007} TBR=kainino@chromium.org,robertma@chromium.org,enga@chromium.org,rmhasan@google.com Change-Id: I2fee3ed2df610c3fc0e385725e3ae0e86718f745 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066464Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#743062}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1b1e6dfe. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 9431619c "Clipboard Tests: Update DOCTYPE to lowercase." 76ee218c "Split html/.../query-encoding/ tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I3be8ea0796671ac0c3d75dbff05e05b403fbfc33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066204Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743061}
-
Andrey Zaytsev authored
Also removed the version updater callback argument as it does not need to be created outside of CheckUpdates(). Bug: 1015841 Change-Id: I4a2bb4a23ce1c24e1a8358c641b797be0a79a21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049982 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#743060}
-
Mugdha Lakhani authored
Design Doc: https://docs.google.com/document/d/166h__sHZGVD7eTBKkBMF7beLGOmT6mwTVe8dtsTCU7A/edit?usp=sharing Before screenshot here: After screenshot here: https: //drive.google.com/open?id=0B486O0P6jAtRZ0ptUEJXemUwczNjTjlGejFPZ1ZaZS02RXFr https: //drive.google.com/a/google.com/file/d/15sHXrBgFOUAT5p2gccLHfIyP5ELYRsXV/view?usp=sharing Bug: b/64863368 Change-Id: I05b8cc3c878f930d0c18b69a4f84ac43a10b2592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873631 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#743059}
-
Marc Treib authored
If Sync-the-feature is enabled, there is only a single, combined storage for passwords. So we should not offer the account storage in this case, and if the opt-in already exists it should be ignored. This CL adds the necessary "!IsSyncFeatureEnabled()" checks plus corresponding tests. Bug: 1024332 Change-Id: I496ecb902297983d51526a74211ff1b754376e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062981Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#743058}
-
Rayan Kanso authored
This is needed for the stale manifest use case. Bug: 1045588 Change-Id: I7deb018afa062f829cc13247ab7faaa86da8a129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050274Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#743057}
-
Benoît Lizé authored
The global memory dump is fetched once per memory metrics recording, and never re-used. However the global dump is never reset, wasting memory. Bug: 1054360 Change-Id: I04f65427194068e579cd87938d4cf65af9bd0962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056820 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#743056}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/631436b3c1f2..e4d24728146d git log 631436b3c1f2..e4d24728146d --date=short --first-parent --format='%ad %ae %s' 2020-02-20 wolfi@chromium.org Use 1000 not 1024 for kB and MB calculations 2020-02-20 rajasekar89be@gmail.com DevTools: fix Reveal in Network panel does not work if filter was set before Created with: gclient setdep -r src/third_party/devtools-frontend/src@e4d24728146d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1035309,chromium:1044651 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I16768ffe4e11ce0765d328c2fc64718de3f76e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065653Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743055}
-
Antonio Gomes authored
BUG=704136, 919392 Change-Id: Id91b5c49e96ecae45b1c10f96d99b74e7c64a75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064748Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#743054}
-
sandromaggi authored
Bug: 1053606 Change-Id: I5051770b0ecb8c1b6d2a91ed31f9b533277c13de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062287Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Auto-Submit: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#743053}
-
Sergey Poromov authored
chromeos-eve-chrome consistently fails: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/3756 Bug: 1054340 Bug: 1000351 Change-Id: I51d89786926f48f7bdab4884bf27bf6b495d4947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065003 Commit-Queue: Sergey Poromov <poromov@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#743052}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/adeb0b9fdd32..189bea09d5ac Created with: gclient setdep -r src-internal@189bea09d5ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I99835ef74504f6366491dc97b73b897b54147bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066056Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743051}
-
Jan Wilken Dörrie authored
While base::Value switched to checked iterators in its list API, base::ListValue still used unchecked std::vector<Value>::iterators. This change fixes this oversight and slightly improves the checked iterator interface by making the comparison operators non-members, thus allowing implicit conversions on both arguments. Bug: 990059 Change-Id: I7b3bb4573300fe7f391c6b911817448f8aee7519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060672 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#743050}
-
Keishi Hattori authored
Introduces HeapMojoReceiverSet which is a wrapper around mojo::ReceiverSet. And uses it for ManifestManager. Bug: 1052319 Change-Id: I683567f0352c9b60811263a662bda85e31299426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063615 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Jasmine Chen authored
This CL skips the wait for 3A-convergence (AE, AF, AWB) when Zero-Shutter Lag (ZSL) is enabled. When configuring streams, camera HAL adapter would add a private usage flag to the configured still capture streams. Video Capture Device (VCD) would then use this private usage flag to determine if ZSL is enabled. If ZSL is enabled, we skip 3A when trying to construct a capture request. BUG=b:130851309 TEST=Tested on kukui and verified VCD is able to get ZSL availability through the private usage flag. Change-Id: I751a432b099fb1e012fbd65e54f57901d508225c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919530 Commit-Queue: Jasmine Chen <lnishan@google.com> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#743048}
-
Sergey Poromov authored
This reverts commit 00abf52b. Reason for revert: Failures on Mac ASan 64 Tests: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/60954 Original change's description: > Always use a white theme for System App popup settings pages > > Bug: 1033339 > Change-Id: Ia8f0c24deb742d04b0a10bb4fbcb4c3322ea1547 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065776 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742992} TBR=alancutter@chromium.org,joelhockey@chromium.org Change-Id: I6152c170c342622e8c53a5566e8b9d2488ebe1c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1033339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065005Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#743047}
-
Peter Kasting authored
Bug: 815016 Change-Id: I68fe2e15917ae11ee46e4090b64fdba3ae25a5db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066151 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Jose Lopes authored
This callback is called in: https://cs.chromium.org/chromium/src/media/filters/source_buffer_state.cc?rcl=aa249ef6fe237699a94759d51dfa5f3cd2b55966&l=852 which is in the context of the method: https://cs.chromium.org/chromium/src/media/filters/source_buffer_state.cc?rcl=aa249ef6fe237699a94759d51dfa5f3cd2b55966&l=590 which is bound repeating, so it can be called multiple times: https://cs.chromium.org/chromium/src/media/filters/source_buffer_state.cc?rcl=bfd9a7897bf5085cdab7041c8df7077b35156b97&l=576 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I180addc28f5d7034d9bb7c46833cc34ed195e04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036099 Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
-
Sergey Poromov authored
This reverts commit 2eb368c0. Reason for revert: Win7 Tests build failures: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29 Sample run: https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/64350 Original change's description: > Implement FileSystem.rmtree for long paths on Windows > > Changes blinkpy filesystem tests to use remove_contents instead of > rmtree. remove_contents calls into rmtree, but > (1) retries several times to delete the files, and > (2) throws by default instead of silently swallowing errors. > This improves all of the tests. Additionally, the retrying was > actually necessary to pass many tests (files were otherwise still > locked during teardown). > > Extends the test_long_paths test to check spaces and apostrophes. > > FileSystem.rmtree is now implemented on Windows by just calling > a shell with "rmdir /s /q". This is necessary, because > shutil.rmtree doesn't work for \\?\C:\ style "extended-length" paths > on Windows, and several other implementations I tried didn't work: > - Loop using os.walk. os.walk doesn't support long paths, and > though it seemed to work on the bots, it failed tests locally. > - Recursive using os.listdir. os.listdir also doesn't support long > paths. > > Tested on dawn-win10-* try job on crrev.com/c/2050036/17. > Found in dawn-win10-* try jobs on crrev.com/c/2050036/4. > > Change-Id: I7c67bb12305a41244829e35293edfc88901b76f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058065 > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742961} TBR=kainino@chromium.org,robertma@chromium.org Bug: 1054331 Change-Id: Iec3f75c925598f37a228771371b08616cb0d97d5 No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064997 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
-
Omar Morsi authored
chrome://settings/certificates should display hardware-backed for a certificate if it is saved on a hardware-backed slot and its private key is stored in the TPM. CL:1967781 introduced kKeyInSoftware attribute for private key which can be used to check whether the key is wrapped by the TPM or not. This CL introduces: 1- Taking advantage of the kKeyInSoftware attribute to check if a private key is hardware-backed or not. 2- Adds support for requesting certificate information list from NSS certificate database. Gathering certificates information is done asynchronously. 1- net_unittests --gtest_filter=NSSCertDatabase* 2- unittests --gtest_filter=CertificateManagerModel* 3- Manually by checking that when importing and binding a client certificate with EC key on a TPM version 1.2, it doesn't display (hardware-backed) in chrome://certificate-manager beside the certificate anymore. Bug: chromium:1043083 Test: Change-Id: I3b2551ae04d5ddadbee28cab823bcbb4278480be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022945 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#743043}
-
Antonio Gomes authored
In order to do this, a couple of remarkable changes took place: - The body of RenderFrameImpl::DownloadURL() and SaveImageFromDataUR() have been moved down to blink::LocalFrame. Note that there were other RenderFrameImpl methods that used to call RenderFrameImpl::DownloadURL() - namely RenderFrameImpl::BeginNavigation. In order to keep this code chain unchanged, WebLocalFrame interface got a DownloadURL() method added, so that it can forward calls to LocalFrame::DownloadURL() from there. - content/renderer/render_frame_impl_browsertest.cc: RenderFrameImplTest got its ctor extended similarly to RenderViewImplTest's (in render_view_browsertest.cc). Now it is possible to inject a custom blink::mojom::LocalFrameHost instance, and catch DownloadURL() mojo call. - web_test_download_manager_delegate.cc: In order to run web_tests that trigger download, we could try to intercept LocalFrameHost for web_tests. Instead, the CL lets the browser/ to handle it. The flow is content requests a download. Mojo calls take place. RFHI::DownloadURL gets called and then DownloadManagerImpl. Particularly, for every download that gets started by the renderer, DownloadManagerDelegate::CheckDownloadAllowed is called. This CL added an extra parameter to this method, in order to idenfity that the download was trigger by the renderer (ie the web_test in case), and then replied to the renderer accordingly. See WebTestDownloadManagerDelegate::CheckDownloadAllowed() for details. - DownloadURL() plumbing methods were removed from WebFrameTestClient, WebFrameTestProxy, WebLocalFrameClient, EmptyLocalFrameClient, LocalFrameClientImpl, LocalFrameClient, ChromeClient. - t_p/blink/public/mojom/frame/frame.mojom: In the normal case - see LocalFrame::DownloadURL() - all members of the blink.mojom.DownloadURLParams struct are filled properly. However, there is another call site - see LocalFrame::SaveImageAt - where only |data_url_blob| struct member is filled, leaving all others "null". |url| is nullable so it is fine, but all others cause crashes on unittests if they are not mark as "nullable" accordingly. - web_frame_test.cc: It implements a BlobRegister instance that intercepts the creation of blink::mojom::Blob, or use FakeBlob instead. Given that the content of the Blob is known, and made of bytes only, it reads off the contents from DataElements. The test also implements a custom blink::mojom::LocalFrameHost instance, so it intercepts mojo calls to DownloadURL() and act accordingly. BUG=1041083 Change-Id: I279bdc142624a0efb6be31535d505e9f6cabe5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028708Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#743042}
-
Wei Lee authored
Bug: 980846 Test: Launch CCA with no error shows Change-Id: I808d0c2c5a99e8c068227645e03c8a619310da59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058932 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
-
Tanmoy Mollik authored
Change-Id: Ibdce0a751ec9754fac8395feb1168e85db6ea9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064909Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#743040}
-
Mirko Bonadei authored
As mentioned on [1], WebRTC uses xcode 10.2 in buckets/webrtc.fyi.star and this may cause the problem mentioned on crbug.com/1052347. [1] - https://bugs.chromium.org/p/chromium/issues/detail?id=1050976#c23 Bug: 1050976 Change-Id: I3e08b4dcce0c9ef8b92f2ac14a822a62ffa3803b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056817Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#743039}
-
Mitsuru Oshima authored
* A window frame should have rounded corners only in normal state, (floating state). All other state won't need them so can be opaque window. * Don't apply this logic if the opacity is explicitly specified (not kInferred) * Old code removed the rounded corner only for maximized/fullscreen. Instead, this CL checks if it's normal. * Consolidated the occlusion region update code for transparent window to WindowState. * Update DCHECK in Window::SetOpaqueRegionsForOcclusion to allow resetting. Bug: 1022544 Test: covered by unit tests. Also tested on the device. OOBE, login screen, arc windows works as intended. Change-Id: Ia8e067945732b81294c3e6733121d433e3087f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059089 Commit-Queue: Mitsuru Oshima (OOO) <oshima@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#743038}
-
Guido Urdaneta authored
With MediaFoundation, VMware exposes a camera even if no physical camera exists. The behavior of this camera is problematic and causes getUserMedia() calls to hang. A previous CL (crrev.com/741120) tried to block this camera, but it had no effect because the blocking mechanism worked only on USB cameras. This CL introduces a blocking mechanism that works on the display name for the camera. Local testing has shown that under DirectShow, the virtual camera is not exposed if no physical camera exists. It works well when a physical camera exists too. Bug: 1044974 Change-Id: I544e33ea4a5717dd91d09784a1bc32e3e268cf0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064996Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#743037}
-
Michael Ershov authored
These requests will allow Chrome OS device to communicate with DM Server to generate a CSR and receive a certificate. CloudPolicyClient encapsulates all the processing of proto structures. CloudPolicyClientCertProvisioningFinishCsrTest.*, CloudPolicyClientCertProvisioningDownloadCertTest.* Bug: 1045895 Change-Id: Ie329692a41103e36b7c99990f80192d83110a834 Test: CloudPolicyClientCertProvisioningStartCsrTest.*, Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059373Reviewed-by: -
chrome://flagsTakashi Toyoshima authored
Now the feature is launched by default, and we do not want to allow users to control the feature via the flag in m82. base::Feature is still remained and command line flags work even after this change. Enterprise policies are also still remained in the current revision, but will be removed behind a finch gate in m82. If there is a serious issue for enterprise users, we may postpone the announced policy removal. Bug: 1053866 Change-Id: Id4abe345878a0d25e74202c3e54620616c223607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065255Reviewed-by:
-
Sergey Poromov authored
This reverts commit b6d8f169. Reason for revert: browser_tests are failing: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3343 Original change's description: > Settings: Migrate about_page/* to Polymer 3 > > Bug: 1026426 > Change-Id: I6ae55030f28fd3588d317f6fd611d04f7bdbfbf8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058067 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742918} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: I2af4e6111deab7bb45c1a306aec449142ffd1cd8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064937Reviewed-by:
-
Jan Wilken Dörrie authored
TBR=ioanap Change-Id: I23175afe330f6d869101fb65c76e9175752f4c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064992Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#743033}
-
Oriol Brufau authored
In r741909 I changed PositionWithAffinityOfHitTestResult to use InnerPossiblyPseudoNode() instead of InnerNode(). HandleSingleClick checks that InnerNode() is not null and has a layout object before calling PositionWithAffinityOfHitTestResult. But seemingly, in some cases the InnerPossiblyPseudoNode() may not have a layout object. This patch changes HandleSingleClick to check InnerPossiblyPseudoNode() in addition to InnerNode(). Hopefully this will fix a possible null deref crash. But I haven't been able to create a testcase. BUG=105345 Change-Id: Ic42a044acc68799c21952a1125b5ffe08bda7494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062282Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#743032}
-
Felipe Erias authored
Add support for the values "jis-b5" and "jis-b4" in the "size" property of the "@page" rule, as specified in the CSS standard: https://www.w3.org/TR/css-page-3/#typedef-page-size-page-size These values represent two Japanese standard paper sizes: - JIS B5 is 182mm wide by 257mm high - JIS-B4 is 257mm wide by 364mm high Test: printing/page-format-data.html Bug: 1047642 Change-Id: Iec39bb535d21ea5a6ee1696b744166e1247be35f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059029Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#743031}
-
Side Yilmaz authored
This CL updates the profile passing to HelpAndFeedback activity from SadTab. Currently, it is always regular profile, however it is not safe because of possible data leakage from incognito to regular profile. This CL updates SadTab to receive the current profile (i.e., regular or off-the-record profile) of current tab and pass it to HelpAndFeedback activity. Bug: 1041781 Change-Id: I6c5b85187f627348e2dadbba8eaa3a18d02ddb94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062972Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Marc Treib authored
It had a single implementation, FCMSyncNetworkChannel, and nothing actually referred to the interface. Bug: 1029481 Change-Id: I4791dd4a4760687f29499faee7986d1dfefb5745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062422 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743029}
-
Eric Leese authored
This reverts commit d4838474. Reason for revert: The new build rule js_library("app") was causing build failures due to a missing app.js file. No-Tree-Checks: true Original change's description: > [system-web-apps] Add chrome-untrusted iframe to sample system web app > > An example of how to embed a chrome-untrusted iframe into a system web > app. > > To do so, we need to add abstract methods in WebUI despite WebUIImpl > being the only class to actually implement it. This is so the > WebUIController can add requestable schemes so the WebUI can request > the chrome-untrusted resource. > > Bug: 1048951 > Change-Id: Ia3152e21412845cf421df74bb00a16e0a8f264b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037186 > Commit-Queue: Jessica Huang <jessing@google.com> > Reviewed-by: calamity <calamity@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Auto-Submit: Jessica Huang <jessing@google.com> > Cr-Commit-Position: refs/heads/master@{#742999} TBR=kinuko@chromium.org,calamity@chromium.org,ortuno@chromium.org,jessing@google.com Change-Id: I7036191fd5c92bcfb42743ef23ed05d58b57063e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064932 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL removes the flag for clearing browsing data in web/ Bug: none Change-Id: If7cdadee8e2c88145ee296ccbead9501762d77ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049969Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#743027}
-
Vasilii Sukhanov authored
Bug: 1052997 Change-Id: I2839187374a6399529770144ce211509b50e5e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062447Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#743026}
-
Balazs Engedy authored
While location bar user input in progress, GetContentSettingWebContents will return nullptr, but ContentSettingImageView::AnimationEnded is still invoked. Add a check in the latter to make sure we are not checking on a null WebContent if the promo should be shown. Bug: 1054074 Change-Id: I261bceb410478360f6af2d84ddf5e01f5c9e6cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064968Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#743025}
-
Jan Wilken Dörrie authored
This change adds a string16 overload for CanonicalizeUsername which will be useful for the Bulk Leak Check. In order to avoid duplicating code, the implementation is turned into a template, used by both the 8-bit and 16-bit version. Bug: 1047726 Change-Id: I03a3d7cd6d037f0c526d35e1f81080b1ce16503f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064548 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
