- 12 Feb, 2020 40 commits
-
-
Maksim Moskvitin authored
ENABLED is now emitted UpdateSubscribedTopics() regardless of conservative enabling feature state if there is no |pending_subscriptions_|. ENABLED is now emitted on successful access token update iff conservative enabling feature is disabled. According to comments in crrev.com/c/1407071 the only reason to emit it here with enabled feature is the case when there is no |pending_subscription_|, which is now handled in UpdateSubscribedTopics(). Bug: 1020117 Change-Id: I1b7a34a4a99c876a172df861b3da6efe03c9cb64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050485 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#740645}
-
Maksim Moskvitin authored
This CL contains following changes: 1. TODO about cancelling pending subscriptions replaced with comment explaining why current behavior is better. 2. Access token request backoff timer no longer resets on the first successful request. Bug: 1020117 Change-Id: I50930bdd5a998b41bd83525d88f5c525b34cd457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047107Reviewed-by:
-
Askar Aitzhan authored
This reverts commit 417551e2. Reason for revert: The CL was for testing QuickFix Builds feature. Original change's description: > Harmless CL to test QuickFix builds feature > > This CL will be reverted immediately after it's landed. The purpose of > doing so is to create a mini-branch at the point where this CL is > landed. > > Bug: 1050955 > Change-Id: I1216574943f1676829101561d9591d946b8a86ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050469 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> > Cr-Commit-Position: refs/heads/master@{#740641} TBR=emaxx@chromium.org,askaraitzhan@google.com Change-Id: I4fac637048c78c22fd6b80bc63533926af0d10c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051926Reviewed-by:
Askar Aitzhan <askaraitzhan@google.com> Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Cr-Commit-Position: refs/heads/master@{#740643}
-
Nico Weber authored
You can pass --build if you want the script to build before swarming. See "Should run-swarmed.py default to building?" on chromium-dev. Bug: none Change-Id: Id80d78670612f77502a03d80759cc3788200de87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050783 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#740642}
-
Askar Aitzhan authored
This CL will be reverted immediately after it's landed. The purpose of doing so is to create a mini-branch at the point where this CL is landed. Bug: 1050955 Change-Id: I1216574943f1676829101561d9591d946b8a86ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050469Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Cr-Commit-Position: refs/heads/master@{#740641}
-
Maksim Moskvitin authored
The request doesn't actually need cookies and already has cookies_allowed policy set to NO. To match this credentials_mode now set to kOmit. Bug: 1020117 Change-Id: I7c9198bc388f890492c07334492e96f14f3776a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049858 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/759492232288..46fd1e889139 git log 759492232288..46fd1e889139 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 treehugger-gerrit@google.com Merge "perf: record unwinding errors, pace ticks, make rbuf size configurable" 2020-02-12 hjd@google.com Merge changes Icabde757,If2d010b1,I67c848a3 Created with: gclient setdep -r src/third_party/perfetto@46fd1e889139 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: If2b9b0ac981eaa0ac7fa89b39cad1cdf677b4bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051817Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740639}
-
Vasilii Sukhanov authored
Bug: 1049185 Change-Id: Id97a5b2781c50e9f54a5bb2195673c39b3e675d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050374Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#740638}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ead1d6709ef6..3413c61fc571 Created with: gclient setdep -r src-internal@3413c61fc571 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia7689b5f5007951140318f560fdfff480024f876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051816Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740637}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 332de339. With Chromium commits locally applied on WPT: 5579aad0 "SharedWorker: Name shared workers identically in credentials mode WPT" 63f8588a "[WPT/common/security-features] Add more docs of generator and its types" acd8a467 "SharedWorker: Use CSP headers to outside settings" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes tdresser@chromium.org: external/wpt/navigation-timing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib0e9e9482dc5f60bb26c2041b06495465a789259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051188Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740636}
-
Jit Yao Yap authored
Bug: 986266 Change-Id: I08220cacd6c1957e52a36ec8cb2066774d92290d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047108 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#740635}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f27be3d65c22..065146856295 git log f27be3d65c22..065146856295 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 aerotwist@chromium.org Revert "[Lighthouse] Rename Audits panel to Lighthouse" 2020-02-12 aerotwist@chromium.org Adds karma-sinon to Karma config 2020-02-12 aerotwist@chromium.org Adds karma-sinon to DEPS 2020-02-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-11 cjamcl@chromium.org [Lighthouse] Rename Audits panel to Lighthouse Created with: gclient setdep -r src/third_party/devtools-frontend/src@065146856295 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I54ac758e51fd7cc01db5a1be358590be753db278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051815Reviewed-by:
-
Side Yilmaz authored
NavigationSheetMediator. |Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates NavigationSheetMediator class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I31ea8e441ae9877c5c26e3643a35f1b465ff9dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050493Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#740633}
-
Anand K. Mistry authored
A common set of share parameters needs to be passed around. Use a common class instead of repeatedly passing multiple arguments to functions. Bug: 939235 Change-Id: Idf41c6e09693c1377cc1613ff18bfe97d7ba3f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049011Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#740632}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/56ab990e..2483f41b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8e4a83ec1bc7504354e1f79ee14f8215a3dbb9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051189Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740631}
-
Simon Zünd authored
This CL is part of the effort to clean up prototype wrangling in DevTools's utilities.js. After this CL we are able to remove {keysArray} from Map. Bug: chromium:1050549 Change-Id: I59792c1dfb5f2a8c78c3a427e55e5497c33a8afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051843Reviewed-by:Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#740630}
-
Colin Blundell authored
This CL componentizes the implementation of launching of date and time settings found in //chrome's SSLErrorControllerClient in order to reuse this functionality in WebLayer (that reuse will happen in a followup). The code has no //chrome dependencies. We placed it in the security_interstitials component as that is the only consumer of this functionality at this time; if need be it can be moved into a more generalized location (e.g., a standalone component) in the future. Tested manually that visiting the bad clock interstitial and clicking "update date and time" still works as expected on Android (note that on Linux, the other platform where I can locally test, this already doesn't work as expected; filed as crbug.com/1051427). Change-Id: I062dbf61392c329f11d9a3f8af748a4ec2086d05 Bug: 1030692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988353 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#740629}
-
Simon Zünd authored
This CL is part of the effort to clean up prototype wrangling in DevTools's utilities.js. R=tvanderlippe@chromium.org Bug: chromium:1050549 Change-Id: I02adeccde5391b8625aee52118f76deea5613e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050587 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6a53dfe7459d..759492232288 git log 6a53dfe7459d..759492232288 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 hjd@google.com Merge "trace_processor: Fix SDE parsing bug" Created with: gclient setdep -r src/third_party/perfetto@759492232288 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id7cf0ad236d96ba890e120be8009c965cbc2b824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051813Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e1ccac7ff9f0..58e7790cc093 git log e1ccac7ff9f0..58e7790cc093 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader b3b2a4fc756f..6cbb02e0dc93 (11 commits) Created with: gclient setdep -r src/third_party/angle@58e7790cc093 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I12a3cad481a0cc2e63daead1dd43b3760458ddab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051809Reviewed-by:
-
Tobias Sargeant authored
Instead of setting the sourcefile to PG when obfuscating Java, set it to :chromium:{mapping file}:{channel}:{version code} so that a) We can recognise chrome/webview stack frames by this string b) The information required to uniquely identify the proguard mapping file in question is directly available in stack traces. Bug: 1044585 Change-Id: Ib4fabccfb7693e5e97edc6f29be1cd6cb61fa1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036091 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#740625}
-
Yoav Weiss authored
Implements https://github.com/w3c/resource-timing/pull/224 Bug: 1049510 Change-Id: Id8fc4b3a4de72b6a51c820a2352d88bea65c935f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047023 Auto-Submit: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#740624}
-
Md. Hasanur Rashid authored
This CL update the function FileSystemContext::CreateCrackedFileSystemURL to use url::Origin instead of GURL. Bug: 598424 Change-Id: Ida06511b8659a393602f4e55e9ae1a2ef4bede46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046944 Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#740623}
-
Roman Aleksandrov authored
Bug: 992967 Change-Id: Ic6a6aa46b4c5f33004a8e2ecb8bbe9d571698588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050693Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#740622}
-
Koji Ishii authored
This patch moves |CurrentText*()| functions and bidi functions to |NGInlineCursorPosition|. This patch has no behavior changes. Bug: 982194 Change-Id: Ibd1ea3a8ff805cd4f5bcf87a6b71f3b9559fc461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050219Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#740621}
-
Maxim Kolosovskiy authored
This reverts commit 9126b2a1. Reason for revert: Suspect this CL cause a failure of SignedExchangePrefetchBrowserTest/SignedExchangePrefetchBrowserTest.PrefetchMainResourceSXG_SignatureExpire/0 as this CL affects resources. https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/50946?blamelist=1#blamelist-tab Original change's description: > Clean up unused PageStatus constants in PeopleHandler > > PageStatus.TIMEOUT isn't used, so remove it and the associated HTML > content and string. > > PageStatus.SPINNER is used as the default state for the page, but isn't > sent from C++, so eliminate the C++ constant. > > Bug: none > Change-Id: I93b2dadb9bb6cf762faed3a825f0b2eda2ad4308 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050033 > Commit-Queue: Marc Treib <treib@chromium.org> > Auto-Submit: James Cook <jamescook@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740598} TBR=jamescook@chromium.org,treib@chromium.org Change-Id: If5728aefbdb0e1292210c9add4cef142dc6da499 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050379Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#740620}
-
Morten Stenshorne authored
This was missing when hit-testing a NG fragment (rather than the LayoutObject). I don't know how to write a WPT for this, but this fixes at least the following tests with LayoutNGFragmentTraversal enabled: fast/events/scrollbar-double-click.html fast/events/touch/gesture/gesture-scrollbar-touchscreen-fling.html fast/events/touch/gesture/gesture-scrollbar.html Bug: 1043787 Change-Id: I8669a16fe0d8762f29ba7a7600bcf7fa161e594f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048084 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#740619}
-
Miyoung Shin authored
This is a follow-up CL of https://crrev.com/c/1993076 and this CL is a part of the effort to use the mojo type in Blink without converting between Blink and Non-Blink. This CL removes scroll_into_view_params_type_converters.{cc, h} and uses mojom::blink::ScrollAlignment mojo type instead of ScrollAlignment class in Blink, and we keep ScrollAlignment class as a helper class. Bug: 1039285 Change-Id: I8cc47a8188b15a5e73f2d27783ef382a015f9720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024638 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#740618}
-
Oriol Brufau authored
Dynamic changes to 'list-style-position' in legacy layout are so broken, especially with nested list items. In lots of cases, some markers end up nested inside the wrong list item, or appear in the wrong position, or an empty line is inserted somewhere. This patch doesn't fix all the cases, which would require a big refactorization. It only fixes the case that I need for bug 457718. The case is: - Initially, <div><div style="list-style-position: inside"><div></div></div></div> - After being laid out, the middle <div> is set to 'outside': <div><div><div></div></div></div> - After reflowing, the inner <div> is set to 'inside': <div><div><div style="list-style-position: inside"></div></div></div> This used to place the 2 outside markers in a 1st line and the inside one in a 2nd line, creating an empty line between them. This patch fixes it. BUG=1051114 TEST=web_tests/external/wpt/css/css-lists/change-list-style-position-002.html The patch also fixes some typos in change-list-style-position-001.html Change-Id: Ib42433ec43eca1925d0a47f4caaabbce7951360c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049854Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#740617}
-
Fergal Daly authored
I added a helper GetParentRenderFrameHost because the previous code would crash if current_render_frame_host() was nullptr. This ensures that we still crash if that ever happens. Change-Id: I0f9d3ef2f5cb1a86a247f5fe5db8b6d9fe47d31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041153Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#740616}
-
arthursonzogni authored
This patch mojoify CSPViolationParams and SourceLocation. It also make the IPC ReportContentSecurityPolicyViolation to cross fewer layers. This removes ~220 lines of code (232 insertions, 451 deletions) This correspond to step 1.N of the Unify CSP document: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao ________________________________________________________________________ The struct CSPViolationParams was "triplicated": - content::CSPViolationParams - blink::mojom::CSPViolationParams - WebContentSecurityPolicyViolation All of them are removed and merged a unique - network::mojom::CSPViolation. ________________________________________________________________________ The struct SourceLocation was "duplicated": - blink::mojom::SourceLocation. - content::SourceLocation. All of them are removed and merged into a unique - network::mojom::SourceLocation. ________________________________________________________________________ "ReportContentSecurityPolicyViolation" was crossing these layers: content/browser -> content/renderer -> blink public -> blink internal Now, it's going straight: content/browser -> blink internal ________________________________________________________________________ Bug: 1021462 Change-Id: Icf3f72700102e9831e68861f87efa167b3a86879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035971Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#740615}
-
Maxim Kolosovskiy authored
This reverts commit c08274e9. Reason for revert: this CL made DumpAccessibilityTreeTest.DisplayLockingViewportActivation flaky on https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29?limit=200 Failures: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/60763 https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/60759 Original change's description: > DL: Don't include skip-viewport-activation subtrees in the AX tree > > Now both render-subtree: skip-viewport-activation and skip-activation > subtrees are not in the AX subtree at all, as discussed in > https://github.com/WICG/display-locking/issues/102#issuecomment-564205445 > > Now only render-subtree:invisible subtrees are in the AX tree, and they > are automatically marked as offscreen because the nodes are activated > when they are on screen. > > Bug: 1001930 > Change-Id: I1de511672f60078a02b3ddf3d989f2da1c44ae9d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028883 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740531} TBR=vmpstr@chromium.org,aboxhall@chromium.org,chrishtr@chromium.org,rakina@chromium.org Change-Id: If1d7041ed1fa81a2693480480eaf8163f2606aa8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051106Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f510ec743553..ead1d6709ef6 Created with: gclient setdep -r src-internal@ead1d6709ef6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I93a28b05cd714d1033289bd21cf626d8dbda7ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051808Reviewed-by:
-
Shik Chen authored
Make it easier to read. Bug: b:141518806 Test: Manually Change-Id: Icbcfcb38563f7bf92dd96423c4de23899cb14e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051475 Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#740612}
-
Yutaka Hirano authored
I removed the restriction on beacon with a blob with a non-CORS safelisted content type at https://crrev.com/c/2011786 but forgot to set the request mode. Fix that. Bug: 1051368 Change-Id: Ibb843c2232af09390ca1155bd8a807c453c61683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050410Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#740611}
-
Hajime Hoshi authored
In BackForwardCacheMetrics::DidCommitNavigation, |last_committed_main_frame_navigation_id_| can be not -1 not only on history navigation but also on reloading. This CL changes the conditions to record UKM only on history navigation. We plan to add other UKMs for back-forward cache, and they should not be recorded when reloading. For example, we are trying to record the reasons why the page was not in the cache, but recording them when reloading does not make sense. Then, we need more strict conditions. Bug: 1033410 Change-Id: I933e7093805f643e60f9059c753a1f5ec2cacd9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988093Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#740610}
-
Morten Stenshorne authored
Presumably because of fragment item fixes. TBR=kojii@chromium.org Change-Id: I5e1ce3be09d4e9af06da90575a3e370eb41e36d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050589Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#740609}
-
Huanzhong Huang authored
(The change is a bug fix. Please refer to bug for details.) The cookie controls tooltip icon in the Incognito NTP is made to respond to mouse clicks so that a setting can easily be found. To improve accessibility, this change makes the icon respond to Enter key. Bug: 1048121 Change-Id: I5bb2c5367c6661404131677af3eb3b88cd62b1ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040410 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#740608}
-
Yuki Shiino authored
Some of Blink implementations are missing header includes about return types. Adds missing header include directives. Example) // IDL TypeA foo(); // Implementation (.h) TypeB* foo(); // TypeB might inherit from TypeA, but who knows? In this case, there is no way for bindings generator to include an appropriate header "type_b.h" because foo's return type is known as "TypeA". Bindings generator includes "type_a.h", but it doesn't help handle a return value of type TypeB. Correct implementation is either of: TypeA* foo(); or, #include "type_b.h" TypeB* foo(); // TypeB is known to inherit from TypeA Bug: 839389 Change-Id: I5092b46a8579a4406a5567f68f6d4266e29eaa72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051797Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/77fb303e58e9..6c218ec60b5f git log 77fb303e58e9..6c218ec60b5f --date=short --first-parent --format='%ad %ae %s' 2020-02-11 afdx@google.com spirv-fuzz: Fuzzer pass that adds access chains (#3182) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@6c218ec60b5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I410a4e373fb7664522ec99306a16748fcf508050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051806Reviewed-by:
-
