GitLab

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/209453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266814 0039d316-1c4b-4281-b951-d872f2087c98

PictureLayerImpl::ReleaseResources calls
set_needs_update_draw_properties, expecting as a result that if it is
false again, that CalculateContentsScale is called in between. However
this assumption is not true as CalculateDrawProperties can skip layers.

Instead, also check should_update_tile_priorities_ which is set in
CalculateContentsScale.

BUG=358350

Review URL: https://codereview.chromium.org/258053011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266813 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347247
TEST=
  (1) Start out with a brand new Chrome profile, that you've never signed into.
  (2) Navigate to https://chrome.google.com/webstore/category/collection/for_your_desktop
  (3) Click on an app (any app).
  (4) Click on the "+ Free" link to install the app.
  At this point, you should be automatically navigated to a sign-in URL.
  That URL should be hosted on chrome://chrome-signin/, *not* on
  https://accounts.google.com/ServiceLogin
R=guohui@chromium.org

Review URL: https://codereview.chromium.org/196783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266812 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=content_unittests --gtest_filter=ServiceWorkerDatabase.* (with valgrind)
TBR=michaeln@chromium.org

Review URL: https://codereview.chromium.org/253103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266811 0039d316-1c4b-4281-b951-d872f2087c98

If there's only 1 tab and the tab is NTP, close this NTP tab and open all
startup urls in new tabs, because the omnibar will stay focused if we
load url in NTP tab.

R=asvitkine@chromium.org,viettrungluu@chromium.org,thakis@chromium.org
TBR=sergeyberezin@chromium.org
BUG=43520

Review URL: https://codereview.chromium.org/240273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266810 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266808 0039d316-1c4b-4281-b951-d872f2087c98

This is to get a BUILD.gn file formatting fix.

BUG=368019

Review URL: https://codereview.chromium.org/253033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266807 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366510
TEST=See bug comment 7 for repro steps.
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/256233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266806 0039d316-1c4b-4281-b951-d872f2087c98

Adopt usage of the DidOverscrollParams struct for overscroll notifications from
the renderer.  This eases the burden of changing overscroll metadata in the
future, and simplifies overscroll-related methods.

This also fixes an issue where repeated flings into the same edge would not
trigger the overscroll effect until a different edge overscrolled or the
overscroll was generated by a touch scroll.

BUG=354444

Review URL: https://codereview.chromium.org/20045007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266805 0039d316-1c4b-4281-b951-d872f2087c98

TESTED=Unit test.  Manually with Cast extension
BUG=331165

Review URL: https://codereview.chromium.org/255443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266804 0039d316-1c4b-4281-b951-d872f2087c98

Explicitly add the control types to the list of types to fetch nodes for
during a request to GetAllNodes().  The control types don't register
with the ProfileSyncService at startup like the other types do, so
they're not in the list of GetRegisteredDirectoryDataTypes like the
others.

BUG=368012

Review URL: https://codereview.chromium.org/251133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266803 0039d316-1c4b-4281-b951-d872f2087c98

R=dtu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/255063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266802 0039d316-1c4b-4281-b951-d872f2087c98

Removes all dependent texture lookups and makes sure we're not using
unnecessarily high precision for texture coordinates.

BUG=269808

Review URL: https://codereview.chromium.org/257803011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266801 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366675

Review URL: https://codereview.chromium.org/257643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266800 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Breaks compile on win builder:
http://build.chromium.org/p/chromium.win/builders/Win%20Builder%20%28dbg%29/builds/29440

Original issue's description:
> Makes change_id unsigned
> 
> Easier this way for clients to track and not worry about overflow.
> 
> BUG=none
> TEST=none
> R=ben@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266793

TBR=ben@chromium.org,sky@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/252143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266799 0039d316-1c4b-4281-b951-d872f2087c98

More details on threading strategy provided in webcrypto_impl.cc.

BUG=245025

Review URL: https://codereview.chromium.org/233733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266798 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364560
Test=This changes the internals of rendering <webview> in chrome-apps. No noticeable changes should be observed.

Review URL: https://codereview.chromium.org/251593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266797 0039d316-1c4b-4281-b951-d872f2087c98

Same as rasterize_and_record_micro.fast_path.key_silk_cases but with forced GPU
rasterization flags added (taken from smoothness.gpu_rasterization.*).

This benchmark will eventually replace rasterize_and_record_micro.fast_path.key_silk_cases,
but we need to stage that change to not break the buildbots (see bug).

BUG=367678

Review URL: https://codereview.chromium.org/256043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266796 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of r260688, which is reverted due to last-minute rebase mistake. 

Previously, we used FileEntry.getMetadata() to retrieve filesystem metadata and getDriveEntryProperties() to get Drive metadata, so we need 2 calls for 1 file on Drive. 

With this patch, getDriveEntryProperties() returns not only Drive metadata but also filesystem metadata. It's enough to call only getDriveEntryProperties() and we can reduce a number of calls by half. 

BUG=345196
TEST=browser_test passes. 
R=asargent@chromium.org, hashimoto@chromium.org, hirono@chromium.org 
TBR=asargent@chromium.org, hashimoto@chromium.org, hirono@chromium.org 
NOTRY=True
# NOTRYing for buildbots already passes (see. crrev.com/256023002)

Review URL: https://codereview.chromium.org/256023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266795 0039d316-1c4b-4281-b951-d872f2087c98

Fix a bug for SetShowState which causes the code do nothing when it is called from AppsContainerView constructor since the show_state_ is considered not changed. 

BUG=367370

Review URL: https://codereview.chromium.org/253833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266794 0039d316-1c4b-4281-b951-d872f2087c98

Easier this way for clients to track and not worry about overflow.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/253883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266793 0039d316-1c4b-4281-b951-d872f2087c98

In order to best run a suite of tests on the bots, we need to support
printing out the list of tests that failed in an easily-machine-readable
manner, and also support running just a subset of tests.

This patch adds the --unexpected-failures flag to run_mojo_python_tests
to write out, one test name per line, a list of failures (full details
are listed in the usage for the script).

It also adds the ability to just run a subset of tests.

If we add any more complexity to this script we really need to write tests
for it.

R=sky@chromium.org
BUG=364709

Review URL: https://codereview.chromium.org/257103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266792 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244628
TEST=manual check on Acer C720

Review URL: https://codereview.chromium.org/228703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266791 0039d316-1c4b-4281-b951-d872f2087c98

Ownership of the HANDLE in ResourceMsg_SetDataBuffer isn't managed
automatically.

Also invert ForwardingFilter/TestFilter's superclass/subclass
relationship. This arrangement avoids the useless dest_ = NULL
codepath.

BUG=366246

Review URL: https://codereview.chromium.org/257763007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266790 0039d316-1c4b-4281-b951-d872f2087c98

The latest version of the NDK experimental crtend in this location.
Andrew Hsieh confirms this is correct for multilib NDK.

BUG=346626

Review URL: https://codereview.chromium.org/256803008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266789 0039d316-1c4b-4281-b951-d872f2087c98

The captive portal window was being blocked by the GAIA auth extensions's
background script because the script could not tell it from the GAIA login
frame. This CL ensures that the login UI has a unique tab ID, making it
distinguishable from the captive portal window.

BUG=367713
TEST=Manual; updated tests forthcoming in bug 367731

Review URL: https://codereview.chromium.org/259663006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266788 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/256943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266787 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362796

Review URL: https://codereview.chromium.org/236073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266783 0039d316-1c4b-4281-b951-d872f2087c98

The dependency is no longer required.

Review URL: https://codereview.chromium.org/259983007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266782 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266781 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365499
TBR=

Review URL: https://codereview.chromium.org/256853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266780 0039d316-1c4b-4281-b951-d872f2087c98

BUG=261628
R=markusheintz@chromium.org

Review URL: https://codereview.chromium.org/254933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266779 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239179

Review URL: https://codereview.chromium.org/258603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266778 0039d316-1c4b-4281-b951-d872f2087c98

We're setting them true, they already default true. We're removing them.

R=piman
BUG=365853, 366114, 365847

Review URL: https://codereview.chromium.org/257113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266777 0039d316-1c4b-4281-b951-d872f2087c98

The math with it just cancels out, so it's not necessary.

BUG=
TEST=open http://www.w3schools.com/html/tryit.asp?filename=tryhtml_youtubeobject with NPAPI flash and scroll it

Review URL: https://codereview.chromium.org/257963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266776 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239179

Review URL: https://codereview.chromium.org/245473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266775 0039d316-1c4b-4281-b951-d872f2087c98

With the current implementation, the field ordering start with 1, while
it must starts with 0 for structs.

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/252633007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266774 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239179

Review URL: https://codereview.chromium.org/251673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266773 0039d316-1c4b-4281-b951-d872f2087c98

Android's delegate overrides Accept/Cancel and does not record
all the necessary histogram actions.

BUG=329200

Review URL: https://codereview.chromium.org/258093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266772 0039d316-1c4b-4281-b951-d872f2087c98

This change is motivated by the need to set the test install attributes before the browser policy connector is initialized for the first time. In particular, test class members may cause the policy connector to be initialized in their constructors, so we also need to set the install attributes in the constructor of a member.

BUG=243341

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266094

Review URL: https://codereview.chromium.org/247283007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266771 0039d316-1c4b-4281-b951-d872f2087c98