- 22 Jan, 2020 40 commits
-
-
Andres Calderon Jaramillo authored
This CL creates a simple pixel test that does not rely on WebGL, canvas, or video and that results in multiple render passes. Motivation: https://crrev.com/c/1637737 broke Android compositing of some mixed WebGL/Canvas2D content. The root cause was an incorrect assumption in that CL: that when the framebuffer for the root render pass is bound, we wouldn't try to bind it again before swapping it. This assumption was wrong in the case of drawing a render pass quad onto the root render pass. See [1]. The aforementioned CL would call BeginSharedImageAccessDirectCHROMIUM() upon binding the root render pass' framebuffer and would call EndSharedImageAccessDirectCHROMIUM() only when the buffer is swapped. So, binding the framebuffer multiple times would result in the shared image system thinking that we wanted concurrent access to the SharedImage. When running some of the existing WebGL/Canvas2D pixel tests, I did see artifacts resulting from the wrong assumption, but they don't happen in all frames. The test in this CL reliably hits the issue. It's rendered using multiple render passes. The page is animated with JS to reliably reproduce the problem. I tried running the test before and after the revert of the bad CL (https://crrev.com/c/1963369). Before that revert, the test failed 20/20 times. After the revert the test succeeded 20/20 times. For this test to catch the regression, it must run on Android Q. [1] https://cs.chromium.org/chromium/src/components/viz/service/display/gl_renderer.cc?l=1134-1136&rcl=64245a1d4d5484c33272c0fcb99731eff23b4103 Bug: 958670,1033279 Test: run locally on Pixel 2 w/ Android Q before/after CL:1963369. Change-Id: Id154e45814043e8a47d58b784df3b854b6036693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979059 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#733856}
-
Dave Tapuska authored
Change-Id: Ic6b3b590cc3efde171ebc5c4686c384d406310d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013515Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#733855}
-
Dan Beam authored
R=mahmadi@chromium.org Fixed: 1043335 Change-Id: I98b1fbcc0a5b5e0d48334e8eb33a31c66f07a4fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008614 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#733854}
-
Sadrul Habib Chowdhury authored
Remove the synthesized BeginMainFrame notifications for the trackers, and enable some of the DCHECKs. BUG=1021963 Change-Id: I6867f5d3dd269bab99e8b468ecc782a8009b7ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995634 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#733853}
-
Tim Song authored
This is a reland of the original fix (see bug), which was reverted due to regressions. This updated version fixes an edge case, which caused a crash when dismissing the message center via accelerator in certian circumstances. BUG=1024100 Change-Id: I525186a7075732946403ebffa5def4631bcde658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013525Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#733852}
-
Tsuyoshi Horo authored
And also renames to FrameSerializerDelegateImpl. This class will be used when creating a web bundle. Bug: 1040752 Change-Id: Ia42a374a005ea688003b5ede3f06c596a4c55304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010239Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#733851}
-
Luciano Pacheco authored
Currently is hard to debug Files app feedback report because Files app URL is redacted from logs, the URL is similar to: chrome-extension://$EXTENSIO_ID/. Bug: 979779 Change-Id: If08ddae7625c431bfe6ca67ac3dd257f14e8410f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011581 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#733850}
-
John Budorick authored
The ini logic was mistakenly keeping trailing spaces when parsing keys (at least). This CL fixes that and adds tests for ini handling. This also makes `avd.py start` default to starting a read-only AVD, as doing so has been useful in the course of debugging this & other issues. Lastly, this removes the use of org.chromium.base.Log from our hand-rolled Unzip implementation. Log is not available in the chromium_commands dex, and emulators that ran out of space were misleadingly failing with "Aborted" rather than a message about disk space issues. Bug: 922145 Change-Id: I86de27c1b1d4d3628312f26e79db45f6d982a961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013650 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#733849}
-
Demetrios Papadopoulos authored
This is done to pick up new formatting (as well as copyright year). Fixed: 1044302 Change-Id: I9b005bd328f9eca56cb1598468981bf768882d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013633 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#733848}
-
Julien Isorce authored
Fixes "vaInitialize failed: unknown libva error" on Wayland with LIBVA_DRIVER_NAME=i965 VaapiWrapper relies on the GL implementation to decide which display to use. If the GL implementation is none, then VaapiWrapper is likely to do the wrong guess resulting in the above error. Bug: 1041229 Change-Id: I1255a032a5e14b3aaffe3026a886de7e6d9ff0d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011640Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=michaeldo@chromium.org Bug: 1042208 Change-Id: I859020ffb6010934dd360e4364546c06465d3281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010783 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#733846}
-
Demetrios Papadopoulos authored
Specifically porting - cr_policy_indicator_behavior.js - cr_policy_indicator.js This is in preparation of further Polymer3 migrations (certificate manager, Settings). Bug: 1042558 Change-Id: Ia2accbc62ac581eaafbdaaa038b5b92765f53bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008017 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#733845}
-
Dan Beam authored
R=dpapad@chromium.org Bug: none Change-Id: Ifb969cba1b97d54d6aa990cf3598573fcd71bb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013919 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#733844}
-
Xianzhu Wang authored
Bug: 1035582 Change-Id: I07410021c7e38c641cfc4064443aa5af61454ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013323 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#733843}
-
Kai Uwe Broulik authored
DBus supports launching services on demand the first time a call is made to them. In case the service isn't currently running, check whether it would be activated when we try to call it. Especially in case of session restoration the browser might be launched before the shell's notification service is fully up and running. Change-Id: I6b2905aa1d74fe4c99a10b27637d842f7fb836cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975711Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#733842}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff2a47b9..4cde67a8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I34734eb71262c778aca37ba366005bd652fb747a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013363Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733841}
-
Alan Cutter authored
This CL moves the implementation of WebAppTabHelper out of web_applications/components down into a new web_applications:common source set. The publicly accessible methods of the class are retained in WebAppTabHelperBase. This is in preparation for migrating some of its dependencies out of web_applications/components. Many of the classes in components should be one level up as they're not isolated components or part of the public interface of web_applications. Bug: 1035242 Change-Id: I9d660e3450f8d0bb7ff7a5346346d117cabd6259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972741 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#733840}
-
Livvie Lin authored
Useful for testing. Bug: 987407 Change-Id: I9af198d67e224f52753b31c7722228c626128b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013519Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733839}
-
Liquan (Max) Gu authored
Context: this CL is to fix an bug where a swipe on the context caused inconsistent behaviours between swipe up and swipe down. While swipe up causes a page to scroll up, swipe down causes the UI to move down. Cause: PH UI is incorrectly configured so that BottomSheet mistakes the sheet as being at the max position. Before change: at full state, when the viewport of the Web View moves to the mid page, swiping down the Web View moves down the UI. Change: config getVerticalScrollOffset() as Preview Tab does. After change: at the same situation, swiping down the Web View scrolls up the content. Bug: 1040651 Change-Id: I4ac3ca369be0f2459d80df8fdfb093cc1b9f57c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008274Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#733838}
-
David Munro authored
Same owners as the UI backend. Test: None Bug: None Change-Id: I9b6e186334deeb4851db21afeead459108989c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011588 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733837}
-
Daniel Rubery authored
This CL adds two modal dialogs for Advanced Protection deep scanning. The first provides more information to the user when they click on the download shelf item. The second notifies the user when a scan has failed, so they can choose to either scan again or to give up on scanning. Mocks: https://docs.google.com/presentation/d/1LpP2sw2pUiux3PhzlPcilPCoRGBNpvm3nF5HltDbbeA/edit#slide=id.g7bb3529d00_0_0 Screenshots: https://screenshot.googleplex.com/EDZpk0WFFUn.png https://screenshot.googleplex.com/O6ezh5nDKBA.png Bug: 1020418 Change-Id: I94aa6d63ea429b760958e9ca26ed70b4231d94a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003400 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#733836}
-
Nick Diego Yamane authored
Tricium has started complaining about clang-tidy checks in x11_shm_image_pool_base.cc at https://crrev.com/a/1747274. This patch addresses the issues reported by it. Bug: None Change-Id: I9c117bdddd767e1b14b0b2df68ad97e9037b12a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013365 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
-
Alexey Baskakov authored
Make BookmarkAppShortcutManager responsible for bookmark apps. Bug: 860581 Change-Id: I683aebfd3bb321b26cf59f026436a5c78e4daac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006282Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#733834}
-
Sophie Chang authored
This makes the HintsFetchedCallback more general and paves the way for the async CanApplyOptimization where we need to associate each hints fetching attempt with its URL. Change-Id: I1c0e809dbcd4244ecc268ec77a107d115291bfd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013841 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#733833}
-
James Cook authored
Update styles for the dialog used with SplitSettingsSync to match go/cros-sync-mock. Remove an unused style from the legacy dialog. Legacy dialog (unchanged): https://screenshot.googleplex.com/1P8qoyMnKOX SplitSettingsSync dialog (updated): https://screenshot.googleplex.com/mXsGDhWqWsC Bug: 1023854 Change-Id: Iba6aaad03db7d9d457d8d32a15db4e51cb0e33df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006487 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#733832}
-
Antonio Gomes authored
... from content.mojom.FrameHost. BUG=1043760 R=avi@chromium.org, dominickn@chromium.org, dtapuska@chromium.org, haraken@chromium.org Change-Id: I404f00adfd4f03b20e918cc8abeef1f4b80d542b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012561Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Reid Kleckner authored
In Python 3, dict.keys() returns a generator instead of a list. Call list() to turn it into a list so that it can be indexed. I bravely decided to put Python 3 on PATH, and I needed this in order to re-run gn gen. This seems to be the only change needed to run `gn gen`. Later on in the build there are Unicode errors during mojo binding actions. R=brucedawson@chromium.org, hans@chromium.org Bug: 941669 Change-Id: Ib80e11798003999469776122b0a32f416909565b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013514Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#733830}
-
Bo Liu authored
Android 10 has a bug that UID used for non-primary user cannot be freed correctly, eventually exhausting the pool of UIDs for isolated services. There is a global pool of 1000 UIDs, and each app zygote has a smaller pool of 100; the bug appplies to both cases. The leaked UID in the app zygote pool are released when the zygote is killed; leaked UIDs in the global pool are released when the device is rebooted. So way to slightly delay until the device needs to be rebooted is to use up the app zygote pool first before using the non-zygote global pool. Add a workaround allocator that's only used under secondary user on Android 10. It will try to bind to a new service from the app zygote. If bind fails, which happens if the UID pool is exhausted, then try using the non app zygote service. Bug: 1035432 Change-Id: I07cba74a21076e4cbc9342705f7b69b97e011c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001998 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#733829}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-font-disk-loader-ios/+log/93acc021e303..8e30188777b0 git log 93acc021e303..8e30188777b0 --date=short --first-parent --format='%ad %ae %s' 2017-02-17 willlarche@users.noreply.github.com [Docs] Clarity in README (#1) Created with: gclient setdep -r src/ios/third_party/material_font_disk_loader_ios/src@8e30188777b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-font-disk-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I38257f67e6c97ec4023161b243678abf4b6257a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013202Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733828}
-
Li Lin authored
This is a reland of e03c42ac Original change's description: > Add Quick Answers context menu observer. > > The feature is guarded by a feature flag that is currently disabled by default. > > This CL implements a temporarily UI for getting early feedback on product and > data quality while we are figuring out the final UI. > > More detail at: go/quick-answers-cros and go/quick-answers > > Bug: 1020004 > Test: Unit tests > Change-Id: I17dac669c230f5fbd2052cd5683344fa30c41b85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961210 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Li Lin <llin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732713} Bug: 1020004 Change-Id: I04c8e73872d467c850227273b33ef6ad7f6d876a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008064Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Stephen Chenney authored
The non-worker version is also flaky. TBR=fs@opera.com Bug: 1042453 Change-Id: I1109cd338dcb06a5cf457418dcc6b2fe6def13ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013499 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#733826}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b5315e84d143..564dcf4c071b git log b5315e84d143..564dcf4c071b --date=short --first-parent --format='%ad %ae %s' 2020-01-21 brcui@microsoft.com DevTools: Add Sources setting option: Allow/Disallow scrolling past end of file 2020-01-21 ericlaw@microsoft.com [DevTools] Fix display of WebSocket messages 2020-01-21 jarhar@chromium.org Explain provisional headers message for cached requests 2020-01-21 cjamcl@chromium.org Add Moto G4 to emulated devices Created with: gclient setdep -r src/third_party/devtools-frontend/src@564dcf4c071b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1040155,chromium:1041752,chromium:924693,chromium:998270 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I868ddc5b8b43e1d90057f384f85bec85d90944a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013902Reviewed-by:
-
Rayan Kanso authored
Keep track of the next wake up time before sending a schedule request to the BackgroundSyncBackgroundTaskScheduler. Bug: 1042041 Change-Id: I02ce7b418ca2546937d7768e8df2cd53bf15822e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005230Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#733824}
-
Mike Dougherty authored
Existing BreadcrumbManagers are associated with BrowserStates via BreadcrumbManagerKeyedService instances. This CL adds an application wide BreadcrumbManager for logging global events not tied to a specific BrowserState. Logged events currently come from listening to UserActions and memory pressure events. Bug: 1003922 Change-Id: If0e1db381755043d85487e0a85fbb9037abae263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987368 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
Eric Robinson authored
In the case where the previous state of the finch trials was unknown (when the previous status was not saved previously due to this feature not being in the code), we had been defaulting to resetting the cache. This CL changes that behavior and only resets when there is a known change to the cache. It also improves the testing to use PRE_ tests to more accurately model reloading behavior rather than relying on explicitly setting variables. Also fixes flaky behavior introduced due to cross-process testing. Note the TODO regarding the bug to clean up the manner in which we resolve the race condition. Bug: 1041542,1041810 Change-Id: I9c40c9be9682b5372e1f3fb2851ef6531802f1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003249 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#733822}
-
Istiaque Ahmed authored
Move ComputedHashes's underlying data into its own class ComputedHashes::Data, that wraps the canonicalization logic in it. Adding items to Data would canonicalize paths, obviating the need for a) the linear search in case-insensitive OS. b) additional dot-space trimming treatment on windows. Bug: 796395 Change-Id: I1517f6daa8253562b731cf62a5c54fb95f2bd10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003261 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#733821}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3003aa622b2f..80880ee99854 git log 3003aa622b2f..80880ee99854 --date=short --first-parent --format='%ad %ae %s' 2020-01-21 natlee@microsoft.com Device Loss handle GetBindGroupLayout and test Created with: gclient setdep -r src/third_party/dawn@80880ee99854 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ie641d7d9d4709bf41043db33fb46819a049a4697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013900Reviewed-by:
-
Xiaocheng Hu authored
When copying in an image document, in most cases, there's no selection, and we just want to copy the image itself. So we have a fast path for that. However, Javascript may insert other contents into an image document, which can be selected and should be copyable. This patch detects this case, and if so, uses the normal code path instead of the fast path. Bug: 1042468 Change-Id: I45f5f296dc93040fd770f017b6220c51048b954b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007657Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#733819}
-
Daniel Rubery authored
This reverts commit cb210848. The original CL and https://chromium-review.googlesource.com/c/chromium/src/+/2003909 interacted, causing a build breakage. This has been fixed between patchsets 1 and 2. Original CL description: > Add code to generate PROMPT_FOR_SCANNING verdicts > > This CL adds the code needed to generate PROMPT_FOR_SCANNING danger > types. This danger type is used when an Advanced Protection user > downloads a file that is marked as UNCOMMON. It causes the user to be > prompted to send this file to Google for deep scanning. The generation > of these verdicts is guarded by a Finch flag as well as the user's > Advanced Protection enrollment status. > > It also removes the old Finch flag related to Safe Browsing performing > additional download scanning for Advanced Protection users, to > minimize confusion. Bug: 1020418 Change-Id: Iea42aa1ad8ca8aa0750449969e265e783ab6f85d TBR: mek@chromium.org, tedchoc@chromium.org, xingliu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013800 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#733818}
-
Jinsuk Kim authored
Deletes the convenience public methods in TabImpl class. The callsites use a new util method defined in Preview or SecurityStateModel. Tests that relied on TabImpl.getSecurityModel for mocking out the method now has a new one in the class being tested. Bug: 995903 Change-Id: I00d52617a10999be8dc36f629dbc64b5aa0d8bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000411 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#733817}
-
