- 10 Nov, 2017 40 commits
-
-
Colin Blundell authored
sync_ui_util::ConstructAboutInformation() currently only initializes the username field if SyncService::signin() is non-null. In an upcoming refactoring to change this function to use the Identity Service instead, it will no longer be possible for the client to differentiate the situation where SyncService::signin() is null from the situation where the user simply isn't signed in. To avoid coupling a behavioral change with a refactoring, this CL first explicitly makes the behavioral change to initialize the username field in all cases, setting it to the empty string if SyncService::signin() is null. The only user-visible effect that this will have is that if there are any situations wher SyncService::signin() is null in production, the user will see the username field being empty in chrome://sync-internals rather than having a value of "Uninitialized." Bug: 783144 Change-Id: Ie090a2635549072f86d15b86fb98891396abdb08 Reviewed-on: https://chromium-review.googlesource.com/758685Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#515505}
-
Shubhie Panicker authored
Bug: 764104 Change-Id: I45cd6ae2d0d4911e0f156e53333080c7e2bf53ba Reviewed-on: https://chromium-review.googlesource.com/762118 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#515504}
-
Yoshifumi Inoue authored
This patch gets rid of null |LocalFrame| checks from |SelectionModifier| since it is always non-null |LocalFrame| initialized from |LocalFrame&| to simplify source code for improving code health. Change-Id: I183aa2eb588d0f3d67c4255acc68f4b05f2771bf Reviewed-on: https://chromium-review.googlesource.com/762831Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515503}
-
Alexandr Ilin authored
The predictors::kSpeculativePreconnectFeature is explicitly disabled in net::Predictor browser tests because the LoadingPredictor if enabled intercepts all prefetch and preconnect coming from a renderer. WarmupManagerTest.testPreconnect() was expecting two connections to be opened but it's not the case for the LoadingPredictor, it opens only one connection. Bug: 699080 Change-Id: I73537c3a59818793e41c5741762fe675a4efa97f Reviewed-on: https://chromium-review.googlesource.com/754837Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515502}
-
Yutaka Hirano authored
They now pass. Bug: 441781 Change-Id: I98dad704808c2ed810ff9d03e0e49200b8e90209 Reviewed-on: https://chromium-review.googlesource.com/762930Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#515501}
-
Wei-Yin Chen (陳威尹) authored
There are lots of occurrences of canUseGooglePlayServices() and canUseFirstPartyGooglePlayServices() using application context and silent error handler. These are refactored to static functions. Bug: 782496 Change-Id: Ifd554cb3ce62784db333f97f6a1bcb4a98999d28 Reviewed-on: https://chromium-review.googlesource.com/760697 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#515500}
-
Nodir Turakulov authored
Hooks tend to have implicit dependencies //.vpython covers or should cover all of them, so run all hooks via vpython Also add missing catapult's dependencies to .vpython. Bug: 781430 Change-Id: I5ec7a760f44bcb806c654ad8da303f78d3dbee3f Reviewed-on: https://chromium-review.googlesource.com/762037 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#515499}
-
Dan Elphick authored
Add a new GetRegistrationTask to be used by BackgroundFetchDataManager when the persistent storage flag is enabled. Adds the origin to the proto stored in the database and check it matches when retrieving a registration, otherwise trigger a storage error. Make BackgroundFetchDataManagerTest parameterized by persistence, which turns on the command line flag. Now all tests run (and pass) with or without persistence although the Cleanup test doesn't test much yet since there's no way yet to interact with a non-active fetch. Bug: 757760 Change-Id: I3aa29e17f9112f282f5672366e52522e549f32d0 Reviewed-on: https://chromium-review.googlesource.com/758762Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#515498}
-
Renee Wright authored
Here is the diff of the generated files https://gist.github.com/rjwright/61829820d0cbb6d304eebc345a29ab76/revisions Bug: 779927 Change-Id: Ia13f9a0c6f788fc7b7030f1248a8ecd44ec6ba7b Reviewed-on: https://chromium-review.googlesource.com/760018 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#515497}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7af1dc56fc10..0ffcc877a624 $ git log 7af1dc56f..0ffcc877a --date=short --no-merges --format='%ad %ae %s' 2017-11-09 nodir [gclient hooks] add .bat to vpython on windows Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I4186dae198699abdb543b860c8db91eb3d9baa6b Reviewed-on: https://chromium-review.googlesource.com/762947Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515496}
-
Rakina Zata Amni authored
Currently, EventTarget cannot be constructed or be subclassed (in JavaScript). The spec for EventTarget was updated to allow constructing and subclassing EventTarget. A new class, EventTargetImpl, is created as the user-constructable version of EventTarget. Even though the name is EventTargetImpl, it will be exposed as EventTarget to JavaScript. We are using a hacky approach by making EventTarget::Create return an instance of EventTargetImpl, which means an instance of EventTargetImpl will be returned when the EventTarget object is constructed in JavaScript. Spec: https://dom.spec.whatwg.org/#dom-eventtarget-eventtarget Design doc: https://docs.google.com/a/google.com/document/d/1TXMAkLeaNpbbETeqTyJZ57YnmqzgchyhFsANVZ2Ow3Y/edit?usp=sharing Bug: 740576 Change-Id: Ia0569ee99c4d856120c387ca6aceed5fbe1491b5 Reviewed-on: https://chromium-review.googlesource.com/754248Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#515495}
-
Guido Urdaneta authored
When multiple getUserMedia and stop() requests are active concurrently, getUserMedia() sometimes fails with TrackStartError. The reason is that the underlying video capture subsystem does not keep a count of how many sources have opened a video device. It can happen that a stop request stops video capture while a getUserMedia() request is being processed, with the result being that the video device is closed before getUserMedia() starts the new video track, resulting in an error. One solution to this problem is to make sure that stop requests and getUserMedia() requests cannot run concurrently, which is the approach followed by this CL. This CL basically moves handling of MediaStramTrack.stop() from MediaStreamCenter to UserMediaClient, and puts stop() requests in the same queue used for getUserMedia() and applyConstraints() requests. Bug: 778039 Change-Id: Id7e0ee38e40265fd599dc6dd0712f0b667d2e1a5 Reviewed-on: https://chromium-review.googlesource.com/751981Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#515494}
-
Takashi Toyoshima authored
Since the feature was launched, let me remove the code for field trial. Bug: 683027 Change-Id: I2f09e1484c4b8e88f636e25a0a79847f6458ac35 Reviewed-on: https://chromium-review.googlesource.com/760140 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#515493}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/309fa59a2992..c7056ca0027e $ git log 309fa59a2..c7056ca00 --date=short --no-merges --format='%ad %ae %s' 2017-11-09 npm Remove a couple of unused methods in CXFA_FFWidget Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I924626b6cd3c20eede9a2ffe7294b8713ad52cd8 Reviewed-on: https://chromium-review.googlesource.com/762770 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515492}
-
Darren Shen authored
We currently don't support relative URLs. This patch uses ScriptState to resolve relative URLs. Note that the CSSURLImageValue.url needs to return the original (relative) url given by the constructor. Since CSSImageValue already stores the relative url for serialization, we only need to expose it to CSSURLImageValue. Bug: 783031 Change-Id: I12b7ae8e98306e4debd6d3b1a9fd1ef1eca9752e Reviewed-on: https://chromium-review.googlesource.com/760057 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#515491}
-
Kunihiko Sakamoto authored
This implements link rel=modulepreload without submodules fetch, behind the Experimental Web Platform feature flag. LinkLoader fetches module script using Modulator::FetchSingle, so it populates the module map but does not fetch descendant modules. Unlike the preload fetches by link rel=preload, this doesn't set FetchParameters::SetLinkPreload flag, so it works like a regular script fetch. HTMLPreloadScanner fetches module scripts in a similar way to speculative preload of <script type=module>, i.e. just fetch a ScriptResource and not populate the module map. Spec PR: https://github.com/whatwg/html/pull/2383 Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ynkrM70KDD4 Bug: 740886 Change-Id: I5f4420e305f4962b3fbe3f703ce95a5a43e4f7a9 Reviewed-on: https://chromium-review.googlesource.com/662697 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#515490}
-
Yoshifumi Inoue authored
This patch changes |NextBoundary()| to utilize |EmitsSmallXForTextSecurity| |TextIteratorBehavior| to handle -webkit-text-security CSS property in |TextIterator| to reduce source code for improving code health. This patch is similar to the patch[1]. http://crrev.com/c/760218: Utilize EmitsSmallXForTextSecurity TextIteratorBehavior in PreviousBoundary() Bug: 778507 Change-Id: Ia62bcec825be863ff15a9075eeb22f2a6a9ee981 Reviewed-on: https://chromium-review.googlesource.com/760063 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#515489}
-
Yves Arrouye authored
Set a CrOS setting from cloud's device settings' forced re-enrollment. Add an enrollment policy observer which observes the setting and uploads an enterprise enrollment certificate when identification is needed. This certificate will be used by the server to obtain the device's enrollment ID for automatic forced re-enrollment. Bug: 778535 Test: unit_tests Change-Id: I7e95148e8101c27faa3dc1d21eb44971c79ee3c6 Reviewed-on: https://chromium-review.googlesource.com/758116 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#515488}
-
Tatsuhisa Yamaguchi authored
Zip Archiver is a new component extension that handles zipping and unzipping. After this change, Files app. will use Zip Archiver for unzipping zip files. It will also allow to unzip a zip file in the Google Drive volume or other non-local places. Bug: 783200 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3851c8c801d58a7573632e664b4fc2fca92acb83 Reviewed-on: https://chromium-review.googlesource.com/758696Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#515487}
-
Daniel Cheng authored
Change-Id: I40fc2ff294e2f8c66380d49f0d350e7eba3c7bc5 Reviewed-on: https://chromium-review.googlesource.com/762949Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#515486}
-
Rakina Zata Amni authored
The spec for node filtering steps was recently updated, adding active flags to avoid recursive invocations. This change added the active flag property and the active flag checks in the node filtering steps. Spec: https://dom.spec.whatwg.org/#concept-traversal-active Bug: 753271 Change-Id: I7cdd57f86401bd6ea9a8012f28b47afa8a60a65b Reviewed-on: https://chromium-review.googlesource.com/760238 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#515485}
-
Sriram authored
Bug: 782141 Change-Id: I243c94935989866778fa75169070326364ddfe38 Reviewed-on: https://chromium-review.googlesource.com/760438 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#515484}
-
Yoshifumi Inoue authored
This patch changes |PreviousBoundary()| to utilize |EmitsSmallXForTextSecurity| |TextIteratorBehavior| to handle -webkit-text-security CSS property in |SimplifiedBackwardTextIterator| to reduce source code for improving code health. This patch is similar to the patch[1]. [1] http://crrev.com/c/760063: Utilize EmitsSmallXForTextSecurity TextIteratorBehavior in NextBoundary() Bug: 778507 Change-Id: I4612c7916498ee2604062ac50eb79803f93172e9 Reviewed-on: https://chromium-review.googlesource.com/760218 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#515483}
-
yoshiki iguchi authored
This change is prevent a notification from hiding during the user is entering a text. This CL works with: - ag/3166118 - ag/3174823 Bug: b/68156269 Change-Id: I1107e1141acebe62e8f381020534b007fa0cbaf5 Reviewed-on: https://chromium-review.googlesource.com/754252Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#515482}
-
John Abd-El-Malek authored
This is a followup to r514556 per comments in https://chromium-review.googlesource.com/c/chromium/tools/build/+/758799/. Bug: Change-Id: If42ea0e4bd43f10a5a44f7ce16dd4c721c9f3603 Reviewed-on: https://chromium-review.googlesource.com/761976 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#515481}
-
Hidehiko Abe authored
Rewrite GetProperties_TetherNetwork test with fake. BUG=234463 TEST=Ran bots. Change-Id: If991bbbccb221578d9db614790eb244593205efd Reviewed-on: https://chromium-review.googlesource.com/749602Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#515480}
-
Catherine Mullings authored
This CL includes the initial changes to support the new extension API that merges the page action and browser action APIs. Namely this CL adds changes to support the new manifest key called "extension_action" and defines the new API. Bug: Change-Id: Id8975237c02df85c1144451e00de5b116e3bab21 Reviewed-on: https://chromium-review.googlesource.com/714651 Commit-Queue: catmullings <catmullings@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515479}
-
Manish Jethani authored
With crrev.com/c/641294 we introduced user style sheets, but without taking into account custom properties. This patch adds support for custom properties in user style sheets by calling StyleResolver::ApplyMatchedProperties for user rules in the correct order. BUG=632009,781223 Change-Id: I1c103fc37484835008b1b55e9b3b8099af50a48a Reviewed-on: https://chromium-review.googlesource.com/754247Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#515478}
-
Miguel Casas-Sanchez authored
This CL adds a new file vaapi_video_decode_accelerator_unittest and adds it to media_unittests when use_vaapi is true. The new file is then compiled as part of the top level chromiumos_preflight group (in particular by chromeos_amd64-generic_chromium_compile_only_ng), and also in the linux_chromium_chromeos_ bots. This CL also adds a few test cases, dealing mostly with the interaction of input buffers and the VaVDA's internal |decoder_|. (More tests to come). Note that: vaapi_..._unittest needs vaapi to be compiled but not to be run. Bug: 717265 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4b8768e79401170269190292ebf18ef616adb1f8 Reviewed-on: https://chromium-review.googlesource.com/753756 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#515477}
-
Yoshifumi Inoue authored
This patch disables LayoutNG for block-level contenteditable until we're ready to start working on. Also gives us more test opportunities of mixed-tree layout. This patch is continued from the patch[1]. The idea of this patch is attaching legacy layout object to block-level element if it is editaible instead of NG layout object. Hence, this patch doesn't disable inline-level contenteditable, e.g. <span contenteditable>foo</span>. Following patch will handle inline-level contenteditable as similar as RUBY in NG block layout object. [1] http://crrev.com/c/734962 [LayoutNG] Disable LayoutNG for contenteditable Bug: 707656 Change-Id: Ia7a20d88f2e9499dc614791e46021072e4702669 Reviewed-on: https://chromium-review.googlesource.com/758309 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#515476}
-
Alexey Kozyatinskiy authored
All except one in debugger-pause folder. R=chenwilliam@chromium.org Bug: chromium:667560 Change-Id: I5feb2808726219c608301b77a3a406063c0d04be Reviewed-on: https://chromium-review.googlesource.com/761196Reviewed-by:
Will Chen <chenwilliam@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#515475}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/22499b0969ac..832536627766 $ git log 22499b096..832536627 --date=short --no-merges --format='%ad %ae %s' 2017-11-10 angle-deps-roller Roll skia/third_party/externals/angle2/ 9e888a46f..ee6884e7b (1 commit) 2017-11-10 egdaniel Revert "Dynamically load the vulkan library in our test tools" Created with: roll-dep src/third_party/skia BUG=783054 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Ic8a46e40c2a38f4f05946ef67fc8dd53f0a08f33 Reviewed-on: https://chromium-review.googlesource.com/762124Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515474}
-
Yutaka Hirano authored
This CL replaces Domain::kTest with ordinary Domain::kNet failures. As Domain now has only one element (kNet), this CL removes the enum entirely. Bug: 748491 Change-Id: If593ee0111b18dfdd2bb6ba98332f0ed93dd78e4 Reviewed-on: https://chromium-review.googlesource.com/749612Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#515473}
-
Scott Violet authored
These tests now pass since PDF were made to work (755440). BUG=755272 TEST=test only change TBR=msw@chromium.org Change-Id: Id79e8aa6dbf810a5f6789943e5b6a2665e2dc3e4 Reviewed-on: https://chromium-review.googlesource.com/761956Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#515472}
-
Mark Mentovai authored
6f6f8a144d89 Add FileModificationTime 13e17bf90f1e Fix FileModificationTime for Android e2b9ab3ed202 win: Tests shouldn’t freak out when CodeView PDB links are absent 0e3c38a4ca52 win: Make ProcessSnapshotTest.CrashpadInfoChild use a loaded module b8f61fdc8b1e Add TimevalToTimespec and use it to get CurrentTime on macOS Bug: 782781 Change-Id: Id8943d8e245cf3cbdb97ad52bcd664fa9dddab2a Reviewed-on: https://chromium-review.googlesource.com/761878 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#515471}
-
Wenzhao Zang authored
1) We need larger bullets, which is essentially the same with setting different sizes (or FontList) for the bullets and placeholder. 2) We need letter spacing, which can be done by making the line advance more each time in |RenderTextHarfBuzz::ShapeRunWithFont|. Bug: 719015 Change-Id: Ie5370e44d767e54264fa2e4ccb02a481063558da Reviewed-on: https://chromium-review.googlesource.com/732526Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#515470}
-
Will Harris authored
This is a reland of bc2056c3 Original change's description: > Change size in memory mapped region to size_t > > Subsequently, remove some static_casts that are no longer needed. > > On Windows, while it is possible to create a file mapping of a file > > 32-bits long it is not possible to create the view to the file > mapping, so changing this to size_t should have no loss of functionality. > > BUG=778316 > > Change-Id: I81cd2e0808794fdb83fc21c796367369ea2da220 > Reviewed-on: https://chromium-review.googlesource.com/755114 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515257} Bug: 778316 Change-Id: I7456feb2e84fc8bf78514d570f868212093500dd Reviewed-on: https://chromium-review.googlesource.com/761408Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#515469}
-
Timothy Loh authored
The durable storage permission is automatically granted or denied based on various heuristics and we never prompt the user for permission. This patch removes this permission from histograms which are only logged for permissions that prompt. Bug: 638076 Change-Id: I7b421f87b5eb2f6fcb0527a90efe1b7908842e4d Reviewed-on: https://chromium-review.googlesource.com/756476Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#515468}
-
Yuwei Huang authored
This CL implements OAuthTokenGetter for Android. This is part of the project of implementing a centralized access token getter in client C++ code, so that multiple components like telemetry logger, ICE config fetcher, and session connector can use the same token fetcher without requesting access token back and forth through JNI. Bug: 780736 Change-Id: I265fe963ef6f9e1720b3a7e3f209704be8686957 Reviewed-on: https://chromium-review.googlesource.com/760184 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#515467}
-
Dave Schuyler authored
This Cl replaces the use of paper-menu in MD extensions with an iron-selector Bug: 779282 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I424fbced792781e1ad2a063ab50ce9a93f156660 Reviewed-on: https://chromium-review.googlesource.com/762107Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#515466}
-