GitLab

Swaps Chrome/Chromium where appropriate.
Screenshot in bug.

BUG=622174
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2106253002
Cr-Commit-Position: refs/heads/master@{#403194}

This catches issues with compositing solid color quads.
Test is initially expected to fail until reference images are generated.

R=kbr@chromium.org
BUG=624256
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2112603003
Cr-Commit-Position: refs/heads/master@{#403193}

https://chromium.googlesource.com/angle/angle.git/+log/be5a8a4..3c75419

BUG=chromium:617848,598924,chromium:617627,chromium:534814,483282,620937

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2119463002
Cr-Commit-Position: refs/heads/master@{#403192}

This CL changes the return types of both properties to FrozenArray<>,
amends Notification.actions to also freeze the individual
NotificationAction objects contained therein, and enables the properties
by default.

In addition, [SameObject] semantics have been added to the two
properties, which now mean that they will continue to return the same
value, making the equality operator work as expected.

Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/0mBO8Q5FhTo/2OagzgagBgAJ

BUG=547716, 442132

Review-Url: https://codereview.chromium.org/1974033003
Cr-Commit-Position: refs/heads/master@{#403191}

1. Moved and resized the avatar icon as well as icon badges
1. Moved avatar name up to be on the right of the profile icon
2. Moved username and "Your accounts" link up and below the avatar name
3. Other dimension and padding changes

See design doc here ("Reflow the items in the first section"): https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.6xesoh23gozz

See redlines here:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu#

See screenshots here (marked with "3.*"):
https://drive.google.com/corp/drive/folders/0B7Fvv7JszRyGY2NrSEhheHptdG8

Downstream CL: https://codereview.chromium.org/2052473003/

BUG=615893

Review-Url: https://codereview.chromium.org/2023093002
Cr-Commit-Position: refs/heads/master@{#403190}

BUG=621512

Review-Url: https://codereview.chromium.org/2106793002
Cr-Commit-Position: refs/heads/master@{#403189}

Instead of observing through the WebstoreAPI, observe directly in the TabHelper.
This is a great deal less code, more direct, and also fixes a lifetime issue
with the TabHelper being deleted before the inline installation completes.

BUG=613949

Review-Url: https://codereview.chromium.org/2103663002
Cr-Commit-Position: refs/heads/master@{#403188}

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2102123002
Cr-Commit-Position: refs/heads/master@{#403187}

If DidStopLoading is called on WebContentsObserver immeditely after navigation
is requested, then window_ in could be released via StopObservingIfDone as soon
as GoForward/GoBack is called

OerscrollNavigationOverlay::OnOverscrollCompleted requests navigaions by calling
GoForward/GoBack on the controller. If these navigations immeditely trigger
DidStopLoading, main_window->SetTransform would segfault.
Protect against this case by setting up the transforms and window positioning
before doing navigation.

BUG=623620

Review-Url: https://codereview.chromium.org/2102283002
Cr-Commit-Position: refs/heads/master@{#403186}

AcceptConnection and OnInitialize are racing. Only pause the interface
registry if OnInitialize is not invoked.

TEST=arc video playback well
BUG=620845

Review-Url: https://codereview.chromium.org/2112493003
Cr-Commit-Position: refs/heads/master@{#403185}

https://helpx.adobe.com/security/products/flash-player/apsb16-18.html

BUG=412078
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
TBR=jschuh@chromium.org

Review-Url: https://codereview.chromium.org/2113703002
Cr-Commit-Position: refs/heads/master@{#403184}

Reduce the depth used by PerformanceTests/Parser/
query-selector-deep.html and query-selector-id-deep.html

These performance tests have been disabled since June 2013 as they were
observed to crash "on 6 of the last 9 runs"

BUG=245702

Review-Url: https://codereview.chromium.org/1880383002
Cr-Commit-Position: refs/heads/master@{#403183}

This patch keeps track of a script tag's type and language attributes,
and gates preloading if they are invalid. This aligns the preload scanner's
policy with the ScriptLoader's policy.

BUG=623109

Review-Url: https://codereview.chromium.org/2099853002
Cr-Commit-Position: refs/heads/master@{#403182}

In addition to removing the failure expectations associated with http://crbug.com/608457, this CL also sorts expectation lines in the file, and changes expectations based on local runs on my workstation:

Added pass expectations:
 crbug.com/508725 imported/wpt/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script.html [ Pass ]
 crbug.com/508725 imported/wpt/mediacapture-streams/GUM-trivial-constraint.https.html [ Pass ]
crbug.com/508725 imported/wpt/pointerevents/pointerevent_constructor.html [ Pass ]

Removed failure expectations:
 crbug.com/508734 imported/wpt/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-fixed.html [ Timeout ]

BUG=608457

Review-Url: https://codereview.chromium.org/2113463003
Cr-Commit-Position: refs/heads/master@{#403181}

There's a crash caused by asynchronous audio focus events.
MediaSessionDelegate may receive audio focus change signals after
MediaSession::~MediaSession is called. This CL adds checks to see if the
native MediaSession is destroyed before calling it's methods.

BUG=624208

Review-Url: https://codereview.chromium.org/2111163002
Cr-Commit-Position: refs/heads/master@{#403180}

It is a standalone .so library meant to be LD_PRELOAD-ed
using awkward tricks into the Android zygote to get heap dumps.
Never worked too well in Chrome as it intercepted only malloc
calls, without being able to hook allocations in PartitionAlloc
or Blink GC.
This is subsumed by the work of crbug.com/602701 which
integrates native heap profiling with chrome://tracing and
supports all the major chrome allocators.
For future heap profiling adventures use
//components/tracing/docs/heap_profiler.md

This CL also removes //third_party/bsdtrees that was introduced
as a dependency to libheap_profiler. Nothing else seems to
depend on it.

BUG=382489

Review-Url: https://codereview.chromium.org/2105873005
Cr-Commit-Position: refs/heads/master@{#403179}

Cleaning up video-controls-visibility* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2118453002
Cr-Commit-Position: refs/heads/master@{#403178}

ScatteredStreamWriter is the core class that will be used to
serialize proto messages in flight into the trace buffer chunks.
This class handles writes and spreads them over non-contiguous
memory chunks without causing extra copies.

BUG=608719

Review-Url: https://codereview.chromium.org/2047273002
Cr-Commit-Position: refs/heads/master@{#403177}

Design doc: https://docs.google.com/document/d/1qdlgaC277SnnmQv7hoNFTGp-OCvokEc4mA2NmAzOyBU/edit?usp=sharing

BUG=550967
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1991273003
Cr-Commit-Position: refs/heads/master@{#403176}

Jim is no longer working on Chromium (much?), and does not typically respond to
metrics code reviews. Avoid delaying contributors by removing him from the list
of OWNERS.

BUG=none
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2114483002
Cr-Commit-Position: refs/heads/master@{#403175}

BUG=443781,568175
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2098613005
Cr-Commit-Position: refs/heads/master@{#403174}

Reason for revert:
Now tested with webview-related downstream gn args enabled.

TBR=brettw
BUG=620034

Review-Url: https://codereview.chromium.org/2109293003
Cr-Commit-Position: refs/heads/master@{#403173}

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=zelidrag@chromium.org

Review-Url: https://codereview.chromium.org/2083493004
Cr-Commit-Position: refs/heads/master@{#403172}

This CL updates the test filters for the FYI bot LinuxBrowserSideNavigation.
This follows the change for ServiceWorker support where we removed our first
implementation that was only partially working.
Making this NOTRY since there are no code changes and this is for an FYI bot.

BUG=504347, 576261
TBR=carlosk@chromium.org
NOTRY=TRUE

Review-Url: https://codereview.chromium.org/2110263003
Cr-Commit-Position: refs/heads/master@{#403171}

zoom, translate, passwords) and content settings icon.

This doesn't do anything for other icon label bubble views (like the
location icon). Some of the code in ContentSettingImageView should
probably be moved into IconLabelBubbleView for that. Also, there's no
hover or focus effect when the label is showing (e.g. when Chrome first
blocks a popup and there's text next to the icon). Since it remains
unclear to me how the hover and press effects should look in this
scenario, limit the ink drop to when only the icon is visible.

BUG=591140

Review-Url: https://codereview.chromium.org/2098643002
Cr-Commit-Position: refs/heads/master@{#403170}

Multiple parts of the code need to access the "ln="
field, if any, in the second line text fields of a
SuggestionAnswer. Move the parse and access method
to a central place, and fix up the callers.

BUG=

Review-Url: https://codereview.chromium.org/2091473003
Cr-Commit-Position: refs/heads/master@{#403169}

Covers:
rtc_video_decoder.cc
rtc_video_decoder_factory.cc
rtc_video_decoder_factory.h
rtc_video_decoder.h
rtc_video_decoder_unittest.cc
rtc_video_encoder.cc
rtc_video_encoder_factory.cc
rtc_video_encoder_factory.h
rtc_video_encoder.h

The above files have been moved to content/renderer/media/gpu.

BUG=None
TEST=Build Chrome on ChromeOS

Review-Url: https://codereview.chromium.org/2095393002
Cr-Commit-Position: refs/heads/master@{#403168}

BUG=624503

Review-Url: https://codereview.chromium.org/2102883005
Cr-Commit-Position: refs/heads/master@{#403167}

-[NSWindow isVisible].

After restoring from a miniaturize, child windows are currently reattached too
early. This is because AppKit draws the window before updating the result of
-[NSWindow isVisible], and we need to participate in that draw. But updating
child window relationships at this time causes layering issues when the window
has finished restoring.

BUG=620266

Review-Url: https://codereview.chromium.org/2069103004
Cr-Commit-Position: refs/heads/master@{#403166}

Also change all remaining invocations of the copy constructor or copy assignment
operator to move or explicit copy.

This CL lands server change 126070406 by bnc.

BUG=488484, 621905

Review-Url: https://codereview.chromium.org/2102253003
Cr-Commit-Position: refs/heads/master@{#403165}

Previous CL on authorization timeout decrease is being reverted https://codereview.chromium.org/2106373002/, this one should be landed instead.

The reason is we hit authorization timeout on platforms other than Windows (https://uma.googleplex.com/p/chrome/timeline_v2?sid=74e6fc3b3d0ef041f64f37272402ebb1), but the goal was to address windows driver hangs only.

BUG=615589

Review-Url: https://codereview.chromium.org/2116443002
Cr-Commit-Position: refs/heads/master@{#403164}

BUG=615382

Review-Url: https://codereview.chromium.org/2110653002
Cr-Commit-Position: refs/heads/master@{#403163}

Refactored using Seb's method ;)

BUG=None
TEST=AutofillFieldTest

Review-Url: https://codereview.chromium.org/2113453002
Cr-Commit-Position: refs/heads/master@{#403162}

This is a roll-back to 5.3.332.1. This is the most stable candidate out of the latest Canaries.

If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back.

When in doubt please try to contact the committer and reviewers of this CL before reverting it.

TBR=machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2117443003
Cr-Commit-Position: refs/heads/master@{#403161}

Record only one poll action if the same field is queried for suggestions multiple times consecutively.

BUG=624753

Review-Url: https://codereview.chromium.org/2111863002
Cr-Commit-Position: refs/heads/master@{#403160}

This target was overlooked and will be used by refactoring of
ios_chrome_unittests.

BUG=624450

Review-Url: https://codereview.chromium.org/2119433002
Cr-Commit-Position: refs/heads/master@{#403159}

https://chromium.googlesource.com/skia.git/+log/fc5b70a8e427..df4f47b8ff63

$ git log fc5b70a8e..df4f47b8f --date=short --no-merges --format='%ad %ae %s'
2016-06-30 benjaminwagner Revert of Better encapsulate oval/rrect batchs. (patchset #4 id:60001 of https://codereview.chromium.org/2104423003/ )
2016-06-29 bsalomon Hide more GrBatch Geometry structs. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2110903002
2016-06-29 bsalomon Better encapsulate oval/rrect batchs. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104423003

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;master.tryserver.chromium.android:android_arm64_dbg_recipe
TBR=benjaminwagner@google.com

Review-Url: https://codereview.chromium.org/2111893002
Cr-Commit-Position: refs/heads/master@{#403158}

BUG=619741

Review-Url: https://codereview.chromium.org/2108873004
Cr-Commit-Position: refs/heads/master@{#403157}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/11d23802de36..ead31d8dd552

$ git log 11d23802d..ead31d8dd --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2112493004
Cr-Commit-Position: refs/heads/master@{#403156}

* Add remote-shell interface to control system modality
* Add shell-mode event to notify the shell mode switch
* Shadow underlay should be deleted when shadow is turned off

In new patch
* updated system modal test in shell_surface_unittests to match new api.

BUG=b/29625835, b/29229887
TBR=reveman@chromium.org

Review-Url: https://codereview.chromium.org/2109303003
Cr-Commit-Position: refs/heads/master@{#403155}