- 19 May, 2020 40 commits
-
-
Collin Baker authored
This is a reland of 2a23cb68 The build failure was due to an ash header being included in a non-ChromeOS build. This managed to build correctly until my CL. The reland makes the include conditional on building for ChromeOS. TBR=oshima@chromium.org Original change's description: > Scale source window during tab drag-and-drop > > This behavior is very similar to tablet mode tab drags from the native > tab strip. Some of this code is copied, and some is shared (through > TabletModeBrowserWindowDragSessionWindowsHider). > > Bug: 1069869 > Change-Id: If5c6f163f7d8af9918be3bc97ca8a91b1df063c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202507 > Commit-Queue: Collin Baker <collinbaker@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770272} Bug: 1069869 Change-Id: I02f6becf72fac663a744d2033e16e2fd14dce843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209384Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#770322}
-
Trent Apted authored
Syncs media_app.externs.js with cl/312200889. Annoyingly closure doesn't let fromClipboard remain undefined, so make it explicitly false. Bug: b/134975059 Change-Id: I6c0fb8fbc91c5dfce52a4ec3cce92467869c9296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206771Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#770321}
-
dpapad authored
Bug: 1000989 Change-Id: Ia607dc32e46ab88d88f889feef873189bad5ea3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209290 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770320}
-
Rouslan Solomakhin authored
Move PaymentRequestUpdateEventListener from sub-interface in PaymentApp.java to its own file. Bug: 1083242 Change-Id: I0d8323b7dc2f75546ca3086897cb642e1e85111d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205873 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#770319}
-
Alexandre Frechette authored
Bug: 1044196 Change-Id: Ie4a96b06ee8169bee76e07c79334cbc6d34a78aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209345Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#770318}
-
Piotr Pawliczek authored
Adds a method that allows for setting a new port value directly from a string. Also add missing validation for the old SetPort(int) method. BUG=none TEST=on my laptop, a dedicated unit test was added Change-Id: I3adc98928ef7e136619cbce4184dff1d1dc11e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208650 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#770317}
-
Ben Joyce authored
Makes it so we only jetify libraries that specifically request it. Previously we jetified all libraries and let them opt out. Now everything is opted out unless requested to be jetified. This will decrease build time. before change building chrome_public_apk: user 118m19.720s sys 12m29.984s after change building chrome_public_apk: user 112m5.589s sys 11m25.513s Bug: 1069613 Change-Id: I20bbef5cb1bad9c84fc53272af6a0835692f586c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172133 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#770316}
-
Will Cassella authored
There are a lot of occurrences of c-style casts and other minor warnings that clutter my error-jumping keybinding. This CL removes them, and additionally introduces an implementation of operator<<(std::ostream&) for media::HTMLMediaElement that just outputs its memory address, since that already appears to be the de facto way of printing it. Change-Id: Idaa763ceed878835fa3e7661c0c85355ba3ef42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183289Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#770315}
-
Manuel Rego Casasnovas authored
This patch is just adding some missing rebaselines generated with "./tools/blink_tool.py rebaseline-cl" after the patch changing rounding of decimal borders: https://chromium-review.googlesource.com/c/chromium/src/+/2199140 BUG=1084502,1081246 TBR=pdr@chromium.org,schenney@chromium.org Change-Id: I3b21eb5422b972b97065af101fdf34295cefc482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207461Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#770314}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0d8925a3c32..3985a19c64c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sebsg@google.com,kmilka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1044639,chromium:1068763,chromium:1073377 Tbr: sebsg@google.com,kmilka@google.com Change-Id: I18d1bbd3eda193a2c90ecf68dcbf4edfbc2f2b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209285Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770313}
-
Mike Klein authored
This guards https://skia-review.googlesource.com/c/skia/+/290880 for Blink rebaselines. Bug: skia:10257 Change-Id: If9ad5d0ee00f54fcb927d892bb0d3fd167b0b5d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209240Reviewed-by:
Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Cr-Commit-Position: refs/heads/master@{#770312}
-
Katie D authored
Although I can't reproduce this locally, it is still flaking after crrev.com/c/2135831: see https://findit-for-me.appspot.com/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySwsSBUZsYWtlIkBjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFNlbGVjdFRvU3BlYWtUZXN0LkZvY3VzUmluZ01vdmVzV2l0aE1vdXNlDA AX-Relnotes: n/a Bug: 950049 Change-Id: I85dddd9223cf073f866cd8da07f2a62298a8edb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209248 Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#770311}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1589903980-88790d48e5518ac3f655ae4b6dd9841a6fd4af4d.profdata to chrome-win32-master-1589918391-06a94f69d9536b141ee986a6b7b41f34bfb60d1d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic3f023fdb18c8d71c4a9b54c7c364533a0b4aa61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209559Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770310}
-
gogerald authored
Screen record: https://drive.google.com/file/d/14Pr1ICTj_6_K117EUGbOU5EnSRkw0Sgt/view?usp=sharing Bug: 1082111 Change-Id: Iedb826031aacbfb15a4dfde6ab2af6ecf6ad3890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202959 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#770309}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c8b57189087c..324f995d2827 2020-05-19 chiur@google.com Allow counters to be grouped with GpuCounterGroup If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:150943541 Tbr: perfetto-bugs@google.com Test: Test: gpu_counter_group.sql Change-Id: I12b5835e1ae6ac3365edf9c02e58eee1c5e6db3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209479Reviewed-by:
-
Peter Kasting authored
View creation/destruction responsibility still lies with this class; but in the meantime the Views hierarchy owns the sub-views. Also some const correctness and code brevity changes while I was here. Bug: 1044687 Change-Id: I79d25721a8fb2037f36fb0594390f16ea2d79e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199732 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#770307}
-
Lindsay Pasricha authored
Bug: 1065456 Change-Id: I28e87ad10e39c3d01324fc567b50441aee860cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209335Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#770306}
-
Liquan (Max) Gu authored
Before: On ExpandablePaymentHandler, long press a text on the WebContents, no selection popup (aka action mode)is shown. After: On ExpandablePaymentHandler, long press a text on the WebContents, selection popup is shown. The selection popup has the basic text processing actions like copy, paste, select all. Change: * Initiate SelectionPopup for the WebContents of PaymentHandlerCoordinator. Bug: 1046952 Change-Id: I19934f04d73bb8337e4f568bdc3b4e00353d6dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204640 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Caitlin Fischer authored
The motivation for migrating this Java test is that it started flaking on an FYI builder. Bug: 1061212, 1049736 Change-Id: I5d2bea89cc9fbfd361e60cef3c160b20697f07f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200422 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#770304}
-
Allen Bauer authored
NotificationMenuView Bug: 1044687 Change-Id: Ie7b3c57bef5d55d306e5f083d709cc29a8bb0444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209493Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#770303}
-
Chris Hamilton authored
This adds a main thread counterpart to the GraphOwned and GraphRegistered concepts. It allows the PM to be used as rendezvous point on the main thread, and enables clean lifetime management. A follow-up CL will rework all existing observers and mechanisms to use these concepts, cleaning up several singletons. Change-Id: I14ba38ca7502c52017a4a84473197b5123bbd93d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203226 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#770302}
-
Sergey Poromov authored
As requisition has nothing to do with device cloud policy, it should be extracted to the right place. This change is just a simple no-op refactoring that doesn't change any logic or lifetime of the objects. Follow-up ones will change the logic properly. Bug: 383695 Test: Run tryjobs Change-Id: Ic2f8a526bb5fd81f9abfe576baebcf1303c41ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207195Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#770301}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/7e802793566c..87616f7ce2ea 2020-05-19 dschuff@chromium.org Rename ARM builders If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1076899 Tbr: mseaborn@chromium.org Change-Id: Ia9404115f1df2b0a06386b73af2abe5bf9a2d046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209477Reviewed-by:
-
David Black authored
Non-system notification types are no longer supported and we can easily revert this CL later if need be. Bug: b:153495778 Change-Id: Id900b384e5713e971b0014a33aad0360b58b9e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204266Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#770299}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1589903980-9824f0da2e5a5b705292a405f6736e894a220581.profdata to chrome-mac-master-1589918391-a0887a91c82b4d67a3cc1bb913e11420854f3688.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I6df79bef7c5c818520f97bc6aef9b8894065ff16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209485Reviewed-by:
-
shrekshao authored
Related flakes: https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel/558210? No-Try: True Tbr: kbr@chromium.org Bug: 1082525 Change-Id: I6a0c4ebef33d9c56d3b98456669ca0b55a6821ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209532Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#770297}
-
Kevin Babbitt authored
Windows Narrator needs a way to determine the boundaries of a "browser tab" in the UIA tree for the purpose of scoping certain commands. In email conversations, we've proposed using "topmost element with a ControlType of Document and an implementation of TextPattern" as that boundary. This CL adds a test as a backstop against changing that element. AX-Relnotes: n/a Bug: 1084249b Change-Id: Icce3d78bc9ab1f0c4a2f4ffaed22635a2a28f3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207937 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#770296}
-
Tomasz Wiszkowski authored
This change allows long text suggestions to reveal their content by wrapping around. Gallery: http://gallery/projects/MCHbtQVoQ2HCZagVm68s-q2A/files/MCH3vYMThUXAZMDbz-OKEqND Bug: 1077360 Change-Id: Ia809b4724d0ca06ca431038a105998af71265b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207959 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#770295}
-
Katie D authored
Allows users to focus into and out of the caption bubble using F6, which rotates focus between focusable panes. AX-Relnotes: N/A Bug: 1055150 Change-Id: I82efd54644fbc1cada2cb3e2f5cf4c52da21336a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197255Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#770294}
-
Rushan Suleymanov authored
Currently deduplication is made in ModelTypeWorker based on |originator_client_item_id| which may be not equal to GUID for legacy bookmark entities. This implies possibility of duplicates in GUIDs. This patch introduces UMA histograms to log different cases of duplicates and a feature toggle to disable new behaviour if needed. Duplicate entities are thrown away by creation time of the entity: the latest one will remain. Bug: 1081061 Change-Id: If7c9ddb323c85e6bf3cccf45e0e088bcb11f202b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199290 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#770293}
-
Alex Gough authored
Prelude to removal of WithSandboxType API. See linked bug for rationale. Does not change behavior. Bug: 1065087 Change-Id: Ia0ea4ee060941383fdc52274a067fd9ad33f0f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202960 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#770292}
-
Anders Hartvoll Ruud authored
Due to limits in how HashMap works, the full integer range is not usable when using an integer as the key: two values must be chosen to represent the empty value, and the deleted value. For the default hash traits, this is 0 and -1 (0 and ~0 for unsigned). The MatchedPropertiesCache currently excludes 0 from being cached, but neglects ~0. Also, the exclusion is not explained, so it looks like unnecessary magic if the reader is not familiar with the quirks of the default HashTraits. This CL check for hash validity using HashTraits<unsigned>:: EmptyValue() and ::IsDeletedValue, which explains a bit better why certain hash values are excluded. Bug: 1057072 Change-Id: I8b178a3608365660099041c84a1a659e3efb5ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195983Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#770291}
-
Nate Fischer authored
This adds CHECKs to verify the chrome_user_metrics_extension proto is correctly formed for WebView. We see records on the backend which are missing system_profiles (and other fields). This adds CHECKs to catch this scenario and provide more info for why this is happening. Bug: 1081925 Test: None Change-Id: I7a58edfc0679798bd50e1dac6da9defff76a0c93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197481 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Oriol Brufau authored
The layout changes from r728894 were reverted in r758566. It doesn't seem that we will be able to reland that soon, so this patch reverts the WPT tests. Some modifications are kept as new tentative tests. BUG=1024927 Change-Id: I36e59f192dac713fe1799c14cbd4f8c83ee39bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207241 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
-
danakj authored
If focus was in a child frame, when we navigate to the next test, focus gets lost. For example, without this, running the following tests in order causes a failure: [1/2] paint/selection/text-selection-drag-in-frame-scrolled.html passed [2/2] paint/selection/text-selection-newline.html failed unexpectedly (image diff) R=avi@chromium.org Bug: 1083790, 866140 Change-Id: I7e5962e8e74bdf904e05445cd4d634daf259ca75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209377 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#770288}
-
Timothy Gu authored
Since If6853404f1e87de4f95a24f6231282543814bd63, the "uuid" variable has been referring to the MD5 of a fixed string. Update the comment as such, and remove the now-unneeded .uuid file writing. Also update test_fonts/README.chromium as the manual UUID change is no longer necessary or effective. Bug: 767754 Change-Id: I07a9b10a631e755877cbcb7df40a53359329f8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209397 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Timothy Gu <timothygu@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#770287}
-
danakj authored
The test is failing because it is performing a compositor frame while hidden. The test uses runAfterLayoutAndPaint() in ways it does not need to, so move it to use requestAnimationFrame() directly to see if that helps. While doing so, I noticed that the triangles drawn while hidden are not lost if a requestAnimationFrame() draws while inside the event listener for page visibility. That is now documented in a comment, with a double call to requestAnimationFrame() to work around it. R=kbr@chromium.org Bug: 1083585 Change-Id: Iefb9a49f7ef337b86f9de898fa71a96cf65d0513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209331Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#770286}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/71e9acb97c77..2671dac29c27 2020-05-19 hbos@webrtc.org Fix all known VideoStreamEncoderTest flakes. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1ff976fee152a87e82c3bbf70a1b53a77b4a65ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209279Reviewed-by:
-
Chong Gu authored
Switch to the updated ViewTokenPair::New() API Replace deprecated PresentView() API call. Behavior should be unchanged. Change-Id: I0db9974424a61b4fa8a39619f218f55e25e7a6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208178 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#770284}
-
Brian Sheedy authored
Fixes an issue where multiple failures in Skia Gold-backed Android instrumentation pixel tests would result in each triage link getting concatenated to all previous links instead of being reported on its own. Bug: 1084645 Change-Id: I3976d8e7cc10e0f005c06802b1c97239211c2944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209342 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#770283}
-
