GitLab

R=ecobos@igalia.com
BUG=706118

Review-Url: https://codereview.chromium.org/2802063002
Cr-Commit-Position: refs/heads/master@{#462767}

WebState::CreateWithStorageSession().

Because it looks passing nil doesn't work. Alternatively I can update
the code to make CreateWithStorageSession(params, nil) to be equivalent
of Create(params) if you prefer.

Background:
I wrote code to expect that CreateWithStorageSession(params, nil) is
equivalent of Create(params), resulted in a weird error.

Review-Url: https://codereview.chromium.org/2802613005
Cr-Commit-Position: refs/heads/master@{#462766}

It's not used by anyone.

BUG=707371

Review-Url: https://codereview.chromium.org/2806663002
Cr-Commit-Position: refs/heads/master@{#462765}

Also tweak the shards.

BUG=

Review-Url: https://codereview.chromium.org/2805163002
Cr-Commit-Position: refs/heads/master@{#462764}

This is essentially the result of the following shell command followed by
git cl format:

    find . -type f -exec sed -i 's/"wtf\//"platform\/wtf\//g' {} \;

DEPS is updated in order to prevent further introduction of "wtf/".

BUG=691465
R=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2803603004
Cr-Commit-Position: refs/heads/master@{#462763}

Don't enable select all if the contenteditable has nothing to select.

BUG= 696134

Review-Url: https://codereview.chromium.org/2787893004
Cr-Commit-Position: refs/heads/master@{#462762}

This CL just adds a flags for zip archiver, a new chrome extension for
files app.

BUG=706851

Review-Url: https://codereview.chromium.org/2799233002
Cr-Commit-Position: refs/heads/master@{#462761}

base::MRUCache instead of std::map. No functional change.

BUG=705029

Review-Url: https://codereview.chromium.org/2801533002
Cr-Commit-Position: refs/heads/master@{#462760}

Relax the restrictions on the list of top-level boxes so that MP4 files are
more reliably detected.

BUG=709166
TEST=updated test passes

Review-Url: https://codereview.chromium.org/2797133009
Cr-Commit-Position: refs/heads/master@{#462759}

https://crbug.com/682075#c17 for details.

BUG=682075,707839
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2806623002
Cr-Commit-Position: refs/heads/master@{#462758}

I am looking at refactoring some code used by UpdateLanguageList and I
found that it had no test case.

Review-Url: https://codereview.chromium.org/2722413002
Cr-Commit-Position: refs/heads/master@{#462757}

- use symbols to map scripts and UISourceCodes to FormatData;
- make FormatterScriptMapping independent on both debugger model and
    editor action;
- make FormatData agnostic of source code type, just keep original
    and formatted source codes.

Review-Url: https://codereview.chromium.org/2801543002
Cr-Commit-Position: refs/heads/master@{#462756}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e650872309eb..f0fd0b23669d

$ git log e65087230..f0fd0b236 --date=short --no-merges --format='%ad %ae %s'
2017-04-06 simonhatch Dashboard - Make update_test_suites use less memory.
2017-04-06 benjhayden Refactor histogram-set-view to an MVC pattern.
2017-04-06 eakuefner [Dashboard] Replace paper-progress with paper-spinner

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2798863006
Cr-Commit-Position: refs/heads/master@{#462755}

BUG=475060

Review-Url: https://codereview.chromium.org/2799113003
Cr-Commit-Position: refs/heads/master@{#462754}

For new added accelerators, we want to ensure it is search key based by
adding the test.

BUG=706018,706462
TEST=AcceleratorTableTest.CheckSearchBasedAccelerators

Review-Url: https://codereview.chromium.org/2802583002
Cr-Commit-Position: refs/heads/master@{#462753}

[CrOS Tether] Refactor BleScanner so that it takes a BluetoothAdapter in its constructor instead of constructing it itself.

The tether module will have a shared adapter passed to all classes which need it.

BUG=672263

Review-Url: https://codereview.chromium.org/2803153002
Cr-Commit-Position: refs/heads/master@{#462752}

BUG=676220
R=thestig@chromium.org,peter@chromium.org

Review-Url: https://codereview.chromium.org/2803873003
Cr-Commit-Position: refs/heads/master@{#462751}

BUG=676588
R=tkent@chromium.org

Review-Url: https://codereview.chromium.org/2798293003 .
Cr-Commit-Position: refs/heads/master@{#462750}

No logic change.

This CL swaps "about:*" literals for the correct value in
ContentUrlConstants.

Review-Url: https://codereview.chromium.org/2803853006
Cr-Commit-Position: refs/heads/master@{#462749}

In SPv1 we create cc layers for composited animations even if they
paint no content.

In SPv2, we only create cc layers when something is painted,
a.k.a., there is a PaintChunk.

This means that in SPv1 we could be assured that a composited
animation that painted no content would still have a cc layer
with the animation's compositor element id set on it, but in
SPv2 such an animation will have no cc layer and accordingly
it is impossible to run it as a composited animation.

In SPv2, we choose to not composite such animations.

To do otherwise would require:

1. code complexity to identify when this is the case,
through a dummy PaintChunk or similar, and ensure that
we create a cc layer even though there's nothing in need
of painting.

2. compositor resource overhead to maintain a layer
solely for the purpose of executing a composited animation
even though it is not producing any visible content.

BUG=692310
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2724083002
Cr-Commit-Position: refs/heads/master@{#462748}

[CrOS Tether] Make BluetoothThrottler a singleton which can be easily shared between EasyUnlock and tethering.

BUG=672263

Review-Url: https://codereview.chromium.org/2805113002
Cr-Commit-Position: refs/heads/master@{#462747}

If a script injection is cancelled (e.g. context destroyed before
execution), ScriptInjectionCallback::willExecute() is not called but
::completed() is called. In such cases, execution time shouldn't be
reported.

BUG=708897

Review-Url: https://codereview.chromium.org/2797423002
Cr-Commit-Position: refs/heads/master@{#462746}

BUG=672263

Review-Url: https://codereview.chromium.org/2781263004
Cr-Commit-Position: refs/heads/master@{#462745}

Revert of Media Remoting: End to end integration tests. (patchset #4 id:120001 of https://codereview.chromium.org/2692593002/ )

Reason for revert:

Findit identified CL at revision 462739 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzYwZDRlMGE2M2ViM2YyYmUyNmFjYTEyODFiZTI5YzY0YjBmNWM2NzAM

Original issue's description:
> Media Remoting: End to end integration tests.
>
> Add end to end integration tests for Media Remoting. Refactors
> PipelineIntegrationTest to test both media and media remoting pipeline.
> Re-use current tests. No new tests are added in this CL.
>
> BUG=684065
>
> Review-Url: https://codereview.chromium.org/2692593002
> Cr-Commit-Position: refs/heads/master@{#462739}
> Committed: https://chromium.googlesource.com/chromium/src/+/60d4e0a63eb3f2be26aca1281be29c64b0f5c670

TBR=miu@chromium.org,sandersd@chromium.org,xjz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=684065

Review-Url: https://codereview.chromium.org/2804183002
Cr-Commit-Position: refs/heads/master@{#462744}

Cr-Commit-Position: refs/heads/master@{#462743}

This was assuming that YUV to RGB conversion had been done if the output
format was YUV, which is the opposite of what should be happening.

Make the CHECK for extra YUV to RGB conversion happen always, by adding
a "can ignore for testing" flag for the pixel tests that violate this
assumption.

BUG=709099
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2799603006
Cr-Commit-Position: refs/heads/master@{#462742}

The problem is that it was registering as a TabObserver but
not removing itself.  This moves the TabObserver logic into
NewTabPage, which does handle proper clean up.

BUG=708710

Review-Url: https://codereview.chromium.org/2803063003
Cr-Commit-Position: refs/heads/master@{#462741}

This is a continuation of other work to move CSS.*Value types to the nested
namespace blink::cssvalue to avoid name collisions. I will be moving over type
2 or 3 at a time per CL. In some cases we need to temporarily introduce using
statements while we're shuffling the classes around. These will be cleaned up
once all types have been moved to blink::cssvalue.

BUG=667961

Review-Url: https://codereview.chromium.org/2804673003
Cr-Commit-Position: refs/heads/master@{#462740}

Add end to end integration tests for Media Remoting. Refactors
PipelineIntegrationTest to test both media and media remoting pipeline.
Re-use current tests. No new tests are added in this CL.

BUG=684065

Review-Url: https://codereview.chromium.org/2692593002
Cr-Commit-Position: refs/heads/master@{#462739}

Ideally this should be YUY2, but we have a fallback to B8G8R8A8 and
should check that it's being used at most very rarely.

BUG=678800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2799183002
Cr-Commit-Position: refs/heads/master@{#462738}

BUG=709208

Review-Url: https://codereview.chromium.org/2800013002
Cr-Commit-Position: refs/heads/master@{#462737}

https://pdfium.googlesource.com/pdfium.git/+log/c758d9dd3f94..8a24b25ee0b0

$ git log c758d9dd3..8a24b25ee --date=short --no-merges --format='%ad %ae %s'
2017-04-06 thestig Clean up CBC_QRCoderVersion and friends.

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2807553002
Cr-Commit-Position: refs/heads/master@{#462736}

Subsequence display items cause complications for the SPv2 compositing algorithm
because they confuse the PaintChunker. Also, they are the last remaining
paired display item in SPv2 that blocks simplifying the display list format.

BUG=692614

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2793233002
Cr-Commit-Position: refs/heads/master@{#462735}

ValueStore::Status mirrors a leveldb "Status" object which contains an error/success code and a string message.

LevelDB is carefully written so that an "OK" status does not have a message associated with it. But then in the Chrome ValueStore code the string is unconditionally retrieved (LevelDB maps this to "OK") and then expensive search-and-replace operations are performed on it.

This changes the levelDB "Status" to avoid the status string on "OK". This no-string-on-OK state is already implied by the Status header.

Review-Url: https://codereview.chromium.org/2799543002
Cr-Commit-Position: refs/heads/master@{#462734}

Allow the embargo status of a permission to be cleared when the user changes the
setting for an embargoed permission to "Ask" or "Allow". However, the system
will still remember that the setting was previously embargoed, so if another
permission prompt is dismissed for that permission, it will be re-embargoed.
Permissions embargoed because they are blacklisted will be re-embargoed if they
are still on the blacklist during the next permission request.

BUG=704771
TEST=Run Chrome with the command line flag
--enable-features=BlockPromptsIfDismissedOften and navigate to
https://permission.site. Place the notification permission under embargo by
clicking the "Notifications" button three times until the permission prompt no
longer appears. In the page info bubble, the "Notifications" drop-down should
say "block". Choose "Allow" instead, which should update the bubble to allow
notifications and ask for the page to be reloaded. Then change the drop-down to
"Ask", which should also update the notifications permission back to "Ask".
Click the "Notifications" button on the page again and notice the permission
prompt to ask for notifications permission is shown again.

Review-Url: https://codereview.chromium.org/2790473004
Cr-Commit-Position: refs/heads/master@{#462733}

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2803543003
Cr-Commit-Position: refs/heads/master@{#462732}

This CL adds |supports_torch| to mojom.PhotoCapabilities, to differentiate
the capability from the actual value of |torch|, and wires it
for the Android implementations and for the LayoutTests.

Tested via unittests and manual test using
https://rawgit.com/Miguelao/demos/master/imagecapture.html

BUG=700607

Review-Url: https://codereview.chromium.org/2798263003
Cr-Commit-Position: refs/heads/master@{#462731}

This check was previously added for OriginTrialEnabled and SecureContext
(r461653). This applies the same check to FeaturePolicy which has the
same limitation (i.e., this *should* work but currently generates broken
code where FeaturePolicy is totally ignored, and therefore must be a
compile-time error for now.

BUG=695123

Review-Url: https://codereview.chromium.org/2802873003
Cr-Commit-Position: refs/heads/master@{#462730}

BUG=709148
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2803853002
Cr-Commit-Position: refs/heads/master@{#462729}

Since string is called string in Google3 but std::string in Chromium,
an alias is needed to make the two codebases identical.

Also ran git cl format.

This CL lands server change 151592591 by bnc.

BUG=488484

Review-Url: https://codereview.chromium.org/2801603003
Cr-Commit-Position: refs/heads/master@{#462728}