GitLab

After crbug.com/836562 was fixed it introduced crbug.com/860649. In order to solve this we need to
keep track of which indexPaths are being inserted and if 2 items are inserted in the same indexPath
we need to manually shift the previous indexPath row, if not we will end up with 2 insertions in
the same indexPath and get a consistency crash.

Because of this and the fact that we want to get rid of the initial insertion and search animations
(crbug.com/859736) I decided to get rid of the historyInserter updates and just reloadData.
We will still update individual rows for the status message and deletion when editing.

Bug: 860649, 859736
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib8c7488110441727be767ead22903700927f69d1
Reviewed-on: https://chromium-review.googlesource.com/1141127
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578152}

DecodeURLEscapeSequences() decoded some parts of an input string in UTF-8,
and other parts of the string in isomorphic encoding. This behavior doesn't
make sense, is harmful against browser interoperability, and is used only
in 0.0013% of page views (only in scroll-to-fragment cases).

DecodeURLEscapeSequences() is used in many code paths, and we have usage
data only for scroll-to-framgnet. However this CL tries to remove this
weird behavior entirely.


Bug: 845824
Change-Id: Ib1cbbd3e1c26ebaaca7b3537b9732121835fdc9f
Reviewed-on: https://chromium-review.googlesource.com/1146535Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578151}

`new FailCaller` in oauth2_access_token_fetcher_immediate_error.cc may
return a stale pointer if PostTask in its ctor failed, since base::Bind
there increments the ref count, and the callback destruction releases
it.

This CL moves the PostTask after the completion of the ctor call.

Bug: 866456
Change-Id: Id185e46292238955b3da9015903dfa6a8c94e7e9
Reviewed-on: https://chromium-review.googlesource.com/1146345Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578150}

In integrated mode, CronetEngine is allowed to use the shared network
task runner by other Chromium-based clients (like webview, Chrome
Android, Cronet) without self-initialization, which make it avaialbe to
expose Cronet Java API in Chromium-based clients without creating 2
different network stacks.

Besides, multiple CronetEngine instances could also share the same
network stack in integrated mode.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I83678f78f420d033db2a0df75a9934abf4021465
Reviewed-on: https://chromium-review.googlesource.com/1136338
Commit-Queue: Shenghuai Ji <shenghuai@google.com>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578149}

Implements a Python version of the robot arm control code using a
Maestro servo controller. This will eventually replace the older
Arduino-based version that requires new control code versions to
be flashed onto the Arduino.

Bug: 849341
Change-Id: Ib89e21984d9f73aa2637cb5444468ff000373c19
Reviewed-on: https://chromium-review.googlesource.com/1097697
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578148}

Re-enable several tests that were broken without this change:
  DesktopWindowTreeHostMusTest.Deactivate
  DesktopWindowTreeHostMusTest.StackAbove
  WidgetTestInteractive.ExitFullscreenRestoreState
  WidgetObserverTest.ActivationChange
(WindowTree::SetFocus would fail and revert without a root window)
(tests mayby passed flakily by not getting revert responses in time)

Add logging; remove unused WidgetObserverTest widget; cleanup.

Bug: 864614, 864615, 864618, 864800
Test: automated tests don't flake (passed 100+ runs for me)
Change-Id: Idf34e6b4cae9a268eb580ecdbadb023da711b102
Reviewed-on: https://chromium-review.googlesource.com/1149087
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578147}

Bug: 831271
Change-Id: Ib86785e129c7ca9398734fe582e0fa446a5c3cf2
Reviewed-on: https://chromium-review.googlesource.com/1150857Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578146}

This CL adds "content" to the list of URI schemes that we don't want to
save into history. This fixes an issue where media opened via the
MediaLauncherActivity were being saved into history.

Bug: 864777
Change-Id: I4c438aace5a4da62fa73a958db79756c63391b2f
Reviewed-on: https://chromium-review.googlesource.com/1150608Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578145}

Add a missing dependency from web_applications/extensions to //chrome/common,
as BookmarkAppDataRetriever uses chrome::mojom::ChromeRenderFrame.
This should fix a flaky build error on bots:

../..\chrome/browser/web_applications/extensions/bookmark_app_data_retriever.h(12,10):  fatal error: 'chrome/common/chrome_render_frame.mojom.h' file not found
#include "chrome/common/chrome_render_frame.mojom.h"
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win/71019

Change-Id: I3f2e71533551378681ef91cd402988b427c0d750
Reviewed-on: https://chromium-review.googlesource.com/1149665Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578144}

In the new virtual keyboard UI, the floating virtual keyboard has a
an irregular shape. This is implemented by drawing the shape over a
transparent background, so it looks like the window has the correct
shape. However, clicking the transparent areas does not propagate to
the window behind the keyboard, breaking the illusion.

We add a new private extension API for setting a custom hit test area
for the virtual keyboard from the IME extension. By using this API, the
IME can specify the exact shape of the virtual keyboard so that events
are propagated correctly based on the shape.

Only the new UI will be calling this API, so nothing changes for the
old UI (hit test area == window bounds).

Bug: 866380
Change-Id: I38d9cc7f263d09cb3343be6d298667bdba7dd9ea
Reviewed-on: https://chromium-review.googlesource.com/1147680
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578143}

https://webrtc.googlesource.com/src.git/+log/d9e4a06374b3..68936b1f34e6


git log d9e4a06374b3..68936b1f34e6 --date=short --no-merges --format='%ad %ae %s'
2018-07-25 buildbot@webrtc.org Roll chromium_revision f2569c57..17efa884 (577860:577964)


Created with:
  gclient setdep -r src/third_party/webrtc@68936b1f34e6

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I36d0bf4685c28d85a8dbb9ed4415271459ee2449
Reviewed-on: https://chromium-review.googlesource.com/1150781Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578142}

This reverts commit ccc23774.

Reason for revert: After fixing the TableViewDisclosureHeaderFooterView constraints by using optional padding on a different CL, this change is causing issues on iPhoneX, will revert this CL.

Original change's description:
> [ios] Fixes cutoff Disclosure header subtitle label
> 
> Changes the vertical stackView distribution to
> UIStackViewDistributionFillProportionally,so the stackView
> doesn't cut the subtitle label for lack of space.
> 
> 
> Bug: 862744
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I524dacb378515088faae9e99c0db408ad3f9b4b0
> Reviewed-on: https://chromium-review.googlesource.com/1147541
> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
> Commit-Queue: Sergio Collazos <sczs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577401}

TBR=kkhorimoto@chromium.org,edchin@chromium.org,sczs@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 862744
Change-Id: I58feef6efd7bc449a6d06b531eb8c2c977af534b
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1150542Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578141}

Bug: 865520
Change-Id: I7a8a5539db8bf793abe086e1f02ff07a17a58ef8
Reviewed-on: https://chromium-review.googlesource.com/1148692
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578140}

It just means root surface doesn't exist or doesn't have an active frame
so update the naming.

Bug: 867594
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I42a4b5db05ef8168c31f6a2fd9b9694b8cf5200c
Reviewed-on: https://chromium-review.googlesource.com/1150613Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578139}

Change-Id: Iaf007e192df6f094583545db9c18b60573404bb1
Reviewed-on: https://chromium-review.googlesource.com/1149414Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578138}

The base class KeyboardUI doesn't call ShouldWindowOverscroll, so it
doesn't really need to be on the base class. ShouldWindowOverscroll
is only used by ChromeKeyboardUI, so we just move it to be a private
method on that class.

TBR=yhanada@chromium.org

Change-Id: I5b95c83d64f6e2d8d2c8d50ac42bb34416a06aaa
Reviewed-on: https://chromium-review.googlesource.com/1150014Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578137}

There were 4 mechanisms for enabling/disabling variations in WebView:
- a command-line flag (mEnabledByCmd)
- the AGSA experiment in m67 (mEnabledByExperiment)
- the hard-coded setting (sVariationsAlwaysEnabled)
- the hold-back experiment in m68 & m69 (sEnableState)

Remove all of them, so that variations is always enabled.

Set the hold-back experiment histogram, VariationsEnableState, to expire
after m69. Don't mark it as obsolete yet, because we'll want to watch it
for the lifetime of m68 & m69.

BUG=851045

Change-Id: I44bd36789019074f422ec0c25be2afadba95b8c4
Reviewed-on: https://chromium-review.googlesource.com/1150772Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578136}

This CL homogeneises the if-else bracketing style in said file: these
blocks get {} if either the condition or the body in either branch is
> 1 line.  Otherwise, no brackets.

Simplified the logic of a few service methods too, and extracted
the calculation of CanvasResourceProvider::ResourceUsage |usage|
in GetOrCreateCanvasResourceProvider() so that it looks similar\
on both sides of the branch.

No new functionality intended.

Bug: 839970
Change-Id: I6e275a330f145aea861ae9344aa172ffc5840a27
Reviewed-on: https://chromium-review.googlesource.com/1150437
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578135}

* Have a single public constructor, instead of separate constructors
  for sync and async requests. This means sync requests now need to
  call Start().
* Determine sync/async based on the ResourceLoaderOption parameter's
  synchronous_policy
* Before this change, the constructor took a ThreadableLoaderOptions
  parameter, which was just a single-member struct for setting a
  timeout. Remove the unnecessary struct wrapper, and change the
  timeout from an unsigned long specifying the timeout in
  milliseconds (where 0 means no timeout) to a
  base::Optional<TimeDelta>.

TBR=peter@chromium.org,yhirano@chromium.org

Change-Id: If312cfeec7494a8f74ca28992e2688eec8e923a1
Reviewed-on: https://chromium-review.googlesource.com/1150570
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578134}

This patch ensures that if we've changed mix-blend-mode property, then
we call SetNeedsPropertyTreeUpdate.

R=pdr@chromium.org

Bug: 867403
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Idcd6e54c1d6ca3db0d0e088038cc144def2789b8
Reviewed-on: https://chromium-review.googlesource.com/1150687
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578133}

This not only results to smaller file size, but also makes the code more
portable, since it is less dependent on chrome:// URLs, and can eventually
lead to running those elements and tests outside the context of a browser_tests
and without js2gtest.

For example this makes it easier to keep maintaining the following WebUI demo
https://freshp86.github.io/chromium-webui/demo.html, and potentially move it within
the Chromium repo itself.

Bug: 866236
Change-Id: I1459789177ba5ede252c3ade3e0952686f4f01b5
Reviewed-on: https://chromium-review.googlesource.com/1144610
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578132}

The tab management system saves and restores the last-focused control
for each tab.

However, if the last-focused control is destroyed, the browser focuses
the Omnibox by default. In those cases, the edit model's saved focus
state will be incorrect.

This CL prevents that weird state from occurring by cross-checking the
edit model's saved focus state with the actual focus state restored by
the tab management system.

This state de-syncing was always there, but has been recently made
visibly apparent because of:
https://chromium-review.googlesource.com/c/chromium/src/+/1144211

Bug: 866781
Change-Id: I0e85be9f650ae896021096e6c546b9f085d528d6
Reviewed-on: https://chromium-review.googlesource.com/1149191
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578131}

Only suppress streaming in the cases where V8 will actually consume the code
code cache. It is no longer necessary to suppress it when we might want to
produce a code cache.

BUG=865098

Change-Id: I5ac4e798d7c7a732f87e0520ec4221da2646ae3e
Reviewed-on: https://chromium-review.googlesource.com/1149360
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578130}

Favicons for suggestions have been getting incorrectly rounded. This
led to a discrepency in how they appeared on the tab and location-bar
vs. the Omnibox suggestions.

This CL does a few things:

 1) Changes the icon_view_ member of OmniboxMatchCellView from the
    OmniboxImageView class (which rounds corners) to a plain ImageView.
    This fixes the heart of the bug.

 2) Renames OmniboxImageView => RoundedCornerImageView, to make things
    more explicit.

 3) Renames image_view_ to answer_image_view_ to make things more
    explicit. Also updates the comment to clarify that it's used for
    all suggestion answers, not just rich entities.

As a followup, we should investigate eliminating / refactoring
RoundedCornerImageView, as it appears (in the code) to apply the entity
image corner radius to all answers-in-suggest images.

But that's a less noticeable and separate concern.

Bug: 866187
Change-Id: Ib35528e109d484dfca6013569c6cd52f71a8f6ae
Reviewed-on: https://chromium-review.googlesource.com/1147503Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578129}

This method was previously unused, but with the network service moving
out of process, the speech recognition code will now need to use it.

No idea if we use speech recognition on headless (Though it does seem
unlikely), so this may not be needed?

Bug: 841445
Change-Id: I2c75a53663f46ddfbbd14aeac4ab3d6686d7d6e0
Reviewed-on: https://chromium-review.googlesource.com/1145711Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578128}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4c27ac5c..ee658ba8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ic6d0cb617a7d34844a0c18e6214e42c08aee4aa8
Reviewed-on: https://chromium-review.googlesource.com/1150765Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578127}

1) Change style.hidden to style.visibility = "hidden" so that
   offsetWidth/offsetHeight are non-zero.

2) In addition to the absolute positioning, need to use "clip-path" to
   clip the thumbnail, so that it remains square after being selected
   (transform: scale(0.8) is applied to the thumbnail).

Spec: https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8

Bug: 867299
Change-Id: I6becad4fc0384c1e20c2069d4f1b89c8203ec01b
Reviewed-on: https://chromium-review.googlesource.com/1150454Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578126}

This reverts commit 05d439ba.

Reason for revert: Perf regression crbug.com/867670

Original change's description:
> [Blink] Unify replaced element clipping
> 
> Prior to this CL each replaced element type implemented its own clipping.
> This CL refactors it so that a clip node will be applied in the common
> path, ReplacedPainter::Paint(), so the specialized
> XyzPainter::PaintReplaced() won't need to apply their own clips.
> 
> Note that ImagePainter still mutates its internal painting for changed
> clip rect. This behavior should be changed in a follow-up CL, and
> changing only the content box of a replaced element should only result
> in incremental invalidation.
> 
> BUG=730284
> 
> Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Ia5c1412b1bd3182a22849d0b3196f3e72d52248a
> Reviewed-on: https://chromium-review.googlesource.com/1147617
> Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577741}

TBR=trchen@chromium.org,pdr@chromium.org

Change-Id: Ib91981e97c8558a462336f98f5ad219ef48bcef4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 730284
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1150255Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578125}

https://chromium.googlesource.com/catapult.git/+log/c7d74cd68934..c829a63538ba


git log c7d74cd68934..c829a63538ba --date=short --no-merges --format='%ad %ae %s'
2018-07-25 benjhayden@chromium.org Add API support for the new ReportTemplate system.
2018-07-25 dtu@chromium.org [pinpoint] Hack to use performance_test_suite for patch jobs.
2018-07-25 benjhayden@chromium.org Allow anonymous /api/test_suites requests.


Created with:
  gclient setdep -r src/third_party/catapult@c829a63538ba

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:867521
TBR=sullivan@chromium.org

Change-Id: I0350fffd262ed295aaae1a1c71c662cdbc7d249c
Reviewed-on: https://chromium-review.googlesource.com/1150365Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578124}

Changing all the WebXR internal tests to use the test API specified in
https://github.com/immersive-web/webxr-test-api. This will make tests
more maintainable as changes to the backend mocking need only be made
once.

Bug: 863557
Change-Id: I4b8740269c0faa74073ef9294b6b27b78b18715a
Reviewed-on: https://chromium-review.googlesource.com/1136982
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578123}

We used to check whether login status is USER to decide whether user
signed in, which is wrong. So check IsActiveUserSessionStarted()
instead.

Bug: 867662
Change-Id: I2c71f494ab2698d063697395e609cad69a962444
Reviewed-on: https://chromium-review.googlesource.com/1150800
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578122}

ContentViewCore is still mentioned in many comments and names of
methods/classes though it's gone. This CL replaces it with
WebContents or content layer appropriately to the context.
Also did some accidental clean up discovered by build/lint.

There is no functional changes.

Bug: 598880
Change-Id: I87e325a9c1b930ea1ceb462c842be28bf96a21e6
Reviewed-on: https://chromium-review.googlesource.com/1149677
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578121}

https://pdfium.googlesource.com/pdfium.git/+log/1f7db295b1de..a5d2bf1131fe


git log 1f7db295b1de..a5d2bf1131fe --date=short --no-merges --format='%ad %ae %s'
2018-07-25 thestig@chromium.org Remove CFX_MemoryStream uses in tests.
2018-07-25 tsepez@chromium.org Use struct {Single,Range}Cmap in FPDFAPI_CIDFromCharCode().
2018-07-25 hinoka@google.com README.md: Update waterfall location
2018-07-25 thestig@chromium.org Change CFX_BufferSeekableReadStream to take a span.
2018-07-25 thestig@chromium.org Only build cfx_fileaccess_windows.cpp on Windows.
2018-07-25 thestig@chromium.org Move CPDF_SyntaxParser init methods into ctor.
2018-07-25 hnakashima@chromium.org Disable submit in XFA forms.
2018-07-25 tsepez@chromium.org Introduce ToXMLElement() checked downcast helper function


Created with:
  gclient setdep -r src/third_party/pdfium@a5d2bf1131fe

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:860896,chromium:842503
TBR=dsinclair@chromium.org

Change-Id: If7bcdd2cc19be54976a33cb521e5fe2717fae483
Reviewed-on: https://chromium-review.googlesource.com/1150362Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578120}

Now that we always have a CursorManager we don't need a virtual
IsCursorVisible method and we can simplify the unit test.

Bug: 631103, 840391
Test: ash_unittests
Change-Id: I1af8a8f0d88df2da03147deb779cf41a13763dde
Reviewed-on: https://chromium-review.googlesource.com/1150806Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578119}

https://chromium.googlesource.com/angle/angle.git/+log/5188a2747b40..eb4b86975848


git log 5188a2747b40..eb4b86975848 --date=short --no-merges --format='%ad %ae %s'
2018-07-25 theoking@google.com Introduced eglMakeCurrent Perf Test


Created with:
  gclient setdep -r src/third_party/angle@eb4b86975848

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Ied1c8c3bcff842c9c65e9a3f0fc9b4ed1f03c423
Reviewed-on: https://chromium-review.googlesource.com/1150621Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578118}

Two changes
- Remove all use of GLFence in backpressure
  - In case GLFence objects were responsible for crashiness
- Move the glFlush from SwapBuffers to ScheduleOverlay
  - ScheduleOverlay is a regular GL call, so it may be executed
    in a more "safe" context than SwapBuffers
  - This results in many more glFlush calls, but almost all are
    no-ops

Possible outcomes
- Crashes just change signature to ScheduleCALayer
  - Not very helpful
- Crashes are reduced
  - Tells us that either
  - Our GLFence use was the cause of crashes
  - Making GL calls from inside SwapBuffers caused crashes

TBR=kbr

Bug: 863817
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I23342b190a0d8b652dde8f96f1cb1169b577764c
Reviewed-on: https://chromium-review.googlesource.com/1150569Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578117}

This is a reland of 568cc6a9, which had
been reverted in 8fba4f3d (bug 867520)
due to failing link on windows builders with proprietary_codecs in their
build configuration (bug 867536).

Versus the original change, this one includes an additional MEDIA_EXPORT
on the inner type "media::mp4::BitstreamConverter::AnalysisResult".

Original change's description:
> MSE: refactor mp4 AnnexB validation to also report keyframe-ness
>
> In preparation for logging when there appears to be a mismatch between
> MSE MP4 keyframe metadata and the encoded video bitstream's keyframe
> metadata, this change incorporates basic analysis of the latter as part
> of the existing Annex-B bitstream validation for MSE MP4 video.
>
> Note that mp4::BitstreamConverter::AnalysisResult contains
> base::Optional<bool> for each of conformance and keyframe-ness fields.
> If a field doesn't have a value, that portion of the result was not
> analyzed.
>
> Note that keyframe analysis is implemented only for AVC currently, but
> even that is skipped if the frame is detected as non-conformant before
> enough indications of whether or not it is a keyframe are detected.
> Neither AVC-DV nor HEVC AnnexB analyses do any actual keyframe analysis,
> since such was either skipped or not yet implemented previously,
> respectively.
>
> A subsequent CL will use the newly reported MSE MP4 video bitstream
> converter's keyframe analysis results, if that analysis was done, in
> reporting to chrome://media-internals when the bitstream keyframe-ness
> mismatches that of the mp4 container for a coded frame.
>
> BUG=860420,584384
>
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I169c7774070ad232c86658bcd7803160323993ad
> Reviewed-on: https://chromium-review.googlesource.com/1144456
> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
> Reviewed-by: Sergey Volk <servolk@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577717}

Bug: 860420, 584384
Change-Id: I8bbb3abc2079b53a14db8babbf04d5bad9e94767
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1150247Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578116}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/afdbf84ebc72..d81364a25e1e


git log afdbf84ebc72..d81364a25e1e --date=short --no-merges --format='%ad %ae %s'
2018-07-25 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@d81364a25e1e

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I2e50930270b933746d168d616218edcb0afce153
Reviewed-on: https://chromium-review.googlesource.com/1150780Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578115}

Extension content scripts have permission to make cross-origin requests
to hosts they have permission to access. On extension unload, remove
these heightened permissions. Add a test to cover the same.

Bug: 843381
Change-Id: Ib24e6593c423177f2a3993413c3d4695fe8efe7c
Reviewed-on: https://chromium-review.googlesource.com/1120641Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578114}

Bug: 775644, 773382
Change-Id: I8c0426728b31644797e6e641d16ac049ab61a8ce
Reviewed-on: https://chromium-review.googlesource.com/1148950Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578113}