GitLab

Using wpt-import in Chromium 4a933ce4.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20307

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=markdittmer

No-Export: true
Change-Id: I74c2030bbcfd8f82779c16a38514d634b88787b8
Reviewed-on: https://chromium-review.googlesource.com/1119541
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571360}

The actual Assistant Settings URL is not yet available. Not sure yet if
we will hardcode it on the client, fetch it from the server, or if it
will be synced to the client via flag.

This CL:
- Creates AssistantControllerObserver to observe events broadcast from
  the top level Assistant controller.
- Implements AssistantControllerObserver in AssistantUiController to
  hide UI on opening a URL in a new tab, and to show UI when receiving
  a web UI deep link.
- Implements AssistantControllerObserver in AssistantWebView to embed
  rendered WebContents on receipt of a web UI deeplink received event.

See bug for screenshot.

Bug: b:110433859
Change-Id: Ie48fad9de91bc8886e723a5b510c31a6243a7aaa
Reviewed-on: https://chromium-review.googlesource.com/1118752
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571359}

https://skia.googlesource.com/skia.git/+log/a782dcb3c407..7e2327b133db


git log a782dcb3c407..7e2327b133db --date=short --no-merges --format='%ad %ae %s'
2018-06-28 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-28 egdaniel@google.com Revert "Reland "Make GrVkBackendContext no longer derive from SkRefCnt.""
2018-06-28 egdaniel@google.com Revert "Reland "Move Vulkan DebugCallback code into tools.""
2018-06-28 egdaniel@google.com Revert "Reland "Let client pass in full extension to GrVkBackendContext.""
2018-06-28 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a26de2500503..fa5d84be4145 (11 commits)
2018-06-28 caryclark@skia.org fix blank catalog images
2018-06-28 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-28 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@7e2327b133db

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@chromium.org

Change-Id: I85f01fc13c36fe6dea3f462b15253154ed66e5f1
Reviewed-on: https://chromium-review.googlesource.com/1119333Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571358}

The timestamp at which the PTS measured is incorrect. It should be
the timestamp returned by video_decoder()->GetCurrentPts, and not
MonotonicClockNow.

Bug: b/110629346
Test: Manual
Change-Id: I59412ff3f9d2286a3e01d58e097c125eb2454245
Reviewed-on: https://chromium-review.googlesource.com/1114320
Commit-Queue: Mina Almasry <almasrymina@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571357}

Bug: 852429
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I32d6cae65a26ab3439caa41447a8ffd027b8e0ac
Reviewed-on: https://chromium-review.googlesource.com/1111382
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571356}

Handle the case of a context being invalidated before accessing
chrome.app.isInstalled. This can happen in cases where the owning frame
is removed.

Add a regression test for the same.

Bug: 855853
Change-Id: Ic9e5f5a45fc2a833c5c1a45d3b7c1e8c04c71a18
Reviewed-on: https://chromium-review.googlesource.com/1119066Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571355}

The WebView requesting a variations seed opens a file descriptor to
receive the seed. We should close it after the request.

BUG=857223

Change-Id: I594067ce0c33bed2137bc39e5c133ba22bca0c04
Reviewed-on: https://chromium-review.googlesource.com/1117707
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571354}

This CL aims at removing APIs from ash::SearchResultContainerView,
which is part of the cleanup of app list focus.

Bug: 766807
Test: covered by tests
Change-Id: I6292ac38d157c23984b6151b2dd522be1e5caabe
Reviewed-on: https://chromium-review.googlesource.com/1116896
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571353}

This reverts commit a6dc11ea.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 571213 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E2ZGMxMWVhNjMwMzc4ZWE4OWNhNGY1ODdlNWVlYmM2NjYxNTExMjAM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28074

Sample Failed Step: ash_unittests

Original change's description:
> Handle custom/bitmap cursors in ws2.
> 
> Go through CursorFactoryOzone to load the PlatformCursor (which
> confusingly could be CursorData, but for now is X11CursorOzone). Also
> set fields on the cross-platform Cursor type so that code which relies
> on it such as CursorWindowController::UpdateCursorImage will work.
> That code path can be exercised with --ash-enable-cursor-motion-blur
> although there is currently no use of custom cursors with ws2.
> 
> Bug: 837705
> Change-Id: I9f725c5a5350e28cf8bded6b53bf48759cb644f8
> Reviewed-on: https://chromium-review.googlesource.com/1105562
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571213}

Change-Id: I5bda2cd762ef24cbf5b31eac96a7e0d1e96e84c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 837705
Reviewed-on: https://chromium-review.googlesource.com/1119586
Cr-Commit-Position: refs/heads/master@{#571352}

I am currently seeing ~200ms starting AV sync difference at the
beginning of playback, so add some checks to see if the audio/video
start at the desired time or not.

1. Add AV sync unittests tha check that the video started on time.
2. Add logging to in AvSync that logs the difference between the
   audio/video playback starting time and the actual starting time.

Bug: b/109701656
Test: On device unittests

Change-Id: I2283517953d55f9224a7e3813029e5f5c58a0ebb
Reviewed-on: https://chromium-review.googlesource.com/1111318
Commit-Queue: Mina Almasry <almasrymina@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571351}

This is a reland of c902850a

Original change's description:
> [ChromeDriver] Listen on both IPv4 & IPv6
> 
> On hosts that support both IPv4 and IPv6, ChromeDriver now listens on
> both protocols.
> 
> Bug: chromedriver:779
> Change-Id: I4a115cc0ca5cf0396acdad8d4c1a72f169120368
> Reviewed-on: https://chromium-review.googlesource.com/1080448
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
> Commit-Queue: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564984}

Bug: chromedriver:779
Change-Id: Id8949883a272c33f9c1fc975ba8706f6fca908b4
Reviewed-on: https://chromium-review.googlesource.com/1112159
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571350}

Currently AudioContext has no way of uninitializing the instance without
an explicit context closure. This extends BaseAudioContext's
ContextDestroyed to AudioContext so we can hook up its own uninitialize
routine, and then eventually calls the parent's uninitializer.

This also fixes other issue of UKM metrics being reported in less cases
because they were only reported when context.close() was called.

Bug: 856690, 688052, 670065
Change-Id: I721dc2c27201caab1b0a95baf8f6906f44b76979
Reviewed-on: https://chromium-review.googlesource.com/1115516
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571349}

Heavy Page capping browsertest has a lot of repeated code that should be
moved to helper methods to make the tests more readable.

Change-Id: I73f8b7a950a261d2850500535b6e907f6ab9cd63
Reviewed-on: https://chromium-review.googlesource.com/1119536Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571348}

The Service Workers API provides clientIds for FetchEvents and the
clients API. The Web Locks API provides clientIds for the query() API.
These should match for a given client (e.g. a controlled iframe
holding a lock and making a fetch) - add a test to verify that this is
the case.

(This currently fails in Chrome since clientIds are minted
separately for Service Workers and Web Locks.)

Bug: 804548, 810117
Change-Id: I3b56e52a203dd89b9070d804d92aaada0176b8ed
Reviewed-on: https://chromium-review.googlesource.com/1117888
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571347}

https://pdfium.googlesource.com/pdfium.git/+log/35ab1bd0328a..5fbb98122c59


git log 35ab1bd0328a..5fbb98122c59 --date=short --no-merges --format='%ad %ae %s'
2018-06-28 tsepez@chromium.org Fix logic error in CJX_InstanceManager::count()
2018-06-28 thestig@chromium.org Remove redundant FPDF_PAGEOBJECT null-ness checks.


Created with:
  gclient setdep -r src/third_party/pdfium@5fbb98122c59

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:353450
TBR=dsinclair@chromium.org

Change-Id: I3a1d4240ed411c4dbd2801fb2ef7fae39307b8eb
Reviewed-on: https://chromium-review.googlesource.com/1118814Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571346}

Rename NGLayoutInputObject::GetLayoutObject to GetLayoutBox()

Bug: 728378
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ie4a1beed8aed3268ecfca4d62113490f393f01de
Reviewed-on: https://chromium-review.googlesource.com/1119360
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571345}

* Test verifies fake root is shown, then mounts container
  and verifies that correct volume and contents are displayed.
  Unmounts volume, and verifies that fake root is shown again.
* Sets prefs / features for crostini and registers mount callback
  with FakeCrosDisksClient to simulate sshfs mounting.

Bug: 845075
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ice3f96430ef063a9942fdd2c40e99b30b35b0c50
Reviewed-on: https://chromium-review.googlesource.com/1094574
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571344}

ARC IMEs added via Play Store are not associated with any language
by design. Instead, each IME supports only one fake language
|kArcImeLanguage| defined in ui/base/ime/chromeos/.

This CL allows chrome://settings/inputMethods to show such IMEs
at the bottom of the list by doing the following:

 - Return |kArcImeLanguage| and its display name from the
   GetLanguageList() private API.
 - Do not show the fake language in add_languages_dialog.js since
   it's for internal use only.
 - Modify manage_input_methods_page.js to show ARC IMEs associated
   with |kArcImeLanguage|.
 - Handle ARC IMEs in the AddInputMethod() private API.

Bug: b:74499980
Bug: 845079
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I28a1b01705387dc9cd87dd0b873dc3ca23087cbf
Reviewed-on: https://chromium-review.googlesource.com/1114680Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571343}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8bcc71ebebc5..cb0889ef01d0


git log 8bcc71ebebc5..cb0889ef01d0 --date=short --no-merges --format='%ad %ae %s'
2018-06-28 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@cb0889ef01d0

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: If2cd6d518e32f8100714d2a92751ca90a93ce732
Reviewed-on: https://chromium-review.googlesource.com/1119331Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571342}

GetProfileByUser() will return null for a non logged in user, so do not
use IsOwnerProfile() to set is_owner.

This also fixes behavior in ChromeUserManagerImpl where the active user
was not correctly set as the owner when kStubCrosSettings is set
because UserManagerBase::UserLoggedIn is calling
RegularUserLoggedInAsEphemeral() instead of RegularUserLoggedIn() for
non owners, and the logic to set the user as the owner was in
RegularUserLoggedIn().

Bug: 856441
Change-Id: I085d46accb3c97c1b6ee5615b838a5de796e3f8b
Reviewed-on: https://chromium-review.googlesource.com/1118921
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571341}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b3853afe341f..ae1f03388f7a


git log b3853afe341f..ae1f03388f7a --date=short --no-merges --format='%ad %ae %s'
2018-06-28 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-28 vadimsh@chromium.org [cipd] Bump cipd and vpython to versions that use v2 protocol by default.
2018-06-28 jbudorick@chromium.org gclient: escape cipd variables when flattening DEPS.
2018-06-28 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-28 ehmaldonado@chromium.org gclient: Don't include CIPD package name in hierarchy.


Created with:
  gclient setdep -r src/third_party/depot_tools@ae1f03388f7a

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:801423,chromium:None
TBR=agable@chromium.org

Change-Id: I7b9f1d0635aeb8fec52b5bc1541c10001489df04
Reviewed-on: https://chromium-review.googlesource.com/1119329Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571340}

It was confusing about the display zoom and a11y feature magnifier
zoom. Modify the descriptions to make it more clear.

Bug: 854868
Test: manual
Change-Id: I037e9990b2d6eb43b19e5151077032f3fb52818f
Reviewed-on: https://chromium-review.googlesource.com/1115718
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571339}

Using wpt-import in Chromium 23b63ae4.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20306

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=markdittmer

No-Export: true
Change-Id: Id87100dcd1a3710da9b9502de0240110a910484f
Reviewed-on: https://chromium-review.googlesource.com/1119354
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571338}

The change in [1] inadvertantly caused us to allocate a temporary buffer
for decoding an image and then copying into the target memory, if
requested with kNone_SkFilterQuality. Fix it.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1106608

R=ericrk@chromium.org

Bug: 855416
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I01d23176ae12808022f67286025243bcaab655ed
Reviewed-on: https://chromium-review.googlesource.com/1119348Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571337}

The Bluetooth stack cannot handle certain BLE operations concurrently.

Bug: internal b/109767461
Test: cast_bluetooth_unittests. Manual.
Change-Id: Ia3b15c64fa553a8221aa995cbab42c15cc977f7a
Reviewed-on: https://chromium-review.googlesource.com/1109580
Commit-Queue: Bailey Forrest <bcf@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571336}

This effectively removes the grey navigation bar divider line when the
navigation bar color is black on Android P+.

BUG=844173

Change-Id: I5147f63aadd9d79d084fa582284e46fb2c6b6fe9
Reviewed-on: https://chromium-review.googlesource.com/1119369
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571335}

Making CloseWindow W3C compliant by returning the result of
GetWindowHandles. Modified testCloseWindow in run_py_tests.py
to test this conformance.

Bug: chromedriver:1990
Change-Id: I2e90e9e9ca16559ea3678846a7d605b402b4d431
Reviewed-on: https://chromium-review.googlesource.com/1115813Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Cole Winstanley <cwinstanley@google.com>
Cr-Commit-Position: refs/heads/master@{#571334}

When the avatar button is activated using the keyboard the first profile
should be highlighted. But the new Refresh avatar button was using a
code path that always indicated the keyboard was used.

As a short-term fix, this patch avoids that code path entirely.

Bug: 849810
Change-Id: I87c32cf76870d92911f227afd74a9dd1e201a4b2
Reviewed-on: https://chromium-review.googlesource.com/1119385Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571333}

This CL fabricates a rich suggestion/new answer layout for calculator
responses by creating a mimicking a suggestiondetails entry.

Change-Id: I5fdc83b2f31d703e0ed8421e9be65233c9be2cb1
Reviewed-on: https://chromium-review.googlesource.com/1111460
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Mitsuru Oshima (OOO 6/27) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571332}

Bug: 849857
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I2bdac0e55708bc7461041365ac736ad2c5bc7bc1
Reviewed-on: https://chromium-review.googlesource.com/1114204Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571331}

Custom tabs don't have an overflow menu or menu wrapper which was
causing a null pointer exception. This CL adds a null check.

Bug: 857416
Change-Id: Ic2604bb7545cb1e94df6c9a720da74e7171e11c0
Reviewed-on: https://chromium-review.googlesource.com/1119150Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571330}

This call clears persisted state that is tied to navigation history.

Bug: 797981
Change-Id: Ie0e2224f673b07ef6edc80e30f0cbb518dea0029
Reviewed-on: https://chromium-review.googlesource.com/1119157Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571329}

Pixel_OffscreenCanvasTransferBeforeStyleResize on Mac Intel HighSierra

TBR=kbr@chromium.org

Bug: 857578
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie29b7978a7328bb3c47f722bd695839aa76c1eca
Reviewed-on: https://chromium-review.googlesource.com/1119070
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571328}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/5e83981..a5c263c

Bug: 853978, 857303
Change-Id: I9cf554d30f5f51bcdca25f7fa6b1027312de0e77
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1117894Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571327}

Previously history filtering was using selectRowAtIndexPath: to select the rows that were going to
be filtered by the searchController. This caused that previously selected cells on edit mode were
filtered out when searching. This CL introduces an Array to hold these indexes to filter out later.

Also, when there're no results when search filtering, the emptyTableView shouldn't be displayed.

Bug: 857088
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I40bd4e5181d84fc23edae1eeea64e899aa120d4f
Reviewed-on: https://chromium-review.googlesource.com/1118909Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571326}

The leak is now fixed.

Bug: 855583,843511
Change-Id: Id8367b404108467783ac5e2c8c186b7ba210df4f
Reviewed-on: https://chromium-review.googlesource.com/1117611Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571325}

https://chromium.googlesource.com/catapult.git/+log/7ddf0ed7f771..e2d6bbca629c


git log 7ddf0ed7f771..e2d6bbca629c --date=short --no-merges --format='%ad %ae %s'
2018-06-28 benjhayden@chromium.org Remove Test and TestMetadata indexes.


Created with:
  gclient setdep -r src/third_party/catapult@e2d6bbca629c

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia282d1c275ce6114148b0ac6e303932141452161
Reviewed-on: https://chromium-review.googlesource.com/1119325Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571324}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/66c52be1969a..8bcc71ebebc5


git log 66c52be1969a..8bcc71ebebc5 --date=short --no-merges --format='%ad %ae %s'
2018-06-28 xixuan@chromium.org chromeos_config: Mark reef as experimental.
2018-06-28 yueherngl@google.com octopus: mark paladin as important (not experiment)
2018-06-28 dhanyaganesh@chromium.org CreateTarball: Adding psutil based listening on directories to be tarred


Created with:
  gclient setdep -r src/third_party/chromite@8bcc71ebebc5

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:854862,chromium:547055
TBR=chrome-os-gardeners@chromium.org

Change-Id: I41a1df6c6122c1eb6d6c66cc415ae2518ba3356b
Reviewed-on: https://chromium-review.googlesource.com/1119326Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571323}

This reverts commit aa1b9b70.

Reason for revert: Just in case. There comes a concern from a reviewer.

Original change's description:
> bindings: Clear ScriptState self-reference at disposing worker global scope
> 
> Each v8::Context is wired with a ScriptState, and it clears the
> self-reference of ScriptState at its termination.
> In worker threads, it means that ScriptState is kept alive until
> terminating v8::Isolate, although ScriptState is not used after
> disposing global scope.
> 
> This CL explicitly does tasks in weak callback registered in v8::Context
> at disposing global scope. Actual tasks are (1)to clear self-persistent
> of ScriptState and (2)to drop a weak reference from ScriptState to
> v8::Context.
> This change makes it possible to release ScriptState at anytime before
> v8::Isolate termination.
> 
> 
> Bug: 773605
> Change-Id: I9da5052c035a0b56dd47a6305df89809b05408a7
> Reviewed-on: https://chromium-review.googlesource.com/1117976
> Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571107}

TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org

Change-Id: Ibf5511ad731ec8c18ad2df32f24060e9be81ba86
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773605
Reviewed-on: https://chromium-review.googlesource.com/1119425Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571322}

This reverts commit f02c92e1.

Reason for revert: still breaking perf waterfall https://ci.chromium.org/buildbot/chromium.perf/linux-perf/315

Original change's description:
> Reland "gtest perf tests: Output well formed test results json"
> 
> This reverts commit 9eeaba4e.
> 
> Reason for revert: Will re-land with fix
> 
> Original change's description:
> > Revert "gtest perf tests: Output well formed test results json"
> > 
> > This reverts commit 71b865f4.
> > 
> > Reason for revert: break many perf tests (see https://ci.chromium.org/buildbot/chromium.perf/linux-perf/307)
> > 
> > Original change's description:
> > > gtest perf tests: Output well formed test results json
> > > 
> > > This CL changes the run_gtest_perf_test.py script to output well formed
> > > test results json.
> > > 
> > > Bug: 855234
> > > Change-Id: Ia5ce6e258865e34a2aa37635c014cd54efa62796
> > > Reviewed-on: https://chromium-review.googlesource.com/1112635
> > > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#570943}
> > 
> > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> > 
> > Change-Id: Ia0aaff923014438005ebc0a8677c3bbbebb808ac
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 855234
> > Reviewed-on: https://chromium-review.googlesource.com/1118238
> > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > Commit-Queue: Ned Nguyen <nednguyen@google.com>
> > Cr-Commit-Position: refs/heads/master@{#571083}
> 
> TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> 
> Change-Id: Idb255b1fafb7f254fd44d6554f93ff27608279f2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 855234
> Reviewed-on: https://chromium-review.googlesource.com/1118789
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571245}

TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org

Change-Id: I6bc0869caa6a763dc8bb542fd5a1b3d25853ac86
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855234
Reviewed-on: https://chromium-review.googlesource.com/1119445Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#571321}