- 14 Feb, 2018 40 commits
-
-
Robert Iannucci authored
This will prevent tests sensitive to cold vpython startup time from timing out. Bug: 804174 Change-Id: Ieaf6e0d94fa668fd26481fe3efcaf6d0e968864d Reviewed-on: https://chromium-review.googlesource.com/917802Reviewed-by:
Daniel Jacques <dnj@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#536766}
-
Elly Fong-Jones authored
This change: 1) Adds a HEAVY_UNDERLINE text style 2) Has RenderText apply it for compositions, instead of UNDERLINE 3) Has RenderTextHarfBuzz and RenderTextMac draw HEAVY_UNDERLINE properly Bug: 612675 Change-Id: I08f997dfb1edee1ea29d8c828302d7a24418975b Reviewed-on: https://chromium-review.googlesource.com/905125Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#536765}
-
Andrey Pronin authored
For Chromium builds, instead of triggering tpm ownership on boot, rely on it being triggered after the first login (as it was before CL:688763). after booting, (b) the tpm is owned after logging in. Bug: 799664 Test: clear the owner, reboot, verify that (a) the tpm is not owned Change-Id: I991333e0f049c998dc126827dc141419bf1c3503 Reviewed-on: https://chromium-review.googlesource.com/917537Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Andrey Pronin <apronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#536764}
-
Joy Ming authored
This CL switches the implementation of the DownloadLocationDialog from AlertDialog to ModalDialogManager. Bug: 792775 Change-Id: Ida60fb9cd55f9b2e07a918bfb90e79468552de6d Reviewed-on: https://chromium-review.googlesource.com/915105 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#536763}
-
https://webrtc.googlesource.com/src.git/+log/d377f041944f..13735821487e $ git log d377f0419..137358214 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia050aa14d6548dbe53381eb5df233125f06dad0d Reviewed-on: https://chromium-review.googlesource.com/919252 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536762}
-
Kyle Horimoto authored
This class fetches access tokens for the current user using the IdentityManager service. This will be used to fetch synced CryptAuth data in the DeviceSync API. Bug: 752273 Change-Id: I3978c7438a78f54800db3bb5b9f5e9221c9104d6 Reviewed-on: https://chromium-review.googlesource.com/906969Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#536761}
-
Steve Kobes authored
Bug: 811073 Change-Id: Id357417202933651460086559f34238b363142c7 Reviewed-on: https://chromium-review.googlesource.com/919258Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#536760}
-
Stefan Zager authored
The line removed in this CL was added in: https://chromium-review.googlesource.com/c/chromium/src/+/914864 That CL was to fix a crash, but the crash only occurs when root layer scrolling is enabled. The call to ScrollAnchor::Dispose from LocalFrameView::Dispose was added just for completeness, but does not affect the original crash. This new crash suggests that LocalFrameView may still process scroll events after Dispose() has been called. Which is strange and horrible, but probably not worth fully investigating at this point. Instead, just remove the call to scroll_anchor_.Dispose() and wait for root layer scrolling to make the surrounding code obsolete. BUG=812023 R=skobes@chromium.org,bokan@chromium.org Change-Id: I0715ab5a76e2fee6b4f378fc470d816b851bfa44 Reviewed-on: https://chromium-review.googlesource.com/919396Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#536759}
-
James Cook authored
It's a mojo mini-app. It's only used with mash, which only runs on Chrome OS. Move it to the Chrome OS UI directory. NOPRESUBMIT=true Bug: none Test: bots Change-Id: I8da161c8ec4c95ab284d4b0e5248b6fff5a04406 Reviewed-on: https://chromium-review.googlesource.com/917208 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#536758}
-
Eugene But authored
Old name was presumably used to match was_within_same_page IPC, but SameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with the rest of Chromium code. Bug: 695189 Change-Id: If70aa7b7b315773a496db08fc2b7878465b5c5b4 Reviewed-on: https://chromium-review.googlesource.com/912104Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#536757}
-
Elly Fong-Jones authored
There's a subtle lifetime issue exposed by this test. See the linked bug for more details. Bug: 810139 Change-Id: If04cc1573c7983ab62627770ea96c7a5ef6a56cb Reviewed-on: https://chromium-review.googlesource.com/919463Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#536756}
-
Nicolas Pena authored
This CL changes MemoryInfo so that, when the heap statistics are calculated, the values for totalJSHeapSize and usedJSHeapSize are not used if the number of pages is greater than 1. Bug: 807651 Change-Id: I99bc52e0e2cb8e17c797fdb3868110fc409ad00e Reviewed-on: https://chromium-review.googlesource.com/904972Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#536755}
-
James Cook authored
Now that we have //ash/components we're trying to clean up //ui to get it back to its original state of being low-level UI libraries. This code was written during the Athena days (when we were trying to avoid using ash). It is only used inside //ash, so move it there. Bug: none Test: ash_unittests, ui_chromeos_unittests Change-Id: I2484d2d54a8ad99b855719c968708c3008ba52a0 Reviewed-on: https://chromium-review.googlesource.com/917439Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#536754}
-
Robert Liao authored
The ExtensionPopup resizes its view dynamically after it can be anchored and shown. This change adds child resize support to BubbleAnchorHelper to accommodate that scenario. Move is brought along for free. BUG=728174 Change-Id: I7ca12b92da339263ca5558254d2bbb0595a57b4c Reviewed-on: https://chromium-review.googlesource.com/915010 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#536753}
-
https://pdfium.googlesource.com/pdfium.git/+log/d8d6f55140bd..785d126bd57a $ git log d8d6f5514..785d126bd --date=short --no-merges --format='%ad %ae %s' 2018-02-14 npm Roll pdfium/third_party/freetype/src/ 036bdc0c9..4a03f1744 (2 commits) 2018-02-14 dsinclair Set node to owning element 2018-02-14 dsinclair Cleanup some CXFA_Node flags and methods. 2018-02-14 dsinclair Cleanup CXFA_Node::SetFlag Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I92d59d95ae32ccbd9c7c656ba3f724acf3f64673 Reviewed-on: https://chromium-review.googlesource.com/919383 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536752}
-
edchin authored
This CL adds an experiment flag for Tab Grid, and simply uses the flag to show a blank tab grid when enabled. Bug: 804496 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9d24d64c77cba8889f2c699763d610617263b9cc Reviewed-on: https://chromium-review.googlesource.com/917427 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#536751}
-
Kyle Horimoto authored
Now, it is a pure virtual class with a test double. This is in preparation for using it in the MultiDevice service. Bug: 752273 Change-Id: I01f79a0361ec71e51a30dc3a56b28555dc594712 Reviewed-on: https://chromium-review.googlesource.com/910118Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
liberato@chromium.org authored
Already seems to time out 100% of the time, and similar tests in TestExpectations are marked as crash. So, adding that to this one as well. TBR=dom-dev@chromium.org Bug: 811993 Change-Id: I4451212e7e4263ed3c843c4860ce1834ebd0079b Reviewed-on: https://chromium-review.googlesource.com/917222 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#536749}
-
wutao authored
This cl allows client to set custom_frame_view color. Changes: 1. Add OnWindowPropertyChanged to CustomFrameViewAshWindowStateDelegate. 2. Client can set custom_frame_view color by setting window property aura::client::kTopViewColor. Bug: 811159, 768932 Test: CustomFrameViewAshTest.KTopViewColor and manually test color update. Change-Id: Ic2306c399b0d4cda88ffb0f96c48a15e3e6f430b Reviewed-on: https://chromium-review.googlesource.com/912518 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima (In Tokyo) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#536748}
-
https://skia.googlesource.com/skia.git/+log/0ee866dac78b..5b6fa82ee12b $ git log 0ee866dac..5b6fa82ee --date=short --no-merges --format='%ad %ae %s' 2018-02-14 brianosman Respect FPArgs local matrix when picking a filtering mode in image shader 2018-02-14 kjlubick Trim down Emscripten SDK asset size 2018-02-13 benjaminwagner Do not copy vulkan-1.dll to Win bots. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Ic820b07dd5bccf43afc4b742a8302d9ae60bcdf2 Reviewed-on: https://chromium-review.googlesource.com/919254Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536747}
-
Koji Ishii authored
Following bot results are included. 3740 3742 3746 3749 3750 3753 1 lines were removed and 21 lines were deflaked by consecutive results since 3699. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I934d43db60e15dd176db569fc9793b79d5cc4e7e Reviewed-on: https://chromium-review.googlesource.com/917721 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#536746}
-
edchin authored
Crash is caused by the previousPanelIndex being out-of-bounds into the panels array. This CL ensures that previousPanelIndex is kept up-to-date when any panels are removed so that it is not out-of-bounds. Bug: 805530 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id193a85585510c50e9bb92680f0782fee7e34d1a Reviewed-on: https://chromium-review.googlesource.com/916943Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#536745}
-
Hajime Hoshi authored
This is part of efforts to replace default timer task runners with other appropriate task runners in the renderer. Bug: 624694, 804694 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id745eed43a86ce079fd870586ce6169b928ba1dd Reviewed-on: https://chromium-review.googlesource.com/917884Reviewed-by:
-
Danyao Wang authored
When switching to an evicted tab, WKBasedNavigationManager loads restore_session.html to restore back/forward history. This load should not be counted as a new page load by TabUsageRecorder. This fixes TabUsageRecorderTestCase/testEvictedTabReloadBackground. Bug: 807428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If194acd0de633bc170f221d8a960514995425bce Reviewed-on: https://chromium-review.googlesource.com/917524Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#536743}
-
Isha Bobra authored
This CL is a followup on the following CL: https://chromium-review.googlesource.com/736043 The above CL returns the deepest child of web view on ACTION_PREVIOUS_HTML_ELEMENT if can_wrap_to_last_element flag in OneShotAccessibilityTreeSearch is set to true. This CL sets that flag for Android. Assuming a web view is in between native elements, the following order will be followed for a11y focus: Native elements -> web view container -> inside web view container -> native elements. So web view container will always be focused only in the above order. Bug: 661793 Change-Id: I62dbcb143ed5a152172dc7cde9355f4b7eed79e1 Reviewed-on: https://chromium-review.googlesource.com/884302Reviewed-by:
-
Vadym Doroshenko authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/823238/ introduces processing messages from IFrames. Function CRWWebController:respondToMessage: userIsInteracting:originURL:isMainFrame: incorrectly processes case when no handler for message form IFrames. Which leads to using |handler|, when |handler| = nil. This CL fixes that. Bug: 801485 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I661754b83e2e09a4a907634d15f50e62a315c343 Reviewed-on: https://chromium-review.googlesource.com/916604 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c345b4a..39b1f697 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I399fc534ca6bf58c91815887f0be6b3655e6a30c Reviewed-on: https://chromium-review.googlesource.com/919221Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#536740}
-
Matt Menke authored
This caused a regression on Cronet perf tests. I'll reland with some windows-only ifdefs. Sadly, our infrastructure makes it easier to revert and reland with modifications than to land another CL, if you have a lot of local branches. This reverts commit ac0c504b. Reason for revert: <INSERT REASONING HERE> Original change's description: > Add URLRequest creation stack traces to AssertNoURLRequests crashes. > > We have a top crasher here (Again...), and need to figure out just > what's going on. Hopefully once we ship the network service, we'll > never see these crashes again (Well, at least in the network > process). > > Bug: 800391 > Change-Id: Ifbd45274ac73ca90c7103aea66ba0f7d254c9e6e > Reviewed-on: https://chromium-review.googlesource.com/916894 > Reviewed-by: Eric Roman <eroman@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536575} TBR=eroman@chromium.org,mmenke@chromium.org Change-Id: Id648cff17e81452d0203b13d1b4b00a49976a6b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800391 Reviewed-on: https://chromium-review.googlesource.com/919401Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#536739}
-
Donn Denman authored
When Contextual Search enters a disabled state it removes notifiers for showing the UI. However if the UI is already showing it should hide it immediately. This CL adds a call to hide when disabling for any reason, including network connectivity loss. BUG=783352 Change-Id: I826d38264cd6c0cb5ca6ece804c2f44c3b0ee924 Reviewed-on: https://chromium-review.googlesource.com/917647Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/2f68cb53f593..d8d6f55140bd $ git log 2f68cb53f..d8d6f5514 --date=short --no-merges --format='%ad %ae %s' 2018-02-14 dsinclair Cleanup CXFA_Document const-ness Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ifcd5e6d8366666afac1b93bd445d6fa9c46fe767 Reviewed-on: https://chromium-review.googlesource.com/919248Reviewed-by:
-
Luna Lu authored
Shadow page has a frame and upon service worker startup, UseCounter will count page visits. This CL adds a flag "is_shadow_page_" in Settings and sets the flag to be true in WorkerPageShadow initialization (by default the flag's value is false). In UseCounter it checks for shadow pages and drop counts for shadow pages. Note that this flag will eventually go away since browser side use counter does not have problems with workers. So once the blink side use counter is removed, this change can be undone. This change has also been verified to work locally. Bug: 694880 Change-Id: I1cbe857d776591098bbbbf256ef8aa546c399af5 Reviewed-on: https://chromium-review.googlesource.com/917028 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#536736}
-
Julia Tuttle authored
Bug: 763433 Change-Id: Id87010fd5d25122500be8b80efe56fe446dd8633 Reviewed-on: https://chromium-review.googlesource.com/916581Reviewed-by:
Chris Bentzel <cbentzel@chromium.org> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#536735}
-
Vladislav Kuzkokov authored
Bug: 625126 Change-Id: If67d226a432060596cf424e148f16b7a5035aeb5 Reviewed-on: https://chromium-review.googlesource.com/914821Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#536734}
-
Benoit Lize authored
Change-Id: Iaf6cd9ecaaf601192847a84007d5596cbb10a367 Reviewed-on: https://chromium-review.googlesource.com/919086Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#536733}
-
Andrew Grieve authored
Bug: 777511 Change-Id: I4cf8f627784038f1fb0ed32d8f25843bdbff3613 Reviewed-on: https://chromium-review.googlesource.com/916556Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#536732}
-
Ted Choc authored
This removes the dependency on an immediate onUpdate from the framework to have a default title. BUG= Change-Id: I0e36b40b25e0a26c618e48cbf99c4a470f19ccf0 Reviewed-on: https://chromium-review.googlesource.com/918781Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#536731}
-
https://skia.googlesource.com/skia.git/+log/8242c5c199f5..0ee866dac78b $ git log 8242c5c19..0ee866dac --date=short --no-merges --format='%ad %ae %s' 2018-02-14 egdaniel Revert "When creating emptyp MipMap proxies, don't instantiate them immediately." 2018-02-14 robertphillips Fix compilation of opList-based DDL implementation Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I09e9f2bce7ccb6f935c9555563dcef49f079c77c Reviewed-on: https://chromium-review.googlesource.com/919246 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
erikchen authored
Bug 1: When an AllocationTracker is destroyed from a client disconnecting, queued barrier callbacks would not be run. This would cause the heap dump to never be emitted. Bug 2: The implementation of MemlogConnectionManager::OnNewConnection called mojo::SharedBufferHandle::Create, which uses synchronous IPC with the browser process. This can cause deadlock/timeouts, since the browser process synchronously waits for the memlog pipe to free up and eventually gives up after 10 seconds, tearing down the allocator shim. The solution is to create a dedicated thread for calling mojo::SharedBufferHandle::Create, thus avoiding the deadlock. Change-Id: Ib3f4143381ce03c353ffe93d45794070e3b007d5 Bug: 811711 Reviewed-on: https://chromium-review.googlesource.com/917243 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#536729}
-
Mustaq Ahmed authored
Currently RemoteFrame::Navigate is the user of Frame::HasTransientUserActivation that passes a RemoteFrame*, and it seems wrong because the user activation (user gesture) needed by the navigation should belong to the LocalFrame that initiated the navigation. Follow-up CLs after this one will update UserActivation code in Frame to take a LocalFrame* instead of a Frame*, and get rid of redundant IPCs. Bug: 811414 Change-Id: I771c1694043edb54374a44213d16715d9c7da704 Reviewed-on: https://chromium-review.googlesource.com/914736 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
-
Louis Romero authored
This delegate method will change in a follow-up CL from notifying the animations will start, to asking the delegate to trigger the animations at its convenience. Context: go/bvc-tab-switcher-animators Bug: 787833 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3da5140c0dd224fd0689a32461c9ac6f43a6a7ea Reviewed-on: https://chromium-review.googlesource.com/895687 Commit-Queue: Louis Romero <lpromero@chromium.org> Reviewed-by:
-
