- 16 Apr, 2020 40 commits
-
-
Ben Pastene authored
profile_provider_unittest is a big target, and takes some time to build: https://chromium-build-stats.appspot.com/ninja_log/2020/04/15/luci-chrome-ci-xenial-us-west1-c-highmem-16-1-jm5p/ninja_log.luci-chrome-ci-xenial-us-west1-c-highmem-16-1-jm5p.chrome-bot.20200415-113309.9739.gz/trace.html By moving it into //:gn_all, we can speed up the build time of //:chromiumos_preflight while still allowing bots that run the test to find the target. Change-Id: I5881faf0b11a22899f8639c55dc28dd554cd8906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150815Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#759711}
-
Yusuf Sengul authored
Bug: 1071326 Change-Id: I77b95cf30552cd87dbb8b921b66f9a7636efe5fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152215Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#759710}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a0a377b4..6cb05cce Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I34852b328f76d140b3f873192f05cc14b0afd190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152606Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759709}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9036394cfefb..7027d3e67c45 git log 9036394cfefb..7027d3e67c45 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 lalitm@google.com tp: add parent slice id to slice table Created with: gclient setdep -r src/third_party/perfetto@7027d3e67c45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:153450605 Tbr: perfetto-bugs@google.com Change-Id: I4616b223a22e85ef6edc6c72b618295db0f7d03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151434Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759708}
-
Guido Urdaneta authored
Disable several P2PQuicTransportMockConnectionTests that are failing on many bots. Bug: 1071340 Change-Id: I353863488e2cf3357eb167539cb3c7908a1407f5 TBR: ianswett@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153066Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#759707}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ab983012a2d4..514232c46d65 git log ab983012a2d4..514232c46d65 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 bclayton@google.com VkSemaphore: Unlock/Lock the mutex outside the blocking_call. 2020-04-16 bclayton@google.com Regres: Include a better error message when git add fails. 2020-04-16 bclayton@google.com Regres: Avoid dereferencing a nil on process timeout. Created with: gclient setdep -r src/third_party/swiftshader@514232c46d65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I420453664ba81032b803243ff03493f8c8994bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152709Reviewed-by:
-
Annie Sullivan authored
Shift csharrison down in hopes of spreading out the reviewer load a little. Change-Id: Iacac4dd0103c07d7505336d312dbf60152d03783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151484 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#759705}
-
Pavel Yatsuk authored
The crash in crbug.com/1066814 indicates that Toast.show() was called on the same toast object twice. Code pattern, where toast object is retained between callbacks, allows for such scenario. In this CL I change logic to cancel old toast and create a new instance before calling Toast.show(). BUG=1066814 Change-Id: I9694d465a500202920cf23104eccf89c1176cb94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151853Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#759704}
-
Brian Sheedy authored
Optimizes the Android Skia Gold code in the following ways: 1. Adds an "Initialize" step and shuffles arguments around so that goldctl only has to initialize the working directory once instead of every time a comparison is performed, saving ~250ms per comparison. 2. Because #1 causes each session to only be valid for a single instance/corpus/keys_file combination, adds SkiaGoldSessionManager to lazily create sessions as necessary. 3. Short circuits the "Authenticate" step if the session is already authenticated, saving ~40ms per comparison. Change-Id: I72677ec8b0a0a3757ce198e8b8e1d34be7b74257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148153Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#759703}
-
Chris Mumford authored
Corrected indent to be four spaces IAW the style guide. Doing this makes all Python scripts uniformaly formatted in //third_party/sqlite/scripts. Bug: None Change-Id: I476654c330bf957e0ad65d46c44df53e1eacdf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150236Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#759702}
-
Robert Flack authored
Bug: 730065 Change-Id: I60f2dc628d00c0cf9c70bdff417f5c8cc07f8243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112981Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#759701}
-
Kevin Ellis authored
CSS animations require property-value pairs for the first and last keyframe for all animated properties. This patch adds tracking of when missing properties should be inserted and lazily calculates the property values as required in getKeyframes. Bug: 1068332 Change-Id: I29fdca2a393a115672c682fd7377416a7869971f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137510Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#759700}
-
Ken Rockot authored
When a FilesystemProxy is given an empty root path in UNRESTRICTED mode, it expects all API calls to receive absolute paths only. This constraint was imposed under the assumption that no existing LevelDB ChromiumEnv users were using relative paths (and thus creating persistent databases in the arbitrary current working directory). Well that turned out to be a bad assumption. This changes FilesystemProxy so that when given an empty root, it resolves relative paths against the current working directory. Fixed: 1071158 Change-Id: I52f48394ba65d66ebdc072d7b40951c6dfa29534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151311 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#759699}
-
Devlin Cronin authored
Waiting for a state and waiting for an event are subtly different: for an event, the waiter *must* be constructed before the event is fired (or else will spin forever), whereas for a state, a waiter may be constructed at any point (because the state can be queried). Update the docs with this differentiation and an example. Bug: None Change-Id: Ice984ee861df46d9010986e72779639e6c19e400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151470 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#759698}
-
Koji Ishii authored
|NGInlineCursor::MoveToItem| consumes 4.11% of total time in perf_tests/layout/chapter-reflow.html. One of its frequent caller is |MakeNull|. This patch optimizes |MakeNull| not to use |MoveToItem|. Bug: 982194 Change-Id: I3d8bef0bd40b0c8ad1bac8f5a296ce7e0cd1bde2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151773 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759697}
-
Esmael El-Moslimany authored
Bug: 1071009 Change-Id: I47fbb65bdf8adeea437e919b476ee8f1d3caafdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152003Reviewed-by:
-
Justin Donnelly authored
Change-Id: Icd693ebb3a68a8e1cddbfa686ccf2df904b7ba64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147371 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#759695}
-
Guido Urdaneta authored
It is failing consistently on some Linux bots. Bug: 1071403 Change-Id: Icd58e5223373b0d9a0161e1477e35941ca21766e TBR: karandeepb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152805 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Dan Harrington authored
Note that I've chosen to NOT use 'next_stream_state'. Instead, we load the data similar to the way we load data when doing the initial load. Doing it this way is simpler, but will limit us to doing background refreshes only when there are no attached surfaces. Bug: 1044139 Change-Id: I304a7ba158e6a9c7e333606f63c50c947216638a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145933Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#759693}
-
Rainhard Findling authored
* This is done as preparation for a subsequent refactoring of the safety check WebUi code. It moves the source of truth for the safety check parent status from the JS side to the C++ side. This removes some of the interdependencies of parent to children (and vice versa), and allows for a subsequent splitting of parent and children into individual parts on the WebUi side. * This CL is part 1 of the change, which adds logic to handle the parent state in C++ and the communication from C++ to JS. Bug: 1015841 Change-Id: I3716457964377ae3177884d5987281fd2c470a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144022Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#759692}
-
Nodir Turakulov authored
Move resultdb enablement from CI to all builders. Change-Id: I8e9f3d068bcdf0c00aac2e6050940d6b249a3db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151181Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#759691}
-
Colin Blundell authored
Following the pattern of //chrome, we will need to add a new world ID for translate, and the new ID will need to be accessible from the renderer. Bug: 1025620 Change-Id: I8154436d61e35a764f79348ac0ca55e641097989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152373 Commit-Queue: Colin Blundell <blundell@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Colin Blundell <blundell@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#759690}
-
Mark Yacoub authored
This reverts commit 0e18fd2d. Reason for revert: Atomic modesetting fails on puff for MST HDMI after boot Original change's description: > Reland "Ozone: Implement Atomic Modeset" > > If the device supports KMS Atomic APIs, Enable CRTC using Atomic Modeset > Commit instead of legacy SetCRTC. > > (reverted on crrev.com/c/2080775) > > BUG=987274 > TEST=displays should start and continue to function normally for devices > supporting atomic APIs. > HardwareDisplayControllerTest.CheckModesettingSetsProps > HardwareDisplayPlaneManagerAtomicTest.CheckPropsAfterModeset > > Change-Id: If08b015d1e62f51e9ec3c243c1e5a2965449345e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106476 > Commit-Queue: Mark Yacoub <markyacoub@google.com> > Auto-Submit: Mark Yacoub <markyacoub@google.com> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751717} TBR=dnicoara@chromium.org,markyacoub@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1067121 Change-Id: I777bf3455416f559d35349beda5036a2931b978e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152766Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#759689}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d113c17a489e..cbdc14be1be4 git log d113c17a489e..cbdc14be1be4 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 tobine@google.com doc: Discuss manual roll in note on Vulkan-Headers repo Created with: gclient setdep -r src/third_party/angle@cbdc14be1be4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I5da7ae51d19f97757fa29ff69adeaa36eac6538d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152705Reviewed-by:
-
Ben Pastene authored
Bug: 1071166 Change-Id: I94e85ba687b44bb208b4429c3e249865332b6e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150978 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#759687}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 767015, 1063749 Change-Id: I5d2d4771603678a792a37e71fd66cdc2a81f43b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152372Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#759686}
-
Kuo-Hsin Yang authored
The tab title may contain PII and should not be in the feedback report. Log the tab resource id and renderer pid to identify the tab. BUG=chromium:1070935 TEST=check the related tab manager logs after tab discard. Change-Id: I0fbbd1f222ba16ad80c431b66790f71df46b0501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152058Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#759685}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3c49531fb490..d059dfbc06e0 git log 3c49531fb490..d059dfbc06e0 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 mbonadei@webrtc.org Fix link in documentation. (take 2) Created with: gclient setdep -r src/third_party/webrtc@d059dfbc06e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6e08f6ef63f3375b2abc2d967a6bd74697a94ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151433Reviewed-by:
-
Colin Blundell authored
In flows where WebContents detects that a tab should be closed (e.g., on window.close()), it calls out to its delegate. WebLayer's TabImpl currently handles this by calling out to the client via NewTabCallback#onCloseTab(). However, there is no reason to delegate this functionality to the client: instead, WebLayer can directly close the tab, notifying the client of the closure via TabListCallback#onTabRemoved(). This CL makes that change, deprecating NewTabCallback#onCloseTab() as a public API. Embedders should adapt to this change by listening to TabListCallback#onTabRemoved(), and using it on 84 and above to implement the functionality that they are currently implementing in NewTabCallback#onCloseTab(). Note that the latter should still be kept on the embedder side for as long as they are supporting WebLayer impl versions < 84. For an example adaptation, see WebLayerShellActivity.java in this CL (nb: this does not implement any version checks as it's not relevant for WebLayer Shell). Any checks for the closed tab being the active tab that were being done in onCloseTab() should instead become checks for the active tab being null in onTabRemoved(); the latter will be the case if the tab was the active tab prior to being removed. We leave the prior flow in the implementation for clients < 84, since these clients are expecting that flow in order to work correctly. Note that this change opens the possibility that the embedder calls into a Tab object whose impl has been destroyed (e.g., if they fail to take appropriate action on TabListCallback#onTabRemoved()). To harden WebLayer against that case, this CL adds a new ITabClient#onTabDestroyed() API to have Tab null out its impl pointer on TabImpl destruction. This change is a precursor to implementing tab closing in the case where the initial navigation in a tab results in an intent being launched. Bug: 1031465 Change-Id: I88c28a3deb23f192ad1ca09ace0d111ce976e63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145877Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#759683}
-
S. Ganesh authored
This CL adds a PolicyManagerInterface that all future Policy Managers will support, as well as a DefaultPolicyManager. Bug: 1068797 Change-Id: Idf70e93a6b084e6a519cb65738f45ed51ecaae29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140994Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#759682}
-
Laís Minchillo authored
Test: none Change-Id: I1441585aa8345bc3fb60504b303635a85d8c9ac3 Fixed: 1061976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144072 Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#759681}
-
Mugdha Lakhani authored
PageInfoController is moving to //components soon. This is part of a series of CLs that remove //chrome dependencies from it. This CL moves one such dependency, ContentSettingValues, to components and updates references everywhere it's used. Bug: 1052375 Change-Id: I010f30be5e20a90b1d3746804ef929f0502994b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150906 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#759680}
-
Joey Scarr authored
This was linking to https://rota-ng.appspot.com/legacy/sheriff_v8.json which has been dead for a while. Bug: 1071344 Change-Id: I58145b96e38dc1e010070db53f22f14c8a1500d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151769Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Joey Scarr <jsca@chromium.org> Cr-Commit-Position: refs/heads/master@{#759679}
-
Justin Cohen authored
iOS 13.4 added better logging for finding leaked background tasks, but it requires setting a name. This change also adds a metric to track what backgroundTimeRemaining is for any tasks initiated in the background. Bug: 1064280 Change-Id: I074b7a229b4c9ca91b0f37d583d8a07994546178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1132097 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#759678}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d28d4891fbd9..a0c450d5b58f git log d28d4891fbd9..a0c450d5b58f --date=short --first-parent --format='%ad %ae %s' 2020-04-16 aerotwist@chromium.org Adds support for Total Blocking Time in Perf panel Created with: gclient setdep -r src/third_party/devtools-frontend/src@a0c450d5b58f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1054381 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia15e1c11dc65eea015bb7d08ef4b6ac0df6dffe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152632Reviewed-by:
-
Jeremy Roman authored
This was missed in crrev.com/c/2013473. Bug: 1040627 Change-Id: I1928292ab7f2d9ae2eab7577899300d995c9ca1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152633Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#759676}
-
Aaron Colwell authored
Removing a field that doesn't appear to be used anywhere and cleaned up all the call sites. Bug: 1015882 Change-Id: Ie6ed3db2a56d0416ec61a7f77da454b2fcc15fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151683 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#759675}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a9c9d66f12c..2d65b73337ee git log 7a9c9d66f12c..2d65b73337ee --date=short --first-parent --format='%ad %ae %s' 2020-04-16 tdenniston@google.com [svg] Fix multiple transforms specified Created with: gclient setdep -r src/third_party/skia@2d65b73337ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I5ee8ec4ee73175c63f4978bc4604075c58bf9f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152631Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/45e5510c53da..ab983012a2d4 git log 45e5510c53da..ab983012a2d4 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 bclayton@google.com Make memoryPageSize() functions thread-safe. 2020-04-16 bclayton@google.com Vulkan: Move SpecializationInfo to own file. Created with: gclient setdep -r src/third_party/swiftshader@ab983012a2d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4a38e4532454daffea0e4690eaa4fe009ed9ee60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152629Reviewed-by:
-
Vasiliy Telezhnikov authored
This is a reland of d60e79d1 The problem was that resources were never returned because ScopedBatchReturnResources was in outer scope than ScopedAllowGpuAccess so the state when we don't batch already, but still have access to gpu thread didn't exist. Solution to merge ScopedBatchReturnResources and ScopedAllowGpuAccess to make sure everything happens in right order. Original change's description: > Limit access to gpu thread in DisplayResourceProvider > > This CL makes sure that DisplayResourceProvider return resources only > when GPU Thread is available to make sure ReleaseImageContexts will > complete in finite time. > > This doesn't change anything for Chrome where GPU Thread is always > available, but on webview RenderThread that used for gpu access during > composition is available only during specific times (init, dtor, > DrawAndSwap) > > Bug: 1068716 > > Change-Id: I8fa482ab7399d6ce7639c1d76187be86ce152059 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138551 > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757967} Bug: 1068716 Change-Id: Idf531b9ee9e10057b571725a256d2af09efbea69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149377Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#759672}
-
