- 18 Oct, 2019 34 commits
-
-
Justin Cohen authored
Bug: 987646, 1015113 Change-Id: If62dfade0113e2502529339aef967304bd66f726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865423 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#707204}
-
Jay Harris authored
Bug: 829689 Change-Id: I525854254fd2e9fc2bad57c87ffdaa9175e452a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865740Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#707203}
-
tby authored
Two small changes: 1. Add a new metric for whether we display any Drive files or not, as a canary for our model getting into a bad state. 2. Log the zero-state launch type even when the experiment is disabled, for easier baseline comparison. Bug: 1011221 Change-Id: Id85f418063b7bf1c5faab4b012071146686807e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863054Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#707202}
-
Kent Tamura authored
* ScriptedAnimationController kicks Document::FlushAutofocusCandidates Now ScriptedAnimationController takes into account of existence of autofocus candidates. * Document::FlushAutofocusCandidates needs to call UpdateStyleAndLayoutTree() for each of candidates. IsFocusable() needs up-to-date style. UpdateStyleAndLayoutTree() was unnecessary because FlushAutofocusCandidates() was called after layout. Bug: 1015275 Change-Id: I06dcb9b3cd2564d35fba3f893e7ce4b8736c91bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863067 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#707201}
-
Xinghui Lu authored
Interstitials are only shown for GSUITE and enterprise passwords. Bug: 1012084 Change-Id: I79dd08d39168d7fb034575915243f568a77d4622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845915 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#707200}
-
Shakti Sahu authored
This CL adds support for default pagination in download home. Bug: 1014319 Change-Id: Ia42ce1166bf58fc1b3126c8cc81a2f48ff45e429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839636 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#707199}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b97e8677d349..9fdb14b94056 git log b97e8677d349..9fdb14b94056 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 mmortensen@google.com Handle platform_version in packages.GetTargetVersions. 2019-10-17 guocb@chromium.org Revert "cros_build_lib.run: drop old signal workaround (reland)" 2019-10-17 vapier@chromium.org service: sysroot: fix logic bug with None Created with: gclient setdep -r src/third_party/chromite@9fdb14b94056 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I0e7f41dbd131d08bc07cd9a5a3847ec5a62996cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867320Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707198}
-
Nate Fischer authored
No change to logic. This inlines strings for the Dev UI, as we don't aim to translate them anyway. Inlining strings is preferable to translateable="false" entries in GRD files (see bug for rationale). This adds lint suppressions as necessary. Bug: 1014805 Test: adb shell am start com.google.android.webview/org.chromium.android_webview.ui.CrashesListActivity Test: Manually verify the UI looks right Change-Id: I67e66ced3ae7d9adbc61e68b92751e6865e1b0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866269Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#707197}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 33e3bac4. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: If12369fdd0a07b95c2b1a51c507fcde23497b8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867355Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707196}
-
Regan Hsu authored
The End of Life Message contains the End of Life date that needs to be read out to pass a11y requirements. Bug: 993828 Change-Id: I874fcee726b10e720925995804768a1b3899acf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854016Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707195}
-
Takashi Toyoshima authored
Previous patch introduced the enable_cors flag. But there are other call sites to create NetworkContext, and they are expected to follow the base::Feature default. Current content::BrowserContext has a default implementation to rely on base::Feature in ShouldEnableOutOfBlinkCors(), and it's safe for the NetworkContextParams to take a similar approach, relying on base::Feature by default, and follow the specified mode only when it is explicitly set. This fixes the failed test in PrefetchBrowserTestPrivacyChanges at linux-oor-cors-rel bot, and solves production code behaviors for headless Chrome, WebView, content shell, and so on. Without this patch, they work without OOR-CORS always, even when the Blink CORS is disabled too. Bug: 1015289 Change-Id: Ib495cbb2734c5bbd71cd39f5540eca04d1942d66 TBR: mmenke@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866098 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#707194}
-
siyua authored
Previous behavior: 1) User clicks save on local save bubble 2) "card saved" animation start 3) when animation ends, the sign-in promo pops up from the credit card icon. 4) If user dismisses the sign-in promo and click the credit card again, the manage cards bubble will pop up from the credit card icon. Current behavior (when status chip exp is enabled): 1) User clicks save on local save bubble 2) The credit card icon disappears and avatar button shows a highlight 3) The sign-in promo will pop up from the avatar toolbar after avatar's highlight animation finishes. 4) There will be no manage cards bubble since the credit card icon is gone. 5) If avatar profile bubble is shown when the sign in promo is shown, close the promo. Mock is https://docs.google.com/presentation/d/130d5_4XAWqI01xt5ejlKw2lohePNQJbxIJQCBK0Kc5k/edit#slide=id.g42e5d4ae9b_0_0 Steps to try on local: 1.Turn on flags autofill-enable-toolbar-status-chip and enable-autofill-credit-card-upload-feedback 2. Sign out from Chrome 3.Go to https://dump-truck.appspot.com/usecase-cc/cc.html and save a card 4.Click save on the bubble. Bug: 932818 Change-Id: Iee405f022bf3cdd6f69c8cc3b9219cd1b55affac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804684 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#707193}
-
Shakti Sahu authored
This CL adds the following changes : 1 - Splits the DateOrderedListMutator functionalities into separate classes 2 - Moves the comparison functions into separator Comparator classes 3 - Moves the part for adding headers into LaberAdder classes 4 - Enhance JustNowProvider to cache item IDs Bug : 1015635 Change-Id: I2207f1ff331baf36891f1d42a1a876b5ae2b0ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854460 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#707192}
-
Vitaly Buka authored
Initialization of variables with "inconvenient" pattern makes "uninitialized memory read" bugs to manifest earlier. On internal Google code-base enabling this flags breaks about 400 unittest which cased by about 150 different "uninitialized memory read" bugs. Failure with this flag is always a bug. About half of them are detectable by msan, if they had coverage. The rest escapes from msan due some compiler optimizations. One noticeable case which is not detectable by current msan is: ``` union U { char small; char large[10]; }; union U u = {}; ``` Almost always u.large is going to be zero-initialized, but neither C not C++ standards require that, and in some rare cases the tail stays uninitialized. Strangely on Chromium code the flag so far triggered only https://chromium-review.googlesource.com/c/chromium/src/+/1769232 Thanks to good msan coverage? Initialization slightly regress browser performance, about 1.5% at average, but it should not be significant for non-official builds. Other platforms will be enabled in follow up changes after additional testing. Bug: 977230 Change-Id: Ia543522547b19d7bcfdf4e38db8956b06f6f50d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795632Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#707191}
-
Lukasz Anforowicz authored
Bug: 988763, 988773 Change-Id: I7f59411d71793ea6752fa90cb58fcbb99c80f1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860674Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#707190}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fd843fa45664..16af35606f4d git log fd843fa45664..16af35606f4d --date=short --no-merges --format='%ad %ae %s' 2019-10-17 ehmaldonado@chromium.org presubmit: Remove unused imports. Created with: gclient setdep -r src/third_party/depot_tools@16af35606f4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1009814 Change-Id: I8f1e620ceb624a108dcf10b2062570ee59c22c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867318Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707189}
-
Jinsuk Kim authored
This CL replaces the text chrome://newtab (or chrome-native://newtab) on gesture navigation sheet entry with "New Tab" which is more user-friendly. Also gives the entry a default Chrome icon rather than monogram icon. Bug: 1014140 Change-Id: Ia522580f2504f4d8c90932f9f99a46ab8ffb2fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866123Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#707188}
-
Kelvin Jiang authored
This CL changes the association of DNR actions for removeHeaders rules from 1 RequestAction/extension to 1 RequestAction/matched rule (in RulesetMatcher.) This is needed for correctly showing the action count for removeHeaders rules when a request with multiple headers might: 1) Have each header's removal caused by different rules 2) Have 1 rule cause the removal of multiple headers. Bug: 1009887 Change-Id: I0ad5d735dfdaea18dc688ed9e0c8d90449985fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839237 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#707187}
-
Dana Fried authored
This CL hides the hover card on any gesture event and also ignores mouse events on tabs when mouse input is disabled (which happens between a touch event and the next actual mouse event). This prevents flashing of hover state and hover cards. Bug: 1007935 Change-Id: I65255c31f6c624d9062398bb298830090500a49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849988 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707186}
-
meacer authored
This CL reuses the populated strings from page info UI for the site details message on Android. Bug: 1014694 Change-Id: I28e15835f923f3047fee44dfd7b91c9a7d05c93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867384 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#707185}
-
Joe DeBlasio authored
This CL updates the strings for Safety Tips for M79 after discussion with UI. Only the lookalike strings changed. They now look like this: Desktop: https://drive.google.com/file/d/1QMIPXkjRoQo65dnbzXbLuLiUbPM3Dexw/view?usp=sharing Mobile: https://drive.google.com/file/d/1TOiO1QbkSoKwD2O02gslsATSd8tJ7UL0/view?usp=sharing Bug: 1015659 Change-Id: Icfad11942b92f2532f8a789e2349adaab03c7a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867380 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#707184}
-
Dan Beam authored
Fixed: 1012995 Change-Id: I8f0c776cfd4f3166d1867568ec8151d4c7c41478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863759 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707183}
-
Yi Xu authored
Bug: 645994 Change-Id: Iadc2c787270edfebb449c3a0e221ac7d33c4f713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865771 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#707182}
-
Bettina authored
Bug: 1015609 Change-Id: I32f29a641fd736b3eb139a7123ddab71ba5732ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864325Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#707181}
-
Justin Cohen authored
This reverts commit bad1b4e3. Reason for revert: Failures: https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/19468?blamelist=1#blamelist-tab Original change's description: > Add SettingsAddPaymentMethod to the field trial config > > Bug: none > Change-Id: I60a3cdad143ac8e414415c1d03c34e59e843e34b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864779 > Auto-Submit: Gauthier Ambard <gambard@chromium.org> > Commit-Queue: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707046} TBR=mpearson@chromium.org,gambard@chromium.org Change-Id: Ib80c5961d6c1cfc7598fbdeca832aa2e7fcfbd4a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865565Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707180}
-
Lily Chen authored
This change delays the construction of the GURL (representing the cookie domain, which is used to match against the ContentSettingPatterns in the Legacy cookie access content setting), until it is determined that it is actually needed. In particular, if the content settings for that type do not contain any domain-specific settings, we don't actually need to do any URL matching since any URL will match. In these cases, we can skip constructing the GURL since that can be expensive. This optimization only works for the network implementation of CookieSettings, not for the components/content_settings implementation of CookieSettings. Bug: 1014715 Change-Id: If6535290671b28811f84922ec05c0be58e00bc6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865754 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#707179}
-
Tomasz Wiszkowski authored
This change allows DrawableState to be null for hiding decoration icon. This is particularly useful for basic suggestions where we may still show no decorations. Added basic tests confirming behavior. Bug: 982818 Change-Id: Ib05445dffe70e4784947cc5bffc598ae7417d989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866621 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#707178}
-
Evan Stade authored
As with WebView, the client is responsible for handling download requests. The Android shell client simply uses Android's DownloadManager. Bug: none Change-Id: I0204a2101f675c35682f0c75cbe34a506c7b5e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862121 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#707177}
-
arthursonzogni authored
Patch https://chromium-review.googlesource.com/c/chromium/src/+/1864780 removed the filter for every android_browsertest, because they were all passing locally. Unfortunately, they are all failing on the android-bfcache-debug. Enable only AndroidBrowserTest.Smoke to prevent the bot from timing out. TBR=altimin@chromium.org Change-Id: Ib41f0443f8678c38783c64a214e78f41f42027e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867451Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#707176}
-
minch authored
see recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIiWTBWSk5Pd0JsQ0hva0x0MTUtNVBqZGoyWGtV/view?usp=sharing Bug: 1002733 Change-Id: Ia4e1bc3f4d913c8543f8b593454abf3f4d3d7871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865623Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#707175}
-
Henrique Nakashima authored
The main purpose of ChromeIntentUtil is to construct an intent to ChromeLauncherActivity, so it makes sense to be in the same package as ChromeLauncherActivity, for the lack of a better place. Bug: 995916 Change-Id: Ieb3d01d080f418f664ce5ff881831516cf02b1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867291Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#707174}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/db8df1765017..e8b962bd3c97 git log db8df1765017..e8b962bd3c97 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 60f3e975..1d5b803f (706891:707010) 2019-10-17 peah@webrtc.org AEC3: Removed some usages of DirectPathFilterDelays 2019-10-17 kcwu@google.com Use FakeRenderer when fuzzing 2019-10-17 peah@webrtc.org AEC3: Add multichannel support in the ERLE estimation Created with: gclient setdep -r src/third_party/webrtc@e8b962bd3c97 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:952606,chromium:1009077,chromium:1009073 Change-Id: I6c0eb417fd1b5818ff363ef3f770dc2629027793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867430Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707173}
-
Hesen Zhang authored
Bug: 1013685 Change-Id: Ie6d891ea3b97eaee29f694390d8b093d307b4c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865132 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#707172}
-
Christopher Thompson authored
When working on crrev.com/c/1829462, I noticed in manual testing that the component loading the configuration from disk can take upwards of 6 seconds to complete, causing the configuration to not be loaded by the time an affected page navigation has completed (causing the UI to not be shown correctly). The current version of the TLSDeprecationConfigComponentInstallerPolicy loads the configuration proto from disk using a PostTask with priority BEST_EFFORT, causing the configuration load to be delayed, especially near browser startup. Changing the priority of the load task to USER_VISIBLE (since the state of the config affects security UI shown to users) causes this race to go away (or become much, much less likely to occur, which is sufficient in this case). Bug: 1011089 Change-Id: Idd98b225a7ae9d6444acf0d8121fa6055f8e06e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831451 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707171}
-
- 17 Oct, 2019 6 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/74af4241e484..12fa2ef9c6d1 Created with: gclient setdep -r src-internal@12fa2ef9c6d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8386523369031da30388ba010781da73fe4091a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867429Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707170}
-
Xiaoqian Dai authored
Clamshell mode behavior will remain the same, i.e., tapping on the overview background will return to its previous state, it can either be in-app or home screen. Bug: 997885 Change-Id: I5006c69081157b30f695a05642d20e3d7f505822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867375Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#707169}
-
Daniel Cheng authored
This uses the terminology from http://www.chromium.org/developers/design-documents/blink-coordinate-spaces. Change-Id: I800f69b8a39c99ad79e52873464dbf106d60497d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865654 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#707168}
-
Clark DuVall authored
This is a reland of cf1e154f Added in the fixes from http://crrev.com/c/1867289 to fix browsertests. Original change's description: > [WebLayer] Load pak files correctly on Android > > Loading pak files was not quite working right in weblayer, since we were > not loading locale paks. This caused text on e.g. submit buttons to not > show up in some configurations like loading from monochrome. > > This change makes weblayer load pak assets similar to webview, and > uses the webview pak deps for the weblayer support APK, since those > should be sufficient for weblayer. > > As an added bonus this also allows l10n to work, so switching the > default language of the device will show buttons and labels in that > language. > > Change-Id: I1a2b47009e7bb74f1ea3c16dc6f52451e2b78066 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865015 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706978} TBR=jam@chromium.org,torne@chromium.org Change-Id: I58961564500bcc92d05bf84e7372c2aca8a17c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866925Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#707167}
-
Peter Boström authored
ToolbarButton is already responsible for interior margins as insets on both sides. Prior to this all ToolbarButtons could have a leading margin but no trailing margin. In practice it just consolidates code for consistency. This change ends up removing duplication of GetAnchorBoundsInScreen() and UpdateBorder() both of which are already handled in ToolbarButton. As a bonus (!) this applies Fitts' law to toolbars shown in fullscreen windows, which I needed to verify that extending trailing margins still worked as expected on Mac. Bug: None Change-Id: I72bdd6be6663167226a8e9b8446d874859774cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866982Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#707166}
-
Thanh Nguyen authored
This CL adds required metrics for Improved App Search on Chrome OS project. Bug: 990684 Change-Id: I8c940317af0ef1bca1856ee3790d53b6e96b321a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850678 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#707165}
-