- 30 Dec, 2019 40 commits
-
-
Xiaocheng Hu authored
Bug: 1038351 Change-Id: I22dcbecad69c604136d0fccf4372238556ce2559 Tbr: tienmai@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984353Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#727773}
-
Caleb Rouleau authored
performance test suite is failing here https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/80918 the issue is that we assume that the file will be named .exe, but it isn't sometimes. I revert the changes that were made to the shard map in this change and turn off the unittests that depended on the old version. R=adithyas@chromium.org Bug: 1024767 Change-Id: I0a732dd7c3c35a096ea40b65d43f246513a8913a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984175Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727772}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I98867c7ae88b31e35a56f1585a98a80d4ccdabc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982148Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727771}
-
haozhe authored
Chrome passed all tests Firefox passed all tests other than background-size-composition Bug: 1034538 Change-Id: I0588c7e06c4ef1d545a88098e6dd4af74eb906d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972812Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#727770}
-
haozhe authored
Chrome pass all tests Firefox does not support hanging: https://bugzilla.mozilla.org/show_bug.cgi?id=784648 Bug: 1034538 Change-Id: Ic60846b2e439eb325c682b01376ac0805f0b6a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976494Reviewed-by:
-
Boris Sazonov authored
This CL revises how ProfileOAuth2TokenServiceDelegate is keeping track of the list of accounts that have been advertised to the native code by OnRefreshTokenAvailable. Before, the persistent storage on the Java side was used. Now, a simple instance variable on the C++ side is used instead. Bug: 1006772 Change-Id: I4bb7ddec56f387d332abdef6d1b5c43add617207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983225Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#727768}
-
haozhe authored
Chrome passes all the tests Firefox failed the offset-position composition(https://bugzilla.mozilla.org/show_bug.cgi?id=1559232) Bug: 1034538 Change-Id: I245a6d8e9da8252aed7f5d76ddfbadd052813fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974690Reviewed-by:
-
Evan Stade authored
Convert a condition/early out to a DCHECK. There should always be a URL pattern, because an extension that has a content script but no URL pattern ("matches" in the manifest) fails to load. This conditional has been there since user_script_listener.cc was added ~10 years ago, but I don't think it's possible to fail. That said, this check failing is the only logical way I can see the other DCHECK (the one causing the bug) might fail, so adding it might shed light on the cause of the bug. Bug: 1036028 Change-Id: Id91dcf66cb0d02f134cc2a7de7b2003d20b4e621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977240Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#727766}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f04938adfc40..7449dc8a7f22 git log f04938adfc40..7449dc8a7f22 --date=short --first-parent --format='%ad %ae %s' 2019-12-30 lalitm@google.com trace_processor: remove RowId type from trace_processor Created with: gclient setdep -r src/third_party/perfetto@7449dc8a7f22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0bf5c14651b64097e0a7c211d8b71c5380aedebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982147Reviewed-by:
-
Xiaocheng Hu authored
[Sheriff] Mark virtual/gpu-rasterization/images/exif-orientation-image-document.html as flaky on Mac Sample flake: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20(retina)/23669 Bug: 1037798 Change-Id: I686ecb3eb070277ff755c44d20a089197d343e25 NoTry: True Tbr: xiaochengh@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984419Reviewed-by:
-
Adithya Srinivasan authored
Bug: 1038342 Change-Id: I9189f756a00b8f5a170c5c76a956340e4aef4968 Tbr: jamescook@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984174Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96464fc25283..fe2d3c73348b git log 96464fc25283..fe2d3c73348b --date=short --first-parent --format='%ad %ae %s' 2019-12-30 reed@google.com SkBlurMaskFilter.h is only needed for (deprecated) emboss Created with: gclient setdep -r src/third_party/skia@fe2d3c73348b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I3e16961be7be1186168d4bc4281e25830663103f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982145Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5b94048566ab..471dda709844 git log 5b94048566ab..471dda709844 --date=short --first-parent --format='%ad %ae %s' 2019-12-28 fqj@chromium.org config: build betty-arcvm-master for vmmst-android-pfq 2019-12-28 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-28 saklein@chromium.org query_build_logs: fix builder link and row order. Created with: gclient setdep -r src/third_party/chromite@471dda709844 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I589d9c01e995146da794e2eb5f6059675a7ba4b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984341Reviewed-by:
-
Kaustubha Govind authored
This method is needed to allow tests to exercise the full host resolution manager stack. Bug: 1032710 Change-Id: Ib302caa9e1eb2438e63a5a144a8e50a51eb094e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980759Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Kaustubha Govind <kaustubhag@chromium.org> Cr-Commit-Position: refs/heads/master@{#727760}
-
Caleb Rouleau authored
R=adithyas@chromium.org NOTRY=true Bug: 1024767 Change-Id: I722ea30fe7b9d32f24cb6325102144ea455879d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984172Reviewed-by:
-
Tricia Crichton authored
The tests for javascript atoms in chromedriver/js have not been part of any automated test script. This cl adds them to the python test script. Bug: chromedriver:3280 Change-Id: I8b1292212df9c7c096489d17dffe312dea14168f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970552 Commit-Queue: Tricia Crichton <triciac@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#727758}
-
David Bokan authored
Currently, when a scroll offset animation is created, we set the currently scrolling node to the node we're animating (i.e. we "latch" it). Conceptually, the latch should be controlled by the gesture events sent by the browser. This CL removes this latching from the animation system. As a side effect, this means animations on the inner viewport scroll layer no longer latch to the inner viewport but the outer (hence the removed DCHECK). This was actually a bug since any scrolling against either viewport should latch to the outer viewport but I'm not sure if this manifests in any real way. See the comments in LTHI::GetNodeToScroll for how viewport scroll nodes are typically latched. This was broken off from the followup https://crrev.com/c/1981066 where we stop calling ScrollEndImpl to unlatch at the end of scroll animations. Without this change we would incorrectly remain latched to the inner viewport layer and causes a failure in the unit test: LayerTreeHostImplTimelinesTest.ImplPinchZoomScrollAnimated Bug: 996537,940508 Change-Id: I18f39bb6d2cfe6e2821f69315b08bd24e56a0882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981065 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#727757}
-
Tricia Crichton authored
Enable 2 selenium tests that are marked as not implemented but that pass in our environment. Bug: chromedriver:3199 Change-Id: I9968f64ae5613992f2652ae8a6ef21af2c1acc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982715Reviewed-by:
-
Andrew Grieve authored
Follow-ups from fe1d5a12. * Added missing flush() * Fixed apk / arch being swapped in regex * Fixed index.html .value vs .checked mixup * Mark --platform as obsolete as well. TBR=agrieve Bug: None Change-Id: Id913e47fa6ba0711c1e4292a724c3a04efa52729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984171Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#727755}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7c095dc67ce6..96464fc25283 git log 7c095dc67ce6..96464fc25283 --date=short --first-parent --format='%ad %ae %s' 2019-12-30 benjaminwagner@google.com Update Linux Vulkan SDK Created with: gclient setdep -r src/third_party/skia@96464fc25283 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I13580ace848bc2429c8138deb5b15be253dc8d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984340Reviewed-by:
-
Adithya Srinivasan authored
Bug: 1038339 Change-Id: I9c881ec52be131d63923221737a86e8adb5eedbf Tbr: tienmai@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984169Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/10380c17f672..dc5a6b58d2c1 Created with: gclient setdep -r src-internal@dc5a6b58d2c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If005e9cae8a8edc044b8bbe86c1f3243068ce540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984339Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727752}
-
Boris Sazonov authored
Fixes "add account" flow in AccountManagementFragment that was broken by https://crrev.com/c/1817607. Before: Activity is finished right after the preference is clicked. Thus, isResumed check in createAddAccountIntent returns false and the intent is not started. After: Activity is finished from createAddAccountIntent callback, so isResumed check passes. Bug: 1036777 Change-Id: Ieaf443adf586eb1dd5949eca021ee9b499201bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982556 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#727751}
-
Dominick Ng authored
This CL moves infobar listener registration earlier, and makes it complete on all animation completions to try and deflake testBlockedAmbientBadgeDoesNotAppearAgainForMonths. BUG=1036413 Change-Id: I52cb9a621930c9668dacdb8a746e735203ca9560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980249 Commit-Queue: Peter Conn <peconn@chromium.org> Auto-Submit: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#727750}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b53da373457..10380c17f672 Created with: gclient setdep -r src-internal@10380c17f672 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1ed726b2e0ab373feda5560cafe2aae81b7452f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983517Reviewed-by:
-
Yuki Shiino authored
Fixes trivial bugs. - Wrong assertion in blink_v8_bridge.py - Support [Global=(Worklet, PaintWorklet)] - Enumeration type is included in "string types" Bug: 839389 Change-Id: Idaea55a6d827a4b816c4e844062eda6f253efb40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983113Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#727748}
-
Yuki Shiino authored
Reuses the same Mako template as long as the template text is the same. This patch reduces code generation time by around 20%. Bug: 839389 Change-Id: If8241ba70c2d572f5b6fd963f662193cc71450ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983115 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8ac79125c052..9d2c2dba2865 git log 8ac79125c052..9d2c2dba2865 --date=short --first-parent --format='%ad %ae %s' 2019-12-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9986f224..f19d6cb8 (727633:727734) Created with: gclient setdep -r src/third_party/webrtc@9d2c2dba2865 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0554622451ac49c718a6fc62e83025237fc8658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983516Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e3495a882fd7..3b53da373457 Created with: gclient setdep -r src-internal@3b53da373457 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8f72bfe178796d505ee6e5cc07dd2bcfba69ee7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983514Reviewed-by:
-
Shik Chen authored
Bug: b:117810572, b:141518780 Test: Pass camera.CCAUI* Change-Id: Ic83d7fd209672eafc2a9d25c98e69d9e580abcc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961867 Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#727744}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3945.86-1577097374-benchmark-81.0.4009.0-r1 to 81-3945.86-1577097374-benchmark-81.0.4011.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I70cd09f033e7bb1e7817c7f2eb8fbfc2a8977785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984236Reviewed-by:
-
Colin Blundell authored
Bug: 1030692 Change-Id: I45b1d92da317d4bba26ac7584112f4510b360a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983232Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#727742}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a2520bfd110b..e3495a882fd7 Created with: gclient setdep -r src-internal@e3495a882fd7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If112a53b3d4424d21e69c0316fbc951e738a2a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984167Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fca5a005aa88..9fac1817ede6 git log fca5a005aa88..9fac1817ede6 --date=short --first-parent --format='%ad %ae %s' 2019-12-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 5de15a256eb0..6334d594f68c (4 commits) Created with: gclient setdep -r src/third_party/angle@9fac1817ede6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I3177925beacf9170b12aab886e4f5c1257023590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984165Reviewed-by:
-
Colin Blundell authored
This CL brings up renderer-side autofill detection in WebLayer and communication of that autofill detection to the browser. On the browser side, we inject an AutofillProvider into the autofill system, to which the autofill component delegates the browser-side UI flow. This setup anticipates the usage of an AutofillProvider implementation on Android that integrates with the system-level autofill support; bringup of that implementation will occur in a followup CL. This CL has several moving parts: - Creation of the renderer-side AutofillAgent that parses documents for autofill purposes - Creation of the browser-side ContentAutofillDriver that drives the browser-side flow and communicates with AutofillAgent - Hookup of the communication between AutofillAgent and ContentAutofillDriver - A minimal AutofillClient implementation that implements only the touchpoints used within the WebLayer flow of Autofill and is passed to ContentAutofillDriver on creation - A stub AutofillProvider implementation that enables cross-platform browsertests and is passed to ContentAutofillDriver on creation - Testing infrastructure for such a browsertest and the browsertest itself There as of yet no user-visible behavioral changes, so no manual testing instructions with this CL. The followup CL will introduce the Android production implementation via bringing up the Java-side system-level integration, connecting it to a C++ AutofillProviderAndroid instance, and passing *that* instance to ContentAutofillDriver. Bug: 1025617 Change-Id: I3aa30179c78d23e527fe24b43472f744d4393fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965660 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Nikita Podguzov authored
This is required to use USE_CUPS defines. Bug: 1021488 Change-Id: I4ea179f3a3ea707a0aee74935c0ea256c3535d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972147Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#727738}
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-3987.0-1577100150-benchmark-81.0.4009.0-r1 to 81-3987.0-1577100150-benchmark-81.0.4011.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I29dcffaaf34415bfa4ad3ce6a662d8166cb4f981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984232Reviewed-by:
-
Colin Blundell authored
This CL provides an initial integration of the captive portal interstitial within WebLayer. In this initial integration, the captive portal interstitial is brought up when the user has hit an SSL error and the underlying Android captive portal detection reports that the user is behind a captive portal. The focus of this initial implementation is to make the basic use case available and develop integration tests of this use case. Functionality of Chrome's embedding of CaptivePortalBlockingPage beyond this basic use case is not ported over to WebLayer but instead is targeted for the next stage of sharing of //chrome's embedding of security interstitials with WebLayer (crbug.com/1030692). We have highlighted those touchpoints in this initial bringup, which will help to guide the design of that sharing. Bug: 1025059 Change-Id: I10354585f0ca4deff835abce76ed7051faaa853d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980747 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1aa3a0603b9191a65a53716f8e256c237aa7d299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984166Reviewed-by:
-
Peter Kasting authored
Bug: none Tbr: stevenjb Change-Id: Ia9fc42e0433fd57549cd6fc3c19223ea44ac7827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983511Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#727734}
-
