GitLab

We add the following log messages:
* Error message when one of tracingCategories & traceEventsToMeasure is specified
but not the other.
* Hint users to use tools/perf/run_benchmark to get tracing based metrics

BUG=701059

Review-Url: https://codereview.chromium.org/2856463003
Cr-Commit-Position: refs/heads/master@{#468332}

The browser code contains partial support for using multiple zygote
processes, which exists to support Flash component updates. However,
at present the browser process only creates a single zygote, on startup,
and uses that for everything. Clean up the code to make that more clear.

* Remove probably-unused lazy zygote creation code.
* Always use ZygoteHandle instead of ZygoteHandle*. ZygoteHandle is always
a pointer under the hood.
* Add CHECKs to validate the assumption there is only one zygote.

This came up while investigating a zygote check failure on Chrome OS.
I'm concerned that the lazy-launch code could be starting a zygote during
browser process shutdown. See crbug.com/692227

BUG=692227,569191
TEST=manually load web pages, extensions and nacl apps to trigger child
process creation, verify they load properly

Review-Url: https://codereview.chromium.org/2850903002
Cr-Commit-Position: refs/heads/master@{#468331}

Revert of Photo Picker Dialog: Use sandboxed utility process for decoding images. (patchset #11 id:240001 of https://codereview.chromium.org/2816733002/ )

Reason for revert:
generate_orderfiles.py fails due to AndroidManifest.xml change (see http://crbug.com/717071 )

BUG=717071

Original issue's description:
> Photo Picker Dialog: Use sandboxed utility process for decoding images.
>
> BUG=656015
>
> Review-Url: https://codereview.chromium.org/2816733002
> Cr-Commit-Position: refs/heads/master@{#468209}
> Committed: https://chromium.googlesource.com/chromium/src/+/83c9f3f4faeb35a3a2607446def65f1a8da7aa49

TBR=twellington@chromium.org,yusufo@chromium.org,tedchoc@chromium.org,finnur@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=656015

Review-Url: https://codereview.chromium.org/2853793003
Cr-Commit-Position: refs/heads/master@{#468330}

SkPixelRef no longer stores an SkImageInfo

BUG=skia:6535
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2848063002
Cr-Commit-Position: refs/heads/master@{#468329}

The |hit_test_bounds_override_inner_| member of
aura::Window is no longer used, so remove it.
No functional changes.

BUG=344924
TEST=aura_unittests
TBR=varkha@chromium.org

Review-Url: https://codereview.chromium.org/2852653004
Cr-Commit-Position: refs/heads/master@{#468328}

This CL removes the following files from bindings/core/v8 and updates
all include sites to use their platform/bindings version:

- ActiveScriptWrappable.h
- ConditionalFeatures.h
- DOMDataStore.h
- DOMWrapperMap.h
- DOMWrapperWorld.h
- Microtask.h
- ScopedPersistent.h

BUG=682322
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2848963002
Cr-Commit-Position: refs/heads/master@{#468327}

Part 2/2.

BUG=713847

Review-Url: https://codereview.chromium.org/2851103002
Cr-Commit-Position: refs/heads/master@{#468326}

This uses the new DelayedPersistentAllocation to avoid allocating the
full "counts" array when only one value is being stored.  That one
value is kept in the HistogramSamples metadata.  When a second value
is recorded, the counts-array is created and the single-sample is
moved; it is there-after unused.

This change only affects SampleVector.  A future change may add the
same support for PersistentSampleMap.

A quick test shows persistent memory use is reduced by 44% (from 924
KiB to 512 KiB) after a clean start and the loading of three pages:
  chrome://histograms
  https://www.google.com/
  chrome://histograms  (again)

BUG=705342

Review-Url: https://codereview.chromium.org/2811713003
Cr-Original-Commit-Position: refs/heads/master@{#466401}
Committed: https://chromium.googlesource.com/chromium/src/+/4162bafec82ea11c98d4dc2572337a039b79fdb9
Review-Url: https://codereview.chromium.org/2811713003
Cr-Commit-Position: refs/heads/master@{#468325}

They should not come close to one hour.

BUG=717028
TEST=test only change
R=jonross@chromium.org
TBR=jonross@chromium.org

Review-Url: https://codereview.chromium.org/2855623002
Cr-Commit-Position: refs/heads/master@{#468324}

In https://codereview.chromium.org/2810943005/, we added a presubmit script
to check if eventSender is still used in new layout tests. Here, We add a
doc to explain why we want to replace EventSender and give some examples
on how to use this new API in testing.

BUG=711340

Review-Url: https://codereview.chromium.org/2844803005
Cr-Commit-Position: refs/heads/master@{#468323}

The command buffer client handles all the unpack parameters but
alignment for non-compressed texture uploads from client data.
Resetting the unpack state was handled transparently on the
service-side. This implements the resetting in the passthrough cmd
decoder too.

This makes the following tests pass with the passthrough command buffer:
 - conformance2/textures/misc/tex-unpack-params
 - deqp/functional/gles3/texturespecification/teximage2d_unpack_params
 - deqp/functional/gles3/texturespecification/teximage3d_unpack_params
 - deqp/functional/gles3/texturespecification/texsubimage2d_unpack_params
 - deqp/functional/gles3/texturespecification/texsubimage3d_unpack_params

BUG=chromium:602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2844393004
Cr-Commit-Position: refs/heads/master@{#468322}

BUG=715729

Review-Url: https://codereview.chromium.org/2844843002
Cr-Commit-Position: refs/heads/master@{#468321}

BUG=705865
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2851203002
Cr-Commit-Position: refs/heads/master@{#468320}

Decreased the number of missing header files by 4.

BUG=661774

Review-Url: https://codereview.chromium.org/2854603002
Cr-Commit-Position: refs/heads/master@{#468319}

https://pdfium.googlesource.com/pdfium.git/+log/ce8e51e6c444..72b715d51383

$ git log ce8e51e6c..72b715d51 --date=short --no-merges --format='%ad %ae %s'
2017-05-01 npm Add PDF reference to CFX_Matrix comment

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I9b0e04c24e07ab8ba754d96b22859e1cb8297f3a
Reviewed-on: https://chromium-review.googlesource.com/491049
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468318}

iOS has a custom method for determining which omnibox suggestion types
are search/query types (as opposed to URL types). This change removes it
in favor of the cross-platform method used on other platforms. This has
useful effects on how we display navsuggest and calculator suggestions
and eliminates the need to maintain separate logic.

See the bug for a detailed description of the motivation for this change
and an analysis of its effects.

BUG=716047

Review-Url: https://codereview.chromium.org/2852553002
Cr-Commit-Position: refs/heads/master@{#468317}

BUG=715060

Review-Url: https://codereview.chromium.org/2850863002
Cr-Commit-Position: refs/heads/master@{#468316}

https://skia.googlesource.com/skia.git/+log/0c5cf5d7a260..53f77bd4fdd7

$ git log 0c5cf5d7a..53f77bd4f --date=short --no-merges --format='%ad %ae %s'
2017-04-28 fmalita Initial clip-mask-layer support
2017-04-28 jvanverth Optimizations for analytic shadows.

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I1783644d20be8d8950df6db24daf042d277590c3
Reviewed-on: https://chromium-review.googlesource.com/490838Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468315}

This test was failing on Android Nexus 5 device due to the loading taking
too long. Simplifying its test case seems to fix the problem.

BUG=715685
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2849153002
Cr-Commit-Position: refs/heads/master@{#468314}

Since we didn't install them, we can't update them.
BUG=714740

Review-Url: https://codereview.chromium.org/2847973002
Cr-Commit-Position: refs/heads/master@{#468313}

These were tests for WebSocket, XHR and fetch bandwidth. They produced a large
number of false positives and so had been disabled on the bots. Since there is
no-one available to care for these tests, remove them.

BUG=551950,549017,715500

Review-Url: https://codereview.chromium.org/2844633002
Cr-Commit-Position: refs/heads/master@{#468312}

Removing as the CHECKs were not triggered and bug was resolved.

BUG=699269

Review-Url: https://codereview.chromium.org/2850133003
Cr-Commit-Position: refs/heads/master@{#468311}

We WebViewFrameWidget keeps a RefPtr to WebViewImpl we need to make WebViewBase
ref counted. Removed the ref counted from WebViewImpl when moving it to
WebViewBase.

BUG=712963

Review-Url: https://codereview.chromium.org/2850113002
Cr-Commit-Position: refs/heads/master@{#468310}

RequestInit::header is supposed to hold a HeadersInit (ie. just a WebIDL
union) object, not a fully-fledged Headers one.

Make it so, and add a HeadersInit overload to Headers::FillWith() so all the
checks for which union type is being used are centralized in one place.
Additionally, this also makes it easier to finally define RequestInit with
an IDL file in the future.

R=tyoshino@chromium.org,yhirano@chromium.org

Review-Url: https://codereview.chromium.org/2840193002
Cr-Commit-Position: refs/heads/master@{#468309}

Production files should not be in javatest/.

BUG=None

Review-Url: https://codereview.chromium.org/2843333003
Cr-Commit-Position: refs/heads/master@{#468308}

The work continues the effort to remove direct dependencies on web/WebViewImpl.h
by moving methods to a pure virtual base class, and updating references to use
the base class rather than the implementation.

We need to break cyclic dependencies in web/ to allow us to move files up into
core/ and modules/.

BUG=712963

Review-Url: https://codereview.chromium.org/2851993002
Cr-Commit-Position: refs/heads/master@{#468307}

In verified-boot mode, ftrace trace_marker is not allowed for writting
due to security concern. As an altenative, we use a socket for processes in
Android to write trace events, and send back the trace data via Mojo
handle.

All change set includes:
- http://crrev.com/2400163003 (Chromium)
- http://ag/2028075 (Android system/core)
- http://ag/1738271 (Android device/google/cheets2)

BUG=653795
TEST=Run chrome://tracing and see events from Android.

Review-Url: https://codereview.chromium.org/2400163003
Cr-Commit-Position: refs/heads/master@{#468306}

BUG=n/a

Review-Url: https://codereview.chromium.org/2847983002
Cr-Commit-Position: refs/heads/master@{#468305}

This patch prunes a call site of the deprecated function to improve
code health.

The change is safe because the call site only needs the selection type,
not the selection itself. After this patch, it also aligns with the
code in Editor::RespondToChangedSelection.

BUG=698633
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2852913002
Cr-Commit-Position: refs/heads/master@{#468304}

Reland of Disable flaky ExperimentalAppWindowApiTest.SetIcon (patchset #1 id:1 of https://codereview.chromium.org/2855563002/ )

Reason for revert:
Build failure causing original revert seems to have been a flake.

Original issue's description:
> Revert of Disable flaky ExperimentalAppWindowApiTest.SetIcon (patchset #1 id:1 of https://codereview.chromium.org/2849073003/ )
>
> Reason for revert:
> Speculatively reverting due to build failure on Mac https://build.chromium.org/p/chromium/builders/Mac/builds/26841
>
> Original issue's description:
> > Disable flaky ExperimentalAppWindowApiTest.SetIcon
> >
> > TBR=benwells@chromium.org
> > BUG=716726
> >
> > Review-Url: https://codereview.chromium.org/2849073003
> > Cr-Commit-Position: refs/heads/master@{#468285}
> > Committed: https://chromium.googlesource.com/chromium/src/+/78552aab8b749f33cd8176a977bdff4fa7d5de50
>
> TBR=benwells@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=716726
>
> Review-Url: https://codereview.chromium.org/2855563002
> Cr-Commit-Position: refs/heads/master@{#468289}
> Committed: https://chromium.googlesource.com/chromium/src/+/dfe887bdaf1ea9fb0b3a7566dbdde620c869d42c

TBR=benwells@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=716726

Review-Url: https://codereview.chromium.org/2856523003
Cr-Commit-Position: refs/heads/master@{#468303}

CL#1 This snackbar will be used to convey to the user the result
of any action performed on the Translate infobar.

BUG=713514
TBR=groby@chromium.org

Review-Url: https://codereview.chromium.org/2838833003
Cr-Commit-Position: refs/heads/master@{#468302}

Reland of CSS Motion Path: delete implementation of motion-offset property (patchset #1 id:1 of https://codereview.chromium.org/2856513002/ )

Reason for revert:
https://codereview.chromium.org/2841863005 was extremely unlikely to be the root cause of Mac-specific failures.

Original issue's description:
> Revert of CSS Motion Path: delete implementation of motion-offset property (patchset #2 id:40001 of https://codereview.chromium.org/2841863005/ )
>
> Reason for revert:
> Speculatively reverting due to build failure on Mac https://build.chromium.org/p/chromium/builders/Mac/builds/26841
>
> Original issue's description:
> > CSS Motion Path: delete implementation of motion-offset property
> >
> > The 'motion-offset' property has been replaced by 'offset-distance'.
> >
> > 'motion-offset' is among the properties disabled in M58.
> >
> > Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1MbAgAJ
> >
> > BUG=711937
> >
> > Review-Url: https://codereview.chromium.org/2841863005
> > Cr-Commit-Position: refs/heads/master@{#468287}
> > Committed: https://chromium.googlesource.com/chromium/src/+/612ac411762985a97166c4144ff0d049716a80db
>
> TBR=bugsnash@chromium.org,meade@chromium.org,ericwilligers@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=711937
>
> Review-Url: https://codereview.chromium.org/2856513002
> Cr-Commit-Position: refs/heads/master@{#468291}
> Committed: https://chromium.googlesource.com/chromium/src/+/d62951aca80fa961d7feb4c05fe62b0893f59bfd

TBR=bugsnash@chromium.org,meade@chromium.org,suzyh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=711937

Review-Url: https://codereview.chromium.org/2856523002
Cr-Commit-Position: refs/heads/master@{#468301}

Reland of Disable flaky CommandLineExtensionsDontLoad test (patchset #1 id:1 of https://codereview.chromium.org/2855553002/ )

Reason for revert:
Build failure causing original revert seems to have been a flake.

Original issue's description:
> Revert of Disable flaky CommandLineExtensionsDontLoad test (patchset #1 id:1 of https://codereview.chromium.org/2852933002/ )
>
> Reason for revert:
> Speculatively reverting due to build failure on Mac https://build.chromium.org/p/chromium/builders/Mac/builds/26841
>
> Original issue's description:
> > Disable flaky CommandLineExtensionsDontLoad test
> >
> > TBR=emaxx@chromium.org
> > BUG=716727
> >
> > Review-Url: https://codereview.chromium.org/2852933002
> > Cr-Commit-Position: refs/heads/master@{#468286}
> > Committed: https://chromium.googlesource.com/chromium/src/+/91f64acccbfe592af367f79ae74649d520528f0b
>
> TBR=emaxx@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=716727
>
> Review-Url: https://codereview.chromium.org/2855553002
> Cr-Commit-Position: refs/heads/master@{#468290}
> Committed: https://chromium.googlesource.com/chromium/src/+/606b2b5d25564f187a843d25e5c2998d4ad2c04e

TBR=emaxx@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=716727

Review-Url: https://codereview.chromium.org/2848223002
Cr-Commit-Position: refs/heads/master@{#468300}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/489561d2..df06cc9f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2852943002
Cr-Commit-Position: refs/heads/master@{#468299}

Revert of Changing default Windows compiler to VS 2017 (patchset #1 id:1 of https://codereview.chromium.org/2852433005/ )

Reason for revert:
Reverting as planned - it was just a test switch to VS 2017, which seems to have gone smoothly. I'm hopeful that canary 60.0.3086.0 is being built with VS 2017, to
complete the test.

Original issue's description:
> Changing default Windows compiler to VS 2017
>
> This is a single character change to temporarily switch Chrome to
> building with VC++ 2017. This CL is currently purely for testing
> purposes and will be landed for the weekend in order to flesh out any
> remaining bugs.
>
> This is a retry of crrev.com/2762093003 which failed due to a compiler
> warning which was missed in local testing and the try bots. That warning
> has been resolved and a local build of 'all' completed cleanly.
>
> BUG=683729
>
> Review-Url: https://codereview.chromium.org/2852433005
> Cr-Commit-Position: refs/heads/master@{#468239}
> Committed: https://chromium.googlesource.com/chromium/src/+/060d293f1d87d450a824dc46f564792272ed34a3

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=683729

Review-Url: https://codereview.chromium.org/2851143002
Cr-Commit-Position: refs/heads/master@{#468298}

This fix will set translate infobar with a translating status in the beginning, then highlighted the targeted language tab after translated.

Tested on my device

BUG=703887

Review-Url: https://codereview.chromium.org/2845013002
Cr-Commit-Position: refs/heads/master@{#468297}

- Apply color and line-height to the whole page
- Set iron-icon-width/height globally, reducing the number of places
  where specific sizing is necessary
- Import cr-shared-style into Bookmarks' shared style module, which
  removes the need to specify some button styles
- Use paper-icon-button-light in folder-node, which simplifies CSS and
  slightly improves performance
- Make item highlight colors consistent

BUG=715394
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846673003
Cr-Commit-Position: refs/heads/master@{#468296}

AnimationEffectTiming.idl and AnimationEffectTimingReadOnly.idl
now use
attribute PlaybackDirection direction;
for consistency with the spec.

https://w3c.github.io/web-animations/#the-animationeffecttiming-interface
https://w3c.github.io/web-animations/#the-animationeffecttimingreadonly-interface

BUG=716963

Review-Url: https://codereview.chromium.org/2856503002
Cr-Commit-Position: refs/heads/master@{#468295}

The parser will in some cases create new elements in documents that
have become frame-detached. Account for that -- no execution context
due to the document having become detached -- when processing the
event listeners of an event attribute.

R=haraken
BUG=714353

Review-Url: https://codereview.chromium.org/2855443002
Cr-Commit-Position: refs/heads/master@{#468294}

Currently, when we generate non bit fields, we order them in
alphabetical order. This may result in unnecessary padding, e.g.

struct {
  char a;
  /* char padding[3] */
  int b;
  char c;
  /* char padding[3] */
};

See [1] for an explanation.

This patch defines an ordering on field types so that we can sort
non bit fields from largest alignment size to smallest. This heuristic
minimises the padding most of the time:

struct {
  int b;
  char a;
  char c;
  /* char padding[2] */
};

This is purely a memory optimisation, not speed. It does not take into
account data access patterns and cache locality. We use the data from
[2] to define the order of types.

With this heuristic, some of the generated code has changed, but it is
unlikely to have changed the size of any structs.

Diff of generated files:
https://gist.github.com/darrnshn/81d146c2696ef100d56309e5b4b529ff/revisions

[1] http://www.drdobbs.com/cpp/padding-and-rearranging-structure-member/240007649?pgno=2
[2] https://codereview.chromium.org/2841413002

BUG=628043

Review-Url: https://codereview.chromium.org/2844223002
Cr-Commit-Position: refs/heads/master@{#468293}