GitLab

Add a snapshot of the WHATWG Encoding spec's encodings.js and document
the deltas from it in shared.js. Skip testing "replacement" encodings.

Also, Simplify the constructors by just passing through a TextEncoding
object rather than digging out a string then recreating it.

No functional changes.

BUG=277037
R=jshin@chromium.org

Review URL: https://codereview.chromium.org/269593009

git-svn-id: svn://svn.chromium.org/blink/trunk@173754 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=371250

Review URL: https://codereview.chromium.org/277563004

git-svn-id: svn://svn.chromium.org/blink/trunk@173752 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After changes by inspector team that removed dependency from inspector
to WebSocket, the construction of WebSocketFrame there is meaningless.
Remove them.

BUG=none

Review URL: https://codereview.chromium.org/279783002

git-svn-id: svn://svn.chromium.org/blink/trunk@173750 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change makes the per-heap address-to-page cache positive only and handles
large pages more naturally. There is now a separate whole-process negative
cache that keeps track of pages that are not in any of the heaps. This speeds up my microbenchmark from ~87 to ~65.

R=ager@chromium.org, haraken@chromium.org, wibling@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/271703002

git-svn-id: svn://svn.chromium.org/blink/trunk@173749 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Prepare to move HTMLFormElement, HTMLFormElement::PastNamesMap, FormKeyGenerator, and FormState to Oilpan heap.

BUG=357163

Review URL: https://codereview.chromium.org/270483003

git-svn-id: svn://svn.chromium.org/blink/trunk@173748 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/278803002

git-svn-id: svn://svn.chromium.org/blink/trunk@173747 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=erik.corry@gmail.com, tkent@chromium.org
BUG=

Review URL: https://codereview.chromium.org/274023002

git-svn-id: svn://svn.chromium.org/blink/trunk@173746 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/275573003

git-svn-id: svn://svn.chromium.org/blink/trunk@173745 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Web Animations: Timeline should not advance during task execution (https://codereview.chromium.org/275753002/)

Reason for revert:
Still failing Win7 debug:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/5195

Original issue's description:
> Web Animations: Timeline should not advance during task execution
> 
> Previously the animation clock was only frozen during animation frame
> callbacks. This meant that the timeline was able to advance during other
> tasks.
> 
> This patch allows the clock to advance once per task, either to the
> compositor supplied frame start time or to an approximation of the next
> expected frame time.
> 
> http://dev.w3.org/fxtf/web-animations/#script-execution-and-live-updates-to-the-model
> 
> This is a reland of r173583[1], the previous patch hit added assertions
> due to double rounding issues, the new approach avoids these. Also ensures
> that other unit tests see a non-zero currentTime (seen in some webkit_unit_test
> runs on Android).
> 
> [1] https://src.chromium.org/viewvc/blink?view=rev&revision=173583
> BUG=367903
> TBR=abarth
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173729

TBR=noel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=367903

Review URL: https://codereview.chromium.org/275863002

git-svn-id: svn://svn.chromium.org/blink/trunk@173744 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I'm making ScriptValue understand the ScriptState from which the ScriptValue is created. For that goal, this CL makes ScriptPromise understand the ScriptState from which the ScriptPromise is created. For that goal, this CL passes around ScriptState in a lot of places.

BUG=357144

Review URL: https://codereview.chromium.org/273683006

git-svn-id: svn://svn.chromium.org/blink/trunk@173743 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/277863002

git-svn-id: svn://svn.chromium.org/blink/trunk@173742 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The "distinguishing argument index" is the next part of the overload
resolution algorithm.

In overload resolution, you first distinguish by number of arguments,
then distinguish by checking the type of a single argument at some index;
this CL adds the index computation.

In practice it's just the first index where types differ,
but there are additional conditions to check.
http://heycam.github.io/webidl/#dfn-distinguishing-argument-index

Next CL will add the very lengthy "distinguishability classes".

After that we'll finally be ready to start changing the code generation,
based first on number of arguments, secondly on type!

Also:
* Some refactoring
* Fixes some tests that were invalid overloads, and were caught
by the new checks!
(No invalid overloads in actual IDLs, but test cases were too simple.)

R=haraken
BUG=293561

Review URL: https://codereview.chromium.org/275763002

git-svn-id: svn://svn.chromium.org/blink/trunk@173741 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=371725
TBR=ksakamoto

Review URL: https://codereview.chromium.org/275813002

git-svn-id: svn://svn.chromium.org/blink/trunk@173740 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173722

BUG=371698
TBR=dominicc@chromium.org

Review URL: https://codereview.chromium.org/278833002

git-svn-id: svn://svn.chromium.org/blink/trunk@173739 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173730

BUG=25293
TBR=sudarshan.p@samsung.com

Review URL: https://codereview.chromium.org/274053002

git-svn-id: svn://svn.chromium.org/blink/trunk@173738 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Fix webkit_unit_tests to use the threaded parser and enable everywhere. (https://codereview.chromium.org/271793007/)

Reason for revert:
Sorry to revert this patch. The assert it adds is getting hit in webkit_unit_tests on WebKit Mac 10.6 (dbg).

Log: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28dbg%29/builds/14735/steps/webkit_unit_tests/logs/stdio

Snippet from log:
ASSERTION FAILED: !testClientForFrame(m_webView->mainFrame())->isLoading()
../../third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp(271) : void blink::FrameTestHelpers::WebViewHelper::reset()

Original issue's description:
> Fix webkit_unit_tests to use the threaded parser and enable everywhere.
> 
> In order to support the threaded parser, FrameTestHelpers utilities has
> been updated to magically wait for loads to finish. There are also
> several new helpers for other common operations in tests that
> understand how to wait for the threaded parser to complete.
> 
> Tests that need to interleave more complicated operations can fall back
> to pumpPendingRequestsDoNotUse(). Most tests should prefer the new
> helper utilities though.
> 
> BUG=366354
> R=abarth@chromium.org, eseidel@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173731

TBR=abarth@chromium.org,eseidel@chromium.org,dcheng@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=366354

Review URL: https://codereview.chromium.org/272143002

git-svn-id: svn://svn.chromium.org/blink/trunk@173737 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the last patch for postMessage plumbing:
1/3: https://codereview.chromium.org/263143004/ (blink)
2/3: https://codereview.chromium.org/246023007/ (chromium)
3/3: THIS PATCH

BUG=366063
TEST=http/tests/serviceworker/postmessage-to-client.html
R=jsbell@chromium.org, tkent@chromium.org

Review URL: https://codereview.chromium.org/264233003

git-svn-id: svn://svn.chromium.org/blink/trunk@173736 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=371716
TBR=ojan

Review URL: https://codereview.chromium.org/278813002

git-svn-id: svn://svn.chromium.org/blink/trunk@173735 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=369615
TBR=ojan

Review URL: https://codereview.chromium.org/275803002

git-svn-id: svn://svn.chromium.org/blink/trunk@173734 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173714

BUG=371680
TBR=dominicc@chromium.org

Review URL: https://codereview.chromium.org/271043002

git-svn-id: svn://svn.chromium.org/blink/trunk@173733 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ServiceWorker should see everything in Worker, just as DedicatedWorker and
SharedWorker already do, per Kinuko:
https://code.google.com/p/chromium/issues/detail?id=369115#c3
http://heycam.github.io/webidl/#Global

R=kinuko
TBR=haraken
BUG=369115

Review URL: https://codereview.chromium.org/277853002

git-svn-id: svn://svn.chromium.org/blink/trunk@173732 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In order to support the threaded parser, FrameTestHelpers utilities has
been updated to magically wait for loads to finish. There are also
several new helpers for other common operations in tests that
understand how to wait for the threaded parser to complete.

Tests that need to interleave more complicated operations can fall back
to pumpPendingRequestsDoNotUse(). Most tests should prefer the new
helper utilities though.

BUG=366354
R=abarth@chromium.org, eseidel@chromium.org

Review URL: https://codereview.chromium.org/271793007

git-svn-id: svn://svn.chromium.org/blink/trunk@173731 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The image/x-png is a non-standard mimetype, now replaced by image/png.
Adding support to be backward compatible and also match the behavior
of other browsers like Firefox. The patch adds the Layout TestCases.

BUG=25293

Review URL: https://codereview.chromium.org/270473002

git-svn-id: svn://svn.chromium.org/blink/trunk@173730 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously the animation clock was only frozen during animation frame
callbacks. This meant that the timeline was able to advance during other
tasks.

This patch allows the clock to advance once per task, either to the
compositor supplied frame start time or to an approximation of the next
expected frame time.

http://dev.w3.org/fxtf/web-animations/#script-execution-and-live-updates-to-the-model

This is a reland of r173583[1], the previous patch hit added assertions
due to double rounding issues, the new approach avoids these. Also ensures
that other unit tests see a non-zero currentTime (seen in some webkit_unit_test
runs on Android).

[1] https://src.chromium.org/viewvc/blink?view=rev&revision=173583
BUG=367903
TBR=abarth

Review URL: https://codereview.chromium.org/275753002

git-svn-id: svn://svn.chromium.org/blink/trunk@173729 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173673

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/276863002

git-svn-id: svn://svn.chromium.org/blink/trunk@173728 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As part of the picture specification, the source element gets added with several new attributes, that are used in HTMLImageElement's source selection algorithm.
This CL adds these attributes.

BUG=368830

Review URL: https://codereview.chromium.org/267693002

git-svn-id: svn://svn.chromium.org/blink/trunk@173727 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173673

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/275033002

git-svn-id: svn://svn.chromium.org/blink/trunk@173726 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We don't allow on-heap allocations in the audio thread. We change AsyncAudioDecoder::decode so we won't allocate an AudioBuffer in the audio thread.

BUG=340522

Review URL: https://codereview.chromium.org/205173002

git-svn-id: svn://svn.chromium.org/blink/trunk@173725 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173673

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/275763003

git-svn-id: svn://svn.chromium.org/blink/trunk@173724 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replace FormAssociatedElement raw pointers with Member<>.

- Make FormAttributeTargetObserver GarbageCollectedFinalized in order to make
  FormAttributeTargetObserver::m_element traceable.
- Define a typedef for
  WillBeHeapVector<RawPtrWillBeMember<FormAssociatedElement>>. The raw name is
  long and the type is used in many places.

BUG=357163

Review URL: https://codereview.chromium.org/270823004

git-svn-id: svn://svn.chromium.org/blink/trunk@173723 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=enne@chromium.org
BUG=371698

Review URL: https://codereview.chromium.org/271033002

git-svn-id: svn://svn.chromium.org/blink/trunk@173722 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
We still have open layer squashing bugs.

Original issue's description:
> Re-enable layer squashing
> 
> We've fixed all the know bugs. Hopefully this time it will stick. If you find
> that this CL caused a regression, please mark the bug as blocking
> http://crbug.com/365701
> 
> BUG=365701
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173696

TBR=chrishtr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=365701

Review URL: https://codereview.chromium.org/279703002

git-svn-id: svn://svn.chromium.org/blink/trunk@173721 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173673

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/276843003

git-svn-id: svn://svn.chromium.org/blink/trunk@173720 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173673

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/272913002

git-svn-id: svn://svn.chromium.org/blink/trunk@173719 bbb929c8-8fbe-4397-9dbb-9b2b20218538

See http://src.chromium.org/viewvc/blink?view=revision&revision=165278.
This changed behavior of ArrayBuffer allocation on OOM from crashing to
returning null. Add CRASH to keep old behavior.

BUG=357356

Review URL: https://codereview.chromium.org/242323003

git-svn-id: svn://svn.chromium.org/blink/trunk@173718 bbb929c8-8fbe-4397-9dbb-9b2b20218538

V8StringResource<T>::prepareBase was not a good name.
Because V8StringResource<T>::prepare added some additional checks depending
on T, I renamed them to "check", added the check to prepareBase and rename it
to "prepare". This is a refactoring CL and doesn't change the behavior.

BUG=NONE

Review URL: https://codereview.chromium.org/276613007

git-svn-id: svn://svn.chromium.org/blink/trunk@173717 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Test code is basically copied from falken@'s:
https://github.com/mattto/ServiceWorker/tree/master/examples/layout-tests
(minus one obsolete FIXME, plus another FIXME)

BUG=366538
TEST=http/tests/serviceworker/current-on-load.html
TEST=http/tests/serviceworker/current-on-reload.html

Review URL: https://codereview.chromium.org/265943003

git-svn-id: svn://svn.chromium.org/blink/trunk@173716 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=enne@chromium.org
BUG=371651

git-svn-id: svn://svn.chromium.org/blink/trunk@173715 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=371680
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/272903002

git-svn-id: svn://svn.chromium.org/blink/trunk@173714 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The new width of table was not being applied when changed dynamically
even though the table-layout is fixed.

On calculating whether we need to set the m_tableLayout as fixed or
auto the change in layout parameters such as width, height etc was
not considered hence the right layout type was not being set. Incase
there are any layout changes we need to see whether m_tableLayout
needs to be changed or not.

R=jchaffraix@chromium.org
BUG=239421

Review URL: https://codereview.chromium.org/264283002

git-svn-id: svn://svn.chromium.org/blink/trunk@173713 bbb929c8-8fbe-4397-9dbb-9b2b20218538