GitLab

Original CL: https://codereview.chromium.org/300853008/
Original Description:
Refactors ExternalInstallUI to have determinate lifetimes.
This is likely the first of multiple patches targeting this area of code; the
next one will concentrate on pulling the related logic out of ExtensionService.

----------------------------------------------------

The original patch contained a cycle in that when an external install warning
was clicked, it would accept or remove the extension, and then remove the error.
Since the manager listened for the extension to be loaded or unloaded, this
resulted in a double-removal.  Fix is straightforward.

We also didn't have tests for actually interacting with the dialog, so two have
been added.

TBR=yoz@chromium.org
BUG=378042

Review URL: https://codereview.chromium.org/309643007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274325 0039d316-1c4b-4281-b951-d872f2087c98

Adds the public headers and visibility to the desc command.

Improve formatting of visibility printing.

Don't duplicate group deps in the tree output of "desc"

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/306013007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274324 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379798
TBR=tommi@chromium.org

Review URL: https://codereview.chromium.org/307253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274323 0039d316-1c4b-4281-b951-d872f2087c98

launcher inits the view manager, running the "window manager" app @ root.
window manager embeds another app.

R=sky@chromium.org
TEST=mojo_shell --origin=http://127.0.0.1:4444 --disable-cache mojo:mojo_demo_launcher
http://crbug.com/365012

Review URL: https://codereview.chromium.org/303163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274322 0039d316-1c4b-4281-b951-d872f2087c98

This blocks the DLL from loading in sandbox processes.  It was causing sandbox
startup failure on Win64.

TBR=jschuh@chromium.org
BUG=379730

Review URL: https://codereview.chromium.org/308993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274319 0039d316-1c4b-4281-b951-d872f2087c98

With each TrayBackgroundView now backed by its own layer, calling SchedulePaint on StatusAreaWidgetDelegate no longer notifies them of the need to paint.

When the shelf changes its dimming state it triggers painting. Add support for StatusAreaWidget to notify each of the layer backed trays that painting is needed

TEST=Launch a non-maximized browser. The system tray will be a dark grey. Maximize the browser. The tray should be a lighter grey. This will mimic the colour changes of the application launcher on the shelf.
BUG=378115

Review URL: https://codereview.chromium.org/302153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274318 0039d316-1c4b-4281-b951-d872f2087c98

E.g., something like

  out/Debug/mojo_shell file://$PWD/out/Debug/lib/libmojo_sample_app.so

should work.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/302173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274317 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379170
TBR=asargent

Review URL: https://codereview.chromium.org/309533013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274316 0039d316-1c4b-4281-b951-d872f2087c98

Broke Windows compile:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Builder&number=180

FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\remoting\host\win\remoting_core.wts_session_process_delegate.obj.rsp /c ..\..\remoting\host\win\wts_session_process_delegate.cc /Foobj\remoting\host\win\remoting_core.wts_session_process_delegate.obj /Fdobj\remoting\remoting_core.cc.pdb 
c:\b\build\slave\win_x64_builder\build\src\remoting\host\win\wts_session_process_delegate.cc(386) : error C2661: 'IPC::ChannelProxy::ChannelProxy' : no overloaded function takes 4 arguments
ninja: build stopped: subcommand failed.


> Introduce IPC::ChannelProxy::Create*() and IPC::SynChannel::Create*()
> 
> This change hides constructors of these classes so that we can turn
> them polymorphic classes.
> 
> Note that having almost identical ChannelProxy::Init*() isn't great
> and they will be replaced by a factory-like abstraction in coming
> changes.
> 
> TEST=none
> R=darin,cpu
> BUG=377980
> 
> Review URL: https://codereview.chromium.org/301973003

TBR=morrita@chromium.org

Review URL: https://codereview.chromium.org/312553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274315 0039d316-1c4b-4281-b951-d872f2087c98

Expose client_id in chromeosInforPrivate for enterprise
kiosk.

BUG=328437

Review URL: https://codereview.chromium.org/308913004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274313 0039d316-1c4b-4281-b951-d872f2087c98

Currently log lines from the plugin get 2 newlines, which wastes space in
the console output. This strips off the extra newline.

Review URL: https://codereview.chromium.org/308183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274312 0039d316-1c4b-4281-b951-d872f2087c98

Enable a Shell for tests that exist in Linux with Ash.

TEST=TabDragControllerInteractiveUiTest
BUG=330429

Review URL: https://codereview.chromium.org/301613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274311 0039d316-1c4b-4281-b951-d872f2087c98

This change hides constructors of these classes so that we can turn
them polymorphic classes.

Note that having almost identical ChannelProxy::Init*() isn't great
and they will be replaced by a factory-like abstraction in coming
changes.

TEST=none
R=darin,cpu
BUG=377980

Review URL: https://codereview.chromium.org/301973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274310 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jyasskin@chromium.org
BUG=379204

Review URL: https://codereview.chromium.org/304423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274307 0039d316-1c4b-4281-b951-d872f2087c98

Before the CL that introduced NetMetricsLogUploader, Start()
was being called from MetricsService::SendStagedLog().

However, it got lost in the refactoring. This re-adds it.

BUG=375771
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/309793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274306 0039d316-1c4b-4281-b951-d872f2087c98

When the chip is hidden, we instantly show the entire omnibox text, aligned so
that the hostname is in the same place it was in the chip, and clipped to just
have the hostname visible.  Then we animate moving the alignment over to the
normal omnibox text position (i.e. just after the location icon) while
expanding the clip to gradually reveal the whole text.  We also crossfade the
selection colors from the chip colors to the standard omnibox ones.

This also:
* Animates correctly when the hostname is not at the beginning of the origin
  chip (i.e. for EV certs)
* Properly reverses the animation if the user changes state in the middle (hard
  to see with quick animations, but looks nicer if we slow them down or with
  very large animation distances)
* Fixes dropping characters during animation (because the real omnibox is
  visible and focused, and can respond correctly to keypresses)
* Fixes animations improperly running across tab switches
* Cleans up some unused origin chip code

Also tested in RTL mode.

BUG=363681,365818,374251
TEST=With the origin chip on, showing and hiding the URL should animate much more quickly and cleanly

Review URL: https://codereview.chromium.org/302453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274305 0039d316-1c4b-4281-b951-d872f2087c98

view-souce feature and the XSSAuditor in blink. The current technique for testing
view-source pages is to use a hack in the content_shell's dump-render-tree mode
to turn on view-source for the main page when the path /viewsource/ is 
present in the URL.

To test XSS reflections, however, there needs to be a query string containing
the reflection (because putting it in the path would lead to horribly named 
files). To get a query string, we traditionally load a main page which then
loads the more complex URL in a iframe.  Presently, there's no way to make
that iframe a view-source frame (since some guy removed the viewsource="true"
attribute from HTML because it was dangerous).

There are also two other methods that are exposed to javascript: dumpAsMarkup()
and dumpChildFramesAsMarkup().  These give the test scripts the ability to control
the format of the output.  This is needed to simplify diffing the results 
of these kinds of tests.

CL https://codereview.chromium.org/301813002/ is blocked on this.

Review URL: https://codereview.chromium.org/302043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274304 0039d316-1c4b-4281-b951-d872f2087c98

This API is controlled by the app.window.shape permission which has its own whitelist, so there's no need to duplicate in the SetShape implementation.

Review URL: https://codereview.chromium.org/282293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274303 0039d316-1c4b-4281-b951-d872f2087c98

- This strips conditions inside a variables in addition to the toplevel conditions.

- Removes percent signs from the ends of variable names.

Both of these are required to import some of the Blink .gypis.

Make net forward the crypto config. This appears to be necessary to use net's public API.

R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/305013009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274302 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373252
TBR=grunell@chromium.org

Review URL: https://codereview.chromium.org/302173009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274301 0039d316-1c4b-4281-b951-d872f2087c98

This is to share the same code path with WebView, which currently
has its own copy/paste version of the code, and keep its behavior
in sync with it.
This change is a pure refactoring and should have no effect on
Chrome.

BUG=b/14438911

Review URL: https://codereview.chromium.org/308313004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274300 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379432
TEST=None

Review URL: https://codereview.chromium.org/312453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274299 0039d316-1c4b-4281-b951-d872f2087c98

Some ICU settings were incorrect in the non-component build that caused functions not to get linked properly.

We set the wrong exception handling flag in non-component mode.

Add rlz to the GN build.

Some NSS files were missing.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/307993010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274298 0039d316-1c4b-4281-b951-d872f2087c98

We will limit the enhanced bookmark image store database size
to ensure that the db file size is reasonable. So add a function
to query the actual file size.

BUG=378853

Review URL: https://codereview.chromium.org/305963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274297 0039d316-1c4b-4281-b951-d872f2087c98

Reverting as we think it caused checkdeps failure on Linux:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/24742/steps/checkdeps/logs/stdio

ERROR in /b/build/slave/Linux_Builder__dbg__32_/build/src/mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java
  Illegal include: "out/Debug/java_mojo/mojo_public_test_interfaces/src/org/chromium/mojo/bindings/test/sample/SampleServiceConstants.java"
    Because of no rule applying.


> Generate java bindings for constants.
> 
> This CL is the first CL introducing java bindings. It only generates constants.
> 
> This is a reland of https://codereview.chromium.org/291903003
> 
> TBR=viettrungluu@chromium.org,rmcilroy@chromium.org
> 
> Review URL: https://codereview.chromium.org/305963009

TBR=qsr@chromium.org

Review URL: https://codereview.chromium.org/311643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274296 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/309053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274288 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379065

Review URL: https://codereview.chromium.org/307103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274287 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/304993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274285 0039d316-1c4b-4281-b951-d872f2087c98

- MostVisitedSites keeps track of which source the sites come from
- Blacklist requests are sent to the source corresponding to the current
suggestions
- SuggestionsService now handles blacklist requests

BUG=None
TEST=SuggestionsService

Review URL: https://codereview.chromium.org/298703009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274284 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379399
TEST=none
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/307963007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274283 0039d316-1c4b-4281-b951-d872f2087c98

TEST=chrome --ozone-platform=gbm
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/302093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274281 0039d316-1c4b-4281-b951-d872f2087c98

Whenever a resource load is aborted, two events fire: loadabort and
loadstop. This change explicitly mentions two-event behaviour in our
documentation of loadabort and loadstop events.

Review URL: https://codereview.chromium.org/309673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274280 0039d316-1c4b-4281-b951-d872f2087c98

This CL is the first CL introducing java bindings. It only generates constants.

This is a reland of https://codereview.chromium.org/291903003

TBR=viettrungluu@chromium.org,rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/305963009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274278 0039d316-1c4b-4281-b951-d872f2087c98

This is the final cleanup before the unified gesture recognizer is turned on.

Tests are passing with the unified GR flag on and with the flag off.

BUG=332418
Test=GestureRecognizerTest.*, GestureProviderTest.*

Review URL: https://codereview.chromium.org/306483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274277 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/309573007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274276 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274275 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TESTED=try bots built unittests
R=wjia@chromium.org

Review URL: https://codereview.chromium.org/294343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274274 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the lint warns at:
Error: Field requires API level 16 (current min is 14):
    android.view.View#SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION [InlinedApi]
Error: Field requires API level 16 (current min is 14):
    android.view.View#SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN [InlinedApi]
Error: Field requires API level 16 (current min is 14):
    android.view.View#SYSTEM_UI_FLAG_FULLSCREEN [InlinedApi]

So we need to add @SuppressLint("InlinedApi") to suppress these lint errors.

BUG=327768

Review URL: https://codereview.chromium.org/305333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274273 0039d316-1c4b-4281-b951-d872f2087c98

As of May 14, 2014, this benchmark is no longer maintained.
https://github.com/facebookarchive/jsgamebench/commit/3938f9893d8713c47032d8d98bac41c32f4545ec

I think it is time we thank it for all the fish (e.g. http://crbug.com/161828)
and turn our eyes towards new benchmarks.

My motivation for pursuing this is that it has a long cycle time and is flaky in many places.

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/307263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274272 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=mark@chromium.org

Review URL: https://codereview.chromium.org/308123006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274271 0039d316-1c4b-4281-b951-d872f2087c98