GitLab

This CL changes strings used in sync_and_services_preferences, changing
wording to make the string grammatically correct. It also fixes a typo.

Bug: 864791, 864789
Change-Id: I38ee3efb2894562606f6997113aa2d9a81787ef5
Reviewed-on: https://chromium-review.googlesource.com/1142149Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576311}

Make test_ws implement ServiceFactory and package the ui service.
Bind a ws2::WindowService instance to requests for the ui service.
Bind test WindowTreeHostFactory requests in WindowService's registry.
Have the test suites use test_ws + ui services instead of test_wm.

Add a TestGpuInterfaceInterfaceProvider with stub binding functions.
(that and an EventInjector registration placeholder prevent crashes)

Move shadow elevation property registration to ws2::WindowService.

Disable some broken mus-only tests, early return if IsMus from some others.
Remove the old ws service_unittests (catalog conflict packaging ui service)

Bug: 855609
Test: Automated, no regressions.
Change-Id: I58f65551c9c0e1c734ed4ac752b5219ecbead0db
Reviewed-on: https://chromium-review.googlesource.com/1138749
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576310}

https://skia.googlesource.com/skia.git/+log/dc97fdc23571..8364706c02c6


git log dc97fdc23571..8364706c02c6 --date=short --no-merges --format='%ad %ae %s'
2018-07-18 caryclark@google.com correct bookmaker md files
2018-07-18 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 e2c00841a55f..38971fd13599 (2 commits)
2018-07-18 csmartdalton@google.com Add kAAHairline to GpuPathRenderers
2018-07-18 caryclark@skia.org add more fiddle hash checks
2018-07-18 csmartdalton@google.com ccpr: Remove constant scale when solving the cubic midtangent
2018-07-18 reed@google.com add new patheffects
2018-07-18 bungeman@google.com SkUTF16_CountUnichars to error instead of assert.
2018-07-18 robertphillips@google.com Fix explicit allocation bug
2018-07-18 jvanverth@google.com Reland "Add some optimizations to PolyUtils"
2018-07-18 ruiqimao@google.com added GMs that use the vertex caching pipeline
2018-07-18 robertphillips@google.com Pull non-substantive changes out of "Reduce arbitrary opList splitting when sorting"
2018-07-18 timliang@google.com Reland "implemented metal gpu backend texture upload testing"
2018-07-18 csmartdalton@google.com ccpr: Account for stroke and style in path cache keys
2018-07-18 brianosman@google.com Add color space logic to skdiff
2018-07-18 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files
2018-07-18 benjaminwagner@google.com Update Win2016 bots.
2018-07-18 bsalomon@google.com Add valgrind suppression for leak in libGLX_nvidia when caching program binaries
2018-07-18 halcanary@google.com Reland "SkDEBUGF: use __VA_ARGS__"
2018-07-18 ziadb@google.com SkAR-Java: finger painting first implementation


Created with:
  gclient setdep -r src/third_party/skia@8364706c02c6

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: Ic8e39efb74f630cf49710dda61543c722c91cef6
Reviewed-on: https://chromium-review.googlesource.com/1142018Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576309}

No additional work is required; flake no longer reproduces.

Bug: 855368
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If1f701b846d59cd4e0fe6cb4fed846355561ee02
Reviewed-on: https://chromium-review.googlesource.com/1142393Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576308}

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I9e4eb9de5bfd5876711bde8b77367ccd7be67aba
Reviewed-on: https://chromium-review.googlesource.com/1142577Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576307}

This reverts commit 14fd238a.
Removes the chrome.send('showAddUser') in md_login.js to avoid a race
between the powerwash dialog and the Gaia signin screen.

Bug: 837501
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I7ab656ebe522cbd164073b73b3dd927cca7b1f13
Reviewed-on: https://chromium-review.googlesource.com/1129384
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576306}

Bug: 826476
Change-Id: I6b30a7b5c4c252896d557db14e14a54ad4d36ee5
Reviewed-on: https://chromium-review.googlesource.com/1130827
Commit-Queue: Ryan Cui <rcui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576305}

This adds plumbing so that the enterprise policy setting can actually override
the tab lifecycles feature.

BUG=

Change-Id: If86dd7687e993c7ed66955692be8eae88b505990
Reviewed-on: https://chromium-review.googlesource.com/1142355Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576304}

Clean up transfer.js browser test, and generalize it to transfer between
different sources and destinations, move and copy and allow transfer
failures.

This is pre-work to add tests for all the possible transfer behavior
operations.

Bug: 722324
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ib1d43a9fe1b7160fe9c93ec10c8cfb1c460889e0
Reviewed-on: https://chromium-review.googlesource.com/1128660
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576303}

Remove the method from PreloadController and CRWWebController
and replace it with a new WebStateDelegate method ShouldAllowAppLaunching
that is implemented by both PreloadController and BrowserViewController.


Bug: 850760, 674991
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I28cd1b512368f27572a028c43f8caaebfe135a8b
Reviewed-on: https://chromium-review.googlesource.com/1137343Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576302}

Since DeviceMotionData class has all the information from
device::MotionData, and DeviceMotionEventPump is now in blink,
DeviceMotionData is now passed to DeviceMotionDispatcher.
device::MotionData will be removed in a subsequent change.

Bug: 861923
Change-Id: I1165d1dbd128197e2e00d7ad63db17d03e6af810
Reviewed-on: https://chromium-review.googlesource.com/1137171
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576301}

Bug: 803774
Change-Id: I91b9def8e3e4506c4d8913cb351129286f3686d1
Reviewed-on: https://chromium-review.googlesource.com/1141668
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576300}

Port.test_type just tries to guess about test type based on
baselines; it sometimes returns "unknown" for test types that
actually are knowable (e.g. because they're in wpt manifest).

This method isn't used except in the script print_web_test_types.py,
and I believe nobody is using that script.

Bug: 740997
Change-Id: I1e98601504affd2d75ab92409ae20da9d28b92a4
Reviewed-on: https://chromium-review.googlesource.com/1142229
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576299}

Re-introduces dynamic header height on Recent Tabs for iOS11.
Originally this was removed because of an iOS10 bug, but
there's no need to stop supporting dynamic height on iOS11.

Bug: 862744
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I17ec0f4b2257b23c24d8ed3e285efce023e3e141
Reviewed-on: https://chromium-review.googlesource.com/1142697
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576298}

Roll to current release version (1.16)

TBR=bajones@chromium.org

Change-Id: Idcb7094df11ddd773e06b89f75d78835558ac6f0
Reviewed-on: https://chromium-review.googlesource.com/1142785Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576297}

Three more cases are added to the Direct Composition Pixel tests.
Pixel_DirectComposition_Underlay test is created by adding a black block
on top of a video.
Pixel_DirectComposition_Nonroot test is created by adding a white gradient
blending effect on a video.
Pixel_DirectComposition_ComplexOverlays test is created by applying scaleX,
scaleY and rotate.

The H.264 mp4 video clip FourColors.mp4 used in these tests is created by
Maggie Chen. The video frames has 4 color blocks (Yellow, Red, Green, Blue)
and it looks like a still image. With this video, the pixel tests can be
done by solid color block comparisons. No golden images are needed.

Bug:848097

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I95483ba8c96c495b1150c749f1f55243c6a5efa5
Reviewed-on: https://chromium-review.googlesource.com/1136003
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576296}

This CL:

1) Extracts StatementID from sql/connection.{h,cc} into its own files
   sql/statement_id.{h,cc}.
2) Adds tests specifically targeting sql::StatementID.
3) Replaces passing StatementID by const reference with passing by
   value.
4) Removes the StatementID constructor that takes a name, and updates
   the call sites to use the source file+line constructor.

Bug: 863724
Change-Id: I5bc6e160fe294189d3e9a2baa8f6be61b21c38d2
Reviewed-on: https://chromium-review.googlesource.com/1137915
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576295}

This patch fixes first-line baseline when the 'overflow'
property is other than 'visible'.

CSS2 states that:
  The baseline of an 'inline-block' is the baseline of its
  last line box in the normal flow, unless it has either no
  in-flow line boxes or if its 'overflow' property has a
  computed value other than 'visible', in which case the
  baseline is the bottom margin edge.
https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align

This rule should apply only to 'inline-block', but it was
incorrectly applied to first-line baseline as well.

This patch fixes incorrect alignment in the comment lines of
Gerrit code review site.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I49ffd8c050f384765c61c5678a431fa74492356d
Reviewed-on: https://chromium-review.googlesource.com/1140336Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576294}

With this change, all webgl/webgl2 APIs can be run on webgl2-compute
context for passthrough command buffer.

Bug: 859249
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia3c5febb7f5cbeb16d560ee05362c4746f97d5d6
Reviewed-on: https://chromium-review.googlesource.com/1141434Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Cr-Commit-Position: refs/heads/master@{#576293}

Bug: 862537
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic60262906f269376375738afcf3067ee2d93294e
Reviewed-on: https://chromium-review.googlesource.com/1139945Reviewed-by: John Wu <jzw@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576292}

Reviewed by Chrome OS UI team and OK to land in M69.

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I9c614f6113de0ef7dc289f9dc960a4fe9b6a57a8
Reviewed-on: https://chromium-review.googlesource.com/1138646Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576291}

Currently we rely on test-only code to render tabs opened in the
background.

This CL updates RenderWidgetHostViewMac to not rely on test-only code
and does an Aura-analogous operation to render background tabs.

It also makes the Mac version of WasUnOccluded contain all the meat of
the Aura version.

Bug: 856617
Change-Id: Id9f05f627cbadb542772a200f2608787f05a63b7
Reviewed-on: https://chromium-review.googlesource.com/1117762
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576290}

The layout has unclear test flow, as it uses a big test function with
different branches with different assertions for all test cases. As a
result, the expectations for the test cases are unclear.

This patch removes all branching from the test flow, so that it becomes
clear what we expect on each test case. It also reveals that LayoutNG
has different behavior and should be marked failure here.

Bug: 755750
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I7d1a22a5805cc7ad031bf3c7bc24f0b822a3a0da
Reviewed-on: https://chromium-review.googlesource.com/1142573
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576289}

Associated endpoints have been getting error handler invocations
synchronously whenever their corresponding master interface endpoint is
closed. This is bad for reasons explained in the linked bug. Fix!

Bug: 864731
Change-Id: If4a7d205ab42be5ee43926be619e77ad0ab15d68
Reviewed-on: https://chromium-review.googlesource.com/1141078Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576288}

OWNERS files can reference other OWNERS files rather than duplicating
their content. If a COMPONENT is not found in an OWNERS file, the
reference is followed to try to find a COMPONENT.

Bug: 860303
Change-Id: Ia676156a4a3945c85409dd93f5ee9f407faa94a8
Reviewed-on: https://chromium-review.googlesource.com/1134093Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576287}

This implements creating, updating and surfacing transceivers from the
content layer. This is in preparation for the blink layer to implement
its part, but split up for the sake of reviewability. For the big
picture, see:
https://chromium-review.googlesource.com/c/chromium/src/+/1138615

Because the blink layer is needed to surface the transceivers to
JavaScript, and because the codepaths are tested by LayoutTests, the
new code in this CL is not yet exercised or tested, as is ensured by
NOTREACHED(). Follow-up CLs will exercise the code in this CL.

This CL updates the following operations in RTCPeerConnectionHandler to
support both Plan B and Unified Plan once the new codepaths are
unlocked:
- AddTrack()
- RemoveTrack()
- SetLocalDescription()
- SetRemoteDescription()

The only operation missing in AddTransceiver(), to be added separately.

Bug: 777617
Change-Id: I225cf1d903e95e488599d6735b09a57aa2b279bb
Reviewed-on: https://chromium-review.googlesource.com/1141952
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576286}

This was missed in the last set of renamings.

Bug: 863070
Change-Id: I9a44bef5c26a4862c8622a0be0e9d79aad478679
Tbr: jbudorick@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1142612Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576285}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/302bb847d356..f9afc77f283e


git log 302bb847d356..f9afc77f283e --date=short --no-merges --format='%ad %ae %s'
2018-07-18 ehmaldonado@chromium.org Reland "gclient_scm: Use cherry-picking instead of rebasing."


Created with:
  gclient setdep -r src/third_party/depot_tools@f9afc77f283e

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:850812
TBR=agable@chromium.org

Change-Id: I6d5d0c1a1ff3ade569d72e9e2145ecac58db7e30
Reviewed-on: https://chromium-review.googlesource.com/1142020Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576284}

QuickOffice uses beforeunload events. When running inside a mime
handler, these beforeunload event handlers are ignored. Add a
beforeunload event handler to PluginDocument when a plugin requires it.

This event handler is controlled over a mojo interface, exposed to the
mime handler as chrome.mimeHandlerPrivate.setShowBeforeUnloadDialog().

Bug: 819761
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ieb61cf98ce2bf719fc128499f8d0e57d8fe7ad33
Reviewed-on: https://chromium-review.googlesource.com/1139946
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576283}

This CL propagates URL chain and response headers for in memory download
backend that is used in incognito mode for background fetch.

Bug: 863949
Change-Id: I07baff393111aaa2bd2ce2ef9965a78d299be125
Reviewed-on: https://chromium-review.googlesource.com/1142466Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576282}

RenderWidgetHostViewBase::GetLocalSurfaceId passed the viz::LocalSurfaceId
by value.

LocalSurfaceId is large and so copying it around is expensive.
This CL returns a const ref of LocalSurfaceId instead to reduce copying.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ic775202ef5572676e056bd41419edbaefb7e44da

Bug: 672962
Change-Id: Ic775202ef5572676e056bd41419edbaefb7e44da
Reviewed-on: https://chromium-review.googlesource.com/1141990Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576281}

animations using and derived from LinearAnimation.

This allows for easier testing and tuning of the many animations throughout the code. By
setting a scale factor, animations can be sped up or slowed down. This allows for them
to be better observed to ensure the intermediate states for transitions, movements, and
fades look good.

Bug: None
Change-Id: Ia2350e71bf6f3bac3fae26351418a95d2452f415
Reviewed-on: https://chromium-review.googlesource.com/1138820
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576280}

This reverts commit 775612b8.

Reason for revert: caused all Windows debug bots to fail almost all tests. Only one example:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/70380

Original change's description:
> [scheduler] Add task type and queue type to tracing.
> 
> R=​skyostil@chromium.org
> 
> Change-Id: Id0aea377558e876c8178e82eb3a170f678c415cc
> Reviewed-on: https://chromium-review.googlesource.com/1140717
> Commit-Queue: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576201}

TBR=skyostil@chromium.org,altimin@chromium.org

Change-Id: I56291cf103d5626c963c2661c4cdca7c29d74476
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1142173Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576279}

This is a reland of 9b785217 with test
fixes. The failing unit tests weren't being run when I first landed
this, but were enabled afterwards and started breaking, so I rolled
back.

Specifically, I PostTask'd (un)registering with the
NetworkConnectionTracker to the right threads, and added a
PrivetTrafficDetector::Stop method to clean up the registration and
call it from PrivetNotificationService.

Original change's description:
> Migrate PrivetTrafficDetector to use NetworkConnectionTracker.
>
> This migrates PrivetTrafficDetector from using
> net::NetworkChangeNotifier to content::NetworkConnectionTracker, which
> works with the network service enabled.
>
> Bug: 859134
> Change-Id: I06f2ecbe142bbed9a8772f69ab109b0c0dc32581
> Reviewed-on: https://chromium-review.googlesource.com/1123681
> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574700}

Bug: 859134
Change-Id: I19bc5bf0abdbd41cfbd3da1c0881f122adca6c2b
Reviewed-on: https://chromium-review.googlesource.com/1137411Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576278}

Bug: 865206
Change-Id: Id94f5a610b31a5e63c494030a792fe168583d95d
Tbr: rsorokin@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1142702Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576277}

I noticed this used by mistake in a couple CLs recently. The define
isn't set in gn, misleadingly makes people think their code is
tested on cast_shell bot.

TBR=slan@chromium.org

Bug: None
Test: None
Change-Id: Ie4b16ca4b1bb565fe8d45598f7cc0601277907d9
Reviewed-on: https://chromium-review.googlesource.com/1139214
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576276}

RenderWidgetHostViewBase::GetFrameSinkId passed the viz::FrameSinkId
by value and was not a const method.

This CL returns a const ref of FrameSinkId and makes GetFrameSinkId a
const method so it can be accessed even if the caller has a const
pointer or reference to the RenderWidgetHostViewBase object.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I5142a75f21a1c0396ba868bf66699a2fb85a2c33
Bug: 672962
Reviewed-on: https://chromium-review.googlesource.com/1141985
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576275}

R=pwnall@chromium.org

Bug: 857464
Change-Id: I58218cf3f4831842f5fddaca480523e5c9169f35
Reviewed-on: https://chromium-review.googlesource.com/1142474
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576274}

Weather answers with °F will have TOP_ALIGNED text ranges, and
this CL detects them to raise the text, improving readability.

Bug: 864798
Change-Id: I3a2dff9fc0e28283bdeaaa2413d261d076737a8f
Reviewed-on: https://chromium-review.googlesource.com/1142385Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576273}

BUG=NONE

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4626621916085e01fec25150da5ea1fba9cd63a8
Reviewed-on: https://chromium-review.googlesource.com/1139579Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#576272}