GitLab

The String.prototype.lineEndings pretended to cache the lineEndings value
on the instance of String object. However, it turned out to be working
only for string objects, and not for the string primitives.

For example, consider the following code snippet:

    var a = "foo";
    a.lineEndings(); // caching failed

    var b = new String(a);
    b.lineEndings(); // caching successful

    var c = b.substring(0);
    c.lineEndings(); // caching failed

The patch removes the caching from String.prototype.lineEndings(). Instead, it introduces
WI.Text object, which wraps String, caches lineEndings
properly, and provides some other handy methods.

BUG=none
R=dgozman, pfeldman

Review URL: https://codereview.chromium.org/1809533003

Cr-Commit-Position: refs/heads/master@{#381620}

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that by calling serializeIdentifier.

Since the font family property relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior, but with the change that previously we used
single quotes, now double quotes [3]. Most of the expected test
changes are because of this.

In order to fix parsing-css-string-characters.html and
string-quote-binary.html completely, the U+007F handling
mentioned in [3] is implemented.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
[3] https://drafts.csswg.org/cssom/#serialize-a-string

Review URL: https://codereview.chromium.org/1778743003

Cr-Commit-Position: refs/heads/master@{#381619}

The former method is deprecated, the latter is not. They have the same
functionality.
https://developer.apple.com/library/mac/releasenotes/General/MacOSXLionAPIDiffs/IOBluetooth.html

BUG=592663

Review URL: https://codereview.chromium.org/1813533002

Cr-Commit-Position: refs/heads/master@{#381618}

For reference, this color is overlaid atop the frame/toolbar when outlining tabs
and for outlines/shadows when drawing the new tab button.  It's either white or
black with a varying (but usually 0x40) alpha value.

Computing this is surprisingly complicated, beause we're trying to contrast with
two different colors simultaneously (tab and frame), and we also want to set our
magic numbers so as to achieve the colors from the design specs in the default
theme.

After quite a bit of thought, I elected to use a mechanism that defaults to
moving the frame away from the tab luminance; that is, if the tab is "brighter"
than the frame, we make the separator darken the frame, and if the tab is
darker, we try to lighten the frame.  If the frame is already so dark or light
that the result has too low of contrast with the frame color, we reverse
direction.  ("Too low" here is a lot lower than I'd like, but any higher and
we'd end up using light separators for the default theme in incognito mode,
which I think looks good but Sebastien dislikes.)  In the case where we reversed
direction, we have to worry that the result of all this won't contrast enough
with the tab; in that case, we push up the alpha value so the result contrasts
enough with the tab as well.  This last computation is the most expensive
because of how I chose to make it behave, but I think the behavior I selected
(too complicated to explain here, see code/comments for details) will feel more
consistent than any of the simpler methods I considered.

Because computing the separator color can be expensive (every call to
GetRelativeLuminance() can involve floating-point exponentiation among other
things, and in the worst case the color computation computes the desired color
via a 7-iteration loop), I elected to cache the computed value in a map.  This
might be a case of premature optimization, but in debugging it looked like this
color could be requested frequently, and I didn't want to risk performance
problems.

Even this choice presented options.  I used a simple map that I never prune
entries from; at worst, we'll add up to 2 entries per distinct theme the user
switches to while running, which didn't seem too bad.  I considered instead
using base::MRUCache, which would let me cap the size.  I also considered just
keeping a couple member structs containing the relevant information for the
normal and incognito color schemes, but this generally seemed like it ended up
as more code than the other routes.  None of these options seems wildly better
or worse than the others; I'm willing to change course in the face of violent
opinion :)

Finally, because the alpha value of the separator can now vary, I converted the
code in tab_strip.cc that set it to fixed values to instead use scaling
multipliers.  These will compute the same values as before when the separator
has its default (0x40) alpha, but in the case where we've computed some larger
alpha, scaling proportionally seemed like the best thing to do.  I used a
saturated_cast in one place where I wasn't sure the result was guaranteed to
stay <= 255.

BUG=585470
TEST=See bug comment 0

Review URL: https://codereview.chromium.org/1785613004

Cr-Commit-Position: refs/heads/master@{#381617}

These interfaces on LayoutObject will be used to more efficiently
represent object locations in the accessibility tree, rather than storing
everything using absolute coordinates.

BUG=551601

Review URL: https://codereview.chromium.org/1777613002

Cr-Commit-Position: refs/heads/master@{#381616}

This change adds the ability to transfer mach ports over Mojo. Mach ports can
either be wrapped using CreatePlatformHandleWrapper() or a Mojo shared buffer
can be created using CreateSharedBufferWrapper(). For now, Mojo shared buffers
created using MojoCreateSharedBuffer() (or MojoCreateDataPipe()) will still
use posix shared memory.

BUG=582468

Review URL: https://codereview.chromium.org/1712143002

Cr-Commit-Position: refs/heads/master@{#381615}

BUG=568830
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1805343006

Cr-Commit-Position: refs/heads/master@{#381614}

This patch ensures that we process active low res pending high res
tilings, since they can have required for activation tiles. Previously,
this only applied to non ideal tiles, but clearly it's possible to hit
the rare case of low res on active while high res on pending.

R=enne, chrishtr
BUG=595209
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1808043002

Cr-Commit-Position: refs/heads/master@{#381613}

As a part of https://codereview.chromium.org/1774323003, it became clear
that it needed to be possible to call SetClientReady repeatedly, which
some sources didn't support.

Instead of just making that part of the contract, instead fold the two
places where SetClientReady mattered into AddObserver (the first time
where a begin frame could actually be delivered) and remove
SetClientReady from the API.

R=skyostil@chromium.org,sunnyps@chomium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1778853003

Cr-Commit-Position: refs/heads/master@{#381612}

https://chromium.googlesource.com/skia.git/+log/2732e186a113..bf680c30a280

$ git log 2732e186a..bf680c30a --date=short --no-merges --format='%ad %ae %s'
2016-03-16 senorblanco Image filters: fix the zero-sigma fast path in SkBlurImageFilter.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1808683003

Cr-Commit-Position: refs/heads/master@{#381611}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e27a07b4..eaa2e514

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1806963003

Cr-Commit-Position: refs/heads/master@{#381610}

Migrate to use SetContentSettingDefaultScope() which takes GURLs only in plugins.
For special test or specific patterns, remain to use SetContentSetting().

BUG=551747

Review URL: https://codereview.chromium.org/1800913002

Cr-Commit-Position: refs/heads/master@{#381609}

DesktopNotificationProfileUtil::ClearSetting() is changed to take GURLs directly
which internally call HostContentSettingsMap::SetContentSettingDefaultScope().

For case in MessageCenterSettingsController, since the patterns are from user
input, SetContentSetting() is used instead of ClearSetting() to take patterns
directly.

BUG=551747

Review URL: https://codereview.chromium.org/1694923004

Cr-Commit-Position: refs/heads/master@{#381608}

Previously, ToImageSkia, ToUIImage and ToNSImage would assume the
scoped_ptr they pass to AddRepresentation would remain valid after that
method returns. This *should* be the case, but it is poor form to assume
it. Now AddRepresentation returns a valid pointer and the callers return
that, rather than assuming the scoped_ptr stays alive.

BUG=590882

Review URL: https://codereview.chromium.org/1769433002

Cr-Commit-Position: refs/heads/master@{#381607}

This updates from revision
3594dcfbd8cf1cb3ba2c57bd56b761147ea31fca (2016-01-04)

to revision
fa6e6592cd76eb0cf6d442dbebe24f0a22787c6e (2016-03-01)

R=pkasting@chromium.org
BUG=37436

Review URL: https://codereview.chromium.org/1750853002

Cr-Commit-Position: refs/heads/master@{#381606}

PluginObject creation can fail if there isn't a valid V8 context. In this
case we need to take care to free the ppp_class_data.

BUG=594926

Review URL: https://codereview.chromium.org/1805303002

Cr-Commit-Position: refs/heads/master@{#381605}

This means that localization is performed before data is sent to the
WebUI client. This CL removes almost all existing i18n-template usage.
We still have a small number of more complex strings which are created
in JS which are more difficult to convert to the new system.

BUG=563884

Review URL: https://codereview.chromium.org/1609683002

Cr-Commit-Position: refs/heads/master@{#381604}

Move most of the logic for extension action execution into the
ExtensionActionRunner (instead of the ExtensionActionAPI), which
eliminates some of the back-and-forth and makes a more common place
for execution logic and adds slightly finer-grained control for
what to execute. This also becomes more important with upcoming
changes for webRequest/document_start handling.

BUG=595087

Review URL: https://codereview.chromium.org/1804123003

Cr-Commit-Position: refs/heads/master@{#381603}

BUG=595490
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/1809883002

Cr-Commit-Position: refs/heads/master@{#381602}

Since swapped out RenderFrameHosts are no longer used, its swapped out
state is no longer necessary. This CL removes it along with a public
API that exposed it outside of content/.

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1799163002

Cr-Commit-Position: refs/heads/master@{#381601}

https://chromium.googlesource.com/chromium/src/+/001d37a4b

BUG=589525
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/1813573002 .

Cr-Commit-Position: refs/heads/master@{#381600}

BUG=525873

Review URL: https://codereview.chromium.org/1695913002

Cr-Commit-Position: refs/heads/master@{#381599}

We make the ContextProviderCommandBuffer and its WebGraphicsContext3D
private in the command buffer version of the tests, and use a
GLInProcessContext in the in-process version. The shared code only is
exposed to GLES2Interface and ContextSupport.

R=kbr@chromium.org
BUG=584497

Review URL: https://codereview.chromium.org/1807813002

Cr-Commit-Position: refs/heads/master@{#381598}

Adding a check for a null bookmark ID and tests.

BUG=594896
TBR=nyquist@chromium.org

Review URL: https://codereview.chromium.org/1804213002

Cr-Commit-Position: refs/heads/master@{#381597}

R=kbr@chromium.org
BUG=584497

Review URL: https://codereview.chromium.org/1807783002

Cr-Commit-Position: refs/heads/master@{#381596}

In https://codereview.chromium.org/1638303002, we began potentially
removing the overscroll refresh layout at the end of the animations.

According to this article:
http://stackoverflow.com/questions/15636658/nullpointerexception-when-adding-removing-views-of-a-relativelayout-animations

That could potentially be the source of the crashes we are seeing.

Changing it to post the detach instead of calling it synchronously in
the animation listener.

BUG=590359

Review URL: https://codereview.chromium.org/1800293004

Cr-Commit-Position: refs/heads/master@{#381595}

BUG=

Review URL: https://codereview.chromium.org/1801293003

Cr-Commit-Position: refs/heads/master@{#381594}

This is required to update the deployment target to OS X 10.7. Eventually, the
deprecated Keychain methods should be removed entirely.

BUG=595468, 592663

Review URL: https://codereview.chromium.org/1813523002

Cr-Commit-Position: refs/heads/master@{#381593}

BUG=595408
TBR=bcwhite@chromium.org

Review URL: https://codereview.chromium.org/1813543002

Cr-Commit-Position: refs/heads/master@{#381592}

BUG=595168

Review URL: https://codereview.chromium.org/1806723003

Cr-Commit-Position: refs/heads/master@{#381591}

Initial CL in unifying the keyboard behavior between ChromeOS and Android.
If the enable-osk-overscroll flag is set, this change will keep the Blink
viewport size stable and set the visible_viewport_size to the smaller value.

This CL adds a new View (InsetObserverView) to the View hierarchy that will
store the value of insets (OSK, status bar). When there is a resize due to
OSK show, we keep the view bounds the same and change the visible viewport
size.

Design doc: http://go/osk-unification

BUG=404315

Review URL: https://codereview.chromium.org/1386403003

Cr-Commit-Position: refs/heads/master@{#381590}

The following tests are expected to crash on Android Web Kit Layout bots.
editing/caret/caret-color.html
fast/invalid/009.html
fast/hidpi/clip-text-in-hidpi.html

BUG=595483
R=pdr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1813563002

Cr-Commit-Position: refs/heads/master@{#381589}

This is a follow up fix to r361481. After r361481 additional info
about a LoadDataWithBaseURL is stored in DocumentState.

However, if there is an in-page fragment navigation, this additional
info is just thrown away, causing incorrect behavior. Fix this by not
updating this additional info for in-page navigations.

Note this is NOT a fix for crbug.com/561034, which describes a similar
problem, but on the browser side.

BUG=594611
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1802383004

Cr-Commit-Position: refs/heads/master@{#381588}

The inputs needed for isSecureContext() were, previously:
a.) the origins of the current frame and its ancestors
b.) for any sandboxed origins in the ancestor chain, the URLs of those frames

(a) is easily accessible in --site-per-process, but (b) is not. For
sandboxed frames, the URL was used to construct a stand-in origin. The
sandboxed frame was considered potentially trustworthy if the stand-in
origin was potentially trustworthy.

In --site-per-process, instead of using the URL for a sandboxed origin,
we save the necessary information (the potential-trustworthiness) at the
time that the origin becomes sandboxed.

Based on https://codereview.chromium.org/1716303002/

BUG=571079
TEST=secureContexts/* layout tests with --site-per-process
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1723753002

Cr-Commit-Position: refs/heads/master@{#381587}

This is toward deleting the class entirely. These methods were not used
at all, or for a couple of them, had one caller which we redirect to the
GLES2Interface directly.

Adds a DEPS entry for core/testing/ to use GLES2Interface as there's
code in there calling things on WebGraphicsContext3D now.

R=kbr,esprehn,sievers,chrishtr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1809553002

Cr-Commit-Position: refs/heads/master@{#381586}

Revert of Fix typo in Android perf variations for unified media pipeline trial. (patchset #1 id:1 of https://codereview.chromium.org/1808803002/ )

Reason for revert:
This is breaking the media tests downstream.

Original issue's description:
> Fix typo in Android perf variations for unified media pipeline trial.
>
> BUG=533190
> TEST=none
>
> Committed: https://crrev.com/31d22b6338ac6ac8b95e9f4c20cdccea11609be2
> Cr-Commit-Position: refs/heads/master@{#381498}

TBR=asvitkine@chromium.org,dalecurtis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=533190

Review URL: https://codereview.chromium.org/1813553002

Cr-Commit-Position: refs/heads/master@{#381585}

TBR=sullivan
BUG=595404
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1812613002

Cr-Commit-Position: refs/heads/master@{#381584}

This change implements the SetWifiEnabledState API for the Host.

BUG=594723
BUG=b/27107139

Review URL: https://codereview.chromium.org/1798293002

Cr-Commit-Position: refs/heads/master@{#381583}

The solid line separator is retained for both the top and between infobars.

Now both the bottom and the top have pieces that overlap the rest of the
browser. On the top, it's the arrow, and on the bottom, it's the shadow.

This changes the layout of InfoBarContainerView such that it's always
sized with zero overlap. This simplifies layout in the browser view and
is now possible because layers allow child views to draw outside their
bounds. This also makes event hit testing simpler (no need to override
the event targeter for the container).

BUG=520266

Review URL: https://codereview.chromium.org/1800373002

Cr-Commit-Position: refs/heads/master@{#381582}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e4173cd91158..468628c224cf

$ git log e4173cd91..468628c22 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1811693003

Cr-Commit-Position: refs/heads/master@{#381581}