- 05 Dec, 2017 40 commits
-
-
Koji Ishii authored
Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic7afbc244552c74ba9f9eb60a045112d621cfb31 Reviewed-on: https://chromium-review.googlesource.com/790170 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#521623}
-
Xiaochu Liu authored
Skip imageloader RegisterComponent (component copy) in OnCustomInstall and loads the copy in chrome. Additions: Add LoadComponentAtPath in ImageLoaderClient. Save the (compatible) component path in browser_process. BUG=chromium:780575 TEST=unittest; install/load component successfully. Change-Id: Ic14f7d33ee6c8971dd6326f39fda546c94959e14 Reviewed-on: https://chromium-review.googlesource.com/801535Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#521622}
-
Alice Boxhall authored
Bug: 514674 Change-Id: I122ca163f9738e825e80c179e5dff803b488295d Reviewed-on: https://chromium-review.googlesource.com/807336 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521621}
-
Lei Zhang authored
Also mark some PrivetJSONOperation::ResultCallback usage as RepeatingCallback, as determined earlier in r515600. Change-Id: I88e8389b6967dabaef036446814d1f70e1ab61e4 Reviewed-on: https://chromium-review.googlesource.com/804753 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#521620}
-
Giovanni Ortuño Urquidi authored
Clicking on links in the New Tab Page results in the same type of navigation as launching an app. So, sometimes, we try to move the WebContents to a regular browser window even though the WebContents is in a regular browser window already. To solve this, check if we are in a browser window before moving the WebContents. Bug: 790773 Change-Id: I331c4b9c5d59d1e44d2e21d322ee2bfde6775f59 Reviewed-on: https://chromium-review.googlesource.com/802334 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#521619}
-
Scott Violet authored
Tests configure an environment this is a bit different than real code, so need some early outs. BUG=786453 TEST=none Change-Id: I44621add71a17821293949aa837c39c2b5394d9d Reviewed-on: https://chromium-review.googlesource.com/807168Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521618}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/f5be5bafa6f6..614dd0f537d4 $ git log f5be5bafa..614dd0f53 --date=short --no-merges --format='%ad %ae %s' 2017-11-22 kainino Replace TCache with static TType instances 2017-11-28 geofflang GL backend: Only synchronize transform feedback state when it changes. 2017-11-29 bryan.bernhart WebGLCompat: Fix depthstencil query results. 2017-12-01 oetuaho Test multiview extension warning 2017-11-30 oetuaho Fix handling matrix qualifiers on block members 2017-12-01 geofflang Improve documentation about selecting intial CL reviewers. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I5c35e284fcaed34fc4f1bb60e39fcfaf06978d23 Reviewed-on: https://chromium-review.googlesource.com/807488Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521617}
-
Miriam Gershenson authored
This reverts commit c24c3e90. Reason for revert: Turned a functional bug into a security bug Bug: 788131 Original change's description: > Save TTL to cache if in SOA of NXDOMAIN or NODATA results > > When we get an NXDOMAIN results, this will look at the last result > processed and extract the TTL from the SOA record if it exists (possilbe > TODO: look at all the results and get the shortest TTL). For NODATA > results with an rcode of NOERROR and zero answers, again record a cache > entry with the TTL of the SOA if present. > > R=mgersh@chromium.org > > Bug: 115051 > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I6fe029760f4ecfd3b3a91667e95b403a9f37a228 > Reviewed-on: https://chromium-review.googlesource.com/562037 > Commit-Queue: Brad Lassey <lassey@chromium.org> > Reviewed-by: Miriam Gershenson <mgersh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518461} TBR=mgersh@chromium.org,lassey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 115051 Change-Id: I791068c205931c25f4aa9fd6f073476dbb034f7f Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/807149Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#521616}
-
Tim Song authored
CryptAuth enrollment should only happen if a dependent feature is enabled (e.g. EasyUnlock, Instant Tethering) by enterprise policy. BUG=791662 Change-Id: Ie5562033c7b2c22f9b69d209ffed4ad3cbe6be9d Reviewed-on: https://chromium-review.googlesource.com/798019Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#521615}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: Ic63ac5a7cef4546603ec211c81fa64c49595cee2 Reviewed-on: https://chromium-review.googlesource.com/805576Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521614}
-
Mike Wittman authored
https://chromium.googlesource.com/breakpad/breakpad.git/+log/8a0edac9abfe..a61afe7a3e86 $ git log 8a0edac9a..a61afe7a3 --date=short --no-merges --format='%ad %ae %s' 2017-11-30 wittman Make iterator string types match map container string types 2017-11-29 wittman Add optional field indicating multiple symbols at an address 2017-11-27 wittman Update test data for identical-code-folded symbol changes 2017-11-13 wittman Make identical-code-folded symbol output more consistent between runs 2017-11-13 tomas.popela List missing 64-bit arches in the bundled curl Created with: roll-dep src/third_party/breakpad/breakpad R=mark@chromium.org Bug: google-breakpad:749 Change-Id: I748eaf7bbbf69f7001e5b7eef810e8678d7cdafc Reviewed-on: https://chromium-review.googlesource.com/807637Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521613}
-
chrome-release-bot authored
TBR=anantha@chromium.org Change-Id: I9a472e993608badcf82ade6e80b811daae68f5ec Reviewed-on: https://chromium-review.googlesource.com/807804Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#521612}
-
John Abd-El-Malek authored
BUG=783981 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5fa5a48492d1bbded7fa5c43be2caf97626b659d Reviewed-on: https://chromium-review.googlesource.com/791511 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#521611}
-
Qiang Xu authored
This CL description: - This CL could be landed before ash could learn/control spoken feedback enabled state. Ash will call PlayEarcon/PlayShutdownSound any time the caller wants, it bails out on chrome side if spoken feedback is not enabled. original CL description: - Remove PlayEarcon/PlayShutdownSound from ash::AccessibilityDelegate. Convert them calling into chrome through mojo call. - PlayShutdown sound gets shutdown sound duration asynchronously from chrome in ash::AccessibilityController. Callback runs to start real shutdown timer when getting shutdown sound duration. TBR=jamescook@chromium.org, xiyuan@chromium.org, dmazzoni@chromium.org TBR=tsepez@chromium.org Bug: 618070 Test: tested on device without --mash, it works fine. Change-Id: Ie1e04825640bb286e8676121e591810872c9417c Reviewed-on: https://chromium-review.googlesource.com/805361Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#521610}
-
Lei Zhang authored
Change-Id: If0e083df1fbb883342faf9ba80e3cc8c606438ee Reviewed-on: https://chromium-review.googlesource.com/804205 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#521609}
-
Tomasz Mikolajewski authored
To match semantics of ExtensionProvider. Test: All current FSP tests pass. Bug: 790836 Change-Id: I6948086c234319031a4ae95664d9216c2fb5f55c Reviewed-on: https://chromium-review.googlesource.com/802836 Commit-Queue: Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#521608}
-
Stefan Zager authored
When an overflow:auto vertical scrollbar is removed from an RTL LayoutView, then the call to ClampScrollOffsetAfterOverflowChange in LayoutView::UpdateAfterLayout during the second layout pass (after removing the scrollbar) will happen when the ScrollableArea's overflow_rect_ needs updating. BUG=711468 R=skobes@chromium.org,pdr@chromium.org,bokan@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I191a7142808851b266904b1916afc57b4b305940 Reviewed-on: https://chromium-review.googlesource.com/802179 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521607}
-
calamity authored
This reverts commit e8d7bd37. Reason for revert: Seems to be causing these test failures: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Trusty__dbg_/7571/layout-test-results/results.html Original change's description: > [DevTools] show multiline errors in DebuggerPausedMessage > > Without this CL we show only first line, sometimes other lines are > important as well (see attached bug). With this CL we show message > until first call frame. > > R=lushnikov@chromium.org > > Bug: chromium:780816 > Change-Id: I4737c7cb4e7033126eeb7a419bcb59478afea0d2 > Reviewed-on: https://chromium-review.googlesource.com/802076 > Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521587} TBR=lushnikov@chromium.org,kozyatinskiy@chromium.org Change-Id: Ifbb44fa5029f8019317d8757e0289f8c0296607a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:780816 Reviewed-on: https://chromium-review.googlesource.com/807597Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#521606}
-
Xianzhu Wang authored
This keeps consistent with legacy-results.html and rebaseline bots which treat MISSING as regressions. Also rename "unexpected failures" to "regressions" to be consistent with "Regressions" in summary. Also avoid exception when some test is directly under LayoutTests/ (where some developers like me put quick local layout tests). Change-Id: I80da6c9f54c64c98089a90ab72ae51e821a06a7b Reviewed-on: https://chromium-review.googlesource.com/807264 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#521605}
-
Derek Cheng authored
The dropdown will replace the checkbox that is currently in place to control whether media remoting is enabled. Note that this is not meant to be the final iteration of the UX; it is however an improvement over the existing checkbox and is a reasonable interim solution (while we gather feedback + do another UX study) Screenshots: LTR: https://screenshot.googleplex.com/dSPAZY4yHd5 RTL: https://screenshot.googleplex.com/apBUWUvp74q BUG=774245 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I296c47cae0ecf4d16b5b645f92af00a2e1161d4f Reviewed-on: https://chromium-review.googlesource.com/804138 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#521604}
-
Helen Li authored
Reset the NetTestSuite's global task environment in unit test so the MOCK_TIME environment doesn't leak into subsequent tests. Bug: 791804 Change-Id: Ic5df1fc6c21c7ef6b88bff2d05a68b4636b7650a Reviewed-on: https://chromium-review.googlesource.com/807287 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521603}
-
Alexander Alekseev authored
Google AccountId must have GaiaId identifier and correct type, which chromium tests still commonly ignore. This Cl adds correct AccountId initialization to some tests, which are needed for https://chromium-review.googlesource.com/c/chromium/src/+/804968 . TBR=sky@chromium.org,elijahtaylor@chromium.org Bug: 789068 Change-Id: Ied6d77bcdae2723fe9d224e2a35c701539d0e3b1 Reviewed-on: https://chromium-review.googlesource.com/805596 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521602}
-
Devlin Cronin authored
Inspectable views can have any url, including some maddeningly long ones. We need to ensure that these render appropriately on the extension's card in the main view of the chrome://extensions page. Make the following changes: - Ensure that the inspect views section does not grow beyond the content area. - Ensure that the "Inspect views" and "n more..." are always visible - Adjust the overflow for the shown inspectable view to be hidden behind ellipses, and have the title text have the full label. Bug: 789655 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icb6b769ed96c5775ea34a62eb15b89dbf625d124 Reviewed-on: https://chromium-review.googlesource.com/802095 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#521601}
-
erikchen authored
This CL adds two histograms: * OutOfProcessHeapProfiling.UploadTrace.Size is emitted on each trace upload, and reflects the uncompressed size of the trace. * OutOfProcessHeapProfiling.RecordTrace.Success is recorded after each attempt to record a trace, and reflects whether a trace was successfully recorded. This CL makes two other small changes: * Increase the timeout for waiting for a trace to 30 seconds from 10 seconds. * Update the OutOfProcessHeapProfilingMode enum to reflect new profiling modes. Bug: Change-Id: I303349b8a61dd2d5e3d25930f8e4c59cac109795 Reviewed-on: https://chromium-review.googlesource.com/806325 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521600}
-
Donn Denman authored
Updates the flag for Chrome Smart Selection on Android to default enabled. BUG=770767 Change-Id: I39db673c4e37aa7919f5fd3edf4ee4e8a1f0d104 Reviewed-on: https://chromium-review.googlesource.com/807325Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#521599}
-
Hiroshige Hayashizaki authored
Previously, Document::EnforceSandboxFlags() - Calls ApplySandboxFlags(), - Detects indirectly whether a new unique origin is set in ApplySandboxFlags(), and - Modifies Document's SecurityOrigin that is the new unique origin that was just set. This CL moves the modification to the new unique origin into ApplySandboxFlags(), before setting the origin to SecurityContext. |is_potentially_trustworthy| is plumbed to do this. No behavior changes are expected. Bug: 779730 Change-Id: Ia62a35c81bd4130e7a8119cc93e17c6b527f5e12 Reviewed-on: https://chromium-review.googlesource.com/762337Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#521598}
-
dpapad authored
Bug: 787229 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I173e9c72b269c69a18f9c7909cfc60a0158f4707 Reviewed-on: https://chromium-review.googlesource.com/806930Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#521597}
-
Alexander Timin authored
Rename FrameType which is used for reporting to FrameStatus. This removed unfortunate collision between said FrameType and WebFrameScheduler::FrameType which is used to distinguish main frame and subframes. This patch also moves FrameStatus from renderer_metrics_helper to a separate header. This is done to use FrameStatus in ResourceLoadScheduler for per-frame network metrics. The histograms are not changed and still have PerFrameType in their names. R=npm@chromium.org Bug: Change-Id: I1bca2f0ba556969da1fe33093b5b43dd3c8f16e0 Reviewed-on: https://chromium-review.googlesource.com/801674 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521596}
-
Emma Haruka Iwao authored
This patch adds updateViaCache to ServiceWorkerRegistrationOptions struct in mojom and ServiceWorkerContext. Intent to implement and ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/RwjXGTAbuuA/7Q3NPlJ4BAAJ Split from the original patch: https://chromium-review.googlesource.com/c/chromium/src/+/618076 Bug: 675540 Change-Id: I199357745605ebf43a82adfd30b2fbfd5e18e4b4 Reviewed-on: https://chromium-review.googlesource.com/792810Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#521595}
-
Joel Einbinder authored
This should make the color picker much faster Bug: none Change-Id: I487616d71e430cb6c8374473bc1d84d7810f10cf Reviewed-on: https://chromium-review.googlesource.com/807545 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521594}
-
Kurt Horimoto authored
Although this is only used by the new architecture, it is model code built on top of BrowserCoordinator, which also lives in ios/chrome. This CL also renames the test_helpers/ directory to test/ to match other cases in ios/chrome. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9b731c0805b36feb9cbced4688cb9899ac129ca8 Reviewed-on: https://chromium-review.googlesource.com/648076 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#521593}
-
Devlin Cronin authored
JS can be suspended when the renderer receives the IPC to dispatch an event. In this case, the JS shouldn't immediately run, but rather respect the JS state. Currently, the EventEmitter does this by using JSRunner::RunJSFunction() (which does respect JS suspension) with each of the listeners for the event. This mostly works, but has a couple of problems. For one, it makes it difficult to catch exceptions thrown from a JS listener (since the listener isn't notified when we queue it up through the JSRunner). It also doesn't account for the possibility of listeners being removed between a event comes in, and when it is actually disptached. Finally, it makes creating a single result for the dispatch difficult, which is problematic for messaging bindings. Rework the way event dispatching works to instead use a v8::Function wrapper around the EventEmitter to trigger the event being dispatched to listeners. Once that function is triggered, it's safe to use synchronous JS execution, since JS is already running at that point. This addresses the concerns with the current approach. Also add a Suspension utility to the TestJSRunner to simulate JS being suspended in testing, and add unit tests for dispatching events while JS is suspended. Bug: 653596 Change-Id: I7899e1946e8fe750fa2a1f53d62a04e5bd075664 Reviewed-on: https://chromium-review.googlesource.com/792033 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521592}
-
edchin authored
A method (-controllerForUnhandledContent:) was in CRWWebDelegate when it belongs in CRWNativeContentProvider protocol. This helped pull the implementation out of tab.mm and into the BVC, which can provide a base view controller for presenting UI, instead of using rootViewController for presentation. Bug: 791206 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If82dcb4f16a64d5e1fef99e2805588e92f2ca4d9 Reviewed-on: https://chromium-review.googlesource.com/807306 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#521591}
-
Tom Anderson authored
BUG=790683 TBR=creis@chromium.org Change-Id: I9ba4317841f6487795f1fb0676c9dde09f6fe500 Reviewed-on: https://chromium-review.googlesource.com/801264 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521590}
-
John Abd-El-Malek authored
Bug: 783981 Change-Id: I41afc98d8c9d60051cde53f3d17c28515ec9a8aa Reviewed-on: https://chromium-review.googlesource.com/807403Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521589}
-
Emil A Eklund authored
Change FontPlatformData::FontFamilyName to parse the font family name as UTF-8 instead of latin-1 as that is the encoding of the localized family name provided by the API. Verified on Linux, Windows 7/10, and Mac OS X. No test as I was unable to find a font with a localized non-latin family name under a suitable license. Bug: 667154 Change-Id: Iddb7932b68681824062cc2a7bf163459fc356cbb Reviewed-on: https://chromium-review.googlesource.com/807527Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#521588}
-
Alexey Kozyatinskiy authored
Without this CL we show only first line, sometimes other lines are important as well (see attached bug). With this CL we show message until first call frame. R=lushnikov@chromium.org Bug: chromium:780816 Change-Id: I4737c7cb4e7033126eeb7a419bcb59478afea0d2 Reviewed-on: https://chromium-review.googlesource.com/802076Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#521587}
-
Chris Harrelson authored
Full-width offscreen tiles become increasingly expensive on larger displays. Bug: 768799 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ibb2423c6dc956a7ad81a85d12aefd9d58ee28872 Reviewed-on: https://chromium-review.googlesource.com/806994Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521586}
-
Robert Sesek authored
Bug: 598854, 626802 Change-Id: I89e8afa29d884a63b6db68b9618d87ea5863432c Reviewed-on: https://chromium-review.googlesource.com/807169 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#521585}
-
Ovidio Henriquez authored
This change updates the gc-detach.html and detach-gc.html tests to use promise_test as opposed to async_test. This will help us migrate the tests to the wpt/ directory, since we use a wrapper around promise_test to dynamically load Chromium-specific modules. This change also updates gc-detach.html and detach-gc.html to use health-thermometer-iframe.html in order to use getHealthThermometerDevice rather than setBluetoothFakeAdapter. As a result, health-thermometer-iframe.html now contains a "RequestAndConnect" message case, and bluetooth-helpers.js does not rely on the "Ready" message from the health-thermometer-iframe.html anymore. Additionally, bluetooth-helpers.js now contains a function called setUpConnectableHealthThermometerDevice that sets up a fake_peripheral without requesting the device for tests that require the device to be requested outside of the main frame. BUG=769412 Change-Id: I310fd68569fb646e9e4e2ffde202b8f953a47e9b Reviewed-on: https://chromium-review.googlesource.com/777339 Commit-Queue: Ovidio Henriquez <odejesush@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#521584}
-