Commits · 83ad0766180d9196d711dab5cafcafa8f5148422 · eriksson monteiro / tangled

28 Apr, 2012 34 commits

Linux: Use the same safe downloads logic as Windows. (try 2) · 83ad0766

thestig@chromium.org authored Apr 28, 2012

BUG=none
TEST=none

First attempt: http://codereview.chromium.org/10241007/

Review URL: http://codereview.chromium.org/10255018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134438 0039d316-1c4b-4281-b951-d872f2087c98

83ad0766

Update .DEPS.git · 443c4db6

chrome-admin@google.com authored Apr 28, 2012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134437 0039d316-1c4b-4281-b951-d872f2087c98

443c4db6

roll gyp 1342:1344 · ae45277e

scottmg@chromium.org authored Apr 28, 2012

1343: ninja windows: fix expansion of some VS macros
1344: Exclude problematic formats from tests, rather than including all other platforms

TBR=thakis@chromium.org

Review URL: http://codereview.chromium.org/10137011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134436 0039d316-1c4b-4281-b951-d872f2087c98

ae45277e

Report VideoDecoder status through ReadCB instead of through FilterHost. · 8d1e8fb0

xhwang@chromium.org authored Apr 28, 2012

BUG=108340
TEST=media_unittests

Review URL: http://codereview.chromium.org/10248002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134435 0039d316-1c4b-4281-b951-d872f2087c98

8d1e8fb0

Route calls to tcmalloc MallocExtension through allocator agnostic interface · 237a1485

jamesr@chromium.org authored Apr 28, 2012

Our various libraries should not be picking or depending on a particular
allocator choice - that should be an application level choice. This creates
a generic AllocatorExtension interface that can optionally be backed by
entry points to a particular allocator's MallocExtension interface if the
application chooses to.

BUG=125003
TEST=compiles, chrome://tcmalloc works


Review URL: http://codereview.chromium.org/10239012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134434 0039d316-1c4b-4281-b951-d872f2087c98

237a1485

Add some debug info to track down issue 120709. · 6486d9c1

lipalani@chromium.org authored Apr 28, 2012


BUG=
TEST=


Review URL: http://codereview.chromium.org/10248006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134433 0039d316-1c4b-4281-b951-d872f2087c98

6486d9c1

Remove dispatcher in test compositor · 1e795188

oshima@chromium.org authored Apr 28, 2012

I guess this is legacy code from pre webkit compositor era.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/10258006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134432 0039d316-1c4b-4281-b951-d872f2087c98

1e795188

Implement a callout widget for the active panel. · 027e8df4

dcheng@chromium.org authored Apr 28, 2012

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10174037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134431 0039d316-1c4b-4281-b951-d872f2087c98

027e8df4

GpuMemoryManager suggests values for renderer Contents Texture Managers' preferred memory limit. · 30108bd8

mmocny@chromium.org authored Apr 28, 2012


BUG=123382
TEST=Manual


Review URL: http://codereview.chromium.org/10083056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134428 0039d316-1c4b-4281-b951-d872f2087c98

30108bd8

Fixed failure to add language in language settings page. · a7ea8885

danhn@chromium.org authored Apr 28, 2012

BUG=125323
TEST=browser_tests --gtest_filter=WebUIBidiCheckerBrowserTestRTL.TestSettingsLanguageOptionsPage

Review URL: http://codereview.chromium.org/10255017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134427 0039d316-1c4b-4281-b951-d872f2087c98

a7ea8885

Fix unit-tests compilation on Android. · 3439967e

jcivelli@chromium.org authored Apr 28, 2012

The Android compiler does not realize a var is initialized and complains about
it.  Initializing the variable earlier so it stops complaining.

BUG=None
TEST=unit_tests should compile on Android.


Review URL: http://codereview.chromium.org/10254023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134426 0039d316-1c4b-4281-b951-d872f2087c98

3439967e

Add key modifier to minimize/restore button click to minimize/restore-all panels for Windows. · fd3f2669

jennb@chromium.org authored Apr 28, 2012

Changed to use the same technique to detect key modifier for titlebar click.

BUG=123176
TEST=Existing


Review URL: http://codereview.chromium.org/10187021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134425 0039d316-1c4b-4281-b951-d872f2087c98

fd3f2669

Fix labels in chrome://sync · 721ced34

rlarocque@chromium.org authored Apr 28, 2012

Make the labels match the variables being displayed.

BUG=125414
TEST=


Review URL: http://codereview.chromium.org/10253020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134424 0039d316-1c4b-4281-b951-d872f2087c98

721ced34

Experimental USB API · 0b81c3fd

gdk@chromium.org authored Apr 28, 2012

This change adds a new API for low-level access to USB devices. The change
depends on https://chromiumcodereview.appspot.com/10161035/

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/10224009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134423 0039d316-1c4b-4281-b951-d872f2087c98

0b81c3fd

Fixes possible crash in closing menus. Specifically if we Close a · 064fd6c0

sky@chromium.org authored Apr 28, 2012

menu but the parent closes before the Widget::CloseNow task is
processed then MenuHost can attempt to access a deleted menu item.

BUG=125395
TEST=none
R=ben@chromium.org


Review URL: http://codereview.chromium.org/10178031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134422 0039d316-1c4b-4281-b951-d872f2087c98

064fd6c0

RefCounted types should not have public destructors, ipc/ edition · f729d15a

rsleevi@chromium.org authored Apr 28, 2012

BUG=123295
TEST=none


Review URL: http://codereview.chromium.org/10008108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134421 0039d316-1c4b-4281-b951-d872f2087c98

f729d15a

Make so in metro mode popups are background tabs · ef40efe9

cpu@chromium.org authored Apr 28, 2012

BUG=118641
TEST=see bug
Review URL: https://chromiumcodereview.appspot.com/10258007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134419 0039d316-1c4b-4281-b951-d872f2087c98

ef40efe9

Clear uniforms · 2df73893

gman@chromium.org authored Apr 28, 2012

TEST=unit tests
BUG=124764

R=zmo@chromium.org


Review URL: http://codereview.chromium.org/10246004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134418 0039d316-1c4b-4281-b951-d872f2087c98

2df73893

Adding pyauto-based memory usage tests for ChromeOS. · 93bb08dd

dennisjeffrey@chromium.org authored Apr 28, 2012

These tests each open and close a set of tabs twice, and measure/record
memory usage information at certain points during test execution.

BUG=chromium-os:29815
TEST=Verified the test runs successfully on my local ChromeOS device running
a recent official build.

Review URL: https://chromiumcodereview.appspot.com/10161033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134417 0039d316-1c4b-4281-b951-d872f2087c98

93bb08dd

fix ntp/file: pages · aef4e7e8

estade@chromium.org authored Apr 28, 2012

BUG=125420
TEST=you should be able to open both the ntp and a file:// url without the second one flipping out

Review URL: https://chromiumcodereview.appspot.com/10252019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134416 0039d316-1c4b-4281-b951-d872f2087c98

aef4e7e8

Merge VideoCaptureDevice::Capability with media::VideoCaptureCapability · 99633098

yujie.mao@intel.com authored Apr 28, 2012

This is a second patch as the follow up of http://codereview.chromium.org/10108009/, just to facilitate code review
1. Move VideoCaptureDevice::Format to VideoCaptureCapability::Format.
2. Fix a code style issue in media_stream_device_settings.h.
3. Remove the TODO comments in media_stream_device_settings.h, since the media stream infobar is already implemented in linux and windows.

BUG=123738
TEST=content_unittests, media_unittests

Review URL: http://codereview.chromium.org/10035054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134415 0039d316-1c4b-4281-b951-d872f2087c98

99633098

Update .DEPS.git · 93264faf

chrome-admin@google.com authored Apr 28, 2012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134414 0039d316-1c4b-4281-b951-d872f2087c98

93264faf

Revert 134380 - Checkout Web Page Replay in src/third_party (was chrome/tools/build/third_party). · 5bfa71eb

yoz@chromium.org authored Apr 28, 2012

check_licenses failure.

BUG=
TEST=


Review URL: http://codereview.chromium.org/10020064

TBR=slamm@google.com
Review URL: https://chromiumcodereview.appspot.com/10256016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134413 0039d316-1c4b-4281-b951-d872f2087c98

5bfa71eb

Fix the UI label for verifying flash plugin status and re-enable this test. · 4ed506f8

nirnimesh@chromium.org authored Apr 28, 2012

BUG=125062

Review URL: https://chromiumcodereview.appspot.com/10237009
Patch from Vivian <vivianz@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134412 0039d316-1c4b-4281-b951-d872f2087c98

4ed506f8

Disables a test to get the Android FYI bot green · 56749b26

dfalcantara@chromium.org authored Apr 28, 2012

Disables FileUtilProxyTest.Touch; it doesn't seem to have ever worked for Android and is keeping the bot red.

BUG=
TEST=


Review URL: http://codereview.chromium.org/10253018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134411 0039d316-1c4b-4281-b951-d872f2087c98

56749b26

Allow linux trace events to not be time-shifted. · 34cc0e5d

sleffler@chromium.org authored Apr 28, 2012

When importing Linux system events treat a trace_event_clock_sync
record with 0 parent timestamp as a noop.  While here do the same
when the calculated time shift is zero.

BUG=none
TEST=unit tests (updated for null-shift case)

Change-Id: Ifec8ae22bfc7231ee1e22082735df6b389d786b0


Review URL: http://codereview.chromium.org/10137006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134410 0039d316-1c4b-4281-b951-d872f2087c98

34cc0e5d

Update .DEPS.git · 388f36fa

chrome-admin@google.com authored Apr 28, 2012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134409 0039d316-1c4b-4281-b951-d872f2087c98

388f36fa

Print out the error when loading an extension fails. · a82f15d3

wez@chromium.org authored Apr 28, 2012

This is primarily useful for extension developers in helping them diagnose what's wrong in their extension manifest.

Review URL: http://codereview.chromium.org/10050032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134408 0039d316-1c4b-4281-b951-d872f2087c98

a82f15d3

Protect all uses of JSON.parse against exceptions. · b2460a26

jamiewalch@google.com authored Apr 28, 2012

BUG=None
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10221021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134407 0039d316-1c4b-4281-b951-d872f2087c98

b2460a26

WebKit Roll 115452:115483. · 82e88b5c

dglazkov@chromium.org authored Apr 28, 2012

TBR=bulach
TEST=none
BUG=none


Review URL: http://codereview.chromium.org/10178025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134406 0039d316-1c4b-4281-b951-d872f2087c98

82e88b5c

Parent/child fixes. · 113707f4

achuith@chromium.org authored Apr 28, 2012

* Split GDataDirectory::children_ into child_files_ and child_directories_. This is necessary because we plan to offload child_files_ to GDataDB (but not child_directories_).
* Add helpers FindChild and AddChild. Rename RemoveEntryFromChildrenList to RemoveChild.
* Do not serialize GDataEntry::file_name, serialize GDataEntry::parent_resource_id
* Use SetParent instead of set_parent, which also sets the parent_resource_id.
* Implement GetFilePath using recursion instead for simplicity.
* Move SetFileNameFromTitle to within AddEntry.
* Move kGDataRootDirectory (gdata) to ctor of GDataRootDirectory.
* Other minor cleanup.

BUG=chromium-os:29232
TEST=compiles, unit tests pass. Everything looks ok in chrome file manager.
Review URL: https://chromiumcodereview.appspot.com/10258004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134405 0039d316-1c4b-4281-b951-d872f2087c98

113707f4

Fix case where an unmounted partition is accessed during tracing on Windows. · 5aeb9ee3

maruel@chromium.org authored Apr 28, 2012

R=nsylvain@chromium.org
BUG=98834
TEST=


Review URL: http://codereview.chromium.org/10221022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134404 0039d316-1c4b-4281-b951-d872f2087c98

5aeb9ee3

Fix TODO: return name and id as NSArray* instead of QTCaptureDevice*. · 576f97f0

scherkus@chromium.org authored Apr 28, 2012

Patch by Jeremy Mao <yujie.mao@intel.com>:
http://codereview.chromium.org/10198016/

BUG=NONE
TEST=media_unittests

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134403 0039d316-1c4b-4281-b951-d872f2087c98

576f97f0

Fix compilation of unit_tests on Android. · db5d89e4

jcivelli@chromium.org authored Apr 28, 2012

BUG=None
TEST=unit_tests should compile on Android


Review URL: http://codereview.chromium.org/10206032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134402 0039d316-1c4b-4281-b951-d872f2087c98

db5d89e4

27 Apr, 2012 6 commits

VLOG -> DVLOG for uniformity field trials · e3f65929

isherman@chromium.org authored Apr 27, 2012

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10246001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134401 0039d316-1c4b-4281-b951-d872f2087c98

e3f65929

Merge SettingsMap changes from server code · bd36c128

rch@chromium.org authored Apr 27, 2012

Review URL: http://codereview.chromium.org/10254021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134400 0039d316-1c4b-4281-b951-d872f2087c98

bd36c128

Make GTK Panels ignore mouse/keyboard events after drag is ended until mouse is released. · 7a1667be

jennb@chromium.org authored Apr 27, 2012

BUG=125407
TEST=Manually verified repro steps from bug.

Review URL: https://chromiumcodereview.appspot.com/10170037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134399 0039d316-1c4b-4281-b951-d872f2087c98

7a1667be

Update .DEPS.git · 8b94ecaa

chrome-admin@google.com authored Apr 27, 2012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134398 0039d316-1c4b-4281-b951-d872f2087c98

8b94ecaa

Add net_jni_registrar. · b588ef6a

yfriedman@chromium.org authored Apr 27, 2012

It's used as a centralized place to register JNI hooks for Android
components in the net package.


Review URL: http://codereview.chromium.org/10178023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134396 0039d316-1c4b-4281-b951-d872f2087c98

b588ef6a

RefCounted types should not have public destructors, content/browser part 1 · fb90c94f

rsleevi@chromium.org authored Apr 27, 2012

BUG=123295
TEST=none


Review URL: http://codereview.chromium.org/10068037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134395 0039d316-1c4b-4281-b951-d872f2087c98

fb90c94f