GitLab

This CL removes the use of = {} to clear base::queues, because, for classes,
zero initialization simply clears the (non-static) data members, which might
leave the objects in an incorrect meta state because ctors are not called:
this should not be an issue for std::queue, but it is for base::queue, which
is implemented as a base::circular_deque.

Nothing is crashing now, but a sibling unlanded sister CL (crrev.com/c/947341)
had some issues with a similar idiom, so I'm removing it just in case.

[1] http://en.cppreference.com/w/cpp/language/zero_initialization

Bug: 717265
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I96af3e6475c0596f3316219bd51732e085f5e098
Reviewed-on: https://chromium-review.googlesource.com/1005917Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550162}

The LSI allocators previously did not store a copy of the last generated
LSI. As a result, many call sites would have to keep their own copies.

Now that the LSI allocators have their own copies, the call sites can be
updated to no longer store a separate copy.

Viz's display unittests are one such call site.

BUG=759031

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I9b689e7e22971baf9596fcc42ccc7ffb28a4b7af
Reviewed-on: https://chromium-review.googlesource.com/1008963
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550161}

This change:
1) Adds MenuClosureAnimationMac, which implements the Mac menu closure
   animation;
2) Adds logic to MenuItemView to force drawing the item in a selected
   or unselected state as needed, for use in this animation;
3) Adds support to MenuController for disabling handling input events,
   so that the closure animation can appear to be "synchronous";
4) Makes MenuController::Accept possibly asynchronous;
5) Updates unit tests to account for (4)

Bug: 829347
Change-Id: I8676718e6a5e9704b422ed4cb08e8d10002bf45a
Reviewed-on: https://chromium-review.googlesource.com/999803
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550160}

Without them XCode cannot compile generated projects with ICECC.

Bug: 831500
Change-Id: I3b50c730660c4e8a6a06b9fda340e20edb87e40a
Reviewed-on: https://chromium-review.googlesource.com/1006577Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Michal Pichlinski <mpichlinski@opera.com>
Cr-Commit-Position: refs/heads/master@{#550159}

This CL was speculatively reverted in r549859 to try to fix issue
831255. But the issue already disappeared in the Chrome release
prior to the revert. Therefore, this CL didn't cause the issue.

Original code review:
https://chromium-review.googlesource.com/981845

Bug: 831255, 796819
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id76ea08d7ac158ed1958bcf9561aaf1e2c05c8ae
TBR: kinuko
Reviewed-on: https://chromium-review.googlesource.com/1009447Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550158}

This change introduces WriteWithoutResponse() on
BluetoothRemoteGattCharacteristic. In contrast to the regular
WriteRemoteCharacteristic() this method does not wait for a response
from the operating system. For now it is only implemented on Mac, where
it can result in a speedup of 8x for sending data
(see https://crbug.com/808175#c9).

Bug: 808175, 831524
Change-Id: If2012ac8e19d17fe218e273d8d0e300a2b06a19a
Reviewed-on: https://chromium-review.googlesource.com/1000859
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550157}

This removes 'use_once_callback = false' flag from BUILD.gn from
services/resource_coordinator, and fixes all implementations of the
interface.

Bug: 714018, 729950
Change-Id: I203b0957fdc12da1829339f79d84210446ebad7e
Reviewed-on: https://chromium-review.googlesource.com/997064
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550156}

DecodeTask() is posted from mainly QueueInputBuffer() or
RecycleVASurfaceID() in most cases.
Some DecodeTask() posted from QueueInputBuffer() do nothing since va
surface is not available yet. It will be available after AssignPictureBuffers().
If the first buffer contains information about coded size, DecodeTask() for the
succeeding buffers are pended. In this case, DecodeTask() may be called twice;
in QueueInputBuffer() and the other once in AssignPictureBuffers().
If the third buffer is a dummy buffer queued by Flush(), the buffer is not
popped in DecodeTask() and thus FlushTask() is not executed permanently.
It can be a problem when a client expects the picture decoded from second buffer
is returned, because decoding of the second buffer might be pending in driver.
FlushTask() which can ask driver to decode the second buffer is not executed now
due to the above reason.
The following CTS tests behave similarly to the problem case.
* android.media.cts.DecoderTest#testEOSBehaviorH264
* android.media.cts.DecoderTest#testEOSBehaviorVP8"
* android.media.cts.DecoderTest#testEOSBehaviorVP9"

These CTS starts to fail from crrev.com/c/973684. In the CL, DecodeTask() was
changed to not execute DecodeTask() to the succeeding buffers.

This changes VDA as to post DecodeTask() from ReusePictureBuffer(), and the
number of executing DecodeTask() is sufficient to get driver finish decoding
storing picture buffers.

BUG=b:77840176
TEST=CtsMediaTestCases on eve
TEST=VDA unittest

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I31adbaf6cd01b79d1872acf56856cd10e46f9043
Reviewed-on: https://chromium-review.googlesource.com/1006563
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550155}

Store the online sign-in enforcement flag before terminating the
browser when a fatal policy initialization error happens.

This should fix the inability to sign into existing managed profiles
in the case when the policy files got corrupted. In such case the
user session is immediately terminated, because there's currently no
mechanism to fetch the missing policy without going through an
online sign-in flow. The problem was that the next sign-in attempts are
likely to go through the same steps and fail again.

This CL addresses this by enforcing the online authentication for the
next sign-in attempt of that user.

BUG=chromium:830654
TEST=Manual: delete user policy files from existing profile, try to
     sign in - the session should immediately terminate, then try to
     sign in again - the online sign-in should take place, and the
     session should start.

Change-Id: I1ff4c555999b4063a118c751598ecb0515839b3c
Reviewed-on: https://chromium-review.googlesource.com/1000867Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550154}

This change introduces SplitSpan() to u2f_parsing_utils. This method
takes a span and chunks it into smaller parts.

Bug: 763303
Change-Id: I13deb5efca224ae00c8dc5ac8ee2df7fc418ccfd
Reviewed-on: https://chromium-review.googlesource.com/1005183
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550153}

Change-Id: I1e66f2cdc50be889b697b54401be6352607fa649
Reviewed-on: https://chromium-review.googlesource.com/1006528
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550152}

This CL removes the PDFium SAX fuzzer as the SAX reader is being removed
from PDFium.

Bug: pdfium:1063
Change-Id: I1b7ac4dcb31b2558471946fdf8023f7944a49c09
Reviewed-on: https://chromium-review.googlesource.com/1007008Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550151}

Most notably, the scenario where the tab is initially mapped was not
exercised in any test. We now cover this case as well as some other
common updates for both local and remote sessions, which also includes
test coverage for UpdateTrackerWithSpecifics() itself.

This requires some minor API changes in SyncedSessionTracker.

Bug: 814423
Change-Id: If65494ef2f505eb6b49569e4d1d1f0a132f92e08
Reviewed-on: https://chromium-review.googlesource.com/1005176
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550150}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b272c6655f99..deb0ebc0777b

$ git log b272c6655..deb0ebc07 --date=short --no-merges --format='%ad %ae %s'
2018-04-12 ihf Revert "chromeos_config: enable kevin-arcnext hwtests"
2018-04-11 pwang chromeos_config: enable kevin-arcnext hwtests
2018-04-09 briannorris purge_lib: also add exclusions for *-tryjob suffix on test-ap builds
2018-04-10 dgarrett chromeos_config: Remove pre-cq builder from chromeos.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:none,chromium:None


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ia60a77af59e51f05ffbc5cd85e787fc31d150b27
Reviewed-on: https://chromium-review.googlesource.com/1009488Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550149}

There are probably larger changes that need to happen to ensure that
the custom-layout and multicol play nicely together, but this removes
a DCHECK crash for now.

Bug: 823074
Change-Id: I98f4a34bd0c35e8cd3d23501ca64f38b96be9e7d
Reviewed-on: https://chromium-review.googlesource.com/990780
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550148}

Scheduler classes are being renamed as part of scheduler architecture
refactoring.

There are a number of string literals containing "RendererScheduler"
for tracing and UMA purposes. Among these, tracing names are renamed
to "MainThreadScheduler", but UMA names are kept as is in order to
maintain the continuity of UMA data.

Bug: 826203
Change-Id: I0cb113036e602fcf14a255153d0c76f3b2898c83
Reviewed-on: https://chromium-review.googlesource.com/1004888
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550147}

Introduces the <angle> data type.
Test fails because we compute offset-rotate to a pair rather than
'as specified'

had to rebaseline all the tests.

Bug: 820299
Change-Id: Ifdc192550b0b544b9887af80c259b3bfeede556b
Reviewed-on: https://chromium-review.googlesource.com/1003433
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550146}

This guards against a resource exhaustion in the
UNIX sockets space.

Bug: chromium:826957
Change-Id: I0b55ff033812b1778793f0d27398012c557b8e3a
Reviewed-on: https://chromium-review.googlesource.com/995433Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550145}

BUG=None

Change-Id: I7085ae66081b2b22ec68b3132ceb606c8e89f364
Reviewed-on: https://chromium-review.googlesource.com/1009344
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550144}

This test group (5 tests in all) flakes more often than desired on chromium
trys (the CQ). Disable them while the flake cause is being investigated.

Note: these tests are only built and run on ChromeOS. TODO(noel) once issue
829310 is resolved, this change can be reverted.

Bug: 829310
Change-Id: If6e30690d9076debfd988a1fa0d7c93575099a14
Reviewed-on: https://chromium-review.googlesource.com/1006746
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550143}

Update background_application_list_model_unittest.cc to generate
extensions with manifest_version 2.

Bug: 816679
Change-Id: Icb245afea008fb2bdf57ae20e7289539aa39724e
Reviewed-on: https://chromium-review.googlesource.com/1008605
Commit-Queue: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550142}

"supersize archive" would crash upon encountering a .a file that was
linked as a "thin archive" (where the actual .o files are not embedded).

This fixes the tool by transforming all foo.a(bar.o) paths into their
external object paths.

Also adds main() functions for ninja_parser.py for debugging.

Bug: 830843
Change-Id: Iddc374565b8e94a4a89b2faa343256ea2d9f569e
Reviewed-on: https://chromium-review.googlesource.com/1007317
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550141}

We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading
and replace them with appropriate kInternal* task types.

This CL also introduced a new type kInternalAnimation.

Bug: 830489
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia8be580c1f313c89c6928dbb201c0cb2ac435ed8
Reviewed-on: https://chromium-review.googlesource.com/1009448Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550140}

DCHECK on FidoRequestHandlerBase::OnDeviceRemoved will always fail if
user removes a device that has already been removed due to processing
error.

Bug: 780078
Change-Id: Ica0ee018645936706f1691378e9c7f0ad3fd0ca4
Reviewed-on: https://chromium-review.googlesource.com/1006492
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550139}

Media.Audio.Render.[Input|Output]DeviceStreamCreationTime measures the
time from stream creation starting until the StreamCreated callback
gets triggered.

Bug: chromium:672469
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I32f50b8cf19afea7b97ae415fce17308085567bf
Reviewed-on: https://chromium-review.googlesource.com/1000855Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jonas Olsson <jonasolsson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550138}

This change provides C++14 implementations of C++17's std::size(),
std::empty() and std::data().

Bug: 828324
Change-Id: If1b83826a23b26fd557f7854962bcbc771a7ffe0
Reviewed-on: https://chromium-review.googlesource.com/992236
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550137}

It's launched and stable.

Bug: 725883
Change-Id: Ic9d8d49f45f70aae4e236037aa5aabbe28eef534
Reviewed-on: https://chromium-review.googlesource.com/1009942Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550136}

base::TestIOThread::PostTask is a left-over of the OnceCallback support
of TaskRunner::PostTask, that is needed by its user to migrate to
OnceCallback.

Bug: 714018
Change-Id: Iceb18fb84bde555e4fa217c32e463e01adf034a1
Reviewed-on: https://chromium-review.googlesource.com/997313Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550135}

When kIgnoreClipping is passed as a parameter to HitTesting code we
should ignore overflow clipping on the root layer. We pass a hit test
rect into clipping code that we intersect with the usual rects.
Normally this will be the frame rect but when kIgnoreOverflow is used,
the hit test rect is unioned with the entire document rect to ensure
we can hit anywhere in the document.

However, when RLS is turned on hit testing occurs on absolute points,
rather than document points. This means that the scroll offset must be
accounted for in the hit test rect.

Bug: 828815
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I97e78d931685db1227fc975de8a3ed55783dd3e7
Reviewed-on: https://chromium-review.googlesource.com/1007889
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550134}

The functionality of WorkerEntityTracker has been signficantly reduced
to doing the book keeping of UpdateResponseData without any extra logic

This CL does the following

1- Removes the WorkEntityTracker and istead keeps track of the
UpdateResponseData directly

2- Removes has_encrypted_updates_ and replace it by checking
for the existence of UpdateResponseData

3- Deprecated Sync.WorkerApplyHasEncryptedUpdates histogram.

Bug: 516866
Change-Id: I21d72cb604a726524a4bd86bbcdd1f209f83ef10
Reviewed-on: https://chromium-review.googlesource.com/1005178
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550133}

The test fails frequently in Linux Tests.

TBR=msarda@chromium.org

Bug: 831848
Change-Id: Ic180e7dfba538cba90737d2b66ee429c9cd97484
Reviewed-on: https://chromium-review.googlesource.com/1008829Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550132}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I5d9f6be3562adf9db533ee48db026ac14f56c8ad
Reviewed-on: https://chromium-review.googlesource.com/1010023
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550131}

https://chromium.googlesource.com/catapult.git/+log/cc64c0d81aab..60096370137d

$ git log cc64c0d81..600963701 --date=short --no-merges --format='%ad %ae %s'
2018-04-11 sergiyb Allow querying metrics without filtering by sheriff name

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:780805


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I60f4b54067b7ebaf0c46471e315da3d0c6a1fe1c
Reviewed-on: https://chromium-review.googlesource.com/1009492
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550130}

Before a sync cycle is complete, we don't know yet if the sync token is
actually valid, because sync may not have tried it yet.

This means that without this CL, if the user was in auth error state,
and Chrome starts, GetUploadToGoogleState reports that uploading to
Google is active until sync actually tries to push or pull some data.

BUG=830570

Change-Id: Id59157db5fd2b83c4bd073cdf61e7c9da0bc730b
Reviewed-on: https://chromium-review.googlesource.com/1000780Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550129}

This merges IssueTestTokens into SimulateTestUserSignin. IdentityManager
doesn't know of this distinction (signed in but no tokens), and only one
of the (non-disabled) tests depends on it.

Bug: 825190
Change-Id: Id6695ba2febc973c6a0b670624bb1ecf9ed3e0ae
Reviewed-on: https://chromium-review.googlesource.com/1007274Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550128}

It was recently deprecated in favor of the less subtle
SessionID::NewUnique(), with the same implementation. This patch
removes the deprecated API which includes the aforementioned default
constructor as well as SessionID::set_id().

Most calling sites have been migrated in recent CLs and the remaining
ones are now surfaced, both intentional and accidental.

The plan for follow-up patches will consider:
1. Reintroducing the default constructor, but with
   SessionID::InvalidValue() as the default.
2. Moving SessionID::NewUnique() to a factory method in a newly
   introduced KeyedService for this purpose.

Bug: 823798
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3abbc9b5a1497c11a99c9f80c6b2eadb7b7c6df8
Reviewed-on: https://chromium-review.googlesource.com/995899
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550127}

This isn't an ideal UX, although there is currently no defined UX
for this and this mostly just lays the foundation of any future
implementation. When the actual touch point (where the user's finger
is) approaches within 10 pixels of the display edge where there is
another display attached, the keyboard will transfer to the new display
in a default location.

This uses a similar mechanism as the ContainerBehavior change, where
the new display is queued on the KeyboardController and the keyboard
is then hidden. The HideAnimationFinished handler will then check for
any queued display changes, and re-open the keyboard on the new
display.

Bug: 828701
Change-Id: I7d513791b5bd2de9133f6014469cd03c3fa44899
Reviewed-on: https://chromium-review.googlesource.com/1009507
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550126}

Currenlty TextureRef::ExportGpuMemoryBufferHandle() only exports
the first plane of pixmap, which is wrong for multi-plane case.

The fix is to add all planes into the handle to export.

BUG=b:73327993
TEST=run video_decode_accelerator_unittest
/usr/local/autotest/deps/chrome_test/test_src/out/Release/video_decode_accelerator_unittest \
--test_video_data=/usr/local/autotest/deps/chrome_test/test_src/\
media/test/data/test-25fps.vp8:320:240:250:250:35:150:11 \
--thumbnail_output_dir=/usr/local/autotest/results/default/video_VideoDecodeAccelerator/results \
--ozone-platform=gbm \
--rendering_fps=0

Change-Id: Idc9cddf69a43567d75793c327d6533c6bd7e4140
Reviewed-on: https://chromium-review.googlesource.com/1004074Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Commit-Queue: Shuo-Peng Liao <deanliao@google.com>
Cr-Commit-Position: refs/heads/master@{#550125}

The site isolation policies until now could only enable site isolation
but being set to disabled was equivalent to not being set at all.
With this change their disabled state is going to prevent trials from
turning on site isolation per default. The user can still decide to
enable site isolation by using the command line flags directly.

Additionally fixes the problem of adding the isolated origins flag
twice if the browser is restarted programmatically.

BUG=827821, 826624

Change-Id: I754e1d8837b5afb0e7a70acbdb2e823733ad9663
Reviewed-on: https://chromium-review.googlesource.com/997737Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550124}

According to the UX spec, UnifiedSystemTray bubble corners are rounded
and the radius is 20.
To support custom corner radius, this CL adds corner_radius attribute to
TrayBubbleView::InitParams.

Screenshot: http://screen/d8Q63mzrU6A
UX spec: http://shortn/_U7QSE9nhSk

TEST=manual
BUG=811641

Change-Id: Ibf67a61c62fa6db852c040dad91dfd8df2d409e9
Reviewed-on: https://chromium-review.googlesource.com/1003015Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550123}